/* * Copyright 2017 The WebRTC project authors. All Rights Reserved. * * Use of this source code is governed by a BSD-style license * that can be found in the LICENSE file in the root of the source * tree. An additional intellectual property rights grant can be found * in the file PATENTS. All contributing project authors may * be found in the AUTHORS file in the root of the source tree. */ #include #include #include #include #include #include #include #include #include "absl/strings/match.h" #include "absl/strings/str_replace.h" #include "api/audio_codecs/audio_format.h" #include "api/audio_codecs/builtin_audio_decoder_factory.h" #include "api/audio_codecs/builtin_audio_encoder_factory.h" #include "api/create_peerconnection_factory.h" #include "api/field_trials.h" #include "api/field_trials_view.h" #include "api/jsep.h" #include "api/media_types.h" #include "api/peer_connection_interface.h" #include "api/rtc_error.h" #include "api/rtp_parameters.h" #include "api/rtp_transceiver_direction.h" #include "api/rtp_transceiver_interface.h" #include "api/scoped_refptr.h" #include "api/test/rtc_error_matchers.h" #include "api/uma_metrics.h" #include "api/video_codecs/sdp_video_format.h" #include "api/video_codecs/video_decoder_factory_template.h" #include "api/video_codecs/video_decoder_factory_template_dav1d_adapter.h" #include "api/video_codecs/video_decoder_factory_template_libvpx_vp8_adapter.h" #include "api/video_codecs/video_decoder_factory_template_libvpx_vp9_adapter.h" #include "api/video_codecs/video_decoder_factory_template_open_h264_adapter.h" #include "api/video_codecs/video_encoder_factory_template.h" #include "api/video_codecs/video_encoder_factory_template_libaom_av1_adapter.h" #include "api/video_codecs/video_encoder_factory_template_libvpx_vp8_adapter.h" #include "api/video_codecs/video_encoder_factory_template_libvpx_vp9_adapter.h" #include "api/video_codecs/video_encoder_factory_template_open_h264_adapter.h" #include "media/base/codec.h" #include "media/base/media_constants.h" #include "media/base/stream_params.h" #include "p2p/base/transport_description.h" #include "pc/peer_connection_wrapper.h" #include "pc/session_description.h" #include "pc/test/fake_audio_capture_module.h" #include "pc/test/fake_rtc_certificate_generator.h" #include "pc/test/integration_test_helpers.h" #include "pc/test/mock_peer_connection_observers.h" #include "rtc_base/string_encode.h" #include "rtc_base/thread.h" #include "system_wrappers/include/metrics.h" #include "test/gmock.h" #include "test/gtest.h" #include "test/wait_until.h" // This file contains unit tests that relate to the behavior of the // SdpOfferAnswer module. // Tests are writen as integration tests with PeerConnection, since the // behaviors are still linked so closely that it is hard to test them in // isolation. namespace webrtc { using ::testing::Eq; using ::testing::IsTrue; using RTCConfiguration = PeerConnectionInterface::RTCConfiguration; using ::testing::ElementsAre; using ::testing::Pair; using ::testing::SizeIs; namespace { std::unique_ptr CreateAndStartThread() { auto thread = rtc::Thread::Create(); thread->Start(); return thread; } } // namespace class SdpOfferAnswerTest : public ::testing::Test { public: SdpOfferAnswerTest() // Note: We use a PeerConnectionFactory with a distinct // signaling thread, so that thread handling can be tested. : signaling_thread_(CreateAndStartThread()), pc_factory_(CreatePeerConnectionFactory( nullptr, nullptr, signaling_thread_.get(), FakeAudioCaptureModule::Create(), CreateBuiltinAudioEncoderFactory(), CreateBuiltinAudioDecoderFactory(), std::make_unique< VideoEncoderFactoryTemplate>(), std::make_unique< VideoDecoderFactoryTemplate>(), nullptr /* audio_mixer */, nullptr /* audio_processing */, nullptr /* audio_frame_processor */)) { metrics::Reset(); } std::unique_ptr CreatePeerConnection( std::unique_ptr field_trials = nullptr) { RTCConfiguration config; config.sdp_semantics = SdpSemantics::kUnifiedPlan; return CreatePeerConnection(config, std::move(field_trials)); } std::unique_ptr CreatePeerConnection( const RTCConfiguration& config, std::unique_ptr field_trials) { auto observer = std::make_unique(); PeerConnectionDependencies pc_deps(observer.get()); pc_deps.trials = std::move(field_trials); auto result = pc_factory_->CreatePeerConnectionOrError(config, std::move(pc_deps)); EXPECT_TRUE(result.ok()); observer->SetPeerConnectionInterface(result.value().get()); return std::make_unique( pc_factory_, result.MoveValue(), std::move(observer)); } std::optional FindFirstSendCodecWithName( cricket::MediaType media_type, const std::string& name) const { std::vector codecs = pc_factory_->GetRtpSenderCapabilities(media_type).codecs; for (const auto& codec : codecs) { if (absl::EqualsIgnoreCase(codec.name, name)) { return codec; } } return std::nullopt; } protected: std::unique_ptr signaling_thread_; rtc::scoped_refptr pc_factory_; private: rtc::AutoThread main_thread_; }; TEST_F(SdpOfferAnswerTest, OnTrackReturnsProxiedObject) { auto caller = CreatePeerConnection(); auto callee = CreatePeerConnection(); auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); // Verify that caller->observer->OnTrack() has been called with a // proxied transceiver object. ASSERT_EQ(callee->observer()->on_track_transceivers_.size(), 1u); auto transceiver = callee->observer()->on_track_transceivers_[0]; // Since the signaling thread is not the current thread, // this will DCHECK if the transceiver is not proxied. transceiver->stopped(); } TEST_F(SdpOfferAnswerTest, BundleRejectsCodecCollisionsAudioVideo) { auto pc = CreatePeerConnection(); std::string sdp = "v=0\r\n" "o=- 0 3 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "a=group:BUNDLE 0 1\r\n" "a=fingerprint:sha-1 " "4A:AD:B9:B1:3F:82:18:3B:54:02:12:DF:3E:5D:49:6B:19:E5:7C:AB\r\n" "a=setup:actpass\r\n" "a=ice-ufrag:ETEn\r\n" "a=ice-pwd:OtSK0WpNtpUjkY4+86js7Z/l\r\n" "m=audio 9 UDP/TLS/RTP/SAVPF 111\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp-mux\r\n" "a=sendonly\r\n" "a=mid:0\r\n" "a=rtpmap:111 opus/48000/2\r\n" "m=video 9 UDP/TLS/RTP/SAVPF 111\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp-mux\r\n" "a=sendonly\r\n" "a=mid:1\r\n" "a=rtpmap:111 H264/90000\r\n" "a=fmtp:111 " "level-asymmetry-allowed=1;packetization-mode=0;profile-level-id=" "42e01f\r\n"; auto desc = CreateSessionDescription(SdpType::kOffer, sdp); ASSERT_NE(desc, nullptr); RTCError error; pc->SetRemoteDescription(std::move(desc), &error); // There is no error yet but the metrics counter will increase. EXPECT_TRUE(error.ok()); EXPECT_METRIC_EQ( 1, metrics::NumEvents("WebRTC.PeerConnection.ValidBundledPayloadTypes", false)); // Tolerate codec collisions in rejected m-lines. pc = CreatePeerConnection(); auto rejected_offer = CreateSessionDescription( SdpType::kOffer, absl::StrReplaceAll(sdp, {{"m=video 9 ", "m=video 0 "}})); pc->SetRemoteDescription(std::move(rejected_offer), &error); EXPECT_TRUE(error.ok()); EXPECT_METRIC_EQ( 1, metrics::NumEvents("WebRTC.PeerConnection.ValidBundledPayloadTypes", true)); } TEST_F(SdpOfferAnswerTest, BundleRejectsCodecCollisionsVideoFmtp) { auto pc = CreatePeerConnection(); std::string sdp = "v=0\r\n" "o=- 0 3 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "a=group:BUNDLE 0 1\r\n" "a=fingerprint:sha-1 " "4A:AD:B9:B1:3F:82:18:3B:54:02:12:DF:3E:5D:49:6B:19:E5:7C:AB\r\n" "a=setup:actpass\r\n" "a=ice-ufrag:ETEn\r\n" "a=ice-pwd:OtSK0WpNtpUjkY4+86js7Z/l\r\n" "m=video 9 UDP/TLS/RTP/SAVPF 111\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp-mux\r\n" "a=sendonly\r\n" "a=mid:0\r\n" "a=rtpmap:111 H264/90000\r\n" "a=fmtp:111 " "level-asymmetry-allowed=1;packetization-mode=0;profile-level-id=" "42e01f\r\n" "m=video 9 UDP/TLS/RTP/SAVPF 111\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp-mux\r\n" "a=sendonly\r\n" "a=mid:1\r\n" "a=rtpmap:111 H264/90000\r\n" "a=fmtp:111 " "level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=" "42e01f\r\n"; auto desc = CreateSessionDescription(SdpType::kOffer, sdp); ASSERT_NE(desc, nullptr); RTCError error; pc->SetRemoteDescription(std::move(desc), &error); EXPECT_TRUE(error.ok()); EXPECT_METRIC_EQ( 1, metrics::NumEvents("WebRTC.PeerConnection.ValidBundledPayloadTypes", false)); } TEST_F(SdpOfferAnswerTest, BundleCodecCollisionInDifferentBundlesAllowed) { auto pc = CreatePeerConnection(); std::string sdp = "v=0\r\n" "o=- 0 3 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "a=group:BUNDLE 0\r\n" "a=group:BUNDLE 1\r\n" "a=fingerprint:sha-1 " "4A:AD:B9:B1:3F:82:18:3B:54:02:12:DF:3E:5D:49:6B:19:E5:7C:AB\r\n" "a=setup:actpass\r\n" "a=ice-ufrag:ETEn\r\n" "a=ice-pwd:OtSK0WpNtpUjkY4+86js7Z/l\r\n" "m=video 9 UDP/TLS/RTP/SAVPF 111\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp-mux\r\n" "a=sendonly\r\n" "a=mid:0\r\n" "a=rtpmap:111 H264/90000\r\n" "a=fmtp:111 " "level-asymmetry-allowed=1;packetization-mode=0;profile-level-id=" "42e01f\r\n" "m=video 9 UDP/TLS/RTP/SAVPF 111\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp-mux\r\n" "a=sendonly\r\n" "a=mid:1\r\n" "a=rtpmap:111 H264/90000\r\n" "a=fmtp:111 " "level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=" "42e01f\r\n"; auto desc = CreateSessionDescription(SdpType::kOffer, sdp); ASSERT_NE(desc, nullptr); RTCError error; pc->SetRemoteDescription(std::move(desc), &error); EXPECT_TRUE(error.ok()); EXPECT_METRIC_EQ( 0, metrics::NumEvents("WebRTC.PeerConnection.ValidBundledPayloadTypes", false)); } TEST_F(SdpOfferAnswerTest, BundleMeasuresHeaderExtensionIdCollision) { auto pc = CreatePeerConnection(); std::string sdp = "v=0\r\n" "o=- 0 3 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "a=group:BUNDLE 0 1\r\n" "a=fingerprint:sha-1 " "4A:AD:B9:B1:3F:82:18:3B:54:02:12:DF:3E:5D:49:6B:19:E5:7C:AB\r\n" "a=setup:actpass\r\n" "a=ice-ufrag:ETEn\r\n" "a=ice-pwd:OtSK0WpNtpUjkY4+86js7Z/l\r\n" "m=audio 9 UDP/TLS/RTP/SAVPF 111\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp-mux\r\n" "a=sendonly\r\n" "a=mid:0\r\n" "a=rtpmap:111 opus/48000/2\r\n" "a=extmap:3 " "http://www.ietf.org/id/" "draft-holmer-rmcat-transport-wide-cc-extensions-01\r\n" "m=video 9 UDP/TLS/RTP/SAVPF 112\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp-mux\r\n" "a=sendonly\r\n" "a=mid:1\r\n" "a=rtpmap:112 VP8/90000\r\n" "a=extmap:3 " "http://www.ietf.org/id/" "draft-holmer-rmcat-transport-wide-cc-extensions-01\r\n"; auto desc = CreateSessionDescription(SdpType::kOffer, sdp); ASSERT_NE(desc, nullptr); RTCError error; pc->SetRemoteDescription(std::move(desc), &error); EXPECT_TRUE(error.ok()); } // extmap:3 is used with two different URIs which is not allowed. TEST_F(SdpOfferAnswerTest, BundleRejectsHeaderExtensionIdCollision) { auto pc = CreatePeerConnection(); std::string sdp = "v=0\r\n" "o=- 0 3 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "a=group:BUNDLE 0 1\r\n" "a=fingerprint:sha-1 " "4A:AD:B9:B1:3F:82:18:3B:54:02:12:DF:3E:5D:49:6B:19:E5:7C:AB\r\n" "a=setup:actpass\r\n" "a=ice-ufrag:ETEn\r\n" "a=ice-pwd:OtSK0WpNtpUjkY4+86js7Z/l\r\n" "m=audio 9 UDP/TLS/RTP/SAVPF 111\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp-mux\r\n" "a=sendonly\r\n" "a=mid:0\r\n" "a=rtpmap:111 opus/48000/2\r\n" "a=extmap:3 " "http://www.ietf.org/id/" "draft-holmer-rmcat-transport-wide-cc-extensions-01\r\n" "m=video 9 UDP/TLS/RTP/SAVPF 112\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp-mux\r\n" "a=sendonly\r\n" "a=mid:1\r\n" "a=rtpmap:112 VP8/90000\r\n" "a=extmap:3 urn:3gpp:video-orientation\r\n"; auto desc = CreateSessionDescription(SdpType::kOffer, sdp); ASSERT_NE(desc, nullptr); RTCError error; pc->SetRemoteDescription(std::move(desc), &error); EXPECT_FALSE(error.ok()); EXPECT_EQ(error.type(), RTCErrorType::INVALID_PARAMETER); } // transport-wide cc is negotiated with two different ids 3 and 4. // This is not a good idea but tolerable. TEST_F(SdpOfferAnswerTest, BundleAcceptsDifferentIdsForSameExtension) { auto pc = CreatePeerConnection(); std::string sdp = "v=0\r\n" "o=- 0 3 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "a=group:BUNDLE 0 1\r\n" "a=fingerprint:sha-1 " "4A:AD:B9:B1:3F:82:18:3B:54:02:12:DF:3E:5D:49:6B:19:E5:7C:AB\r\n" "a=setup:actpass\r\n" "a=ice-ufrag:ETEn\r\n" "a=ice-pwd:OtSK0WpNtpUjkY4+86js7Z/l\r\n" "m=audio 9 UDP/TLS/RTP/SAVPF 111\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp-mux\r\n" "a=sendonly\r\n" "a=mid:0\r\n" "a=rtpmap:111 opus/48000/2\r\n" "a=extmap:3 " "http://www.ietf.org/id/" "draft-holmer-rmcat-transport-wide-cc-extensions-01\r\n" "m=video 9 UDP/TLS/RTP/SAVPF 112\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp-mux\r\n" "a=sendonly\r\n" "a=mid:1\r\n" "a=rtpmap:112 VP8/90000\r\n" "a=extmap:4 " "http://www.ietf.org/id/" "draft-holmer-rmcat-transport-wide-cc-extensions-01\r\n"; auto desc = CreateSessionDescription(SdpType::kOffer, sdp); ASSERT_NE(desc, nullptr); RTCError error; pc->SetRemoteDescription(std::move(desc), &error); EXPECT_TRUE(error.ok()); } TEST_F(SdpOfferAnswerTest, LargeMidsAreRejected) { auto pc = CreatePeerConnection(); std::string sdp = "v=0\r\n" "o=- 0 3 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "a=fingerprint:sha-1 " "4A:AD:B9:B1:3F:82:18:3B:54:02:12:DF:3E:5D:49:6B:19:E5:7C:AB\r\n" "a=setup:actpass\r\n" "a=ice-ufrag:ETEn\r\n" "a=ice-pwd:OtSK0WpNtpUjkY4+86js7Z/l\r\n" "m=video 9 UDP/TLS/RTP/SAVPF 111\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp-mux\r\n" "a=sendonly\r\n" "a=rtpmap:111 VP8/90000\r\n" "a=mid:01234567890123456\r\n"; auto desc = CreateSessionDescription(SdpType::kOffer, sdp); ASSERT_NE(desc, nullptr); RTCError error; pc->SetRemoteDescription(std::move(desc), &error); EXPECT_FALSE(error.ok()); EXPECT_EQ(error.type(), RTCErrorType::INVALID_PARAMETER); } TEST_F(SdpOfferAnswerTest, RollbackPreservesAddTrackMid) { std::string sdp = "v=0\r\n" "o=- 4131505339648218884 3 IN IP4 **-----**\r\n" "s=-\r\n" "t=0 0\r\n" "a=ice-lite\r\n" "a=msid-semantic: WMS 100030878598094:4Qs1PjbLM32RK5u3\r\n" "a=ice-ufrag:zGWFZ+fVXDeN6UoI/136\r\n" "a=ice-pwd:9AUNgUqRNI5LSIrC1qFD2iTR\r\n" "a=fingerprint:sha-256 " "AD:52:52:E0:B1:37:34:21:0E:15:8E:B7:56:56:7B:B4:39:0E:6D:1C:F5:84:A7:EE:" "B5:27:3E:30:B1:7D:69:42\r\n" "a=extmap:1 urn:ietf:params:rtp-hdrext:ssrc-audio-level\r\n" "a=extmap:4 urn:ietf:params:rtp-hdrext:sdes:mid\r\n" "a=group:BUNDLE 0 1\r\n" "m=audio 40005 UDP/TLS/RTP/SAVPF 111\r\n" "a=rtpmap:111 opus/48000/2\r\n" "a=fmtp:111 " "maxaveragebitrate=20000;maxplaybackrate=16000;minptime=10;usedtx=1;" "useinbandfec=1;stereo=0\r\n" "a=rtcp-fb:111 nack\r\n" "a=setup:passive\r\n" "a=mid:0\r\n" "a=msid:- 75156ebd-e705-4da1-920e-2dac39794dfd\r\n" "a=ptime:60\r\n" "a=recvonly\r\n" "a=rtcp-mux\r\n" "m=audio 40005 UDP/TLS/RTP/SAVPF 111\r\n" "a=rtpmap:111 opus/48000/2\r\n" "a=fmtp:111 " "maxaveragebitrate=20000;maxplaybackrate=16000;minptime=10;usedtx=1;" "useinbandfec=1;stereo=0\r\n" "a=rtcp-fb:111 nack\r\n" "a=setup:passive\r\n" "a=mid:1\r\n" "a=msid:100030878598094:4Qs1PjbLM32RK5u3 9695447562408476674\r\n" "a=ptime:60\r\n" "a=sendonly\r\n" "a=ssrc:2565730539 cname:100030878598094:4Qs1PjbLM32RK5u3\r\n" "a=rtcp-mux\r\n"; auto pc = CreatePeerConnection(); auto audio_track = pc->AddAudioTrack("audio_track", {}); auto first_transceiver = pc->pc()->GetTransceivers()[0]; EXPECT_FALSE(first_transceiver->mid().has_value()); auto desc = CreateSessionDescription(SdpType::kOffer, sdp); ASSERT_NE(desc, nullptr); RTCError error; ASSERT_TRUE(pc->SetRemoteDescription(std::move(desc))); pc->CreateAnswerAndSetAsLocal(); auto saved_mid = first_transceiver->mid(); EXPECT_TRUE(saved_mid.has_value()); auto offer_before_rollback = pc->CreateOfferAndSetAsLocal(); EXPECT_EQ(saved_mid, first_transceiver->mid()); auto rollback = pc->CreateRollback(); ASSERT_NE(rollback, nullptr); ASSERT_TRUE(pc->SetLocalDescription(std::move(rollback))); EXPECT_EQ(saved_mid, first_transceiver->mid()); auto offer2 = pc->CreateOfferAndSetAsLocal(); ASSERT_NE(offer2, nullptr); EXPECT_EQ(saved_mid, first_transceiver->mid()); } #ifdef WEBRTC_HAVE_SCTP TEST_F(SdpOfferAnswerTest, RejectedDataChannelsDoNotGetReoffered) { auto pc = CreatePeerConnection(); EXPECT_TRUE(pc->pc()->CreateDataChannelOrError("dc", nullptr).ok()); EXPECT_TRUE(pc->CreateOfferAndSetAsLocal()); auto mid = pc->pc()->local_description()->description()->contents()[0].mid(); // An answer that rejects the datachannel content. std::string sdp = "v=0\r\n" "o=- 4131505339648218884 3 IN IP4 **-----**\r\n" "s=-\r\n" "t=0 0\r\n" "a=ice-ufrag:zGWFZ+fVXDeN6UoI/136\r\n" "a=ice-pwd:9AUNgUqRNI5LSIrC1qFD2iTR\r\n" "a=fingerprint:sha-256 " "AD:52:52:E0:B1:37:34:21:0E:15:8E:B7:56:56:7B:B4:39:0E:6D:1C:F5:84:A7:EE:" "B5:27:3E:30:B1:7D:69:42\r\n" "a=setup:passive\r\n" "m=application 0 UDP/DTLS/SCTP webrtc-datachannel\r\n" "c=IN IP4 0.0.0.0\r\n" "a=sctp-port:5000\r\n" "a=max-message-size:262144\r\n" "a=mid:" + mid + "\r\n"; auto answer = CreateSessionDescription(SdpType::kAnswer, sdp); ASSERT_TRUE(pc->SetRemoteDescription(std::move(answer))); // The subsequent offer should not recycle the m-line since the existing data // channel is closed. auto offer = pc->CreateOffer(); const auto& offer_contents = offer->description()->contents(); ASSERT_EQ(offer_contents.size(), 1u); EXPECT_EQ(offer_contents[0].mid(), mid); EXPECT_EQ(offer_contents[0].rejected, true); } TEST_F(SdpOfferAnswerTest, RejectedDataChannelsDoGetReofferedWhenActive) { auto pc = CreatePeerConnection(); EXPECT_TRUE(pc->pc()->CreateDataChannelOrError("dc", nullptr).ok()); EXPECT_TRUE(pc->CreateOfferAndSetAsLocal()); auto mid = pc->pc()->local_description()->description()->contents()[0].mid(); // An answer that rejects the datachannel content. std::string sdp = "v=0\r\n" "o=- 4131505339648218884 3 IN IP4 **-----**\r\n" "s=-\r\n" "t=0 0\r\n" "a=ice-ufrag:zGWFZ+fVXDeN6UoI/136\r\n" "a=ice-pwd:9AUNgUqRNI5LSIrC1qFD2iTR\r\n" "a=fingerprint:sha-256 " "AD:52:52:E0:B1:37:34:21:0E:15:8E:B7:56:56:7B:B4:39:0E:6D:1C:F5:84:A7:EE:" "B5:27:3E:30:B1:7D:69:42\r\n" "a=setup:passive\r\n" "m=application 0 UDP/DTLS/SCTP webrtc-datachannel\r\n" "c=IN IP4 0.0.0.0\r\n" "a=sctp-port:5000\r\n" "a=max-message-size:262144\r\n" "a=mid:" + mid + "\r\n"; auto answer = CreateSessionDescription(SdpType::kAnswer, sdp); ASSERT_TRUE(pc->SetRemoteDescription(std::move(answer))); // The subsequent offer should recycle the m-line when there is a new data // channel. EXPECT_TRUE(pc->pc()->CreateDataChannelOrError("dc2", nullptr).ok()); EXPECT_TRUE(pc->pc()->ShouldFireNegotiationNeededEvent( pc->observer()->latest_negotiation_needed_event())); auto offer = pc->CreateOffer(); const auto& offer_contents = offer->description()->contents(); ASSERT_EQ(offer_contents.size(), 1u); EXPECT_EQ(offer_contents[0].mid(), mid); EXPECT_EQ(offer_contents[0].rejected, false); } #endif // WEBRTC_HAVE_SCTP TEST_F(SdpOfferAnswerTest, SimulcastAnswerWithNoRidsIsRejected) { auto pc = CreatePeerConnection(); RtpTransceiverInit init; RtpEncodingParameters rid1; rid1.rid = "1"; init.send_encodings.push_back(rid1); RtpEncodingParameters rid2; rid2.rid = "2"; init.send_encodings.push_back(rid2); auto transceiver = pc->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init); EXPECT_TRUE(pc->CreateOfferAndSetAsLocal()); auto mid = pc->pc()->local_description()->description()->contents()[0].mid(); // A SDP answer with simulcast but without mid/rid extensions. std::string sdp = "v=0\r\n" "o=- 4131505339648218884 3 IN IP4 **-----**\r\n" "s=-\r\n" "t=0 0\r\n" "a=ice-ufrag:zGWFZ+fVXDeN6UoI/136\r\n" "a=ice-pwd:9AUNgUqRNI5LSIrC1qFD2iTR\r\n" "a=fingerprint:sha-256 " "AD:52:52:E0:B1:37:34:21:0E:15:8E:B7:56:56:7B:B4:39:0E:6D:1C:F5:84:A7:EE:" "B5:27:3E:30:B1:7D:69:42\r\n" "a=setup:passive\r\n" "m=video 9 UDP/TLS/RTP/SAVPF 96\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp:9 IN IP4 0.0.0.0\r\n" "a=mid:" + mid + "\r\n" "a=recvonly\r\n" "a=rtcp-mux\r\n" "a=rtcp-rsize\r\n" "a=rtpmap:96 VP8/90000\r\n" "a=rid:1 recv\r\n" "a=rid:2 recv\r\n" "a=simulcast:recv 1;2\r\n"; std::string extensions = "a=extmap:9 urn:ietf:params:rtp-hdrext:sdes:mid\r\n" "a=extmap:10 urn:ietf:params:rtp-hdrext:sdes:rtp-stream-id\r\n"; auto answer = CreateSessionDescription(SdpType::kAnswer, sdp); EXPECT_FALSE(pc->SetRemoteDescription(std::move(answer))); auto answer_with_extensions = CreateSessionDescription(SdpType::kAnswer, sdp + extensions); EXPECT_TRUE(pc->SetRemoteDescription(std::move(answer_with_extensions))); // Tolerate the lack of mid/rid extensions in rejected m-lines. EXPECT_TRUE(pc->CreateOfferAndSetAsLocal()); auto rejected_answer = CreateSessionDescription( SdpType::kAnswer, absl::StrReplaceAll(sdp, {{"m=video 9 ", "m=video 0 "}})); EXPECT_TRUE(pc->SetRemoteDescription(std::move(rejected_answer))); } TEST_F(SdpOfferAnswerTest, SimulcastOfferWithMixedCodec) { auto pc = CreatePeerConnection( FieldTrials::CreateNoGlobal("WebRTC-MixedCodecSimulcast/Enabled/")); std::optional vp8_codec_capability = FindFirstSendCodecWithName(cricket::MEDIA_TYPE_VIDEO, cricket::kVp8CodecName); ASSERT_TRUE(vp8_codec_capability); std::optional vp9_codec_capability = FindFirstSendCodecWithName(cricket::MEDIA_TYPE_VIDEO, cricket::kVp9CodecName); ASSERT_TRUE(vp9_codec_capability); RtpTransceiverInit init; RtpEncodingParameters rid1; rid1.rid = "1"; rid1.codec = *vp8_codec_capability; init.send_encodings.push_back(rid1); RtpEncodingParameters rid2; rid2.rid = "2"; rid2.codec = *vp9_codec_capability; init.send_encodings.push_back(rid2); auto transceiver = pc->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init); auto offer = pc->CreateOffer(); auto& offer_contents = offer->description()->contents(); auto send_codecs = offer_contents[0].media_description()->codecs(); // Verify that the serialized SDP includes pt=. std::string sdp; offer->ToString(&sdp); const cricket::Codec* vp8_send_codec = nullptr; const cricket::Codec* vp9_send_codec = nullptr; for (auto& codec : send_codecs) { if (codec.name == vp8_codec_capability->name && !vp8_send_codec) { vp8_send_codec = &codec; } if (codec.name == vp9_codec_capability->name && !vp9_send_codec) { vp9_send_codec = &codec; } } ASSERT_TRUE(vp8_send_codec); ASSERT_TRUE(vp9_send_codec); EXPECT_THAT(sdp, testing::HasSubstr("a=rid:1 send pt=" + std::to_string(vp8_send_codec->id))); EXPECT_THAT(sdp, testing::HasSubstr("a=rid:2 send pt=" + std::to_string(vp9_send_codec->id))); // Verify that SDP containing pt= can be parsed correctly. auto offer2 = CreateSessionDescription(SdpType::kOffer, sdp); auto& offer_contents2 = offer2->description()->contents(); auto send_rids2 = offer_contents2[0].media_description()->streams()[0].rids(); EXPECT_EQ(send_rids2[0].codecs.size(), 1u); EXPECT_EQ(send_rids2[0].codecs[0], *vp8_send_codec); EXPECT_EQ(send_rids2[1].codecs.size(), 1u); EXPECT_EQ(send_rids2[1].codecs[0], *vp9_send_codec); } TEST_F(SdpOfferAnswerTest, SimulcastAnswerWithPayloadType) { auto pc = CreatePeerConnection( FieldTrials::CreateNoGlobal("WebRTC-MixedCodecSimulcast/Enabled/")); // A SDP offer with recv simulcast with payload type std::string sdp = "v=0\r\n" "o=- 4131505339648218884 3 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "a=ice-ufrag:zGWFZ+fVXDeN6UoI/136\r\n" "a=ice-pwd:9AUNgUqRNI5LSIrC1qFD2iTR\r\n" "a=fingerprint:sha-256 " "AD:52:52:E0:B1:37:34:21:0E:15:8E:B7:56:56:7B:B4:39:0E:6D:1C:F5:84:A7:EE:" "B5:27:3E:30:B1:7D:69:42\r\n" "a=setup:passive\r\n" "m=video 9 UDP/TLS/RTP/SAVPF 96 97\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp:9 IN IP4 0.0.0.0\r\n" "a=mid:0\r\n" "a=extmap:9 urn:ietf:params:rtp-hdrext:sdes:mid\r\n" "a=extmap:10 urn:ietf:params:rtp-hdrext:sdes:rtp-stream-id\r\n" "a=recvonly\r\n" "a=rtcp-mux\r\n" "a=rtcp-rsize\r\n" "a=rtpmap:96 VP8/90000\r\n" "a=rtpmap:97 VP9/90000\r\n" "a=rid:1 recv pt=96\r\n" "a=rid:2 recv pt=97\r\n" "a=simulcast:recv 1;2\r\n"; auto offer = CreateSessionDescription(SdpType::kOffer, sdp); EXPECT_TRUE(pc->SetRemoteDescription(std::move(offer))); auto transceiver = pc->pc()->GetTransceivers()[0]; EXPECT_TRUE( transceiver->SetDirectionWithError(RtpTransceiverDirection::kSendOnly) .ok()); // Check the generated SDP. auto answer = pc->CreateAnswer(); answer->ToString(&sdp); EXPECT_THAT(sdp, testing::HasSubstr("a=rid:1 send pt=96\r\n")); EXPECT_THAT(sdp, testing::HasSubstr("a=rid:2 send pt=97\r\n")); EXPECT_TRUE(pc->SetLocalDescription(std::move(answer))); } TEST_F(SdpOfferAnswerTest, ExpectAllSsrcsSpecifiedInSsrcGroupFid) { auto pc = CreatePeerConnection(); std::string sdp = "v=0\r\n" "o=- 0 3 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "a=group:BUNDLE 0\r\n" "a=fingerprint:sha-1 " "4A:AD:B9:B1:3F:82:18:3B:54:02:12:DF:3E:5D:49:6B:19:E5:7C:AB\r\n" "a=setup:actpass\r\n" "a=ice-ufrag:ETEn\r\n" "a=ice-pwd:OtSK0WpNtpUjkY4+86js7Z/l\r\n" "m=video 9 UDP/TLS/RTP/SAVPF 96 97\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp-mux\r\n" "a=sendonly\r\n" "a=mid:0\r\n" "a=rtpmap:96 H264/90000\r\n" "a=fmtp:96 " "level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=" "42e01f\r\n" "a=rtpmap:97 rtx/90000\r\n" "a=fmtp:97 apt=96\r\n" "a=ssrc-group:FID 1 2\r\n" "a=ssrc:1 cname:test\r\n"; auto offer = CreateSessionDescription(SdpType::kOffer, sdp); RTCError error; pc->SetRemoteDescription(std::move(offer), &error); EXPECT_FALSE(error.ok()); EXPECT_EQ(error.type(), RTCErrorType::INVALID_PARAMETER); } TEST_F(SdpOfferAnswerTest, ExpectAllSsrcsSpecifiedInSsrcGroupFecFr) { auto pc = CreatePeerConnection(); std::string sdp = "v=0\r\n" "o=- 0 3 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "a=group:BUNDLE 0\r\n" "a=fingerprint:sha-1 " "4A:AD:B9:B1:3F:82:18:3B:54:02:12:DF:3E:5D:49:6B:19:E5:7C:AB\r\n" "a=setup:actpass\r\n" "a=ice-ufrag:ETEn\r\n" "a=ice-pwd:OtSK0WpNtpUjkY4+86js7Z/l\r\n" "m=video 9 UDP/TLS/RTP/SAVPF 96 98\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp-mux\r\n" "a=sendonly\r\n" "a=mid:0\r\n" "a=rtpmap:96 H264/90000\r\n" "a=fmtp:96 " "level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=" "42e01f\r\n" "a=rtpmap:98 flexfec-03/90000\r\n" "a=fmtp:98 repair-window=10000000\r\n" "a=ssrc-group:FEC-FR 1 2\r\n" "a=ssrc:1 cname:test\r\n"; auto offer = CreateSessionDescription(SdpType::kOffer, sdp); RTCError error; pc->SetRemoteDescription(std::move(offer), &error); EXPECT_FALSE(error.ok()); EXPECT_EQ(error.type(), RTCErrorType::INVALID_PARAMETER); } TEST_F(SdpOfferAnswerTest, ExpectTwoSsrcsInSsrcGroupFid) { auto pc = CreatePeerConnection(); std::string sdp = "v=0\r\n" "o=- 0 3 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "a=group:BUNDLE 0\r\n" "a=fingerprint:sha-1 " "4A:AD:B9:B1:3F:82:18:3B:54:02:12:DF:3E:5D:49:6B:19:E5:7C:AB\r\n" "a=setup:actpass\r\n" "a=ice-ufrag:ETEn\r\n" "a=ice-pwd:OtSK0WpNtpUjkY4+86js7Z/l\r\n" "m=video 9 UDP/TLS/RTP/SAVPF 96 97\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp-mux\r\n" "a=sendonly\r\n" "a=mid:0\r\n" "a=rtpmap:96 H264/90000\r\n" "a=fmtp:96 " "level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=" "42e01f\r\n" "a=rtpmap:97 rtx/90000\r\n" "a=fmtp:97 apt=96\r\n" "a=ssrc-group:FID 1 2 3\r\n" "a=ssrc:1 cname:test\r\n" "a=ssrc:2 cname:test\r\n" "a=ssrc:3 cname:test\r\n"; auto offer = CreateSessionDescription(SdpType::kOffer, sdp); RTCError error; pc->SetRemoteDescription(std::move(offer), &error); EXPECT_FALSE(error.ok()); EXPECT_EQ(error.type(), RTCErrorType::INVALID_PARAMETER); } TEST_F(SdpOfferAnswerTest, ExpectTwoSsrcsInSsrcGroupFecFr) { auto pc = CreatePeerConnection(); std::string sdp = "v=0\r\n" "o=- 0 3 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "a=group:BUNDLE 0\r\n" "a=fingerprint:sha-1 " "4A:AD:B9:B1:3F:82:18:3B:54:02:12:DF:3E:5D:49:6B:19:E5:7C:AB\r\n" "a=setup:actpass\r\n" "a=ice-ufrag:ETEn\r\n" "a=ice-pwd:OtSK0WpNtpUjkY4+86js7Z/l\r\n" "m=video 9 UDP/TLS/RTP/SAVPF 96 98\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp-mux\r\n" "a=sendonly\r\n" "a=mid:0\r\n" "a=rtpmap:96 H264/90000\r\n" "a=fmtp:96 " "level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=" "42e01f\r\n" "a=rtpmap:98 flexfec-03/90000\r\n" "a=fmtp:98 repair-window=10000000\r\n" "a=ssrc-group:FEC-FR 1 2 3\r\n" "a=ssrc:1 cname:test\r\n" "a=ssrc:2 cname:test\r\n" "a=ssrc:3 cname:test\r\n"; auto offer = CreateSessionDescription(SdpType::kOffer, sdp); RTCError error; pc->SetRemoteDescription(std::move(offer), &error); EXPECT_FALSE(error.ok()); EXPECT_EQ(error.type(), RTCErrorType::INVALID_PARAMETER); } TEST_F(SdpOfferAnswerTest, ExpectAtMostFourSsrcsInSsrcGroupSIM) { auto pc = CreatePeerConnection(); std::string sdp = "v=0\r\n" "o=- 0 3 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "a=group:BUNDLE 0\r\n" "a=fingerprint:sha-1 " "4A:AD:B9:B1:3F:82:18:3B:54:02:12:DF:3E:5D:49:6B:19:E5:7C:AB\r\n" "a=setup:actpass\r\n" "a=ice-ufrag:ETEn\r\n" "a=ice-pwd:OtSK0WpNtpUjkY4+86js7Z/l\r\n" "m=video 9 UDP/TLS/RTP/SAVPF 96 97\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp-mux\r\n" "a=sendonly\r\n" "a=mid:0\r\n" "a=rtpmap:96 H264/90000\r\n" "a=fmtp:96 " "level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=" "42e01f\r\n" "a=rtpmap:97 rtx/90000\r\n" "a=fmtp:97 apt=96\r\n" "a=ssrc-group:SIM 1 2 3 4\r\n" "a=ssrc:1 cname:test\r\n" "a=ssrc:2 cname:test\r\n" "a=ssrc:3 cname:test\r\n" "a=ssrc:4 cname:test\r\n"; auto offer = CreateSessionDescription(SdpType::kOffer, sdp); RTCError error; pc->SetRemoteDescription(std::move(offer), &error); EXPECT_FALSE(error.ok()); EXPECT_EQ(error.type(), RTCErrorType::INVALID_PARAMETER); } TEST_F(SdpOfferAnswerTest, DuplicateSsrcsDisallowedInLocalDescription) { auto pc = CreatePeerConnection(); pc->AddAudioTrack("audio_track", {}); pc->AddVideoTrack("video_track", {}); auto offer = pc->CreateOffer(); auto& offer_contents = offer->description()->contents(); ASSERT_EQ(offer_contents.size(), 2u); uint32_t second_ssrc = offer_contents[1].media_description()->first_ssrc(); offer->description() ->contents()[0] .media_description() ->mutable_streams()[0] .ssrcs[0] = second_ssrc; EXPECT_FALSE(pc->SetLocalDescription(std::move(offer))); } TEST_F(SdpOfferAnswerTest, DuplicateSsrcsAcrossMlinesDisallowedInLocalDescriptionTwoSsrc) { auto pc = CreatePeerConnection(); pc->AddAudioTrack("audio_track", {}); pc->AddVideoTrack("video_track", {}); auto offer = pc->CreateOffer(); auto& offer_contents = offer->description()->contents(); ASSERT_EQ(offer_contents.size(), 2u); uint32_t audio_ssrc = offer_contents[0].media_description()->first_ssrc(); ASSERT_EQ(offer_contents[1].media_description()->streams().size(), 1u); auto& video_stream = offer->description() ->contents()[1] .media_description() ->mutable_streams()[0]; ASSERT_EQ(video_stream.ssrcs.size(), 2u); ASSERT_EQ(video_stream.ssrc_groups.size(), 1u); video_stream.ssrcs[1] = audio_ssrc; video_stream.ssrc_groups[0].ssrcs[1] = audio_ssrc; video_stream.ssrc_groups[0].semantics = cricket::kSimSsrcGroupSemantics; std::string sdp; offer->ToString(&sdp); // Trim the last two lines which contain ssrc-specific attributes // that we change/munge above. Guarded with expectation about what // should be removed in case the SDP generation changes. size_t end = sdp.rfind("\r\n"); end = sdp.rfind("\r\n", end - 2); end = sdp.rfind("\r\n", end - 2); EXPECT_EQ(sdp.substr(end + 2), "a=ssrc:" + rtc::ToString(audio_ssrc) + " cname:" + video_stream.cname + "\r\n" "a=ssrc:" + rtc::ToString(audio_ssrc) + " msid:- video_track\r\n"); auto modified_offer = CreateSessionDescription(SdpType::kOffer, sdp.substr(0, end + 2)); EXPECT_FALSE(pc->SetLocalDescription(std::move(modified_offer))); } TEST_F(SdpOfferAnswerTest, DuplicateSsrcsAcrossMlinesDisallowedInLocalDescriptionThreeSsrcs) { auto pc = CreatePeerConnection(); pc->AddAudioTrack("audio_track", {}); pc->AddVideoTrack("video_track", {}); auto offer = pc->CreateOffer(); auto& offer_contents = offer->description()->contents(); ASSERT_EQ(offer_contents.size(), 2u); uint32_t audio_ssrc = offer_contents[0].media_description()->first_ssrc(); ASSERT_EQ(offer_contents[1].media_description()->streams().size(), 1u); auto& video_stream = offer->description() ->contents()[1] .media_description() ->mutable_streams()[0]; ASSERT_EQ(video_stream.ssrcs.size(), 2u); ASSERT_EQ(video_stream.ssrc_groups.size(), 1u); video_stream.ssrcs.push_back(audio_ssrc); video_stream.ssrc_groups[0].ssrcs.push_back(audio_ssrc); video_stream.ssrc_groups[0].semantics = cricket::kSimSsrcGroupSemantics; std::string sdp; offer->ToString(&sdp); // Trim the last two lines which contain ssrc-specific attributes // that we change/munge above. Guarded with expectation about what // should be removed in case the SDP generation changes. size_t end = sdp.rfind("\r\n"); end = sdp.rfind("\r\n", end - 2); end = sdp.rfind("\r\n", end - 2); EXPECT_EQ(sdp.substr(end + 2), "a=ssrc:" + rtc::ToString(audio_ssrc) + " cname:" + video_stream.cname + "\r\n" "a=ssrc:" + rtc::ToString(audio_ssrc) + " msid:- video_track\r\n"); auto modified_offer = CreateSessionDescription(SdpType::kOffer, sdp.substr(0, end + 2)); EXPECT_FALSE(pc->SetLocalDescription(std::move(modified_offer))); } TEST_F(SdpOfferAnswerTest, AllowOnlyOneSsrcGroupPerSemanticAndPrimarySsrc) { auto pc = CreatePeerConnection(); pc->AddAudioTrack("audio_track", {}); pc->AddVideoTrack("video_track", {}); auto offer = pc->CreateOffer(); auto& offer_contents = offer->description()->contents(); ASSERT_EQ(offer_contents.size(), 2u); uint32_t audio_ssrc = offer_contents[0].media_description()->first_ssrc(); ASSERT_EQ(offer_contents[1].media_description()->streams().size(), 1u); auto& video_stream = offer->description() ->contents()[1] .media_description() ->mutable_streams()[0]; ASSERT_EQ(video_stream.ssrcs.size(), 2u); ASSERT_EQ(video_stream.ssrc_groups.size(), 1u); video_stream.ssrcs.push_back(audio_ssrc); video_stream.ssrc_groups.push_back( {cricket::kFidSsrcGroupSemantics, {video_stream.ssrcs[0], audio_ssrc}}); std::string sdp; offer->ToString(&sdp); // Trim the last two lines which contain ssrc-specific attributes // that we change/munge above. Guarded with expectation about what // should be removed in case the SDP generation changes. size_t end = sdp.rfind("\r\n"); end = sdp.rfind("\r\n", end - 2); end = sdp.rfind("\r\n", end - 2); EXPECT_EQ(sdp.substr(end + 2), "a=ssrc:" + rtc::ToString(audio_ssrc) + " cname:" + video_stream.cname + "\r\n" "a=ssrc:" + rtc::ToString(audio_ssrc) + " msid:- video_track\r\n"); auto modified_offer = CreateSessionDescription(SdpType::kOffer, sdp.substr(0, end + 2)); EXPECT_FALSE(pc->SetLocalDescription(std::move(modified_offer))); } TEST_F(SdpOfferAnswerTest, OfferWithRtxAndNoMsidIsNotRejected) { auto pc = CreatePeerConnection(); std::string sdp = "v=0\r\n" "o=- 0 3 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "a=group:BUNDLE 0\r\n" "a=fingerprint:sha-1 " "4A:AD:B9:B1:3F:82:18:3B:54:02:12:DF:3E:5D:49:6B:19:E5:7C:AB\r\n" "a=setup:actpass\r\n" "a=ice-ufrag:ETEn\r\n" "a=ice-pwd:OtSK0WpNtpUjkY4+86js7Z/l\r\n" "m=video 9 UDP/TLS/RTP/SAVPF 96 97\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp-mux\r\n" "a=sendonly\r\n" "a=mid:0\r\n" // "a=msid:stream obsoletetrack\r\n" "a=rtpmap:96 VP8/90000\r\n" "a=rtpmap:97 rtx/90000\r\n" "a=fmtp:97 apt=96\r\n" "a=ssrc-group:FID 1 2\r\n" "a=ssrc:1 cname:test\r\n" "a=ssrc:2 cname:test\r\n"; auto offer = CreateSessionDescription(SdpType::kOffer, sdp); EXPECT_TRUE(pc->SetRemoteDescription(std::move(offer))); } TEST_F(SdpOfferAnswerTest, RejectsAnswerWithInvalidTransport) { auto pc1 = CreatePeerConnection(); pc1->AddAudioTrack("audio_track", {}); auto pc2 = CreatePeerConnection(); pc2->AddAudioTrack("anotheraudio_track", {}); auto initial_offer = pc1->CreateOfferAndSetAsLocal(); ASSERT_EQ(initial_offer->description()->contents().size(), 1u); auto mid = initial_offer->description()->contents()[0].mid(); EXPECT_TRUE(pc2->SetRemoteDescription(std::move(initial_offer))); auto initial_answer = pc2->CreateAnswerAndSetAsLocal(); std::string sdp; initial_answer->ToString(&sdp); EXPECT_TRUE(pc1->SetRemoteDescription(std::move(initial_answer))); auto transceivers = pc1->pc()->GetTransceivers(); ASSERT_EQ(transceivers.size(), 1u); // This stops the only transport. transceivers[0]->StopStandard(); auto subsequent_offer = pc1->CreateOfferAndSetAsLocal(); // But the remote answers with a non-rejected m-line which is not valid. auto bad_answer = CreateSessionDescription( SdpType::kAnswer, absl::StrReplaceAll(sdp, {{"a=group:BUNDLE " + mid + "\r\n", ""}})); RTCError error; pc1->SetRemoteDescription(std::move(bad_answer), &error); EXPECT_FALSE(error.ok()); EXPECT_EQ(error.type(), RTCErrorType::INVALID_PARAMETER); } TEST_F(SdpOfferAnswerTest, SdpMungingWithInvalidPayloadTypeIsRejected) { auto pc = CreatePeerConnection(); pc->AddAudioTrack("audio_track", {}); auto offer = pc->CreateOffer(); ASSERT_EQ(offer->description()->contents().size(), 1u); auto* audio = offer->description()->contents()[0].media_description(); ASSERT_GT(audio->codecs().size(), 0u); EXPECT_TRUE(audio->rtcp_mux()); auto codecs = audio->codecs(); for (int invalid_payload_type = 64; invalid_payload_type < 96; invalid_payload_type++) { codecs[0].id = invalid_payload_type; // The range [64-95] is disallowed with rtcp_mux. audio->set_codecs(codecs); // ASSERT to avoid getting into a bad state. ASSERT_FALSE(pc->SetLocalDescription(offer->Clone())); ASSERT_FALSE(pc->SetRemoteDescription(offer->Clone())); } } TEST_F(SdpOfferAnswerTest, MsidSignalingInSubsequentOfferAnswer) { auto pc = CreatePeerConnection(); pc->AddAudioTrack("audio_track", {}); std::string sdp = "v=0\r\n" "o=- 0 3 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "a=msid-semantic: WMS\r\n" "a=fingerprint:sha-1 " "4A:AD:B9:B1:3F:82:18:3B:54:02:12:DF:3E:5D:49:6B:19:E5:7C:AB\r\n" "a=setup:actpass\r\n" "a=ice-ufrag:ETEn\r\n" "a=ice-pwd:OtSK0WpNtpUjkY4+86js7Z/l\r\n" "m=audio 9 UDP/TLS/RTP/SAVPF 111\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp:9 IN IP4 0.0.0.0\r\n" "a=recvonly\r\n" "a=rtcp-mux\r\n" "a=rtpmap:111 opus/48000/2\r\n"; auto offer = CreateSessionDescription(SdpType::kOffer, sdp); EXPECT_TRUE(pc->SetRemoteDescription(std::move(offer))); // Check the generated SDP. auto answer = pc->CreateAnswer(); answer->ToString(&sdp); EXPECT_NE(std::string::npos, sdp.find("a=msid:- audio_track\r\n")); EXPECT_TRUE(pc->SetLocalDescription(std::move(answer))); // Check the local description object. auto local_description = pc->pc()->local_description(); ASSERT_EQ(local_description->description()->contents().size(), 1u); auto streams = local_description->description() ->contents()[0] .media_description() ->streams(); ASSERT_EQ(streams.size(), 1u); EXPECT_EQ(streams[0].id, "audio_track"); // Check the serialization of the local description. local_description->ToString(&sdp); EXPECT_NE(std::string::npos, sdp.find("a=msid:- audio_track\r\n")); } // Regression test for crbug.com/328522463 // where the stream parameters got recreated which changed the ssrc. TEST_F(SdpOfferAnswerTest, MsidSignalingUnknownRespondsWithMsidAndKeepsSsrc) { auto pc = CreatePeerConnection(); pc->AddAudioTrack("audio_track", {"default"}); std::string sdp = "v=0\r\n" "o=- 0 3 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "a=group:BUNDLE 0\r\n" // "a=msid-semantic: WMS *\r\n" "a=ice-ufrag:ETEn\r\n" "a=ice-pwd:OtSK0WpNtpUjkY4+86js7Z/l\r\n" "a=fingerprint:sha-1 " "4A:AD:B9:B1:3F:82:18:3B:54:02:12:DF:3E:5D:49:6B:19:E5:7C:AB\r\n" "a=setup:actpass\r\n" "m=audio 9 UDP/TLS/RTP/SAVPF 111\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp:9 IN IP4 0.0.0.0\r\n" "a=recvonly\r\n" "a=rtcp-mux\r\n" "a=mid:0\r\n" "a=rtpmap:111 opus/48000/2\r\n"; auto offer = CreateSessionDescription(SdpType::kOffer, sdp); EXPECT_TRUE(pc->SetRemoteDescription(std::move(offer))); auto first_transceiver = pc->pc()->GetTransceivers()[0]; EXPECT_TRUE(first_transceiver ->SetDirectionWithError(RtpTransceiverDirection::kSendOnly) .ok()); // Check the generated *serialized* SDP. auto answer = pc->CreateAnswer(); const auto& answer_contents = answer->description()->contents(); ASSERT_EQ(answer_contents.size(), 1u); auto answer_streams = answer_contents[0].media_description()->streams(); ASSERT_EQ(answer_streams.size(), 1u); std::string first_stream_serialized = answer_streams[0].ToString(); uint32_t first_ssrc = answer_contents[0].media_description()->first_ssrc(); answer->ToString(&sdp); EXPECT_TRUE( pc->SetLocalDescription(CreateSessionDescription(SdpType::kAnswer, sdp))); auto reoffer = pc->CreateOffer(); const auto& offer_contents = reoffer->description()->contents(); ASSERT_EQ(offer_contents.size(), 1u); auto offer_streams = offer_contents[0].media_description()->streams(); ASSERT_EQ(offer_streams.size(), 1u); std::string second_stream_serialized = offer_streams[0].ToString(); uint32_t second_ssrc = offer_contents[0].media_description()->first_ssrc(); EXPECT_EQ(first_ssrc, second_ssrc); EXPECT_EQ(first_stream_serialized, second_stream_serialized); EXPECT_TRUE(pc->SetLocalDescription(std::move(reoffer))); } // Runs for each payload type in the valid dynamic ranges. class SdpOfferAnswerWithPayloadTypeTest : public SdpOfferAnswerTest, public testing::WithParamInterface { public: static std::vector GetAllPayloadTypesInValidDynamicRange() { std::vector payload_types; // The lower range is [35, 63]. for (int pt = 35; pt <= 63; ++pt) { payload_types.push_back(pt); } // The upper range is [96, 127]. for (int pt = 96; pt <= 127; ++pt) { payload_types.push_back(pt); } return payload_types; } }; TEST_P(SdpOfferAnswerWithPayloadTypeTest, FollowUpOfferDoesNotRepurposePayloadType) { int payload_type = GetParam(); std::string payload_type_str = rtc::ToString(payload_type); auto pc = CreatePeerConnection(); std::string sdp = "v=0\r\n" "o=- 8506393630701383055 2 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "a=group:BUNDLE 0\r\n" "a=extmap-allow-mixed\r\n" "a=msid-semantic: WMS\r\n" "m=video 9 UDP/TLS/RTP/SAVPF " + payload_type_str + "\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp:9 IN IP4 0.0.0.0\r\n" "a=ice-ufrag:7ZPs\r\n" "a=ice-pwd:3/ZaqZrZaVzg1Tfju5x3CGeJ\r\n" "a=ice-options:trickle\r\n" "a=fingerprint:sha-256 7D:29:C5:B8:D2:30:57:F3:0D:CA:0A:8E:4B:6A:AE:53:26" ":9F:14:DF:47:8E:0C:A3:EC:8D:B1:71:B5:D5:5A:9C\r\n" "a=setup:actpass\r\n" "a=mid:0\r\n" "a=extmap:9 urn:ietf:params:rtp-hdrext:sdes:mid\r\n" "a=sendrecv\r\n" "a=msid:- e2628265-b712-40de-81c9-76d49b7079a0\r\n" "a=rtcp-mux\r\n" "a=rtcp-rsize\r\n" "a=rtpmap:" + payload_type_str + " VP9/90000\r\n" "a=rtcp-fb:" + payload_type_str + " goog-remb\r\n" "a=rtcp-fb:" + payload_type_str + " transport-cc\r\n" "a=rtcp-fb:" + payload_type_str + " ccm fir\r\n" "a=rtcp-fb:" + payload_type_str + " nack\r\n" "a=rtcp-fb:" + payload_type_str + " nack pli\r\n" "a=fmtp:" + payload_type_str + " profile-id=0\r\n" "a=ssrc:2245042191 cname:A206VC6FXsn47EwJ\r\n" "a=ssrc:2245042191 msid:- e2628265-b712-40de-81c9-76d49b7079a0\r\n"; // Set remote offer with given PT for VP9. EXPECT_TRUE( pc->SetRemoteDescription(CreateSessionDescription(SdpType::kOffer, sdp))); // The answer should accept the PT for VP9. auto answer = pc->CreateAnswer(); { const auto* mid_0 = answer->description()->GetContentDescriptionByName("0"); ASSERT_TRUE(mid_0); ASSERT_THAT(mid_0->codecs(), SizeIs(1)); const auto& codec = mid_0->codecs()[0]; EXPECT_EQ(codec.name, "VP9"); EXPECT_EQ(codec.id, payload_type); std::string param; EXPECT_TRUE(codec.GetParam("profile-id", ¶m)); EXPECT_EQ(param, "0"); } EXPECT_TRUE(pc->SetLocalDescription(std::move(answer))); // The follow-up offer should continue to use the same PT for VP9. auto offer = pc->CreateOffer(); { const auto* mid_0 = offer->description()->GetContentDescriptionByName("0"); ASSERT_TRUE(mid_0); // We should have more codecs to offer than the one previously negotiated. const auto& codecs = mid_0->codecs(); ASSERT_GT(codecs.size(), 1u); // The previously negotiated PT should still map to the same VP9 codec. auto it = std::find_if( codecs.begin(), codecs.end(), [&](const cricket::Codec& codec) { return codec.id == payload_type; }); ASSERT_TRUE(it != codecs.end()); const auto& vp9_codec = *it; EXPECT_EQ(vp9_codec.name, "VP9"); EXPECT_EQ(vp9_codec.id, payload_type); std::string param; EXPECT_TRUE(vp9_codec.GetParam("profile-id", ¶m)); EXPECT_EQ(param, "0"); // None of the other codecs should collide with our VP9 PT. for (const auto& codec : codecs) { if (codec == vp9_codec) { continue; } EXPECT_NE(codec.id, vp9_codec.id); } } // Last sanity check: it's always possible to set an unmunged local offer. EXPECT_TRUE(pc->SetLocalDescription(std::move(offer))); } INSTANTIATE_TEST_SUITE_P( SdpOfferAnswerWithPayloadTypeTest, SdpOfferAnswerWithPayloadTypeTest, ::testing::ValuesIn(SdpOfferAnswerWithPayloadTypeTest:: GetAllPayloadTypesInValidDynamicRange()), ::testing::PrintToStringParamName()); // Test variant with boolean order for audio-video and video-audio. class SdpOfferAnswerShuffleMediaTypes : public SdpOfferAnswerTest, public testing::WithParamInterface { public: SdpOfferAnswerShuffleMediaTypes() : SdpOfferAnswerTest() {} }; TEST_P(SdpOfferAnswerShuffleMediaTypes, RecyclingWithDifferentKindAndSameMidFailsAnswer) { bool audio_first = GetParam(); auto pc1 = CreatePeerConnection(); auto pc2 = CreatePeerConnection(); if (audio_first) { pc1->AddAudioTrack("audio_track", {}); pc2->AddVideoTrack("video_track", {}); } else { pc2->AddAudioTrack("audio_track", {}); pc1->AddVideoTrack("video_track", {}); } auto initial_offer = pc1->CreateOfferAndSetAsLocal(); ASSERT_EQ(initial_offer->description()->contents().size(), 1u); auto mid1 = initial_offer->description()->contents()[0].mid(); std::string rejected_answer_sdp = "v=0\r\n" "o=- 8621259572628890423 2 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "m=" + std::string(audio_first ? "audio" : "video") + " 0 UDP/TLS/RTP/SAVPF 111\r\n" "c=IN IP4 0.0.0.0\r\n"; auto rejected_answer = CreateSessionDescription(SdpType::kAnswer, rejected_answer_sdp); EXPECT_TRUE(pc1->SetRemoteDescription(std::move(rejected_answer))); auto offer = pc2->CreateOfferAndSetAsLocal(); // This will generate a mid=0 too ASSERT_EQ(offer->description()->contents().size(), 1u); auto mid2 = offer->description()->contents()[0].mid(); EXPECT_EQ(mid1, mid2); // Check that the mids collided. EXPECT_TRUE(pc1->SetRemoteDescription(std::move(offer))); auto answer = pc1->CreateAnswer(); EXPECT_FALSE(pc1->SetLocalDescription(std::move(answer))); } // Similar to the previous test but with implicit rollback and creating // an offer, triggering a different codepath. TEST_P(SdpOfferAnswerShuffleMediaTypes, RecyclingWithDifferentKindAndSameMidFailsOffer) { bool audio_first = GetParam(); auto pc1 = CreatePeerConnection(); auto pc2 = CreatePeerConnection(); if (audio_first) { pc1->AddAudioTrack("audio_track", {}); pc2->AddVideoTrack("video_track", {}); } else { pc2->AddAudioTrack("audio_track", {}); pc1->AddVideoTrack("video_track", {}); } auto initial_offer = pc1->CreateOfferAndSetAsLocal(); ASSERT_EQ(initial_offer->description()->contents().size(), 1u); auto mid1 = initial_offer->description()->contents()[0].mid(); std::string rejected_answer_sdp = "v=0\r\n" "o=- 8621259572628890423 2 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "m=" + std::string(audio_first ? "audio" : "video") + " 0 UDP/TLS/RTP/SAVPF 111\r\n" "c=IN IP4 0.0.0.0\r\n"; auto rejected_answer = CreateSessionDescription(SdpType::kAnswer, rejected_answer_sdp); EXPECT_TRUE(pc1->SetRemoteDescription(std::move(rejected_answer))); auto offer = pc2->CreateOfferAndSetAsLocal(); // This will generate a mid=0 too ASSERT_EQ(offer->description()->contents().size(), 1u); auto mid2 = offer->description()->contents()[0].mid(); EXPECT_EQ(mid1, mid2); // Check that the mids collided. EXPECT_TRUE(pc1->SetRemoteDescription(std::move(offer))); EXPECT_FALSE(pc1->CreateOffer()); } INSTANTIATE_TEST_SUITE_P(SdpOfferAnswerShuffleMediaTypes, SdpOfferAnswerShuffleMediaTypes, ::testing::Values(true, false)); TEST_F(SdpOfferAnswerTest, OfferWithNoCompatibleCodecsIsRejectedInAnswer) { auto pc = CreatePeerConnection(); // An offer with no common codecs. This should reject both contents // in the answer without throwing an error. std::string sdp = "v=0\r\n" "o=- 0 3 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "a=fingerprint:sha-1 " "4A:AD:B9:B1:3F:82:18:3B:54:02:12:DF:3E:5D:49:6B:19:E5:7C:AB\r\n" "a=setup:actpass\r\n" "a=ice-ufrag:ETEn\r\n" "a=ice-pwd:OtSK0WpNtpUjkY4+86js7Z/l\r\n" "m=audio 9 RTP/SAVPF 97\r\n" "c=IN IP4 0.0.0.0\r\n" "a=sendrecv\r\n" "a=rtpmap:97 x-unknown/90000\r\n" "a=rtcp-mux\r\n" "m=video 9 RTP/SAVPF 98\r\n" "c=IN IP4 0.0.0.0\r\n" "a=sendrecv\r\n" "a=rtpmap:98 H263-1998/90000\r\n" "a=fmtp:98 CIF=1;QCIF=1\r\n" "a=rtcp-mux\r\n"; auto desc = CreateSessionDescription(SdpType::kOffer, sdp); ASSERT_NE(desc, nullptr); RTCError error; pc->SetRemoteDescription(std::move(desc), &error); EXPECT_TRUE(error.ok()); auto answer = pc->CreateAnswer(); auto answer_contents = answer->description()->contents(); ASSERT_EQ(answer_contents.size(), 2u); EXPECT_EQ(answer_contents[0].rejected, true); EXPECT_EQ(answer_contents[1].rejected, true); } TEST_F(SdpOfferAnswerTest, OfferWithRejectedMlineWithoutFingerprintIsAccepted) { auto pc = CreatePeerConnection(); // A rejected m-line without fingerprint. // The answer does not require one. std::string sdp = "v=0\r\n" "o=- 0 3 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "a=setup:actpass\r\n" "a=ice-ufrag:ETEn\r\n" "a=ice-pwd:OtSK0WpNtpUjkY4+86js7Z/l\r\n" "m=audio 0 RTP/SAVPF 111\r\n" "c=IN IP4 0.0.0.0\r\n" "a=sendrecv\r\n" "a=rtpmap:111 opus/48000/2\r\n" "a=rtcp-mux\r\n"; auto desc = CreateSessionDescription(SdpType::kOffer, sdp); ASSERT_NE(desc, nullptr); RTCError error; pc->SetRemoteDescription(std::move(desc), &error); EXPECT_TRUE(error.ok()); auto answer = pc->CreateAnswer(); EXPECT_TRUE(pc->SetLocalDescription(std::move(answer))); } TEST_F(SdpOfferAnswerTest, MidBackfillAnswer) { auto pc = CreatePeerConnection(); // An offer without a mid backfills the mid. This is currently // done with a per-peerconnection counter that starts from 0. // JSEP says to only include the mid in the answer if it was in the offer // but due to backfill it is always present. // TODO: https://issues.webrtc.org/issues/338529222 - don't respond with mid. std::string sdp = "v=0\r\n" "o=- 0 3 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "a=setup:actpass\r\n" "a=ice-ufrag:ETEn\r\n" "a=ice-pwd:OtSK0WpNtpUjkY4+86js7Z/l\r\n" "a=fingerprint:sha-1 " "4A:AD:B9:B1:3F:82:18:3B:54:02:12:DF:3E:5D:49:6B:19:E5:7C:AB\r\n" "a=setup:actpass\r\n" "m=audio 9 RTP/SAVPF 111\r\n" "c=IN IP4 0.0.0.0\r\n" "a=sendrecv\r\n" "a=rtpmap:111 opus/48000/2\r\n" // "a=mid:0\r\n" "a=rtcp-mux\r\n"; auto desc = CreateSessionDescription(SdpType::kOffer, sdp); ASSERT_NE(desc, nullptr); RTCError error; pc->SetRemoteDescription(std::move(desc), &error); EXPECT_TRUE(error.ok()); auto offer_contents = pc->pc()->remote_description()->description()->contents(); ASSERT_EQ(offer_contents.size(), 1u); EXPECT_EQ(offer_contents[0].mid(), "0"); auto answer = pc->CreateAnswerAndSetAsLocal(); auto answer_contents = answer->description()->contents(); ASSERT_EQ(answer_contents.size(), 1u); EXPECT_EQ(answer_contents[0].mid(), offer_contents[0].mid()); } TEST_F(SdpOfferAnswerTest, MidBackfillDoesNotCheckAgainstBundleGroup) { auto pc = CreatePeerConnection(); // An offer with a BUNDLE group specifying a mid that is not present // in the offer. This is not rejected due to the mid being backfilled // starting at 0. // TODO: https://issues.webrtc.org/issues/338528603 - reject this. std::string sdp = "v=0\r\n" "o=- 0 3 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "a=setup:actpass\r\n" "a=ice-ufrag:ETEn\r\n" "a=ice-pwd:OtSK0WpNtpUjkY4+86js7Z/l\r\n" "a=fingerprint:sha-1 " "4A:AD:B9:B1:3F:82:18:3B:54:02:12:DF:3E:5D:49:6B:19:E5:7C:AB\r\n" "a=setup:actpass\r\n" "a=group:BUNDLE 0\r\n" "m=audio 9 RTP/SAVPF 111\r\n" "c=IN IP4 0.0.0.0\r\n" "a=sendrecv\r\n" "a=rtpmap:111 opus/48000/2\r\n" // "a=mid:0\r\n" "a=rtcp-mux\r\n"; auto desc = CreateSessionDescription(SdpType::kOffer, sdp); ASSERT_NE(desc, nullptr); RTCError error; pc->SetRemoteDescription(std::move(desc), &error); EXPECT_TRUE(error.ok()); EXPECT_TRUE(pc->CreateAnswerAndSetAsLocal()); } TEST_F(SdpOfferAnswerTest, ReducedSizeNegotiated) { auto caller = CreatePeerConnection(); auto callee = CreatePeerConnection(); auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); auto video_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO); ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); auto receivers = callee->pc()->GetReceivers(); ASSERT_EQ(receivers.size(), 2u); auto audio_recv_param = receivers[0]->GetParameters(); EXPECT_TRUE(audio_recv_param.rtcp.reduced_size); auto video_recv_param = receivers[1]->GetParameters(); EXPECT_TRUE(video_recv_param.rtcp.reduced_size); auto senders = caller->pc()->GetSenders(); ASSERT_EQ(senders.size(), 2u); auto audio_send_param = senders[0]->GetParameters(); EXPECT_TRUE(audio_send_param.rtcp.reduced_size); auto video_send_param = senders[1]->GetParameters(); EXPECT_TRUE(video_send_param.rtcp.reduced_size); } TEST_F(SdpOfferAnswerTest, ReducedSizeNotNegotiated) { auto caller = CreatePeerConnection(); auto callee = CreatePeerConnection(); auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); auto video_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO); auto offer = caller->CreateOfferAndSetAsLocal(); ASSERT_NE(offer, nullptr); std::string sdp; offer->ToString(&sdp); // Remove rtcp-rsize attribute. auto modified_offer = CreateSessionDescription( SdpType::kOffer, absl::StrReplaceAll(sdp, {{"a=rtcp-rsize\r\n", ""}})); EXPECT_TRUE(callee->SetRemoteDescription(std::move(modified_offer))); auto answer = callee->CreateAnswerAndSetAsLocal(); EXPECT_TRUE(caller->SetRemoteDescription(std::move(answer))); auto receivers = callee->pc()->GetReceivers(); ASSERT_EQ(receivers.size(), 2u); auto audio_recv_param = receivers[0]->GetParameters(); EXPECT_FALSE(audio_recv_param.rtcp.reduced_size); auto video_recv_param = receivers[1]->GetParameters(); EXPECT_FALSE(video_recv_param.rtcp.reduced_size); auto senders = caller->pc()->GetSenders(); ASSERT_EQ(senders.size(), 2u); auto audio_send_param = senders[0]->GetParameters(); EXPECT_FALSE(audio_send_param.rtcp.reduced_size); auto video_send_param = senders[1]->GetParameters(); EXPECT_FALSE(video_send_param.rtcp.reduced_size); } TEST_F(SdpOfferAnswerTest, PayloadTypeMatchingWithSubsequentOfferAnswer) { auto caller = CreatePeerConnection(); auto callee = CreatePeerConnection(); // 1. Restrict codecs and set a local description and remote description. // with a different payload type. auto video_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO); std::vector codec_caps = pc_factory_->GetRtpReceiverCapabilities(cricket::MEDIA_TYPE_VIDEO).codecs; codec_caps.erase(std::remove_if(codec_caps.begin(), codec_caps.end(), [](const RtpCodecCapability& codec) { return !absl::EqualsIgnoreCase(codec.name, "VP8"); }), codec_caps.end()); EXPECT_TRUE(video_transceiver->SetCodecPreferences(codec_caps).ok()); auto offer1 = caller->CreateOfferAndSetAsLocal(); // 2. Add additional supported but not offered codec before SRD auto& contents = offer1->description()->contents(); ASSERT_EQ(contents.size(), 1u); auto* media_description = contents[0].media_description(); ASSERT_TRUE(media_description); std::vector codecs = media_description->codecs(); ASSERT_EQ(codecs.size(), 1u); ASSERT_NE(codecs[0].id, 127); auto av1 = cricket::CreateVideoCodec(SdpVideoFormat("AV1", {})); av1.id = 127; codecs.insert(codecs.begin(), av1); media_description->set_codecs(codecs); EXPECT_TRUE(callee->SetRemoteDescription(std::move(offer1))); auto answer1 = callee->CreateAnswerAndSetAsLocal(); EXPECT_TRUE(caller->SetRemoteDescription(std::move(answer1))); // 3. sCP to reenable that codec. Payload type is not matched at this point. codec_caps = pc_factory_->GetRtpReceiverCapabilities(cricket::MEDIA_TYPE_VIDEO).codecs; codec_caps.erase( std::remove_if(codec_caps.begin(), codec_caps.end(), [](const RtpCodecCapability& codec) { return !(absl::EqualsIgnoreCase(codec.name, "VP8") || absl::EqualsIgnoreCase(codec.name, "AV1")); }), codec_caps.end()); EXPECT_TRUE(video_transceiver->SetCodecPreferences(codec_caps).ok()); auto offer2 = caller->CreateOffer(); auto& contents2 = offer2->description()->contents(); ASSERT_EQ(contents2.size(), 1u); auto* media_description2 = contents2[0].media_description(); codecs = media_description2->codecs(); ASSERT_EQ(codecs.size(), 2u); EXPECT_EQ(codecs[1].name, av1.name); EXPECT_NE(codecs[1].id, av1.id); // 4. O/A triggered by remote. This "locks in" the payload type. auto offer3 = callee->CreateOfferAndSetAsLocal(); EXPECT_TRUE(caller->SetRemoteDescription(std::move(offer3))); EXPECT_TRUE(caller->CreateAnswerAndSetAsLocal()); // 5. Subsequent offer has the payload type. auto offer4 = caller->CreateOfferAndSetAsLocal(); auto& contents4 = offer4->description()->contents(); ASSERT_EQ(contents4.size(), 1u); auto* media_description4 = contents4[0].media_description(); ASSERT_TRUE(media_description4); codecs = media_description4->codecs(); ASSERT_EQ(codecs.size(), 2u); EXPECT_EQ(codecs[1].name, av1.name); EXPECT_EQ(codecs[1].id, av1.id); } class SdpOfferAnswerMungingTest : public SdpOfferAnswerTest { public: SdpOfferAnswerMungingTest() : SdpOfferAnswerTest() { metrics::Reset(); } }; TEST_F(SdpOfferAnswerMungingTest, DISABLED_ReportUMAMetricsWithNoMunging) { auto caller = CreatePeerConnection(); auto callee = CreatePeerConnection(); caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO); // Negotiate, gather candidates, then exchange ICE candidates. ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kNoModification, 1))); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Answer.Initial"), ElementsAre(Pair(SdpMungingType::kNoModification, 1))); EXPECT_THAT(WaitUntil([&] { return caller->IsIceGatheringDone(); }, IsTrue(), {.timeout = kDefaultTimeout}), IsRtcOk()); EXPECT_THAT(WaitUntil([&] { return callee->IsIceGatheringDone(); }, IsTrue(), {.timeout = kDefaultTimeout}), IsRtcOk()); for (const auto& candidate : caller->observer()->GetAllCandidates()) { callee->pc()->AddIceCandidate(candidate); } for (const auto& candidate : callee->observer()->GetAllCandidates()) { caller->pc()->AddIceCandidate(candidate); } EXPECT_THAT( WaitUntil([&] { return caller->pc()->peer_connection_state(); }, Eq(PeerConnectionInterface::PeerConnectionState::kConnected), {.timeout = kDefaultTimeout}), IsRtcOk()); EXPECT_THAT( WaitUntil([&] { return callee->pc()->peer_connection_state(); }, Eq(PeerConnectionInterface::PeerConnectionState::kConnected), {.timeout = kDefaultTimeout}), IsRtcOk()); caller->pc()->Close(); callee->pc()->Close(); EXPECT_THAT( metrics::Samples( "WebRTC.PeerConnection.SdpMunging.Offer.ConnectionEstablished"), ElementsAre(Pair(SdpMungingType::kNoModification, 1))); EXPECT_THAT( metrics::Samples( "WebRTC.PeerConnection.SdpMunging.Answer.ConnectionEstablished"), ElementsAre(Pair(SdpMungingType::kNoModification, 1))); EXPECT_THAT(metrics::Samples( "WebRTC.PeerConnection.SdpMunging.Offer.ConnectionClosed"), ElementsAre(Pair(SdpMungingType::kNoModification, 1))); EXPECT_THAT(metrics::Samples( "WebRTC.PeerConnection.SdpMunging.Answer.ConnectionClosed"), ElementsAre(Pair(SdpMungingType::kNoModification, 1))); } TEST_F(SdpOfferAnswerMungingTest, InitialSetLocalDescriptionWithoutCreateOffer) { RTCConfiguration config; config.certificates.push_back( FakeRTCCertificateGenerator::GenerateCertificate()); auto pc = CreatePeerConnection(config, nullptr); std::string sdp = "v=0\r\n" "o=- 0 3 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "a=fingerprint:sha-1 " "D9:AB:00:AA:12:7B:62:54:CF:AD:3B:55:F7:60:BC:F3:40:A7:0B:5B\r\n" "a=setup:actpass\r\n" "a=ice-ufrag:ETEn\r\n" "a=ice-pwd:OtSK0WpNtpUjkY4+86js7Z/l\r\n"; auto offer = CreateSessionDescription(SdpType::kOffer, sdp); RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kWithoutCreateOffer, 1))); } TEST_F(SdpOfferAnswerMungingTest, InitialSetLocalDescriptionWithoutCreateAnswer) { RTCConfiguration config; config.certificates.push_back( FakeRTCCertificateGenerator::GenerateCertificate()); auto pc = CreatePeerConnection(config, nullptr); std::string sdp = "v=0\r\n" "o=- 0 3 IN IP4 127.0.0.1\r\n" "s=-\r\n" "t=0 0\r\n" "a=fingerprint:sha-1 " "D9:AB:00:AA:12:7B:62:54:CF:AD:3B:55:F7:60:BC:F3:40:A7:0B:5B\r\n" "a=setup:actpass\r\n" "a=ice-ufrag:ETEn\r\n" "a=ice-pwd:OtSK0WpNtpUjkY4+86js7Z/l\r\n" "m=audio 9 UDP/TLS/RTP/SAVPF 111\r\n" "c=IN IP4 0.0.0.0\r\n" "a=rtcp-mux\r\n" "a=sendrecv\r\n" "a=mid:0\r\n" "a=rtpmap:111 opus/48000/2\r\n"; auto offer = CreateSessionDescription(SdpType::kOffer, sdp); EXPECT_TRUE(pc->SetRemoteDescription(std::move(offer))); RTCError error; auto answer = CreateSessionDescription(SdpType::kAnswer, sdp); answer->description()->transport_infos()[0].description.connection_role = cricket::CONNECTIONROLE_ACTIVE; EXPECT_TRUE(pc->SetLocalDescription(std::move(answer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Answer.Initial"), ElementsAre(Pair(SdpMungingType::kWithoutCreateAnswer, 1))); } TEST_F(SdpOfferAnswerMungingTest, IceUfrag) { auto pc = CreatePeerConnection(); pc->AddAudioTrack("audio_track", {}); auto offer = pc->CreateOffer(); auto& transport_infos = offer->description()->transport_infos(); ASSERT_EQ(transport_infos.size(), 1u); transport_infos[0].description.ice_ufrag = "amungediceufragthisshouldberejected"; RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kIceUfrag, 1))); } TEST_F(SdpOfferAnswerMungingTest, IcePwd) { auto pc = CreatePeerConnection(); pc->AddAudioTrack("audio_track", {}); auto offer = pc->CreateOffer(); auto& transport_infos = offer->description()->transport_infos(); ASSERT_EQ(transport_infos.size(), 1u); transport_infos[0].description.ice_pwd = "amungedicepwdthisshouldberejected"; RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kIcePwd, 1))); } TEST_F(SdpOfferAnswerMungingTest, IceMode) { auto pc = CreatePeerConnection(); pc->AddAudioTrack("audio_track", {}); auto offer = pc->CreateOffer(); auto& transport_infos = offer->description()->transport_infos(); ASSERT_EQ(transport_infos.size(), 1u); transport_infos[0].description.ice_mode = cricket::ICEMODE_LITE; RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kIceMode, 1))); } TEST_F(SdpOfferAnswerMungingTest, IceOptions) { auto pc = CreatePeerConnection(); pc->AddAudioTrack("audio_track", {}); auto offer = pc->CreateOffer(); auto& transport_infos = offer->description()->transport_infos(); ASSERT_EQ(transport_infos.size(), 1u); transport_infos[0].description.transport_options.push_back( cricket::ICE_OPTION_RENOMINATION); RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kIceOptions, 1))); } TEST_F(SdpOfferAnswerMungingTest, DtlsRole) { auto pc = CreatePeerConnection(); pc->AddAudioTrack("audio_track", {}); auto offer = pc->CreateOffer(); auto& transport_infos = offer->description()->transport_infos(); ASSERT_EQ(transport_infos.size(), 1u); transport_infos[0].description.connection_role = cricket::CONNECTIONROLE_PASSIVE; RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kDtlsSetup, 1))); } TEST_F(SdpOfferAnswerMungingTest, RemoveContent) { auto pc = CreatePeerConnection(); pc->AddAudioTrack("audio_track", {}); auto offer = pc->CreateOffer(); auto& contents = offer->description()->contents(); ASSERT_EQ(contents.size(), 1u); auto name = contents[0].mid(); EXPECT_TRUE(offer->description()->RemoveContentByName(contents[0].mid())); std::string sdp; offer->ToString(&sdp); auto modified_offer = CreateSessionDescription( SdpType::kOffer, absl::StrReplaceAll(sdp, {{"a=group:BUNDLE " + name, "a=group:BUNDLE"}})); RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(modified_offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kNumberOfContents, 1))); } TEST_F(SdpOfferAnswerMungingTest, Mid) { auto pc = CreatePeerConnection(); pc->AddAudioTrack("audio_track", {}); auto offer = pc->CreateOffer(); auto& contents = offer->description()->contents(); ASSERT_EQ(contents.size(), 1u); std::string name(contents[0].mid()); contents[0].set_mid("amungedmid"); auto& transport_infos = offer->description()->transport_infos(); ASSERT_EQ(transport_infos.size(), 1u); transport_infos[0].content_name = "amungedmid"; std::string sdp; offer->ToString(&sdp); auto modified_offer = CreateSessionDescription( SdpType::kOffer, absl::StrReplaceAll( sdp, {{"a=group:BUNDLE " + name, "a=group:BUNDLE amungedmid"}})); RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(modified_offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kMid, 1))); } TEST_F(SdpOfferAnswerMungingTest, LegacySimulcast) { auto pc = CreatePeerConnection(); pc->AddVideoTrack("video_track", {}); auto offer = pc->CreateOffer(); auto& contents = offer->description()->contents(); ASSERT_EQ(contents.size(), 1u); auto* media_description = contents[0].media_description(); ASSERT_TRUE(media_description); uint32_t ssrc = media_description->first_ssrc(); ASSERT_EQ(media_description->streams().size(), 1u); const std::string& cname = media_description->streams()[0].cname; std::string sdp; offer->ToString(&sdp); sdp += "a=ssrc-group:SIM " + rtc::ToString(ssrc) + " " + rtc::ToString(ssrc + 1) + "\r\n" + // "a=ssrc-group:FID " + rtc::ToString(ssrc + 1) + " " + rtc::ToString(ssrc + 2) + "\r\n" + // "a=ssrc:" + rtc::ToString(ssrc + 1) + " msid:- video_track\r\n" + // "a=ssrc:" + rtc::ToString(ssrc + 1) + " cname:" + cname + "\r\n" + // "a=ssrc:" + rtc::ToString(ssrc + 2) + " msid:- video_track\r\n" + // "a=ssrc:" + rtc::ToString(ssrc + 2) + " cname:" + cname + "\r\n"; auto modified_offer = CreateSessionDescription(SdpType::kOffer, sdp); RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(modified_offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kVideoCodecsLegacySimulcast, 1))); } #ifdef WEBRTC_USE_H264 TEST_F(SdpOfferAnswerMungingTest, H264SpsPpsIdrInKeyFrame) { auto pc = CreatePeerConnection(); pc->AddVideoTrack("video_track", {}); auto offer = pc->CreateOffer(); auto& contents = offer->description()->contents(); ASSERT_EQ(contents.size(), 1u); auto* media_description = contents[0].media_description(); ASSERT_TRUE(media_description); std::vector codecs = media_description->codecs(); for (auto& codec : codecs) { if (codec.name == cricket::kH264CodecName) { codec.SetParam(cricket::kH264FmtpSpsPpsIdrInKeyframe, cricket::kParamValueTrue); } } media_description->set_codecs(codecs); RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre( Pair(SdpMungingType::kVideoCodecsFmtpH264SpsPpsIdrInKeyframe, 1))); } #endif // WEBRTC_USE_H264 TEST_F(SdpOfferAnswerMungingTest, OpusStereo) { auto pc = CreatePeerConnection(); pc->AddAudioTrack("audio_track", {}); auto offer = pc->CreateOffer(); auto& contents = offer->description()->contents(); ASSERT_EQ(contents.size(), 1u); auto* media_description = contents[0].media_description(); ASSERT_TRUE(media_description); std::vector codecs = media_description->codecs(); for (auto& codec : codecs) { if (codec.name == cricket::kOpusCodecName) { codec.SetParam(cricket::kCodecParamStereo, cricket::kParamValueTrue); } } media_description->set_codecs(codecs); RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kAudioCodecsFmtpOpusStereo, 1))); } TEST_F(SdpOfferAnswerMungingTest, AudioCodecsRemoved) { auto pc = CreatePeerConnection(); pc->AddAudioTrack("audio_track", {}); auto offer = pc->CreateOffer(); auto& contents = offer->description()->contents(); ASSERT_EQ(contents.size(), 1u); auto* media_description = contents[0].media_description(); ASSERT_TRUE(media_description); std::vector codecs = media_description->codecs(); codecs.pop_back(); media_description->set_codecs(codecs); RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kAudioCodecsRemoved, 1))); } TEST_F(SdpOfferAnswerMungingTest, AudioCodecsAdded) { auto pc = CreatePeerConnection(); pc->AddAudioTrack("audio_track", {}); auto offer = pc->CreateOffer(); auto& contents = offer->description()->contents(); ASSERT_EQ(contents.size(), 1u); auto* media_description = contents[0].media_description(); ASSERT_TRUE(media_description); std::vector codecs = media_description->codecs(); auto codec = cricket::CreateAudioCodec(SdpAudioFormat("pcmu", 8000, 1, {})); codec.id = 19; // IANA reserved payload type, should not conflict. codecs.push_back(codec); media_description->set_codecs(codecs); RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kAudioCodecsAdded, 1))); } TEST_F(SdpOfferAnswerMungingTest, VideoCodecsRemoved) { auto pc = CreatePeerConnection(); pc->AddVideoTrack("video_track", {}); auto offer = pc->CreateOffer(); auto& contents = offer->description()->contents(); ASSERT_EQ(contents.size(), 1u); auto* media_description = contents[0].media_description(); ASSERT_TRUE(media_description); std::vector codecs = media_description->codecs(); codecs.pop_back(); media_description->set_codecs(codecs); RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kVideoCodecsRemoved, 1))); } TEST_F(SdpOfferAnswerMungingTest, VideoCodecsAdded) { auto pc = CreatePeerConnection(); pc->AddVideoTrack("video_track", {}); auto offer = pc->CreateOffer(); auto& contents = offer->description()->contents(); ASSERT_EQ(contents.size(), 1u); auto* media_description = contents[0].media_description(); ASSERT_TRUE(media_description); std::vector codecs = media_description->codecs(); auto codec = cricket::CreateVideoCodec(SdpVideoFormat("VP8", {})); codec.id = 19; // IANA reserved payload type, should not conflict. codecs.push_back(codec); media_description->set_codecs(codecs); RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kVideoCodecsAdded, 1))); } TEST_F(SdpOfferAnswerMungingTest, MultiOpus) { auto pc = CreatePeerConnection(); pc->AddAudioTrack("audio_track", {}); auto offer = pc->CreateOffer(); auto& contents = offer->description()->contents(); ASSERT_EQ(contents.size(), 1u); auto* media_description = contents[0].media_description(); ASSERT_TRUE(media_description); std::vector codecs = media_description->codecs(); auto multiopus = cricket::CreateAudioCodec(SdpAudioFormat("multiopus", 48000, 4, {{"channel_mapping", "0,1,2,3"}, {"coupled_streams", "2"}, {"num_streams", "2"}})); multiopus.id = 19; // IANA reserved payload type, should not conflict. codecs.push_back(multiopus); media_description->set_codecs(codecs); RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kAudioCodecsAddedMultiOpus, 1))); } TEST_F(SdpOfferAnswerMungingTest, L16) { auto pc = CreatePeerConnection(); pc->AddAudioTrack("audio_track", {}); auto offer = pc->CreateOffer(); auto& contents = offer->description()->contents(); ASSERT_EQ(contents.size(), 1u); auto* media_description = contents[0].media_description(); ASSERT_TRUE(media_description); std::vector codecs = media_description->codecs(); auto l16 = cricket::CreateAudioCodec(SdpAudioFormat("L16", 48000, 2, {})); l16.id = 19; // IANA reserved payload type, should not conflict. codecs.push_back(l16); media_description->set_codecs(codecs); RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kAudioCodecsAddedL16, 1))); } TEST_F(SdpOfferAnswerMungingTest, AudioSsrc) { // Note: same applies to video but is harder to write since one needs to // modify the ssrc-group too. auto pc = CreatePeerConnection(); pc->AddAudioTrack("audio_track", {}); auto offer = pc->CreateOffer(); auto& contents = offer->description()->contents(); ASSERT_EQ(contents.size(), 1u); auto* media_description = contents[0].media_description(); ASSERT_TRUE(media_description); ASSERT_EQ(media_description->streams().size(), 1u); media_description->mutable_streams()[0].ssrcs[0] = 4404; RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kSsrcs, 1))); } TEST_F(SdpOfferAnswerMungingTest, HeaderExtensionAdded) { auto pc = CreatePeerConnection(); pc->AddVideoTrack("video_track", {}); auto offer = pc->CreateOffer(); auto& contents = offer->description()->contents(); ASSERT_EQ(contents.size(), 1u); auto* media_description = contents[0].media_description(); ASSERT_TRUE(media_description); // VLA is off by default, id=42 should be unused. media_description->AddRtpHeaderExtension( {RtpExtension::kVideoLayersAllocationUri, 42}); RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kRtpHeaderExtensionAdded, 1))); } TEST_F(SdpOfferAnswerMungingTest, HeaderExtensionRemoved) { auto pc = CreatePeerConnection(); pc->AddVideoTrack("video_track", {}); auto offer = pc->CreateOffer(); auto& contents = offer->description()->contents(); ASSERT_EQ(contents.size(), 1u); auto* media_description = contents[0].media_description(); ASSERT_TRUE(media_description); media_description->ClearRtpHeaderExtensions(); RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kRtpHeaderExtensionRemoved, 1))); } TEST_F(SdpOfferAnswerMungingTest, HeaderExtensionModified) { auto pc = CreatePeerConnection(); pc->AddVideoTrack("video_track", {}); auto offer = pc->CreateOffer(); auto& contents = offer->description()->contents(); ASSERT_EQ(contents.size(), 1u); auto* media_description = contents[0].media_description(); ASSERT_TRUE(media_description); auto extensions = media_description->rtp_header_extensions(); ASSERT_GT(extensions.size(), 0u); extensions[0].id = 42; // id=42 should be unused. media_description->set_rtp_header_extensions(extensions); RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kRtpHeaderExtensionModified, 1))); } TEST_F(SdpOfferAnswerMungingTest, PayloadTypeChanged) { auto pc = CreatePeerConnection(); pc->AddAudioTrack("audio_track", {}); auto offer = pc->CreateOffer(); auto& contents = offer->description()->contents(); ASSERT_EQ(contents.size(), 1u); auto* media_description = contents[0].media_description(); ASSERT_TRUE(media_description); auto codecs = media_description->codecs(); ASSERT_GT(codecs.size(), 0u); codecs[0].id = 19; // IANA reserved payload type, should not conflict. media_description->set_codecs(codecs); RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kPayloadTypes, 1))); } TEST_F(SdpOfferAnswerMungingTest, AudioCodecsReordered) { auto pc = CreatePeerConnection(); pc->AddAudioTrack("audio_track", {}); auto offer = pc->CreateOffer(); auto& contents = offer->description()->contents(); ASSERT_EQ(contents.size(), 1u); auto* media_description = contents[0].media_description(); ASSERT_TRUE(media_description); auto codecs = media_description->codecs(); ASSERT_GT(codecs.size(), 1u); std::swap(codecs[0], codecs[1]); media_description->set_codecs(codecs); RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kAudioCodecsReordered, 1))); } TEST_F(SdpOfferAnswerMungingTest, VideoCodecsReordered) { auto pc = CreatePeerConnection(); pc->AddVideoTrack("video_track", {}); auto offer = pc->CreateOffer(); auto& contents = offer->description()->contents(); ASSERT_EQ(contents.size(), 1u); auto* media_description = contents[0].media_description(); ASSERT_TRUE(media_description); auto codecs = media_description->codecs(); ASSERT_GT(codecs.size(), 1u); std::swap(codecs[0], codecs[1]); media_description->set_codecs(codecs); RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kVideoCodecsReordered, 1))); } TEST_F(SdpOfferAnswerMungingTest, AudioCodecsFmtp) { auto pc = CreatePeerConnection(); pc->AddAudioTrack("audio_track", {}); auto offer = pc->CreateOffer(); auto& contents = offer->description()->contents(); ASSERT_EQ(contents.size(), 1u); auto* media_description = contents[0].media_description(); ASSERT_TRUE(media_description); auto codecs = media_description->codecs(); ASSERT_GT(codecs.size(), 0u); codecs[0].params["dont"] = "munge"; media_description->set_codecs(codecs); RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kAudioCodecsFmtp, 1))); } TEST_F(SdpOfferAnswerMungingTest, VideoCodecsFmtp) { auto pc = CreatePeerConnection(); pc->AddVideoTrack("video_track", {}); auto offer = pc->CreateOffer(); auto& contents = offer->description()->contents(); ASSERT_EQ(contents.size(), 1u); auto* media_description = contents[0].media_description(); ASSERT_TRUE(media_description); auto codecs = media_description->codecs(); ASSERT_GT(codecs.size(), 0u); codecs[0].params["dont"] = "munge"; media_description->set_codecs(codecs); RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kVideoCodecsFmtp, 1))); } TEST_F(SdpOfferAnswerMungingTest, AudioCodecsRtcpFb) { auto pc = CreatePeerConnection(); pc->AddAudioTrack("audio_track", {}); auto offer = pc->CreateOffer(); auto& contents = offer->description()->contents(); ASSERT_EQ(contents.size(), 1u); auto* media_description = contents[0].media_description(); ASSERT_TRUE(media_description); auto codecs = media_description->codecs(); ASSERT_GT(codecs.size(), 0u); codecs[0].feedback_params.Add({"dont", "munge"}); media_description->set_codecs(codecs); RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kAudioCodecsRtcpFb, 1))); } TEST_F(SdpOfferAnswerMungingTest, VideoCodecsRtcpFb) { auto pc = CreatePeerConnection(); pc->AddVideoTrack("video_track", {}); auto offer = pc->CreateOffer(); auto& contents = offer->description()->contents(); ASSERT_EQ(contents.size(), 1u); auto* media_description = contents[0].media_description(); ASSERT_TRUE(media_description); auto codecs = media_description->codecs(); ASSERT_GT(codecs.size(), 0u); codecs[0].feedback_params.Add({"dont", "munge"}); media_description->set_codecs(codecs); RTCError error; EXPECT_TRUE(pc->SetLocalDescription(std::move(offer), &error)); EXPECT_THAT( metrics::Samples("WebRTC.PeerConnection.SdpMunging.Offer.Initial"), ElementsAre(Pair(SdpMungingType::kVideoCodecsRtcpFb, 1))); } } // namespace webrtc