Adding upstream version 4.3.7.upstream/4.3.7upstream

Signed-off-by: Daniel Baumann <daniel.baumann@progress-linux.org>

1 files changed, 34 insertions, 0 deletions

diff --git a/lib/ansiblelint/rules/NoFormattingInWhenRule.py b/lib/ansiblelint/rules/NoFormattingInWhenRule.py
new file mode 100644
index 0000000..a665311
--- /dev/null
+++ b/lib/ansiblelint/rules/NoFormattingInWhenRule.py
@@ -0,0 +1,34 @@
+from ansiblelint.rules import AnsibleLintRule
+
+
+class NoFormattingInWhenRule(AnsibleLintRule):
+    id = '102'
+    shortdesc = 'No Jinja2 in when'
+    description = '``when`` lines should not include Jinja2 variables'
+    severity = 'HIGH'
+    tags = ['deprecated', 'ANSIBLE0019']
+    version_added = 'historic'
+
+    def _is_valid(self, when):
+        if not isinstance(when, str):
+            return True
+        return when.find('{{') == -1 and when.find('}}') == -1
+
+    def matchplay(self, file, play):
+        errors = []
+        if isinstance(play, dict):
+            if 'roles' not in play or play['roles'] is None:
+                return errors
+            for role in play['roles']:
+                if self.matchtask(file, role):
+                    errors.append(({'when': role},
+                                   'role "when" clause has Jinja2 templates'))
+        if isinstance(play, list):
+            for play_item in play:
+                sub_errors = self.matchplay(file, play_item)
+                if sub_errors:
+                    errors = errors + sub_errors
+        return errors
+
+    def matchtask(self, file, task):
+        return 'when' in task and not self._is_valid(task['when'])