1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
|
# Copyright (c) 2016, Will Thames and contributors
# Copyright (c) 2018, Ansible Project
from ansiblelint.rules import AnsibleLintRule
META_STR_INFO = (
'author',
'description'
)
META_INFO = tuple(list(META_STR_INFO) + [
'license',
'min_ansible_version',
'platforms',
])
def _platform_info_errors_itr(platforms):
if not isinstance(platforms, list):
yield 'Platforms should be a list of dictionaries'
return
for platform in platforms:
if not isinstance(platform, dict):
yield 'Platforms should be a list of dictionaries'
elif 'name' not in platform:
yield 'Platform should contain name'
def _galaxy_info_errors_itr(galaxy_info,
info_list=META_INFO,
str_info_list=META_STR_INFO):
for info in info_list:
ginfo = galaxy_info.get(info, False)
if ginfo:
if info in str_info_list and not isinstance(ginfo, str):
yield '{info} should be a string'.format(info=info)
elif info == 'platforms':
for err in _platform_info_errors_itr(ginfo):
yield err
else:
yield 'Role info should contain {info}'.format(info=info)
class MetaMainHasInfoRule(AnsibleLintRule):
id = '701'
shortdesc = 'meta/main.yml should contain relevant info'
str_info = META_STR_INFO
info = META_INFO
description = (
'meta/main.yml should contain: ``{}``'.format(', '.join(info))
)
severity = 'HIGH'
tags = ['metadata']
version_added = 'v4.0.0'
def matchplay(self, file, data):
if file['type'] != 'meta':
return False
meta = {'meta/main.yml': data}
galaxy_info = data.get('galaxy_info', False)
if galaxy_info:
return [(meta, err) for err
in _galaxy_info_errors_itr(galaxy_info)]
return [(meta, "No 'galaxy_info' found")]
|
