1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
|
# -*- coding: utf-8 -*-
# Author: Adrián Tóth <adtoth@redhat.com>
#
# Copyright (c) 2020, Red Hat, Inc.
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to deal
# in the Software without restriction, including without limitation the rights
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
# copies of the Software, and to permit persons to whom the Software is
# furnished to do so, subject to the following conditions:
#
# The above copyright notice and this permission notice shall be included in
# all copies or substantial portions of the Software.
#
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.
import re
from ansiblelint.rules import AnsibleLintRule
class NestedJinjaRule(AnsibleLintRule):
id = '207'
shortdesc = 'Nested jinja pattern'
description = (
"There should not be any nested jinja pattern. "
"Example (bad): ``{{ list_one + {{ list_two | max }} }}``, "
"example (good): ``{{ list_one + max(list_two) }}``"
)
severity = 'VERY_HIGH'
tags = ['formatting']
version_added = 'v4.3.0'
pattern = re.compile(r"{{(?:[^{}]*)?{{")
def matchtask(self, file, task):
command = "".join(
str(value)
# task properties are stored in the 'action' key
for key, value in task['action'].items()
# exclude useless values of '__file__', '__ansible_module__', '__*__', etc.
if not key.startswith('__') and not key.endswith('__')
)
return bool(self.pattern.search(command))
|
