From: Karel Zak Date: Thu, 21 Mar 2024 11:16:20 +0100 Subject: wall: fix escape sequence Injection Let's use for all cases the same output function. Reported-by: Skyler Ferrante Signed-off-by: Karel Zak Origin: https://github.com/util-linux/util-linux/commit/404b0781f52f7c045ca811b2dceec526408ac253 Bug-Debian: https://security-tracker.debian.org/tracker/CVE-2024-28085 Bug-Debian: https://bugs.debian.org/1067849 --- term-utils/wall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/term-utils/wall.c b/term-utils/wall.c index f375eca..90d5b71 100644 --- a/term-utils/wall.c +++ b/term-utils/wall.c @@ -327,7 +327,7 @@ static char *makemsg(char *fname, char **mvec, int mvecsz, int i; for (i = 0; i < mvecsz; i++) { - fputs(mvec[i], fs); + fputs_careful(mvec[i], fs, '^', true, TERM_WIDTH); if (i < mvecsz - 1) fputc(' ', fs); }