1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
|
# Copyright © 2009 Raphaël Hertzog <hertzog@debian.org>
# Copyright © 2012-2013 Guillem Jover <guillem@debian.org>
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <https://www.gnu.org/licenses/>.
package Dpkg::Changelog::Entry::Debian;
use strict;
use warnings;
our $VERSION = '2.00';
our @EXPORT_OK = qw(
match_header
match_trailer
find_closes
);
use Exporter qw(import);
use Time::Piece;
use Dpkg::Gettext;
use Dpkg::Control::Fields;
use Dpkg::Control::Changelog;
use Dpkg::Changelog::Entry;
use Dpkg::Version;
use parent qw(Dpkg::Changelog::Entry);
=encoding utf8
=head1 NAME
Dpkg::Changelog::Entry::Debian - represents a Debian changelog entry
=head1 DESCRIPTION
This class represents a Debian changelog entry.
It implements the generic interface Dpkg::Changelog::Entry.
Only functions specific to this implementation are described below,
the rest are inherited.
=cut
my $name_chars = qr/[-+0-9a-z.]/i;
# The matched content is the source package name ($1), the version ($2),
# the target distributions ($3) and the options on the rest of the line ($4).
my $regex_header = qr{
^
(\w$name_chars*) # Package name
\ \(([^\(\) \t]+)\) # Package version
((?:\s+$name_chars+)+) # Target distribution
\; # Separator
(.*?) # Key=Value options
\s*$ # Trailing space
}xi;
# The matched content is the maintainer name ($1), its email ($2),
# some blanks ($3) and the timestamp ($4), which is decomposed into
# day of week ($6), date-time ($7) and this into month name ($8).
my $regex_trailer = qr<
^
\ \-\- # Trailer marker
\ (.*) # Maintainer name
\ \<(.*)\> # Maintainer email
(\ \ ?) # Blanks
(
((\w+)\,\s*)? # Day of week (abbreviated)
(
\d{1,2}\s+ # Day of month
(\w+)\s+ # Month name (abbreviated)
\d{4}\s+ # Year
\d{1,2}:\d\d:\d\d\s+[-+]\d{4} # ISO 8601 date
)
)
\s*$ # Trailing space
>xo;
my %week_day = map { $_ => 1 } qw(Mon Tue Wed Thu Fri Sat Sun);
my @month_abbrev = qw(
Jan Feb Mar Apr May Jun Jul Aug Sep Oct Nov Dec
);
my %month_abbrev = map { $_ => 1 } @month_abbrev;
my @month_name = qw(
January February March April May June July
August September October November December
);
my %month_name = map { $month_name[$_] => $month_abbrev[$_] } 0 .. 11;
=head1 METHODS
=over 4
=item @items = $entry->get_change_items()
Return a list of change items. Each item contains at least one line.
A change line starting with an asterisk denotes the start of a new item.
Any change line like "C<[ Raphaël Hertzog ]>" is treated like an item of its
own even if it starts a set of items attributed to this person (the
following line necessarily starts a new item).
=cut
sub get_change_items {
my $self = shift;
my (@items, @blanks, $item);
foreach my $line (@{$self->get_part('changes')}) {
if ($line =~ /^\s*\*/) {
push @items, $item if defined $item;
$item = "$line\n";
} elsif ($line =~ /^\s*\[\s[^\]]+\s\]\s*$/) {
push @items, $item if defined $item;
push @items, "$line\n";
$item = undef;
@blanks = ();
} elsif ($line =~ /^\s*$/) {
push @blanks, "$line\n";
} else {
if (defined $item) {
$item .= "@blanks$line\n";
} else {
$item = "$line\n";
}
@blanks = ();
}
}
push @items, $item if defined $item;
return @items;
}
=item @errors = $entry->parse_header()
=item @errors = $entry->parse_trailer()
Return a list of errors. Each item in the list is an error message
describing the problem. If the empty list is returned, no errors
have been found.
=cut
sub parse_header {
my $self = shift;
my @errors;
if (defined($self->{header}) and $self->{header} =~ $regex_header) {
$self->{header_source} = $1;
my $version = Dpkg::Version->new($2);
my ($ok, $msg) = version_check($version);
if ($ok) {
$self->{header_version} = $version;
} else {
push @errors, sprintf(g_("version '%s' is invalid: %s"), $version, $msg);
}
@{$self->{header_dists}} = split ' ', $3;
my $options = $4;
$options =~ s/^\s+//;
my $f = Dpkg::Control::Changelog->new();
foreach my $opt (split(/\s*,\s*/, $options)) {
unless ($opt =~ m/^([-0-9a-z]+)\=\s*(.*\S)$/i) {
push @errors, sprintf(g_("bad key-value after ';': '%s'"), $opt);
next;
}
my ($k, $v) = (field_capitalize($1), $2);
if (exists $f->{$k}) {
push @errors, sprintf(g_('repeated key-value %s'), $k);
} else {
$f->{$k} = $v;
}
if ($k eq 'Urgency') {
push @errors, sprintf(g_('badly formatted urgency value: %s'), $v)
unless ($v =~ m/^([-0-9a-z]+)((\s+.*)?)$/i);
} elsif ($k eq 'Binary-Only') {
push @errors, sprintf(g_('bad binary-only value: %s'), $v)
unless ($v eq 'yes');
} elsif ($k =~ m/^X[BCS]+-/i) {
} else {
push @errors, sprintf(g_('unknown key-value %s'), $k);
}
}
$self->{header_fields} = $f;
} else {
push @errors, g_("the header doesn't match the expected regex");
}
return @errors;
}
sub parse_trailer {
my $self = shift;
my @errors;
if (defined($self->{trailer}) and $self->{trailer} =~ $regex_trailer) {
$self->{trailer_maintainer} = "$1 <$2>";
if ($3 ne ' ') {
push @errors, g_('badly formatted trailer line');
}
# Validate the week day. Date::Parse used to ignore it, but Time::Piece
# is much more strict and it does not gracefully handle bogus values.
if (defined $5 and not exists $week_day{$6}) {
push @errors, sprintf(g_('ignoring invalid week day \'%s\''), $6);
}
# Ignore the week day ('%a, '), as we have validated it above.
local $ENV{LC_ALL} = 'C';
eval {
my $tp = Time::Piece->strptime($7, '%d %b %Y %T %z');
$self->{trailer_timepiece} = $tp;
} or do {
# Validate the month. Date::Parse used to accept both abbreviated
# and full months, but Time::Piece strptime() implementation only
# matches the abbreviated one with %b, which is what we want anyway.
if (not exists $month_abbrev{$8}) {
# We have to nest the conditionals because May is the same in
# full and abbreviated forms!
if (exists $month_name{$8}) {
push @errors, sprintf(g_('uses full \'%s\' instead of abbreviated month name \'%s\''),
$8, $month_name{$8});
} else {
push @errors, sprintf(g_('invalid abbreviated month name \'%s\''), $8);
}
}
push @errors, sprintf(g_("cannot parse non-conformant date '%s'"), $7);
};
$self->{trailer_timestamp_date} = $4;
} else {
push @errors, g_("the trailer doesn't match the expected regex");
}
return @errors;
}
=item $entry->normalize()
Normalize the content. Strip whitespaces at end of lines, use a single
empty line to separate each part.
=cut
sub normalize {
my $self = shift;
$self->SUPER::normalize();
#XXX: recreate header/trailer
}
=item $src = $entry->get_source()
Return the name of the source package associated to the changelog entry.
=cut
sub get_source {
my $self = shift;
return $self->{header_source};
}
=item $ver = $entry->get_version()
Return the version associated to the changelog entry.
=cut
sub get_version {
my $self = shift;
return $self->{header_version};
}
=item @dists = $entry->get_distributions()
Return a list of target distributions for this version.
=cut
sub get_distributions {
my $self = shift;
if (defined $self->{header_dists}) {
return @{$self->{header_dists}} if wantarray;
return $self->{header_dists}[0];
}
return;
}
=item $fields = $entry->get_optional_fields()
Return a set of optional fields exposed by the changelog entry.
It always returns a Dpkg::Control object (possibly empty though).
=cut
sub get_optional_fields {
my $self = shift;
my $f;
if (defined $self->{header_fields}) {
$f = $self->{header_fields};
} else {
$f = Dpkg::Control::Changelog->new();
}
my @closes = find_closes(join("\n", @{$self->{changes}}));
if (@closes) {
$f->{Closes} = join(' ', @closes);
}
return $f;
}
=item $urgency = $entry->get_urgency()
Return the urgency of the associated upload.
=cut
sub get_urgency {
my $self = shift;
my $f = $self->get_optional_fields();
if (exists $f->{Urgency}) {
$f->{Urgency} =~ s/\s.*$//;
return lc($f->{Urgency});
}
return;
}
=item $maint = $entry->get_maintainer()
Return the string identifying the person who signed this changelog entry.
=cut
sub get_maintainer {
my $self = shift;
return $self->{trailer_maintainer};
}
=item $time = $entry->get_timestamp()
Return the timestamp of the changelog entry.
=cut
sub get_timestamp {
my $self = shift;
return $self->{trailer_timestamp_date};
}
=item $time = $entry->get_timepiece()
Return the timestamp of the changelog entry as a Time::Piece object.
This function might return undef if there was no timestamp.
=cut
sub get_timepiece {
my $self = shift;
return $self->{trailer_timepiece};
}
=back
=head1 UTILITY FUNCTIONS
=over 4
=item $bool = match_header($line)
Checks if the line matches a valid changelog header line.
=cut
sub match_header {
my $line = shift;
return $line =~ /$regex_header/;
}
=item $bool = match_trailer($line)
Checks if the line matches a valid changelog trailing line.
=cut
sub match_trailer {
my $line = shift;
return $line =~ /$regex_trailer/;
}
=item @closed_bugs = find_closes($changes)
Takes one string as argument and finds "Closes: #123456, #654321" statements
as supported by the Debian Archive software in it. Returns all closed bug
numbers in an array.
=cut
sub find_closes {
my $changes = shift;
my %closes;
while ($changes && ($changes =~ m{
closes:\s*
(?:bug)?\#?\s?\d+
(?:,\s*(?:bug)?\#?\s?\d+)*
}pigx)) {
$closes{$_} = 1 foreach (${^MATCH} =~ /\#?\s?(\d+)/g);
}
my @closes = sort { $a <=> $b } keys %closes;
return @closes;
}
=back
=head1 CHANGES
=head2 Version 2.00 (dpkg 1.20.0)
Remove methods: $entry->check_header(), $entry->check_trailer().
Hide variables: $regex_header, $regex_trailer.
=head2 Version 1.03 (dpkg 1.18.8)
New methods: $entry->get_timepiece().
=head2 Version 1.02 (dpkg 1.18.5)
New methods: $entry->parse_header(), $entry->parse_trailer().
Deprecated methods: $entry->check_header(), $entry->check_trailer().
=head2 Version 1.01 (dpkg 1.17.2)
New functions: match_header(), match_trailer()
Deprecated variables: $regex_header, $regex_trailer
=head2 Version 1.00 (dpkg 1.15.6)
Mark the module as public.
=cut
1;
|