1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
|
--
-- A stored procedure to reallocate a user's previous address, otherwise
-- provide a free address.
--
-- NOTE: This version of the SP is intended for MySQL variants that do not
-- support the SKIP LOCKED pragma, i.e. MariaDB and versions of MySQL
-- prior to 8.0. It should be a lot faster than using the default SP
-- without the SKIP LOCKED pragma under highly concurrent workloads
-- and not result in thread starvation.
--
-- It is however a *useful hack* which should not be used if SKIP
-- LOCKED is available.
--
-- WARNING: This query uses server-local, "user locks" (GET_LOCK and
-- RELEASE_LOCK), without the need for a transaction, to emulate
-- row locking with locked-row skipping. User locks are not
-- supported on clusters such as Galera and MaxScale.
--
-- Using this SP reduces the usual set dialogue of queries to a single
-- query:
--
-- START TRANSACTION; SELECT FOR UPDATE; UPDATE; COMMIT; -> CALL sp()
--
-- The stored procedure is executed within a single round trip which often
-- leads to reduced deadlocking and significant performance improvements.
--
-- To use this stored procedure the corresponding queries.conf statements must
-- be configured as follows:
--
-- allocate_begin = ""
-- allocate_find = "\
-- CALL fr_allocate_previous_or_new_framedipaddress( \
-- '%{control:${pool_name}}', \
-- '%{User-Name}', \
-- '%{Calling-Station-Id}', \
-- '%{NAS-IP-Address}', \
-- '${pool_key}', \
-- ${lease_duration} \
-- )"
-- allocate_update = ""
-- allocate_commit = ""
--
CREATE INDEX poolname_username_callingstationid ON radippool(pool_name,username,callingstationid);
DELIMITER $$
DROP PROCEDURE IF EXISTS fr_allocate_previous_or_new_framedipaddress;
CREATE PROCEDURE fr_allocate_previous_or_new_framedipaddress (
IN v_pool_name VARCHAR(64),
IN v_username VARCHAR(64),
IN v_callingstationid VARCHAR(64),
IN v_nasipaddress VARCHAR(15),
IN v_pool_key VARCHAR(64),
IN v_lease_duration INT
)
SQL SECURITY INVOKER
proc:BEGIN
DECLARE r_address VARCHAR(15);
-- Reissue an existing IP address lease when re-authenticating a session
--
SELECT framedipaddress INTO r_address
FROM radippool
WHERE pool_name = v_pool_name
AND expiry_time > NOW()
AND nasipaddress = v_nasipaddress
AND pool_key = v_pool_key
LIMIT 1;
-- Reissue an user's previous IP address, provided that the lease is
-- available (i.e. enable sticky IPs)
--
-- When using this SELECT you should delete the one above. You must also
-- set allocate_clear = "" in queries.conf to persist the associations
-- for expired leases.
--
-- SELECT framedipaddress INTO r_address
-- FROM radippool
-- WHERE pool_name = v_pool_name
-- AND nasipaddress = v_nasipaddress
-- AND pool_key = v_pool_key
-- LIMIT 1;
IF r_address IS NOT NULL THEN
UPDATE radippool
SET
nasipaddress = v_nasipaddress,
pool_key = v_pool_key,
callingstationid = v_callingstationid,
username = v_username,
expiry_time = NOW() + INTERVAL v_lease_duration SECOND
WHERE
framedipaddress = r_address;
SELECT r_address;
LEAVE proc;
END IF;
REPEAT
-- If we didn't reallocate a previous address then pick the least
-- recently used address from the pool which maximises the likelihood
-- of re-assigning the other addresses to their recent user
--
SELECT framedipaddress INTO r_address
FROM radippool
WHERE pool_name = v_pool_name
AND expiry_time < NOW()
--
-- WHERE ... GET_LOCK(...,0) = 1 is a poor man's SKIP LOCKED that simulates
-- a row-level lock using a "user lock" that allows the locked "rows" to be
-- skipped. After the user lock is acquired and the SELECT retired it does
-- not mean that the entirety of the WHERE clause is still true: Another
-- thread may have updated the expiry time and released the lock after we
-- checked the expiry_time but before we acquired the lock since SQL is free
-- to reorder the WHERE condition. Therefore we must recheck the condition
-- in the UPDATE statement below to detect this race.
--
AND GET_LOCK(CONCAT('radippool_', framedipaddress), 0) = 1
LIMIT 1;
IF r_address IS NULL THEN
DO RELEASE_LOCK(CONCAT('radippool_', r_address));
LEAVE proc;
END IF;
UPDATE radippool
SET
nasipaddress = v_nasipaddress,
pool_key = v_pool_key,
callingstationid = v_callingstationid,
username = v_username,
expiry_time = NOW() + INTERVAL v_lease_duration SECOND
WHERE
framedipaddress = r_address
--
-- Here we re-evaluate the original condition for selecting the address
-- to detect a race, in which case we try again...
--
AND expiry_time<NOW();
UNTIL ROW_COUNT() <> 0 END REPEAT;
DO RELEASE_LOCK(CONCAT('radippool_', r_address));
SELECT r_address;
END$$
DELIMITER ;
|
