1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
|
import logging
import weakref
from time import sleep, time
from threading import Thread, Event
from typing import Any, List, Tuple
import pytest
import psycopg
from psycopg.pq import TransactionStatus
from psycopg._compat import Counter
try:
import psycopg_pool as pool
except ImportError:
# Tests should have been skipped if the package is not available
pass
def test_package_version(mypy):
cp = mypy.run_on_source(
"""\
from psycopg_pool import __version__
assert __version__
"""
)
assert not cp.stdout
def test_defaults(dsn):
with pool.ConnectionPool(dsn) as p:
assert p.min_size == p.max_size == 4
assert p.timeout == 30
assert p.max_idle == 10 * 60
assert p.max_lifetime == 60 * 60
assert p.num_workers == 3
@pytest.mark.parametrize("min_size, max_size", [(2, None), (0, 2), (2, 4)])
def test_min_size_max_size(dsn, min_size, max_size):
with pool.ConnectionPool(dsn, min_size=min_size, max_size=max_size) as p:
assert p.min_size == min_size
assert p.max_size == max_size if max_size is not None else min_size
@pytest.mark.parametrize("min_size, max_size", [(0, 0), (0, None), (-1, None), (4, 2)])
def test_bad_size(dsn, min_size, max_size):
with pytest.raises(ValueError):
pool.ConnectionPool(min_size=min_size, max_size=max_size)
def test_connection_class(dsn):
class MyConn(psycopg.Connection[Any]):
pass
with pool.ConnectionPool(dsn, connection_class=MyConn, min_size=1) as p:
with p.connection() as conn:
assert isinstance(conn, MyConn)
def test_kwargs(dsn):
with pool.ConnectionPool(dsn, kwargs={"autocommit": True}, min_size=1) as p:
with p.connection() as conn:
assert conn.autocommit
@pytest.mark.crdb_skip("backend pid")
def test_its_really_a_pool(dsn):
with pool.ConnectionPool(dsn, min_size=2) as p:
with p.connection() as conn:
pid1 = conn.info.backend_pid
with p.connection() as conn2:
pid2 = conn2.info.backend_pid
with p.connection() as conn:
assert conn.info.backend_pid in (pid1, pid2)
def test_context(dsn):
with pool.ConnectionPool(dsn, min_size=1) as p:
assert not p.closed
assert p.closed
@pytest.mark.crdb_skip("backend pid")
def test_connection_not_lost(dsn):
with pool.ConnectionPool(dsn, min_size=1) as p:
with pytest.raises(ZeroDivisionError):
with p.connection() as conn:
pid = conn.info.backend_pid
1 / 0
with p.connection() as conn2:
assert conn2.info.backend_pid == pid
@pytest.mark.slow
@pytest.mark.timing
def test_concurrent_filling(dsn, monkeypatch):
delay_connection(monkeypatch, 0.1)
def add_time(self, conn):
times.append(time() - t0)
add_orig(self, conn)
add_orig = pool.ConnectionPool._add_to_pool
monkeypatch.setattr(pool.ConnectionPool, "_add_to_pool", add_time)
times: List[float] = []
t0 = time()
with pool.ConnectionPool(dsn, min_size=5, num_workers=2) as p:
p.wait(1.0)
want_times = [0.1, 0.1, 0.2, 0.2, 0.3]
assert len(times) == len(want_times)
for got, want in zip(times, want_times):
assert got == pytest.approx(want, 0.1), times
@pytest.mark.slow
@pytest.mark.timing
def test_wait_ready(dsn, monkeypatch):
delay_connection(monkeypatch, 0.1)
with pytest.raises(pool.PoolTimeout):
with pool.ConnectionPool(dsn, min_size=4, num_workers=1) as p:
p.wait(0.3)
with pool.ConnectionPool(dsn, min_size=4, num_workers=1) as p:
p.wait(0.5)
with pool.ConnectionPool(dsn, min_size=4, num_workers=2) as p:
p.wait(0.3)
p.wait(0.0001) # idempotent
def test_wait_closed(dsn):
with pool.ConnectionPool(dsn) as p:
pass
with pytest.raises(pool.PoolClosed):
p.wait()
@pytest.mark.slow
def test_setup_no_timeout(dsn, proxy):
with pytest.raises(pool.PoolTimeout):
with pool.ConnectionPool(proxy.client_dsn, min_size=1, num_workers=1) as p:
p.wait(0.2)
with pool.ConnectionPool(proxy.client_dsn, min_size=1, num_workers=1) as p:
sleep(0.5)
assert not p._pool
proxy.start()
with p.connection() as conn:
conn.execute("select 1")
def test_configure(dsn):
inits = 0
def configure(conn):
nonlocal inits
inits += 1
with conn.transaction():
conn.execute("set default_transaction_read_only to on")
with pool.ConnectionPool(dsn, min_size=1, configure=configure) as p:
p.wait()
with p.connection() as conn:
assert inits == 1
res = conn.execute("show default_transaction_read_only")
assert res.fetchone()[0] == "on" # type: ignore[index]
with p.connection() as conn:
assert inits == 1
res = conn.execute("show default_transaction_read_only")
assert res.fetchone()[0] == "on" # type: ignore[index]
conn.close()
with p.connection() as conn:
assert inits == 2
res = conn.execute("show default_transaction_read_only")
assert res.fetchone()[0] == "on" # type: ignore[index]
@pytest.mark.slow
def test_configure_badstate(dsn, caplog):
caplog.set_level(logging.WARNING, logger="psycopg.pool")
def configure(conn):
conn.execute("select 1")
with pool.ConnectionPool(dsn, min_size=1, configure=configure) as p:
with pytest.raises(pool.PoolTimeout):
p.wait(timeout=0.5)
assert caplog.records
assert "INTRANS" in caplog.records[0].message
@pytest.mark.slow
def test_configure_broken(dsn, caplog):
caplog.set_level(logging.WARNING, logger="psycopg.pool")
def configure(conn):
with conn.transaction():
conn.execute("WAT")
with pool.ConnectionPool(dsn, min_size=1, configure=configure) as p:
with pytest.raises(pool.PoolTimeout):
p.wait(timeout=0.5)
assert caplog.records
assert "WAT" in caplog.records[0].message
def test_reset(dsn):
resets = 0
def setup(conn):
with conn.transaction():
conn.execute("set timezone to '+1:00'")
def reset(conn):
nonlocal resets
resets += 1
with conn.transaction():
conn.execute("set timezone to utc")
with pool.ConnectionPool(dsn, min_size=1, reset=reset) as p:
with p.connection() as conn:
assert resets == 0
conn.execute("set timezone to '+2:00'")
p.wait()
assert resets == 1
with p.connection() as conn:
with conn.execute("show timezone") as cur:
assert cur.fetchone() == ("UTC",)
p.wait()
assert resets == 2
@pytest.mark.crdb_skip("backend pid")
def test_reset_badstate(dsn, caplog):
caplog.set_level(logging.WARNING, logger="psycopg.pool")
def reset(conn):
conn.execute("reset all")
with pool.ConnectionPool(dsn, min_size=1, reset=reset) as p:
with p.connection() as conn:
conn.execute("select 1")
pid1 = conn.info.backend_pid
with p.connection() as conn:
conn.execute("select 1")
pid2 = conn.info.backend_pid
assert pid1 != pid2
assert caplog.records
assert "INTRANS" in caplog.records[0].message
@pytest.mark.crdb_skip("backend pid")
def test_reset_broken(dsn, caplog):
caplog.set_level(logging.WARNING, logger="psycopg.pool")
def reset(conn):
with conn.transaction():
conn.execute("WAT")
with pool.ConnectionPool(dsn, min_size=1, reset=reset) as p:
with p.connection() as conn:
conn.execute("select 1")
pid1 = conn.info.backend_pid
with p.connection() as conn:
conn.execute("select 1")
pid2 = conn.info.backend_pid
assert pid1 != pid2
assert caplog.records
assert "WAT" in caplog.records[0].message
@pytest.mark.slow
@pytest.mark.timing
@pytest.mark.crdb_skip("backend pid")
def test_queue(dsn):
def worker(n):
t0 = time()
with p.connection() as conn:
conn.execute("select pg_sleep(0.2)")
pid = conn.info.backend_pid
t1 = time()
results.append((n, t1 - t0, pid))
results: List[Tuple[int, float, int]] = []
with pool.ConnectionPool(dsn, min_size=2) as p:
p.wait()
ts = [Thread(target=worker, args=(i,)) for i in range(6)]
for t in ts:
t.start()
for t in ts:
t.join()
times = [item[1] for item in results]
want_times = [0.2, 0.2, 0.4, 0.4, 0.6, 0.6]
for got, want in zip(times, want_times):
assert got == pytest.approx(want, 0.1), times
assert len(set(r[2] for r in results)) == 2, results
@pytest.mark.slow
def test_queue_size(dsn):
def worker(t, ev=None):
try:
with p.connection():
if ev:
ev.set()
sleep(t)
except pool.TooManyRequests as e:
errors.append(e)
else:
success.append(True)
errors: List[Exception] = []
success: List[bool] = []
with pool.ConnectionPool(dsn, min_size=1, max_waiting=3) as p:
p.wait()
ev = Event()
t = Thread(target=worker, args=(0.3, ev))
t.start()
ev.wait()
ts = [Thread(target=worker, args=(0.1,)) for i in range(4)]
for t in ts:
t.start()
for t in ts:
t.join()
assert len(success) == 4
assert len(errors) == 1
assert isinstance(errors[0], pool.TooManyRequests)
assert p.name in str(errors[0])
assert str(p.max_waiting) in str(errors[0])
assert p.get_stats()["requests_errors"] == 1
@pytest.mark.slow
@pytest.mark.timing
@pytest.mark.crdb_skip("backend pid")
def test_queue_timeout(dsn):
def worker(n):
t0 = time()
try:
with p.connection() as conn:
conn.execute("select pg_sleep(0.2)")
pid = conn.info.backend_pid
except pool.PoolTimeout as e:
t1 = time()
errors.append((n, t1 - t0, e))
else:
t1 = time()
results.append((n, t1 - t0, pid))
results: List[Tuple[int, float, int]] = []
errors: List[Tuple[int, float, Exception]] = []
with pool.ConnectionPool(dsn, min_size=2, timeout=0.1) as p:
ts = [Thread(target=worker, args=(i,)) for i in range(4)]
for t in ts:
t.start()
for t in ts:
t.join()
assert len(results) == 2
assert len(errors) == 2
for e in errors:
assert 0.1 < e[1] < 0.15
@pytest.mark.slow
@pytest.mark.timing
def test_dead_client(dsn):
def worker(i, timeout):
try:
with p.connection(timeout=timeout) as conn:
conn.execute("select pg_sleep(0.3)")
results.append(i)
except pool.PoolTimeout:
if timeout > 0.2:
raise
results: List[int] = []
with pool.ConnectionPool(dsn, min_size=2) as p:
ts = [
Thread(target=worker, args=(i, timeout))
for i, timeout in enumerate([0.4, 0.4, 0.1, 0.4, 0.4])
]
for t in ts:
t.start()
for t in ts:
t.join()
sleep(0.2)
assert set(results) == set([0, 1, 3, 4])
assert len(p._pool) == 2 # no connection was lost
@pytest.mark.slow
@pytest.mark.timing
@pytest.mark.crdb_skip("backend pid")
def test_queue_timeout_override(dsn):
def worker(n):
t0 = time()
timeout = 0.25 if n == 3 else None
try:
with p.connection(timeout=timeout) as conn:
conn.execute("select pg_sleep(0.2)")
pid = conn.info.backend_pid
except pool.PoolTimeout as e:
t1 = time()
errors.append((n, t1 - t0, e))
else:
t1 = time()
results.append((n, t1 - t0, pid))
results: List[Tuple[int, float, int]] = []
errors: List[Tuple[int, float, Exception]] = []
with pool.ConnectionPool(dsn, min_size=2, timeout=0.1) as p:
ts = [Thread(target=worker, args=(i,)) for i in range(4)]
for t in ts:
t.start()
for t in ts:
t.join()
assert len(results) == 3
assert len(errors) == 1
for e in errors:
assert 0.1 < e[1] < 0.15
@pytest.mark.crdb_skip("backend pid")
def test_broken_reconnect(dsn):
with pool.ConnectionPool(dsn, min_size=1) as p:
with p.connection() as conn:
pid1 = conn.info.backend_pid
conn.close()
with p.connection() as conn2:
pid2 = conn2.info.backend_pid
assert pid1 != pid2
@pytest.mark.crdb_skip("backend pid")
def test_intrans_rollback(dsn, caplog):
caplog.set_level(logging.WARNING, logger="psycopg.pool")
with pool.ConnectionPool(dsn, min_size=1) as p:
conn = p.getconn()
pid = conn.info.backend_pid
conn.execute("create table test_intrans_rollback ()")
assert conn.info.transaction_status == TransactionStatus.INTRANS
p.putconn(conn)
with p.connection() as conn2:
assert conn2.info.backend_pid == pid
assert conn2.info.transaction_status == TransactionStatus.IDLE
assert not conn2.execute(
"select 1 from pg_class where relname = 'test_intrans_rollback'"
).fetchone()
assert len(caplog.records) == 1
assert "INTRANS" in caplog.records[0].message
@pytest.mark.crdb_skip("backend pid")
def test_inerror_rollback(dsn, caplog):
caplog.set_level(logging.WARNING, logger="psycopg.pool")
with pool.ConnectionPool(dsn, min_size=1) as p:
conn = p.getconn()
pid = conn.info.backend_pid
with pytest.raises(psycopg.ProgrammingError):
conn.execute("wat")
assert conn.info.transaction_status == TransactionStatus.INERROR
p.putconn(conn)
with p.connection() as conn2:
assert conn2.info.backend_pid == pid
assert conn2.info.transaction_status == TransactionStatus.IDLE
assert len(caplog.records) == 1
assert "INERROR" in caplog.records[0].message
@pytest.mark.crdb_skip("backend pid")
@pytest.mark.crdb_skip("copy")
def test_active_close(dsn, caplog):
caplog.set_level(logging.WARNING, logger="psycopg.pool")
with pool.ConnectionPool(dsn, min_size=1) as p:
conn = p.getconn()
pid = conn.info.backend_pid
conn.pgconn.exec_(b"copy (select * from generate_series(1, 10)) to stdout")
assert conn.info.transaction_status == TransactionStatus.ACTIVE
p.putconn(conn)
with p.connection() as conn2:
assert conn2.info.backend_pid != pid
assert conn2.info.transaction_status == TransactionStatus.IDLE
assert len(caplog.records) == 2
assert "ACTIVE" in caplog.records[0].message
assert "BAD" in caplog.records[1].message
@pytest.mark.crdb_skip("backend pid")
def test_fail_rollback_close(dsn, caplog, monkeypatch):
caplog.set_level(logging.WARNING, logger="psycopg.pool")
with pool.ConnectionPool(dsn, min_size=1) as p:
conn = p.getconn()
def bad_rollback():
conn.pgconn.finish()
orig_rollback()
# Make the rollback fail
orig_rollback = conn.rollback
monkeypatch.setattr(conn, "rollback", bad_rollback)
pid = conn.info.backend_pid
with pytest.raises(psycopg.ProgrammingError):
conn.execute("wat")
assert conn.info.transaction_status == TransactionStatus.INERROR
p.putconn(conn)
with p.connection() as conn2:
assert conn2.info.backend_pid != pid
assert conn2.info.transaction_status == TransactionStatus.IDLE
assert len(caplog.records) == 3
assert "INERROR" in caplog.records[0].message
assert "OperationalError" in caplog.records[1].message
assert "BAD" in caplog.records[2].message
def test_close_no_threads(dsn):
p = pool.ConnectionPool(dsn)
assert p._sched_runner and p._sched_runner.is_alive()
workers = p._workers[:]
assert workers
for t in workers:
assert t.is_alive()
p.close()
assert p._sched_runner is None
assert not p._workers
for t in workers:
assert not t.is_alive()
def test_putconn_no_pool(conn_cls, dsn):
with pool.ConnectionPool(dsn, min_size=1) as p:
conn = conn_cls.connect(dsn)
with pytest.raises(ValueError):
p.putconn(conn)
conn.close()
def test_putconn_wrong_pool(dsn):
with pool.ConnectionPool(dsn, min_size=1) as p1:
with pool.ConnectionPool(dsn, min_size=1) as p2:
conn = p1.getconn()
with pytest.raises(ValueError):
p2.putconn(conn)
def test_del_no_warning(dsn, recwarn):
p = pool.ConnectionPool(dsn, min_size=2)
with p.connection() as conn:
conn.execute("select 1")
p.wait()
ref = weakref.ref(p)
del p
assert not ref()
assert not recwarn, [str(w.message) for w in recwarn.list]
@pytest.mark.slow
def test_del_stop_threads(dsn):
p = pool.ConnectionPool(dsn)
assert p._sched_runner is not None
ts = [p._sched_runner] + p._workers
del p
sleep(0.1)
for t in ts:
assert not t.is_alive()
def test_closed_getconn(dsn):
p = pool.ConnectionPool(dsn, min_size=1)
assert not p.closed
with p.connection():
pass
p.close()
assert p.closed
with pytest.raises(pool.PoolClosed):
with p.connection():
pass
def test_closed_putconn(dsn):
p = pool.ConnectionPool(dsn, min_size=1)
with p.connection() as conn:
pass
assert not conn.closed
with p.connection() as conn:
p.close()
assert conn.closed
def test_closed_queue(dsn):
def w1():
with p.connection() as conn:
e1.set() # Tell w0 that w1 got a connection
cur = conn.execute("select 1")
assert cur.fetchone() == (1,)
e2.wait() # Wait until w0 has tested w2
success.append("w1")
def w2():
try:
with p.connection():
pass # unexpected
except pool.PoolClosed:
success.append("w2")
e1 = Event()
e2 = Event()
p = pool.ConnectionPool(dsn, min_size=1)
p.wait()
success: List[str] = []
t1 = Thread(target=w1)
t1.start()
# Wait until w1 has received a connection
e1.wait()
t2 = Thread(target=w2)
t2.start()
# Wait until w2 is in the queue
ensure_waiting(p)
p.close(0)
# Wait for the workers to finish
e2.set()
t1.join()
t2.join()
assert len(success) == 2
def test_open_explicit(dsn):
p = pool.ConnectionPool(dsn, open=False)
assert p.closed
with pytest.raises(pool.PoolClosed, match="is not open yet"):
p.getconn()
with pytest.raises(pool.PoolClosed):
with p.connection():
pass
p.open()
try:
assert not p.closed
with p.connection() as conn:
cur = conn.execute("select 1")
assert cur.fetchone() == (1,)
finally:
p.close()
with pytest.raises(pool.PoolClosed, match="is already closed"):
p.getconn()
def test_open_context(dsn):
p = pool.ConnectionPool(dsn, open=False)
assert p.closed
with p:
assert not p.closed
with p.connection() as conn:
cur = conn.execute("select 1")
assert cur.fetchone() == (1,)
assert p.closed
def test_open_no_op(dsn):
p = pool.ConnectionPool(dsn)
try:
assert not p.closed
p.open()
assert not p.closed
with p.connection() as conn:
cur = conn.execute("select 1")
assert cur.fetchone() == (1,)
finally:
p.close()
@pytest.mark.slow
@pytest.mark.timing
def test_open_wait(dsn, monkeypatch):
delay_connection(monkeypatch, 0.1)
with pytest.raises(pool.PoolTimeout):
p = pool.ConnectionPool(dsn, min_size=4, num_workers=1, open=False)
try:
p.open(wait=True, timeout=0.3)
finally:
p.close()
p = pool.ConnectionPool(dsn, min_size=4, num_workers=1, open=False)
try:
p.open(wait=True, timeout=0.5)
finally:
p.close()
@pytest.mark.slow
@pytest.mark.timing
def test_open_as_wait(dsn, monkeypatch):
delay_connection(monkeypatch, 0.1)
with pytest.raises(pool.PoolTimeout):
with pool.ConnectionPool(dsn, min_size=4, num_workers=1) as p:
p.open(wait=True, timeout=0.3)
with pool.ConnectionPool(dsn, min_size=4, num_workers=1) as p:
p.open(wait=True, timeout=0.5)
def test_reopen(dsn):
p = pool.ConnectionPool(dsn)
with p.connection() as conn:
conn.execute("select 1")
p.close()
assert p._sched_runner is None
assert not p._workers
with pytest.raises(psycopg.OperationalError, match="cannot be reused"):
p.open()
@pytest.mark.slow
@pytest.mark.timing
@pytest.mark.parametrize(
"min_size, want_times",
[
(2, [0.25, 0.25, 0.35, 0.45, 0.50, 0.50, 0.60, 0.70]),
(0, [0.35, 0.45, 0.55, 0.60, 0.65, 0.70, 0.80, 0.85]),
],
)
def test_grow(dsn, monkeypatch, min_size, want_times):
delay_connection(monkeypatch, 0.1)
def worker(n):
t0 = time()
with p.connection() as conn:
conn.execute("select 1 from pg_sleep(0.25)")
t1 = time()
results.append((n, t1 - t0))
with pool.ConnectionPool(dsn, min_size=min_size, max_size=4, num_workers=3) as p:
p.wait(1.0)
results: List[Tuple[int, float]] = []
ts = [Thread(target=worker, args=(i,)) for i in range(len(want_times))]
for t in ts:
t.start()
for t in ts:
t.join()
times = [item[1] for item in results]
for got, want in zip(times, want_times):
assert got == pytest.approx(want, 0.1), times
@pytest.mark.slow
@pytest.mark.timing
def test_shrink(dsn, monkeypatch):
from psycopg_pool.pool import ShrinkPool
results: List[Tuple[int, int]] = []
def run_hacked(self, pool):
n0 = pool._nconns
orig_run(self, pool)
n1 = pool._nconns
results.append((n0, n1))
orig_run = ShrinkPool._run
monkeypatch.setattr(ShrinkPool, "_run", run_hacked)
def worker(n):
with p.connection() as conn:
conn.execute("select pg_sleep(0.1)")
with pool.ConnectionPool(dsn, min_size=2, max_size=4, max_idle=0.2) as p:
p.wait(5.0)
assert p.max_idle == 0.2
ts = [Thread(target=worker, args=(i,)) for i in range(4)]
for t in ts:
t.start()
for t in ts:
t.join()
sleep(1)
assert results == [(4, 4), (4, 3), (3, 2), (2, 2), (2, 2)]
@pytest.mark.slow
def test_reconnect(proxy, caplog, monkeypatch):
caplog.set_level(logging.WARNING, logger="psycopg.pool")
assert pool.base.ConnectionAttempt.INITIAL_DELAY == 1.0
assert pool.base.ConnectionAttempt.DELAY_JITTER == 0.1
monkeypatch.setattr(pool.base.ConnectionAttempt, "INITIAL_DELAY", 0.1)
monkeypatch.setattr(pool.base.ConnectionAttempt, "DELAY_JITTER", 0.0)
caplog.clear()
proxy.start()
with pool.ConnectionPool(proxy.client_dsn, min_size=1) as p:
p.wait(2.0)
proxy.stop()
with pytest.raises(psycopg.OperationalError):
with p.connection() as conn:
conn.execute("select 1")
sleep(1.0)
proxy.start()
p.wait()
with p.connection() as conn:
conn.execute("select 1")
assert "BAD" in caplog.messages[0]
times = [rec.created for rec in caplog.records]
assert times[1] - times[0] < 0.05
deltas = [times[i + 1] - times[i] for i in range(1, len(times) - 1)]
assert len(deltas) == 3
want = 0.1
for delta in deltas:
assert delta == pytest.approx(want, 0.05), deltas
want *= 2
@pytest.mark.slow
@pytest.mark.timing
def test_reconnect_failure(proxy):
proxy.start()
t1 = None
def failed(pool):
assert pool.name == "this-one"
nonlocal t1
t1 = time()
with pool.ConnectionPool(
proxy.client_dsn,
name="this-one",
min_size=1,
reconnect_timeout=1.0,
reconnect_failed=failed,
) as p:
p.wait(2.0)
proxy.stop()
with pytest.raises(psycopg.OperationalError):
with p.connection() as conn:
conn.execute("select 1")
t0 = time()
sleep(1.5)
assert t1
assert t1 - t0 == pytest.approx(1.0, 0.1)
assert p._nconns == 0
proxy.start()
t0 = time()
with p.connection() as conn:
conn.execute("select 1")
t1 = time()
assert t1 - t0 < 0.2
@pytest.mark.slow
def test_reconnect_after_grow_failed(proxy):
# Retry reconnection after a failed connection attempt has put the pool
# in grow mode. See issue #370.
proxy.stop()
ev = Event()
def failed(pool):
ev.set()
with pool.ConnectionPool(
proxy.client_dsn, min_size=4, reconnect_timeout=1.0, reconnect_failed=failed
) as p:
assert ev.wait(timeout=2)
with pytest.raises(pool.PoolTimeout):
with p.connection(timeout=0.5) as conn:
pass
ev.clear()
assert ev.wait(timeout=2)
proxy.start()
with p.connection(timeout=2) as conn:
conn.execute("select 1")
p.wait(timeout=3.0)
assert len(p._pool) == p.min_size == 4
@pytest.mark.slow
def test_refill_on_check(proxy):
proxy.start()
ev = Event()
def failed(pool):
ev.set()
with pool.ConnectionPool(
proxy.client_dsn, min_size=4, reconnect_timeout=1.0, reconnect_failed=failed
) as p:
# The pool is full
p.wait(timeout=2)
# Break all the connection
proxy.stop()
# Checking the pool will empty it
p.check()
assert ev.wait(timeout=2)
assert len(p._pool) == 0
# Allow to connect again
proxy.start()
# Make sure that check has refilled the pool
p.check()
p.wait(timeout=2)
assert len(p._pool) == 4
@pytest.mark.slow
def test_uniform_use(dsn):
with pool.ConnectionPool(dsn, min_size=4) as p:
counts = Counter[int]()
for i in range(8):
with p.connection() as conn:
sleep(0.1)
counts[id(conn)] += 1
assert len(counts) == 4
assert set(counts.values()) == set([2])
@pytest.mark.slow
@pytest.mark.timing
def test_resize(dsn):
def sampler():
sleep(0.05) # ensure sampling happens after shrink check
while True:
sleep(0.2)
if p.closed:
break
size.append(len(p._pool))
def client(t):
with p.connection() as conn:
conn.execute("select pg_sleep(%s)", [t])
size: List[int] = []
with pool.ConnectionPool(dsn, min_size=2, max_idle=0.2) as p:
s = Thread(target=sampler)
s.start()
sleep(0.3)
c = Thread(target=client, args=(0.4,))
c.start()
sleep(0.2)
p.resize(4)
assert p.min_size == 4
assert p.max_size == 4
sleep(0.4)
p.resize(2)
assert p.min_size == 2
assert p.max_size == 2
sleep(0.6)
s.join()
assert size == [2, 1, 3, 4, 3, 2, 2]
@pytest.mark.parametrize("min_size, max_size", [(0, 0), (-1, None), (4, 2)])
def test_bad_resize(dsn, min_size, max_size):
with pool.ConnectionPool() as p:
with pytest.raises(ValueError):
p.resize(min_size=min_size, max_size=max_size)
def test_jitter():
rnds = [pool.ConnectionPool._jitter(30, -0.1, +0.2) for i in range(100)]
assert 27 <= min(rnds) <= 28
assert 35 < max(rnds) < 36
@pytest.mark.slow
@pytest.mark.timing
@pytest.mark.crdb_skip("backend pid")
def test_max_lifetime(dsn):
with pool.ConnectionPool(dsn, min_size=1, max_lifetime=0.2) as p:
sleep(0.1)
pids = []
for i in range(5):
with p.connection() as conn:
pids.append(conn.info.backend_pid)
sleep(0.2)
assert pids[0] == pids[1] != pids[4], pids
@pytest.mark.crdb_skip("backend pid")
def test_check(dsn, caplog):
caplog.set_level(logging.WARNING, logger="psycopg.pool")
with pool.ConnectionPool(dsn, min_size=4) as p:
p.wait(1.0)
with p.connection() as conn:
pid = conn.info.backend_pid
p.wait(1.0)
pids = set(conn.info.backend_pid for conn in p._pool)
assert pid in pids
conn.close()
assert len(caplog.records) == 0
p.check()
assert len(caplog.records) == 1
p.wait(1.0)
pids2 = set(conn.info.backend_pid for conn in p._pool)
assert len(pids & pids2) == 3
assert pid not in pids2
def test_check_idle(dsn):
with pool.ConnectionPool(dsn, min_size=2) as p:
p.wait(1.0)
p.check()
with p.connection() as conn:
assert conn.info.transaction_status == TransactionStatus.IDLE
@pytest.mark.slow
@pytest.mark.timing
def test_stats_measures(dsn):
def worker(n):
with p.connection() as conn:
conn.execute("select pg_sleep(0.2)")
with pool.ConnectionPool(dsn, min_size=2, max_size=4) as p:
p.wait(2.0)
stats = p.get_stats()
assert stats["pool_min"] == 2
assert stats["pool_max"] == 4
assert stats["pool_size"] == 2
assert stats["pool_available"] == 2
assert stats["requests_waiting"] == 0
ts = [Thread(target=worker, args=(i,)) for i in range(3)]
for t in ts:
t.start()
sleep(0.1)
stats = p.get_stats()
for t in ts:
t.join()
assert stats["pool_min"] == 2
assert stats["pool_max"] == 4
assert stats["pool_size"] == 3
assert stats["pool_available"] == 0
assert stats["requests_waiting"] == 0
p.wait(2.0)
ts = [Thread(target=worker, args=(i,)) for i in range(7)]
for t in ts:
t.start()
sleep(0.1)
stats = p.get_stats()
for t in ts:
t.join()
assert stats["pool_min"] == 2
assert stats["pool_max"] == 4
assert stats["pool_size"] == 4
assert stats["pool_available"] == 0
assert stats["requests_waiting"] == 3
@pytest.mark.slow
@pytest.mark.timing
def test_stats_usage(dsn):
def worker(n):
try:
with p.connection(timeout=0.3) as conn:
conn.execute("select pg_sleep(0.2)")
except pool.PoolTimeout:
pass
with pool.ConnectionPool(dsn, min_size=3) as p:
p.wait(2.0)
ts = [Thread(target=worker, args=(i,)) for i in range(7)]
for t in ts:
t.start()
for t in ts:
t.join()
stats = p.get_stats()
assert stats["requests_num"] == 7
assert stats["requests_queued"] == 4
assert 850 <= stats["requests_wait_ms"] <= 950
assert stats["requests_errors"] == 1
assert 1150 <= stats["usage_ms"] <= 1250
assert stats.get("returns_bad", 0) == 0
with p.connection() as conn:
conn.close()
p.wait()
stats = p.pop_stats()
assert stats["requests_num"] == 8
assert stats["returns_bad"] == 1
with p.connection():
pass
assert p.get_stats()["requests_num"] == 1
@pytest.mark.slow
def test_stats_connect(dsn, proxy, monkeypatch):
proxy.start()
delay_connection(monkeypatch, 0.2)
with pool.ConnectionPool(proxy.client_dsn, min_size=3) as p:
p.wait()
stats = p.get_stats()
assert stats["connections_num"] == 3
assert stats.get("connections_errors", 0) == 0
assert stats.get("connections_lost", 0) == 0
assert 600 <= stats["connections_ms"] < 1200
proxy.stop()
p.check()
sleep(0.1)
stats = p.get_stats()
assert stats["connections_num"] > 3
assert stats["connections_errors"] > 0
assert stats["connections_lost"] == 3
@pytest.mark.slow
def test_spike(dsn, monkeypatch):
# Inspired to https://github.com/brettwooldridge/HikariCP/blob/dev/
# documents/Welcome-To-The-Jungle.md
delay_connection(monkeypatch, 0.15)
def worker():
with p.connection():
sleep(0.002)
with pool.ConnectionPool(dsn, min_size=5, max_size=10) as p:
p.wait()
ts = [Thread(target=worker) for i in range(50)]
for t in ts:
t.start()
for t in ts:
t.join()
p.wait()
assert len(p._pool) < 7
def test_debug_deadlock(dsn):
# https://github.com/psycopg/psycopg/issues/230
logger = logging.getLogger("psycopg")
handler = logging.StreamHandler()
old_level = logger.level
logger.setLevel(logging.DEBUG)
handler.setLevel(logging.DEBUG)
logger.addHandler(handler)
try:
with pool.ConnectionPool(dsn, min_size=4, open=True) as p:
try:
p.wait(timeout=2)
finally:
print(p.get_stats())
finally:
logger.removeHandler(handler)
logger.setLevel(old_level)
def delay_connection(monkeypatch, sec):
"""
Return a _connect_gen function delayed by the amount of seconds
"""
def connect_delay(*args, **kwargs):
t0 = time()
rv = connect_orig(*args, **kwargs)
t1 = time()
sleep(max(0, sec - (t1 - t0)))
return rv
connect_orig = psycopg.Connection.connect
monkeypatch.setattr(psycopg.Connection, "connect", connect_delay)
def ensure_waiting(p, num=1):
"""
Wait until there are at least *num* clients waiting in the queue.
"""
while len(p._waiting) < num:
sleep(0)
|