diff options
author | Daniel Baumann <daniel.baumann@progress-linux.org> | 2024-04-27 16:51:28 +0000 |
---|---|---|
committer | Daniel Baumann <daniel.baumann@progress-linux.org> | 2024-04-27 16:51:28 +0000 |
commit | 940b4d1848e8c70ab7642901a68594e8016caffc (patch) | |
tree | eb72f344ee6c3d9b80a7ecc079ea79e9fba8676d /compilerplugins/clang/blockblock.cxx | |
parent | Initial commit. (diff) | |
download | libreoffice-940b4d1848e8c70ab7642901a68594e8016caffc.tar.xz libreoffice-940b4d1848e8c70ab7642901a68594e8016caffc.zip |
Adding upstream version 1:7.0.4.upstream/1%7.0.4upstream
Signed-off-by: Daniel Baumann <daniel.baumann@progress-linux.org>
Diffstat (limited to '')
-rw-r--r-- | compilerplugins/clang/blockblock.cxx | 108 |
1 files changed, 108 insertions, 0 deletions
diff --git a/compilerplugins/clang/blockblock.cxx b/compilerplugins/clang/blockblock.cxx new file mode 100644 index 000000000..f1d9ec7a9 --- /dev/null +++ b/compilerplugins/clang/blockblock.cxx @@ -0,0 +1,108 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#ifndef LO_CLANG_SHARED_PLUGINS + +#include <cassert> +#include <string> +#include <iostream> +#include <fstream> +#include <set> +#include "plugin.hxx" + +/** + Check for places where we declare a block directly inside a block + */ +namespace { + +class BlockBlock: + public loplugin::FilteringPlugin<BlockBlock> +{ +public: + explicit BlockBlock(loplugin::InstantiationData const & data): + FilteringPlugin(data) {} + + virtual bool preRun() override + { + StringRef fn(handler.getMainFileName()); + if (loplugin::isSamePathname(fn, SRCDIR "/sal/osl/unx/file_misc.cxx")) + return false; + return true; + } + + void run() override { + if (preRun()) { + TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); + } + } + + bool VisitCompoundStmt(CompoundStmt const * ); + bool VisitCaseStmt(CaseStmt const * ); +}; + +bool BlockBlock::VisitCompoundStmt(CompoundStmt const * compound) +{ + if (ignoreLocation(compound)) + return true; + if (compound->size() != 1) + return true; + auto inner = *compound->body_begin(); + if (!isa<CompoundStmt>(inner)) + return true; + if (compiler.getSourceManager().isMacroBodyExpansion(compat::getBeginLoc(compound))) + return true; + if (compiler.getSourceManager().isMacroBodyExpansion(compat::getBeginLoc(inner))) + return true; + if (containsPreprocessingConditionalInclusion(compound->getSourceRange())) { + return true; + } + report( + DiagnosticsEngine::Warning, + "block directly inside block", + compat::getBeginLoc(compound)) + << compound->getSourceRange(); + report( + DiagnosticsEngine::Note, + "inner block here", + compat::getBeginLoc(inner)) + << inner->getSourceRange(); + return true; +} + +bool BlockBlock::VisitCaseStmt(CaseStmt const * caseStmt) +{ + if (ignoreLocation(caseStmt)) + return true; + auto compoundStmt = dyn_cast<CompoundStmt>(caseStmt->getSubStmt()); + if (!compoundStmt) + return true; + if (compoundStmt->size() != 2) + return true; + auto it = compoundStmt->body_begin(); + auto inner1 = *it; + if (!isa<CompoundStmt>(inner1)) + return true; + ++it; + if (!isa<BreakStmt>(*it)) + return true; + report( + DiagnosticsEngine::Warning, + "block directly inside block", + compat::getBeginLoc(compoundStmt)) + << compoundStmt->getSourceRange(); + return true; +} + +loplugin::Plugin::Registration< BlockBlock > blockblock("blockblock", true); + +} + +#endif // LO_CLANG_SHARED_PLUGINS + +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ |