diff options
author | Daniel Baumann <daniel.baumann@progress-linux.org> | 2024-04-27 16:51:28 +0000 |
---|---|---|
committer | Daniel Baumann <daniel.baumann@progress-linux.org> | 2024-04-27 16:51:28 +0000 |
commit | 940b4d1848e8c70ab7642901a68594e8016caffc (patch) | |
tree | eb72f344ee6c3d9b80a7ecc079ea79e9fba8676d /compilerplugins/clang/emptyif.cxx | |
parent | Initial commit. (diff) | |
download | libreoffice-940b4d1848e8c70ab7642901a68594e8016caffc.tar.xz libreoffice-940b4d1848e8c70ab7642901a68594e8016caffc.zip |
Adding upstream version 1:7.0.4.upstream/1%7.0.4upstream
Signed-off-by: Daniel Baumann <daniel.baumann@progress-linux.org>
Diffstat (limited to 'compilerplugins/clang/emptyif.cxx')
-rw-r--r-- | compilerplugins/clang/emptyif.cxx | 94 |
1 files changed, 94 insertions, 0 deletions
diff --git a/compilerplugins/clang/emptyif.cxx b/compilerplugins/clang/emptyif.cxx new file mode 100644 index 000000000..ef7eac50d --- /dev/null +++ b/compilerplugins/clang/emptyif.cxx @@ -0,0 +1,94 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#ifndef LO_CLANG_SHARED_PLUGINS + +#include <cassert> +#include <string> +#include <iostream> +#include <fstream> +#include <set> +#include "plugin.hxx" + +/** + Check for places where we do + if (xxx) ; + or + if (xxx) {} + */ +namespace +{ +class EmptyIf : public loplugin::FilteringRewritePlugin<EmptyIf> +{ +public: + explicit EmptyIf(loplugin::InstantiationData const& data) + : FilteringRewritePlugin(data) + { + } + + virtual void run() override { TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); } + + bool VisitIfStmt(IfStmt const*); + +private: + bool ContainsComment(Stmt const*); +}; + +static bool empty(Stmt const* stmt) +{ + if (isa<NullStmt>(stmt)) + return true; + auto compoundStmt = dyn_cast<CompoundStmt>(stmt); + if (!compoundStmt) + return false; + return compoundStmt->size() == 0; +} + +bool EmptyIf::ContainsComment(Stmt const* stmt) +{ + auto range = stmt->getSourceRange(); + SourceManager& SM = compiler.getSourceManager(); + SourceLocation startLoc = range.getBegin(); + SourceLocation endLoc = range.getEnd(); + char const* p1 = SM.getCharacterData(startLoc); + char const* p2 = SM.getCharacterData(endLoc); + p2 += Lexer::MeasureTokenLength(endLoc, SM, compiler.getLangOpts()); + auto s = llvm::StringRef(p1, p2 - p1); + return s.find("//") != llvm::StringRef::npos || s.find("/*") != llvm::StringRef::npos + || s.find("#if") != llvm::StringRef::npos; +} + +bool EmptyIf::VisitIfStmt(IfStmt const* ifStmt) +{ + if (ignoreLocation(ifStmt)) + return true; + + if (ifStmt->getElse() && empty(ifStmt->getElse()) && !ContainsComment(ifStmt->getElse())) + { + report(DiagnosticsEngine::Warning, "empty else body", + compat::getBeginLoc(ifStmt->getElse())) + << ifStmt->getElse()->getSourceRange(); + return true; + } + + if (!ifStmt->getElse() && empty(ifStmt->getThen()) && !ContainsComment(ifStmt->getThen())) + { + report(DiagnosticsEngine::Warning, "empty if body", compat::getBeginLoc(ifStmt)) + << ifStmt->getSourceRange(); + } + + return true; +} + +loplugin::Plugin::Registration<EmptyIf> emptyif("emptyif", true); +} + +#endif // LO_CLANG_SHARED_PLUGINS + +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ |