From 940b4d1848e8c70ab7642901a68594e8016caffc Mon Sep 17 00:00:00 2001 From: Daniel Baumann Date: Sat, 27 Apr 2024 18:51:28 +0200 Subject: Adding upstream version 1:7.0.4. Signed-off-by: Daniel Baumann --- compilerplugins/clang/sequenceloop.cxx | 80 ++++++++++++++++++++++++++++++++++ 1 file changed, 80 insertions(+) create mode 100644 compilerplugins/clang/sequenceloop.cxx (limited to 'compilerplugins/clang/sequenceloop.cxx') diff --git a/compilerplugins/clang/sequenceloop.cxx b/compilerplugins/clang/sequenceloop.cxx new file mode 100644 index 000000000..7f14d6c4d --- /dev/null +++ b/compilerplugins/clang/sequenceloop.cxx @@ -0,0 +1,80 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ +#ifndef LO_CLANG_SHARED_PLUGINS + +#include +#include +#include +#include +#include + +#include +#include "plugin.hxx" +#include "check.hxx" + +/** + When used in "for" loops, css::uno::Sequence objects tend to end up calling the non-const begin()/end(), + which is considerably more expensive than the const variants because it forces a local copy + of the internal ref-counted impl object. +*/ + +namespace +{ +class SequenceLoop : public loplugin::FilteringPlugin +{ +public: + explicit SequenceLoop(loplugin::InstantiationData const& data) + : FilteringPlugin(data) + { + } + + virtual void run() override + { + if (preRun()) + TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); + } + + bool VisitCXXForRangeStmt(CXXForRangeStmt const*); +}; + +bool SequenceLoop::VisitCXXForRangeStmt(CXXForRangeStmt const* forStmt) +{ + if (ignoreLocation(forStmt)) + return true; + + auto tc = loplugin::TypeCheck(forStmt->getRangeInit()->getType()); + if (tc.Const()) + return true; + if (!tc.Class("Sequence") + .Namespace("uno") + .Namespace("star") + .Namespace("sun") + .Namespace("com") + .GlobalNamespace()) + return true; + const VarDecl* varDecl = forStmt->getLoopVariable(); + auto tc2 = loplugin::TypeCheck(varDecl->getType()); + if (!tc2.LvalueReference().Const()) + return true; + + report(DiagnosticsEngine::Warning, + ("use std::as_const, or otherwise make the for-range-initializer expression const, to" + " avoid creating a copy of the Sequence"), + compat::getBeginLoc(forStmt->getRangeInit())) + << forStmt->getSourceRange(); + return true; +} + +loplugin::Plugin::Registration sequenceloop("sequenceloop"); + +} // namespace + +#endif // LO_CLANG_SHARED_PLUGINS + +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ -- cgit v1.2.3