1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <memory>
#include <string>
#include <iostream>
#include <map>
#include <set>
#include "plugin.hxx"
#include "clang/AST/CXXInheritance.h"
// Check for local variables that we are calling delete on
namespace
{
class MemoryVar:
public loplugin::FilteringPlugin<MemoryVar>
{
public:
explicit MemoryVar(loplugin::InstantiationData const & data): FilteringPlugin(data), mbChecking(false) {}
virtual void run() override {
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
}
bool TraverseFunctionDecl(FunctionDecl*);
bool VisitCXXDeleteExpr(const CXXDeleteExpr*);
bool VisitCXXNewExpr(const CXXNewExpr* );
bool VisitBinaryOperator(const BinaryOperator*);
bool VisitReturnStmt(const ReturnStmt*);
private:
bool mbChecking;
std::set<SourceLocation> maVarUsesSet;
std::set<SourceLocation> maVarNewSet;
std::set<SourceLocation> maVarIgnoreSet;
std::map<SourceLocation,SourceRange> maVarDeclSourceRangeMap;
std::map<SourceLocation,SourceRange> maVarDeleteSourceRangeMap;
StringRef getFilename(SourceLocation loc);
};
StringRef MemoryVar::getFilename(SourceLocation loc)
{
SourceLocation spellingLocation = compiler.getSourceManager().getSpellingLoc(loc);
StringRef name { getFilenameOfLocation(spellingLocation) };
return name;
}
bool MemoryVar::TraverseFunctionDecl(FunctionDecl * decl)
{
if (ignoreLocation(decl)) {
return true;
}
if (!decl->hasBody() || !decl->isThisDeclarationADefinition()) {
return true;
}
maVarUsesSet.clear();
maVarNewSet.clear();
maVarIgnoreSet.clear();
maVarDeclSourceRangeMap.clear();
maVarDeleteSourceRangeMap.clear();
assert(!mbChecking);
mbChecking = true;
TraverseStmt(decl->getBody());
mbChecking = false;
for (const auto& varLoc : maVarUsesSet)
{
// checking the location of the var instead of the function because for some reason
// I'm not getting accurate results from clang right now
StringRef aFileName = getFilename(varLoc);
// TODO these files are doing some weird stuff I don't know how to ignore yet
if (loplugin::hasPathnamePrefix(aFileName, SRCDIR "/vcl/source/filter/")) {
return true;
}
if (loplugin::isSamePathname(aFileName, SRCDIR "/sw/source/core/layout/frmtool.cxx")) {
return true;
}
if (maVarNewSet.find(varLoc) == maVarNewSet.end())
continue;
if (maVarIgnoreSet.find(varLoc) != maVarIgnoreSet.end())
continue;
report(DiagnosticsEngine::Warning,
"calling new and delete on a local var, rather use std::unique_ptr",
varLoc)
<< maVarDeclSourceRangeMap[varLoc];
report(DiagnosticsEngine::Note,
"delete called here",
maVarDeleteSourceRangeMap[varLoc].getBegin())
<< maVarDeleteSourceRangeMap[varLoc];
}
return true;
}
bool MemoryVar::VisitCXXDeleteExpr(const CXXDeleteExpr *deleteExpr)
{
if (!mbChecking)
return true;
if (ignoreLocation(deleteExpr)) {
return true;
}
const Expr* argumentExpr = deleteExpr->getArgument();
if (isa<CastExpr>(argumentExpr)) {
argumentExpr = dyn_cast<CastExpr>(argumentExpr)->getSubExpr();
}
const DeclRefExpr* declRefExpr = dyn_cast<DeclRefExpr>(argumentExpr);
if (!declRefExpr)
return true;
const Decl* decl = declRefExpr->getDecl();
if (!isa<VarDecl>(decl) || isa<ParmVarDecl>(decl)) {
return true;
}
const VarDecl * varDecl = dyn_cast<VarDecl>(decl)->getCanonicalDecl();
if (varDecl->hasGlobalStorage()) {
return true;
}
SourceLocation loc = varDecl->getLocation();
if (maVarUsesSet.insert(loc).second) {
maVarDeclSourceRangeMap[loc] = varDecl->getSourceRange();
maVarDeleteSourceRangeMap[loc] = declRefExpr->getSourceRange();
}
return true;
}
bool MemoryVar::VisitCXXNewExpr(const CXXNewExpr *newExpr)
{
if (!mbChecking)
return true;
if (ignoreLocation(newExpr)) {
return true;
}
const Stmt* stmt = getParentStmt(newExpr);
const DeclStmt* declStmt = dyn_cast<DeclStmt>(stmt);
if (declStmt) {
const VarDecl* varDecl = dyn_cast<VarDecl>(declStmt->getSingleDecl());
if (varDecl) {
varDecl = varDecl->getCanonicalDecl();
SourceLocation loc = varDecl->getLocation();
maVarNewSet.insert(loc);
}
return true;
}
const BinaryOperator* binaryOp = dyn_cast<BinaryOperator>(stmt);
if (binaryOp && binaryOp->getOpcode() == BO_Assign) {
const DeclRefExpr* declRefExpr = dyn_cast<DeclRefExpr>(binaryOp->getLHS());
if (declRefExpr) {
const VarDecl* varDecl = dyn_cast<VarDecl>(declRefExpr->getDecl());
if (varDecl) {
varDecl = varDecl->getCanonicalDecl();
SourceLocation loc = varDecl->getLocation();
maVarNewSet.insert(loc);
}
}
}
return true;
}
// Ignore cases where the variable in question is assigned to another variable
bool MemoryVar::VisitBinaryOperator(const BinaryOperator *binaryOp)
{
if (!mbChecking)
return true;
if (ignoreLocation(binaryOp)) {
return true;
}
if (binaryOp->getOpcode() != BO_Assign) {
return true;
}
const Expr* expr = binaryOp->getRHS();
// unwrap casts
while (isa<CastExpr>(expr)) {
expr = dyn_cast<CastExpr>(expr)->getSubExpr();
}
const DeclRefExpr* declRefExpr = dyn_cast<DeclRefExpr>(expr);
if (!declRefExpr) {
return true;
}
const VarDecl* varDecl = dyn_cast<VarDecl>(declRefExpr->getDecl());
if (!varDecl) {
return true;
}
varDecl = varDecl->getCanonicalDecl();
maVarIgnoreSet.insert(varDecl->getLocation());
return true;
}
// Ignore cases where the variable in question is returned from a function
bool MemoryVar::VisitReturnStmt(const ReturnStmt *returnStmt)
{
if (!mbChecking)
return true;
if (ignoreLocation(returnStmt)) {
return true;
}
const Expr* expr = returnStmt->getRetValue();
if (!expr) {
return true;
}
// unwrap casts
while (isa<CastExpr>(expr)) {
expr = dyn_cast<CastExpr>(expr)->getSubExpr();
}
const DeclRefExpr* declRefExpr = dyn_cast<DeclRefExpr>(expr);
if (!declRefExpr) {
return true;
}
const VarDecl* varDecl = dyn_cast<VarDecl>(declRefExpr->getDecl());
if (!varDecl) {
return true;
}
varDecl = varDecl->getCanonicalDecl();
maVarIgnoreSet.insert(varDecl->getLocation());
return true;
}
loplugin::Plugin::Registration< MemoryVar > X("memoryvar", false);
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
