blob: bd8aaaf03957773c3f7794aa6926fc532178b7d7 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#ifndef LO_CLANG_SHARED_PLUGINS
#include <memory>
#include <cassert>
#include <string>
#include <iostream>
#include <fstream>
#include <set>
#include "plugin.hxx"
#include "check.hxx"
namespace
{
class SimplifyConstruct : public loplugin::FilteringPlugin<SimplifyConstruct>
{
public:
explicit SimplifyConstruct(loplugin::InstantiationData const& data)
: FilteringPlugin(data)
{
}
virtual void run() override { TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); }
bool VisitCXXConstructExpr(CXXConstructExpr const*);
bool VisitVarDecl(VarDecl const*);
// ignore some contexts within which nullptr is fine
bool TraverseReturnStmt(ReturnStmt*) { return true; }
bool TraverseInitListExpr(InitListExpr*) { return true; }
bool TraverseCXXBindTemporaryExpr(CXXBindTemporaryExpr*) { return true; }
// ignore them for the shared visitor too
bool PreTraverseReturnStmt(ReturnStmt*) { return false; }
bool PreTraverseInitListExpr(InitListExpr*) { return false; }
bool PreTraverseCXXBindTemporaryExpr(CXXBindTemporaryExpr*) { return false; }
};
bool SimplifyConstruct::VisitCXXConstructExpr(CXXConstructExpr const* constructExpr)
{
if (ignoreLocation(constructExpr))
return true;
auto tc = loplugin::TypeCheck(constructExpr->getType());
if (!tc.Class("unique_ptr").StdNamespace() && !tc.Class("shared_ptr").StdNamespace()
&& !tc.Class("SvRef").Namespace("tools").GlobalNamespace()
&& !tc.Class("Reference").Namespace("rtl").GlobalNamespace()
&& !tc.Class("Reference")
.Namespace("uno")
.Namespace("star")
.Namespace("sun")
.Namespace("com")
.GlobalNamespace())
return true;
if (constructExpr->getNumArgs() == 1
&& isa<CXXNullPtrLiteralExpr>(constructExpr->getArg(0)->IgnoreParenImpCasts()))
{
report(DiagnosticsEngine::Warning,
"no need to explicitly init an instance of %0 with nullptr, just use default "
"constructor",
constructExpr->getSourceRange().getBegin())
<< constructExpr->getType() << constructExpr->getSourceRange();
}
return true;
}
bool SimplifyConstruct::VisitVarDecl(VarDecl const* varDecl)
{
if (ignoreLocation(varDecl))
return true;
// cannot use OUString s("xxx") style syntax in a parameter
if (isa<ParmVarDecl>(varDecl))
return true;
varDecl = varDecl->getCanonicalDecl();
if (!varDecl->getInit())
return true;
if (varDecl->getInitStyle() != VarDecl::InitializationStyle::CInit)
return true;
if (!varDecl->getType()->isRecordType())
return true;
if (isa<AutoType>(varDecl->getType()))
return true;
auto init = varDecl->getInit();
auto const e1 = compat::IgnoreImplicit(init);
if (!isa<CXXFunctionalCastExpr>(e1) && !isa<CXXTemporaryObjectExpr>(e1))
return true;
// e.g. the LANGUAGE_DONTKNOW defines
if (compiler.getSourceManager().isMacroBodyExpansion(compat::getBeginLoc(init)))
return true;
report(DiagnosticsEngine::Warning, "simplify", varDecl->getLocation())
<< varDecl->getSourceRange();
return true;
}
loplugin::Plugin::Registration<SimplifyConstruct> simplifyconstruct("simplifyconstruct", true);
}
#endif // LO_CLANG_SHARED_PLUGINS
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
