1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
|
// -*- mode:C++; tab-width:8; c-basic-offset:2; indent-tabs-mode:t -*-
// vim: ts=8 sw=2 smarttab
/*
* Ceph - scalable distributed file system
*
* Copyright (C) 2016 John Spray <john.spray@redhat.com>
*
* This is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License version 2.1, as published by the Free Software
* Foundation. See file COPYING.
*/
#include "PyFormatter.h"
#include "common/debug.h"
#include "mon/MonCommand.h"
#include "ActivePyModule.h"
#include "MgrSession.h"
#define dout_context g_ceph_context
#define dout_subsys ceph_subsys_mgr
#undef dout_prefix
#define dout_prefix *_dout << "mgr " << __func__ << " "
int ActivePyModule::load(ActivePyModules *py_modules)
{
ceph_assert(py_modules);
Gil gil(py_module->pMyThreadState, true);
// We tell the module how we name it, so that it can be consistent
// with us in logging etc.
auto pThisPtr = PyCapsule_New(this, nullptr, nullptr);
auto pPyModules = PyCapsule_New(py_modules, nullptr, nullptr);
auto pModuleName = PyString_FromString(get_name().c_str());
auto pArgs = PyTuple_Pack(3, pModuleName, pPyModules, pThisPtr);
pClassInstance = PyObject_CallObject(py_module->pClass, pArgs);
Py_DECREF(pModuleName);
Py_DECREF(pArgs);
if (pClassInstance == nullptr) {
derr << "Failed to construct class in '" << get_name() << "'" << dendl;
derr << handle_pyerror() << dendl;
return -EINVAL;
} else {
dout(1) << "Constructed class from module: " << get_name() << dendl;
}
return 0;
}
void ActivePyModule::notify(const std::string ¬ify_type, const std::string ¬ify_id)
{
if (is_dead()) {
dout(5) << "cancelling notify " << notify_type << " " << notify_id << dendl;
return;
}
ceph_assert(pClassInstance != nullptr);
Gil gil(py_module->pMyThreadState, true);
// Execute
auto pValue = PyObject_CallMethod(pClassInstance,
const_cast<char*>("notify"), const_cast<char*>("(ss)"),
notify_type.c_str(), notify_id.c_str());
if (pValue != NULL) {
Py_DECREF(pValue);
} else {
derr << get_name() << ".notify:" << dendl;
derr << handle_pyerror() << dendl;
// FIXME: callers can't be expected to handle a python module
// that has spontaneously broken, but Mgr() should provide
// a hook to unload misbehaving modules when they have an
// error somewhere like this
}
}
void ActivePyModule::notify_clog(const LogEntry &log_entry)
{
if (is_dead()) {
dout(5) << "cancelling notify_clog" << dendl;
return;
}
ceph_assert(pClassInstance != nullptr);
Gil gil(py_module->pMyThreadState, true);
// Construct python-ized LogEntry
PyFormatter f;
log_entry.dump(&f);
auto py_log_entry = f.get();
// Execute
auto pValue = PyObject_CallMethod(pClassInstance,
const_cast<char*>("notify"), const_cast<char*>("(sN)"),
"clog", py_log_entry);
if (pValue != NULL) {
Py_DECREF(pValue);
} else {
derr << get_name() << ".notify_clog:" << dendl;
derr << handle_pyerror() << dendl;
// FIXME: callers can't be expected to handle a python module
// that has spontaneously broken, but Mgr() should provide
// a hook to unload misbehaving modules when they have an
// error somewhere like this
}
}
bool ActivePyModule::method_exists(const std::string &method) const
{
Gil gil(py_module->pMyThreadState, true);
auto boundMethod = PyObject_GetAttrString(pClassInstance, method.c_str());
if (boundMethod == nullptr) {
return false;
} else {
Py_DECREF(boundMethod);
return true;
}
}
PyObject *ActivePyModule::dispatch_remote(
const std::string &method,
PyObject *args,
PyObject *kwargs,
std::string *err)
{
ceph_assert(err != nullptr);
// Rather than serializing arguments, pass the CPython objects.
// Works because we happen to know that the subinterpreter
// implementation shares a GIL, allocator, deallocator and GC state, so
// it's okay to pass the objects between subinterpreters.
// But in future this might involve serialization to support a CSP-aware
// future Python interpreter a la PEP554
Gil gil(py_module->pMyThreadState, true);
// Fire the receiving method
auto boundMethod = PyObject_GetAttrString(pClassInstance, method.c_str());
// Caller should have done method_exists check first!
ceph_assert(boundMethod != nullptr);
dout(20) << "Calling " << py_module->get_name()
<< "." << method << "..." << dendl;
auto remoteResult = PyObject_Call(boundMethod,
args, kwargs);
Py_DECREF(boundMethod);
if (remoteResult == nullptr) {
// Because the caller is in a different context, we can't let this
// exception bubble up, need to re-raise it from the caller's
// context later.
*err = handle_pyerror();
} else {
dout(20) << "Success calling '" << method << "'" << dendl;
}
return remoteResult;
}
void ActivePyModule::config_notify()
{
if (is_dead()) {
dout(5) << "cancelling config_notify" << dendl;
return;
}
Gil gil(py_module->pMyThreadState, true);
dout(20) << "Calling " << py_module->get_name() << ".config_notify..."
<< dendl;
auto remoteResult = PyObject_CallMethod(pClassInstance,
const_cast<char*>("config_notify"),
(char*)NULL);
if (remoteResult != nullptr) {
Py_DECREF(remoteResult);
}
}
int ActivePyModule::handle_command(
const ModuleCommand& module_command,
const MgrSession& session,
const cmdmap_t &cmdmap,
const bufferlist &inbuf,
std::stringstream *ds,
std::stringstream *ss)
{
ceph_assert(ss != nullptr);
ceph_assert(ds != nullptr);
if (pClassInstance == nullptr) {
// Not the friendliest error string, but we could only
// hit this in quite niche cases, if at all.
*ss << "Module not instantiated";
return -EINVAL;
}
Gil gil(py_module->pMyThreadState, true);
PyFormatter f;
cmdmap_dump(cmdmap, &f);
PyObject *py_cmd = f.get();
string instr;
inbuf.copy(0, inbuf.length(), instr);
ceph_assert(m_session == nullptr);
m_command_perms = module_command.perm;
m_session = &session;
auto pResult = PyObject_CallMethod(pClassInstance,
const_cast<char*>("_handle_command"), const_cast<char*>("s#O"),
instr.c_str(), instr.length(), py_cmd);
m_command_perms.clear();
m_session = nullptr;
Py_DECREF(py_cmd);
int r = 0;
if (pResult != NULL) {
if (PyTuple_Size(pResult) != 3) {
derr << "module '" << py_module->get_name() << "' command handler "
"returned wrong type!" << dendl;
r = -EINVAL;
} else {
r = PyInt_AsLong(PyTuple_GetItem(pResult, 0));
*ds << PyString_AsString(PyTuple_GetItem(pResult, 1));
*ss << PyString_AsString(PyTuple_GetItem(pResult, 2));
}
Py_DECREF(pResult);
} else {
derr << "module '" << py_module->get_name() << "' command handler "
"threw exception: " << peek_pyerror() << dendl;
*ds << "";
*ss << handle_pyerror();
r = -EINVAL;
}
return r;
}
void ActivePyModule::get_health_checks(health_check_map_t *checks)
{
if (is_dead()) {
dout(5) << "cancelling get_health_checks" << dendl;
return;
}
checks->merge(health_checks);
}
bool ActivePyModule::is_authorized(
const std::map<std::string, std::string>& arguments) const {
if (m_session == nullptr) {
return false;
}
// No need to pass command prefix here since that would have already been
// tested before command invokation. Instead, only test for service/module
// arguments as defined by the module itself.
MonCommand mon_command {"", "", "", m_command_perms};
return m_session->caps.is_capable(nullptr, m_session->entity_name, "py",
py_module->get_name(), "", arguments,
mon_command.requires_perm('r'),
mon_command.requires_perm('w'),
mon_command.requires_perm('x'),
m_session->get_peer_addr());
}
|