1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
|
# Any copyright is dedicated to the public domain.
# http://creativecommons.org/publicdomain/zero/1.0/
from __future__ import absolute_import
import time
from datetime import datetime
from time import mktime
import pytest
from mozunit import main
from taskgraph.optimize import project, registry
from taskgraph.optimize.strategies import SkipUnlessSchedules
from taskgraph.optimize.backstop import SkipUnlessBackstop, SkipUnlessPushInterval
from taskgraph.optimize.bugbug import (
BugBugPushSchedules,
DisperseGroups,
FALLBACK,
SkipUnlessDebug,
)
from taskgraph.task import Task
from taskgraph.util.backstop import BACKSTOP_PUSH_INTERVAL
from taskgraph.util.bugbug import (
BUGBUG_BASE_URL,
BugbugTimeoutException,
push_schedules,
)
@pytest.fixture(autouse=True)
def clear_push_schedules_memoize():
push_schedules.clear()
@pytest.fixture
def params():
return {
"branch": "integration/autoland",
"head_repository": "https://hg.mozilla.org/integration/autoland",
"head_rev": "abcdef",
"project": "autoland",
"pushlog_id": 1,
"pushdate": mktime(datetime.now().timetuple()),
}
def generate_tasks(*tasks):
for i, task in enumerate(tasks):
task.setdefault("label", "task-{}".format(i))
task.setdefault("kind", "test")
task.setdefault("task", {})
task.setdefault("attributes", {})
task["attributes"].setdefault("e10s", True)
for attr in (
"optimization",
"dependencies",
"soft_dependencies",
"release_artifacts",
):
task.setdefault(attr, None)
task["task"].setdefault("label", task["label"])
yield Task.from_json(task)
# task sets
default_tasks = list(
generate_tasks(
{"attributes": {"test_manifests": ["foo/test.ini", "bar/test.ini"]}},
{"attributes": {"test_manifests": ["bar/test.ini"], "build_type": "debug"}},
{"attributes": {"build_type": "debug"}},
{"attributes": {"test_manifests": [], "build_type": "opt"}},
{"attributes": {"build_type": "opt"}},
)
)
disperse_tasks = list(
generate_tasks(
{
"attributes": {
"test_manifests": ["foo/test.ini", "bar/test.ini"],
"test_platform": "linux/opt",
}
},
{
"attributes": {
"test_manifests": ["bar/test.ini"],
"test_platform": "linux/opt",
}
},
{
"attributes": {
"test_manifests": ["bar/test.ini"],
"test_platform": "windows/debug",
}
},
{
"attributes": {
"test_manifests": ["bar/test.ini"],
"test_platform": "linux/opt",
"unittest_variant": "fission",
}
},
{
"attributes": {
"e10s": False,
"test_manifests": ["bar/test.ini"],
"test_platform": "linux/opt",
}
},
)
)
def idfn(param):
if isinstance(param, tuple):
return param[0].__name__
return None
@pytest.mark.parametrize(
"opt,tasks,arg,expected",
[
# debug
pytest.param(
SkipUnlessDebug(),
default_tasks,
None,
["task-0", "task-1", "task-2"],
),
# disperse with no supplied importance
pytest.param(
DisperseGroups(),
disperse_tasks,
None,
[t.label for t in disperse_tasks],
),
# disperse with low importance
pytest.param(
DisperseGroups(),
disperse_tasks,
{"bar/test.ini": "low"},
["task-0", "task-2"],
),
# disperse with medium importance
pytest.param(
DisperseGroups(),
disperse_tasks,
{"bar/test.ini": "medium"},
["task-0", "task-1", "task-2"],
),
# disperse with high importance
pytest.param(
DisperseGroups(),
disperse_tasks,
{"bar/test.ini": "high"},
["task-0", "task-1", "task-2", "task-3"],
),
],
ids=idfn,
)
def test_optimization_strategy(responses, params, opt, tasks, arg, expected):
labels = [t.label for t in tasks if not opt.should_remove_task(t, params, arg)]
assert sorted(labels) == sorted(expected)
@pytest.mark.parametrize(
"args,data,expected",
[
# empty
pytest.param(
(0.1,),
{},
[],
),
# only tasks without test manifests selected
pytest.param(
(0.1,),
{"tasks": {"task-1": 0.9, "task-2": 0.1, "task-3": 0.5}},
["task-2"],
),
# tasks which are unknown to bugbug are selected
pytest.param(
(0.1,),
{
"tasks": {"task-1": 0.9, "task-3": 0.5},
"known_tasks": ["task-1", "task-3", "task-4"],
},
["task-2"],
),
# tasks containing groups selected
pytest.param(
(0.1,),
{"groups": {"foo/test.ini": 0.4}},
["task-0"],
),
# tasks matching "tasks" or "groups" selected
pytest.param(
(0.1,),
{
"tasks": {"task-2": 0.2},
"groups": {"foo/test.ini": 0.25, "bar/test.ini": 0.75},
},
["task-0", "task-1", "task-2"],
),
# tasks matching "tasks" or "groups" selected, when they exceed the confidence threshold
pytest.param(
(0.5,),
{
"tasks": {"task-2": 0.2, "task-4": 0.5},
"groups": {"foo/test.ini": 0.65, "bar/test.ini": 0.25},
},
["task-0", "task-4"],
),
# tasks matching "reduced_tasks" are selected, when they exceed the confidence threshold
pytest.param(
(0.7, True, True),
{
"tasks": {"task-2": 0.7, "task-4": 0.7},
"reduced_tasks": {"task-4": 0.7},
"groups": {"foo/test.ini": 0.75, "bar/test.ini": 0.25},
},
["task-4"],
),
# tasks matching "groups" selected, only on specific platforms.
pytest.param(
(0.1, False, False, None, 1, True),
{
"tasks": {"task-2": 0.2},
"groups": {"foo/test.ini": 0.25, "bar/test.ini": 0.75},
"config_groups": {
"foo/test.ini": ["task-1", "task-0"],
"bar/test.ini": ["task-0"],
},
},
["task-0", "task-2"],
),
pytest.param(
(0.1, False, False, None, 1, True),
{
"tasks": {"task-2": 0.2},
"groups": {"foo/test.ini": 0.25, "bar/test.ini": 0.75},
"config_groups": {
"foo/test.ini": ["task-1", "task-0"],
"bar/test.ini": ["task-1"],
},
},
["task-0", "task-1", "task-2"],
),
pytest.param(
(0.1, False, False, None, 1, True),
{
"tasks": {"task-2": 0.2},
"groups": {"foo/test.ini": 0.25, "bar/test.ini": 0.75},
"config_groups": {
"foo/test.ini": ["task-1"],
"bar/test.ini": ["task-0"],
},
},
["task-0", "task-2"],
),
pytest.param(
(0.1, False, False, None, 1, True),
{
"tasks": {"task-2": 0.2},
"groups": {"foo/test.ini": 0.25, "bar/test.ini": 0.75},
"config_groups": {
"foo/test.ini": ["task-1"],
"bar/test.ini": ["task-3"],
},
},
["task-2"],
),
],
ids=idfn,
)
def test_bugbug_push_schedules(responses, params, args, data, expected):
query = "/push/{branch}/{head_rev}/schedules".format(**params)
url = BUGBUG_BASE_URL + query
responses.add(
responses.GET,
url,
json=data,
status=200,
)
opt = BugBugPushSchedules(*args)
labels = [
t.label for t in default_tasks if not opt.should_remove_task(t, params, {})
]
assert sorted(labels) == sorted(expected)
def test_bugbug_multiple_pushes(responses, params):
pushes = {str(pid): {"changesets": ["c{}".format(pid)]} for pid in range(8, 10)}
responses.add(
responses.GET,
"https://hg.mozilla.org/integration/autoland/json-pushes/?version=2&startID=8&endID=9",
json={"pushes": pushes},
status=200,
)
responses.add(
responses.GET,
BUGBUG_BASE_URL + "/push/{}/c9/schedules".format(params["branch"]),
json={
"tasks": {"task-2": 0.2, "task-4": 0.5},
"groups": {"foo/test.ini": 0.2, "bar/test.ini": 0.25},
"config_groups": {"foo/test.ini": ["linux-*"], "bar/test.ini": ["task-*"]},
"known_tasks": ["task-4"],
},
status=200,
)
# Tasks with a lower confidence don't override task with a higher one.
# Tasks with a higher confidence override tasks with a lower one.
# Known tasks are merged.
responses.add(
responses.GET,
BUGBUG_BASE_URL + "/push/{branch}/{head_rev}/schedules".format(**params),
json={
"tasks": {"task-2": 0.2, "task-4": 0.2},
"groups": {"foo/test.ini": 0.65, "bar/test.ini": 0.25},
"config_groups": {
"foo/test.ini": ["task-*"],
"bar/test.ini": ["windows-*"],
},
"known_tasks": ["task-1", "task-3"],
},
status=200,
)
params["pushlog_id"] = 10
opt = BugBugPushSchedules(0.3, False, False, False, 2)
labels = [
t.label for t in default_tasks if not opt.should_remove_task(t, params, {})
]
assert sorted(labels) == sorted(["task-0", "task-2", "task-4"])
opt = BugBugPushSchedules(0.3, False, False, False, 2, True)
labels = [
t.label for t in default_tasks if not opt.should_remove_task(t, params, {})
]
assert sorted(labels) == sorted(["task-0", "task-2", "task-4"])
opt = BugBugPushSchedules(0.2, False, False, False, 2, True)
labels = [
t.label for t in default_tasks if not opt.should_remove_task(t, params, {})
]
assert sorted(labels) == sorted(["task-0", "task-1", "task-2", "task-4"])
def test_bugbug_timeout(monkeypatch, responses, params):
query = "/push/{branch}/{head_rev}/schedules".format(**params)
url = BUGBUG_BASE_URL + query
responses.add(
responses.GET,
url,
json={"ready": False},
status=202,
)
# Make sure the test runs fast.
monkeypatch.setattr(time, "sleep", lambda i: None)
opt = BugBugPushSchedules(0.5)
with pytest.raises(BugbugTimeoutException):
opt.should_remove_task(default_tasks[0], params, None)
def test_bugbug_fallback(monkeypatch, responses, params):
query = "/push/{branch}/{head_rev}/schedules".format(**params)
url = BUGBUG_BASE_URL + query
responses.add(
responses.GET,
url,
json={"ready": False},
status=202,
)
opt = BugBugPushSchedules(0.5, fallback=FALLBACK)
# Make sure the test runs fast.
monkeypatch.setattr(time, "sleep", lambda i: None)
def fake_should_remove_task(task, params, _):
return task.label == default_tasks[0].label
monkeypatch.setattr(
registry[FALLBACK], "should_remove_task", fake_should_remove_task
)
assert opt.should_remove_task(default_tasks[0], params, None)
# Make sure we don't hit bugbug more than once.
responses.reset()
assert not opt.should_remove_task(default_tasks[1], params, None)
def test_backstop(params):
all_labels = {t.label for t in default_tasks}
opt = SkipUnlessBackstop()
params["backstop"] = False
scheduled = {
t.label for t in default_tasks if not opt.should_remove_task(t, params, None)
}
assert scheduled == set()
params["backstop"] = True
scheduled = {
t.label for t in default_tasks if not opt.should_remove_task(t, params, None)
}
assert scheduled == all_labels
def test_push_interval(params):
all_labels = {t.label for t in default_tasks}
opt = SkipUnlessPushInterval(10) # every 10th push
# Only multiples of 10 schedule tasks.
params["pushlog_id"] = 9
scheduled = {
t.label for t in default_tasks if not opt.should_remove_task(t, params, None)
}
assert scheduled == set()
params["pushlog_id"] = 10
scheduled = {
t.label for t in default_tasks if not opt.should_remove_task(t, params, None)
}
assert scheduled == all_labels
def test_expanded(params):
all_labels = {t.label for t in default_tasks}
opt = registry["skip-unless-expanded"]
params["backstop"] = False
params["pushlog_id"] = BACKSTOP_PUSH_INTERVAL / 2
scheduled = {
t.label for t in default_tasks if not opt.should_remove_task(t, params, None)
}
assert scheduled == all_labels
params["pushlog_id"] += 1
scheduled = {
t.label for t in default_tasks if not opt.should_remove_task(t, params, None)
}
assert scheduled == set()
params["backstop"] = True
scheduled = {
t.label for t in default_tasks if not opt.should_remove_task(t, params, None)
}
assert scheduled == all_labels
def test_project_autoland_test(monkeypatch, responses, params):
"""Tests the behaviour of the `project.autoland["test"]` strategy on
various types of pushes.
"""
# This is meant to test the composition of substrategies, and not the
# actual optimization implementations. So mock them out for simplicity.
monkeypatch.setattr(SkipUnlessSchedules, "should_remove_task", lambda *args: False)
monkeypatch.setattr(DisperseGroups, "should_remove_task", lambda *args: False)
def fake_bugbug_should_remove_task(self, task, params, importance):
if self.num_pushes > 1:
return task.label == "task-4"
return task.label in ("task-2", "task-3", "task-4")
monkeypatch.setattr(
BugBugPushSchedules, "should_remove_task", fake_bugbug_should_remove_task
)
opt = project.autoland["test"]
# On backstop pushes, nothing gets optimized.
params["backstop"] = True
scheduled = {
t.label for t in default_tasks if not opt.should_remove_task(t, params, {})
}
assert scheduled == {t.label for t in default_tasks}
# On expanded pushes, some things are optimized.
params["backstop"] = False
params["pushlog_id"] = 10
scheduled = {
t.label for t in default_tasks if not opt.should_remove_task(t, params, {})
}
assert scheduled == {"task-0", "task-1", "task-2", "task-3"}
# On regular pushes, more things are optimized.
params["pushlog_id"] = 11
scheduled = {
t.label for t in default_tasks if not opt.should_remove_task(t, params, {})
}
assert scheduled == {"task-0", "task-1"}
if __name__ == "__main__":
main()
|