1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <cassert>
#include <iterator>
#include <string>
#include "plugin.hxx"
// Second-guess that certain private special member function declarations for
// which no definition can be found are left undefined to prevent them from
// being implicitly declared. Such situations are better expressed by marking
// the function as = delete (it e.g. helps compilers determine
// whether class members are unused if all of a class's member definitions are
// seen in a compilation unit). (Default constructors for classes with multiple
// constructors are exempted as they would not be implicitly declared.
// Destructors are exempted because it is likely that a destructor is defined
// private on purpose.)
namespace {
CXXRecordDecl const * getClass(CXXMethodDecl const * decl) {
CXXRecordDecl const * cls = dyn_cast<CXXRecordDecl>(decl->getDeclContext());
assert(cls != nullptr);
return cls;
}
class DeletedSpecial:
public loplugin::FilteringPlugin<DeletedSpecial>
{
public:
explicit DeletedSpecial(InstantiationData const & data): FilteringPlugin(data) {}
virtual void run() override;
bool VisitCXXMethodDecl(CXXMethodDecl const * decl);
private:
bool whitelist(
CXXMethodDecl const * decl, std::string const & name,
std::string const & path);
};
void DeletedSpecial::run() {
if (compiler.getLangOpts().CPlusPlus
&& compiler.getPreprocessor().getIdentifierInfo(
"LIBO_INTERNAL_ONLY")->hasMacroDefinition())
{
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
}
}
bool DeletedSpecial::VisitCXXMethodDecl(CXXMethodDecl const * decl) {
if (ignoreLocation(decl) || !decl->isFirstDecl() || decl->isDefined()
|| decl->isDefaulted() || decl->getAccess() != AS_private)
{
return true;
}
std::string desc;
if (decl->isCopyAssignmentOperator()) {
if (whitelist(decl, "ImpGraphic", "vcl/inc/impgraph.hxx")
|| whitelist(decl, "SwSubFont", "sw/source/core/inc/swfont.hxx"))
{
return true;
}
desc = "copy assignment operator";
} else if (decl->isMoveAssignmentOperator()) {
desc = "move assignment operator";
} else {
CXXConstructorDecl const * ctor = dyn_cast<CXXConstructorDecl>(decl);
CXXRecordDecl const * cls = getClass(decl);
if (ctor != nullptr && ctor->isCopyConstructor()) {
if (whitelist(decl, "ImpGraphic", "vcl/inc/impgraph.hxx")
|| whitelist(decl, "SbMethod", "include/basic/sbmeth.hxx")
|| whitelist(decl, "ScDBCollection::NamedDBs", "sc/inc/dbdata.hxx")
|| whitelist(decl, "ScDrawPage", "sc/inc/drawpage.hxx")
|| whitelist(decl, "SmEditSource", "starmath/source/accessibility.hxx")
|| whitelist(decl, "SwChartDataSequence", "sw/inc/unochart.hxx")
|| whitelist(decl, "SwDPage", "sw/inc/dpage.hxx")
|| whitelist(decl, "SwRedlineExtraData_Format", "sw/inc/redline.hxx")
|| whitelist(decl, "SwRedlineExtraData_FormattingChanges", "sw/inc/redline.hxx")
|| whitelist(decl, "SwTextAPIEditSource", "sw/source/core/inc/textapi.hxx")
|| whitelist(decl, "XclImpBiff5Decrypter", "sc/source/filter/inc/xistream.hxx")
|| whitelist(decl, "XclImpBiff8Decrypter", "sc/source/filter/inc/xistream.hxx")
|| whitelist(decl, "configmgr::LocalizedPropertyNode", "configmgr/source/localizedpropertynode.hxx")
|| whitelist(decl, "configmgr::LocalizedValueNode", "configmgr/source/localizedvaluenode.hxx")
|| whitelist(decl, "configmgr::PropertyNode", "configmgr/source/propertynode.hxx")
|| whitelist(decl, "oox::xls::BiffDecoder_RCF", "sc/source/filter/inc/biffcodec.hxx")
|| whitelist(decl, "oox::xls::BiffDecoder_XOR", "sc/source/filter/inc/biffcodec.hxx")
|| whitelist(decl, "rptui::OReportPage", "reportdesign/inc/RptPage.hxx"))
{
return true;
}
desc = "copy constructor";
} else if (ctor != nullptr && ctor->isMoveConstructor()) {
desc = "move constructor";
} else if (ctor != nullptr && ctor->isDefaultConstructor()
&& std::distance(cls->ctor_begin(), cls->ctor_end()) == 1)
{
if (whitelist(decl, "AquaA11yFocusListener", "vcl/osx/a11yfocuslistener.hxx")
|| whitelist(decl, "DocTemplLocaleHelper", "sfx2/source/doc/doctemplateslocal.hxx")
|| whitelist(decl, "ScViewDataTable", "sc/source/filter/excel/../../ui/inc/viewdata.hxx")
|| whitelist(decl, "ScViewDataTable", "sc/source/ui/inc/viewdata.hxx")
|| whitelist(decl, "SwLineInfo", "sw/source/core/text/inftxt.hxx")
|| whitelist(decl, "XRenderPeer", "vcl/unx/generic/gdi/xrender_peer.hxx")
|| whitelist(decl, "desktop::DispatchWatcher", "desktop/source/app/dispatchwatcher.hxx")
|| whitelist(decl, "desktop::RequestHandler", "desktop/source/app/officeipcthread.hxx")
|| whitelist(decl, "desktop::RequestHandler", "desktop/source/lib/../app/officeipcthread.hxx")
|| whitelist(decl, "sd::DiscoveryService", "sd/source/ui/remotecontrol/DiscoveryService.hxx")
|| whitelist(decl, "sd::IconCache", "sd/source/ui/inc/tools/IconCache.hxx")
|| whitelist(decl, "sd::RemoteServer", "sd/source/ui/inc/RemoteServer.hxx")
|| whitelist(decl, "sd::slidesorter::cache::PageCacheManager", "sd/source/ui/slidesorter/inc/cache/SlsPageCacheManager.hxx")
|| whitelist(decl, "framework::CommandInfoProvider", "include/framework/commandinfoprovider.hxx")
|| whitelist(decl, "vcl::SettingsConfigItem", "vcl/inc/configsettings.hxx")
|| whitelist(decl, "writerfilter::ooxml::OOXMLFactory", "writerfilter/source/ooxml/OOXMLFactory.hxx"))
{
return true;
}
desc = "default constructor";
} else {
return true;
}
}
report(
DiagnosticsEngine::Warning,
("private %0 is not defined at least in this compilation unit, maybe it"
" should be marked as deleted?"),
decl->getLocation())
<< desc << decl->getSourceRange();
return true;
}
bool DeletedSpecial::whitelist(
CXXMethodDecl const * decl, std::string const & name,
std::string const & path)
{
return getClass(decl)->getQualifiedNameAsString() == name
&& (getFilenameOfLocation(
compiler.getSourceManager().getSpellingLoc(decl->getLocation()))
== SRCDIR "/" + path);
}
loplugin::Plugin::Registration<DeletedSpecial> X("deletedspecial", true);
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
