1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
|
import pytest
from textwrap import dedent
import json
from ceph_volume.util import prepare
from ceph_volume.util.prepare import system
from ceph_volume import conf
from ceph_volume.tests.conftest import Factory
class TestOSDIDAvailable(object):
def test_false_if_id_is_none(self):
assert not prepare.osd_id_available(None)
def test_returncode_is_not_zero(self, monkeypatch):
monkeypatch.setattr('ceph_volume.process.call', lambda *a, **kw: ('', '', 1))
with pytest.raises(RuntimeError):
prepare.osd_id_available(1)
def test_id_does_exist_but_not_available(self, monkeypatch):
stdout = dict(nodes=[
dict(id=0, status="up"),
])
stdout = ['', json.dumps(stdout)]
monkeypatch.setattr('ceph_volume.process.call', lambda *a, **kw: (stdout, '', 0))
result = prepare.osd_id_available(0)
assert not result
def test_id_does_not_exist(self, monkeypatch):
stdout = dict(nodes=[
dict(id=0),
])
stdout = ['', json.dumps(stdout)]
monkeypatch.setattr('ceph_volume.process.call', lambda *a, **kw: (stdout, '', 0))
result = prepare.osd_id_available(1)
assert result
def test_returns_true_when_id_is_destroyed(self, monkeypatch):
stdout = dict(nodes=[
dict(id=0, status="destroyed"),
])
stdout = ['', json.dumps(stdout)]
monkeypatch.setattr('ceph_volume.process.call', lambda *a, **kw: (stdout, '', 0))
result = prepare.osd_id_available(0)
assert result
class TestFormatDevice(object):
def test_include_force(self, fake_run, monkeypatch):
monkeypatch.setattr(conf, 'ceph', Factory(get_list=lambda *a, **kw: []))
prepare.format_device('/dev/sxx')
flags = fake_run.calls[0]['args'][0]
assert '-f' in flags
def test_device_is_always_appended(self, fake_run, conf_ceph):
conf_ceph(get_list=lambda *a, **kw: [])
prepare.format_device('/dev/sxx')
flags = fake_run.calls[0]['args'][0]
assert flags[-1] == '/dev/sxx'
def test_extra_flags_are_added(self, fake_run, conf_ceph):
conf_ceph(get_list=lambda *a, **kw: ['--why-yes'])
prepare.format_device('/dev/sxx')
flags = fake_run.calls[0]['args'][0]
assert '--why-yes' in flags
def test_default_options(self, conf_ceph_stub, fake_run):
conf_ceph_stub(dedent("""[global]
fsid = 1234lkjh1234"""))
conf.cluster = 'ceph'
prepare.format_device('/dev/sda1')
expected = [
'mkfs', '-t', 'xfs',
'-f', '-i', 'size=2048', # default flags
'/dev/sda1']
assert expected == fake_run.calls[0]['args'][0]
def test_multiple_options_are_used(self, conf_ceph_stub, fake_run):
conf_ceph_stub(dedent("""[global]
fsid = 1234lkjh1234
[osd]
osd mkfs options xfs = -f -i size=1024"""))
conf.cluster = 'ceph'
prepare.format_device('/dev/sda1')
expected = [
'mkfs', '-t', 'xfs',
'-f', '-i', 'size=1024',
'/dev/sda1']
assert expected == fake_run.calls[0]['args'][0]
def test_multiple_options_will_get_the_force_flag(self, conf_ceph_stub, fake_run):
conf_ceph_stub(dedent("""[global]
fsid = 1234lkjh1234
[osd]
osd mkfs options xfs = -i size=1024"""))
conf.cluster = 'ceph'
prepare.format_device('/dev/sda1')
expected = [
'mkfs', '-t', 'xfs',
'-f', '-i', 'size=1024',
'/dev/sda1']
assert expected == fake_run.calls[0]['args'][0]
def test_underscore_options_are_used(self, conf_ceph_stub, fake_run):
conf_ceph_stub(dedent("""[global]
fsid = 1234lkjh1234
[osd]
osd_mkfs_options_xfs = -i size=128"""))
conf.cluster = 'ceph'
prepare.format_device('/dev/sda1')
expected = [
'mkfs', '-t', 'xfs',
'-f', '-i', 'size=128',
'/dev/sda1']
assert expected == fake_run.calls[0]['args'][0]
class TestOsdMkfsBluestore(object):
def test_keyring_is_added(self, fake_call, monkeypatch):
monkeypatch.setattr(system, 'chown', lambda path: True)
prepare.osd_mkfs_bluestore(1, 'asdf', keyring='secret')
assert '--keyfile' in fake_call.calls[0]['args'][0]
def test_keyring_is_not_added(self, fake_call, monkeypatch):
monkeypatch.setattr(system, 'chown', lambda path: True)
prepare.osd_mkfs_bluestore(1, 'asdf')
assert '--keyfile' not in fake_call.calls[0]['args'][0]
def test_wal_is_added(self, fake_call, monkeypatch):
monkeypatch.setattr(system, 'chown', lambda path: True)
prepare.osd_mkfs_bluestore(1, 'asdf', wal='/dev/smm1')
assert '--bluestore-block-wal-path' in fake_call.calls[0]['args'][0]
assert '/dev/smm1' in fake_call.calls[0]['args'][0]
def test_db_is_added(self, fake_call, monkeypatch):
monkeypatch.setattr(system, 'chown', lambda path: True)
prepare.osd_mkfs_bluestore(1, 'asdf', db='/dev/smm2')
assert '--bluestore-block-db-path' in fake_call.calls[0]['args'][0]
assert '/dev/smm2' in fake_call.calls[0]['args'][0]
class TestMountOSD(object):
def test_default_options(self, conf_ceph_stub, fake_run):
conf_ceph_stub(dedent("""[global]
fsid = 1234lkjh1234"""))
conf.cluster = 'ceph'
prepare.mount_osd('/dev/sda1', 1)
expected = [
'mount', '-t', 'xfs', '-o',
'rw,noatime,inode64', # default flags
'/dev/sda1', '/var/lib/ceph/osd/ceph-1']
assert expected == fake_run.calls[0]['args'][0]
def test_mount_options_are_used(self, conf_ceph_stub, fake_run):
conf_ceph_stub(dedent("""[global]
fsid = 1234lkjh1234
[osd]
osd mount options xfs = rw"""))
conf.cluster = 'ceph'
prepare.mount_osd('/dev/sda1', 1)
expected = [
'mount', '-t', 'xfs', '-o',
'rw',
'/dev/sda1', '/var/lib/ceph/osd/ceph-1']
assert expected == fake_run.calls[0]['args'][0]
def test_multiple_whitespace_options_are_used(self, conf_ceph_stub, fake_run):
conf_ceph_stub(dedent("""[global]
fsid = 1234lkjh1234
[osd]
osd mount options xfs = rw auto exec"""))
conf.cluster = 'ceph'
prepare.mount_osd('/dev/sda1', 1)
expected = [
'mount', '-t', 'xfs', '-o',
'rw,auto,exec',
'/dev/sda1', '/var/lib/ceph/osd/ceph-1']
assert expected == fake_run.calls[0]['args'][0]
def test_multiple_comma_whitespace_options_are_used(self, conf_ceph_stub, fake_run):
conf_ceph_stub(dedent("""[global]
fsid = 1234lkjh1234
[osd]
osd mount options xfs = rw, auto, exec"""))
conf.cluster = 'ceph'
prepare.mount_osd('/dev/sda1', 1)
expected = [
'mount', '-t', 'xfs', '-o',
'rw,auto,exec',
'/dev/sda1', '/var/lib/ceph/osd/ceph-1']
assert expected == fake_run.calls[0]['args'][0]
def test_underscore_mount_options_are_used(self, conf_ceph_stub, fake_run):
conf_ceph_stub(dedent("""[global]
fsid = 1234lkjh1234
[osd]
osd mount options xfs = rw"""))
conf.cluster = 'ceph'
prepare.mount_osd('/dev/sda1', 1)
expected = [
'mount', '-t', 'xfs', '-o',
'rw',
'/dev/sda1', '/var/lib/ceph/osd/ceph-1']
assert expected == fake_run.calls[0]['args'][0]
ceph_conf_mount_values = [
['rw,', 'auto,' 'exec'],
['rw', 'auto', 'exec'],
[' rw ', ' auto ', ' exec '],
['rw,', 'auto,', 'exec,'],
[',rw ', ',auto ', ',exec,'],
[',rw,', ',auto,', ',exec,'],
]
string_mount_values = [
'rw, auto exec ',
'rw auto exec',
',rw, auto, exec,',
' rw auto exec ',
' rw,auto,exec ',
'rw,auto,exec',
',rw,auto,exec,',
'rw,auto,exec ',
'rw, auto, exec ',
]
class TestNormalizeFlags(object):
# a bit overkill since most of this is already tested in prepare.mount_osd
# tests
@pytest.mark.parametrize("flags", ceph_conf_mount_values)
def test_normalize_lists(self, flags):
result = sorted(prepare._normalize_mount_flags(flags).split(','))
assert ','.join(result) == 'auto,exec,rw'
@pytest.mark.parametrize("flags", string_mount_values)
def test_normalize_strings(self, flags):
result = sorted(prepare._normalize_mount_flags(flags).split(','))
assert ','.join(result) == 'auto,exec,rw'
@pytest.mark.parametrize("flags", ceph_conf_mount_values)
def test_normalize_extra_flags(self, flags):
result = prepare._normalize_mount_flags(flags, extras=['discard'])
assert sorted(result.split(',')) == ['auto', 'discard', 'exec', 'rw']
@pytest.mark.parametrize("flags", ceph_conf_mount_values)
def test_normalize_duplicate_extra_flags(self, flags):
result = prepare._normalize_mount_flags(flags, extras=['rw', 'discard'])
assert sorted(result.split(',')) == ['auto', 'discard', 'exec', 'rw']
@pytest.mark.parametrize("flags", string_mount_values)
def test_normalize_strings_flags(self, flags):
result = sorted(prepare._normalize_mount_flags(flags, extras=['discard']).split(','))
assert ','.join(result) == 'auto,discard,exec,rw'
@pytest.mark.parametrize("flags", string_mount_values)
def test_normalize_strings_duplicate_flags(self, flags):
result = sorted(prepare._normalize_mount_flags(flags, extras=['discard','rw']).split(','))
assert ','.join(result) == 'auto,discard,exec,rw'
class TestMkfsBluestore(object):
def test_non_zero_exit_status(self, stub_call, monkeypatch):
conf.cluster = 'ceph'
monkeypatch.setattr('ceph_volume.util.prepare.system.chown', lambda x: True)
stub_call(([], [], 1))
with pytest.raises(RuntimeError) as error:
prepare.osd_mkfs_bluestore('1', 'asdf-1234', keyring='keyring')
assert "Command failed with exit code 1" in str(error.value)
def test_non_zero_exit_formats_command_correctly(self, stub_call, monkeypatch):
conf.cluster = 'ceph'
monkeypatch.setattr('ceph_volume.util.prepare.system.chown', lambda x: True)
stub_call(([], [], 1))
with pytest.raises(RuntimeError) as error:
prepare.osd_mkfs_bluestore('1', 'asdf-1234', keyring='keyring')
expected = ' '.join([
'ceph-osd',
'--cluster',
'ceph',
'--osd-objectstore', 'bluestore', '--mkfs',
'-i', '1', '--monmap', '/var/lib/ceph/osd/ceph-1/activate.monmap',
'--keyfile', '-', '--osd-data', '/var/lib/ceph/osd/ceph-1/',
'--osd-uuid', 'asdf-1234',
'--setuser', 'ceph', '--setgroup', 'ceph'])
assert expected in str(error.value)
|
