Adding upstream version 1.22.4.upstream/1.22.4

Signed-off-by: Daniel Baumann <daniel.baumann@progress-linux.org>

2 files changed, 91 insertions, 0 deletions

diff --git a/t/cppcheck.t b/t/cppcheck.t
new file mode 100644
index 0000000..28d420f
--- /dev/null
+++ b/t/cppcheck.t
@@ -0,0 +1,62 @@
+#!/usr/bin/perl
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <https://www.gnu.org/licenses/>.
+
+use strict;
+use warnings;
+
+use Test::More;
+use Test::Dpkg qw(:needs);
+
+test_needs_author();
+test_needs_command('cppcheck');
+test_needs_srcdir_switch();
+
+plan tests => 1;
+
+my $builddir = $ENV{abs_top_builddir} || '.';
+
+my @cppcheck_opts = (qw(
+  --quiet
+  --force
+  --error-exitcode=2
+  --inline-suppr
+  --suppressions-list=t/cppcheck/cppcheck.supp
+  --std=c99 --std=c++03
+  -Ilib
+  -Ilib/compat
+  -Isrc/common
+),
+  "-I$builddir",
+qw(
+  -D__GNUC__=12
+  -D__GNUC_MINOR__=0
+  -D_DIRENT_HAVE_D_TYPE=1
+  -DWITH_LIBSELINUX=1
+  -DLIBDPKG_VOLATILE_API=1
+), (
+  '--enable=warning,performance,portability,style',
+  '--template=\'{file}:{line}: {severity} ({id}): {message}\''
+));
+my $tags = qx(cppcheck @cppcheck_opts . 2>&1);
+
+# Fixup the output:
+chomp $tags;
+
+my $ok = length $tags == 0;
+
+ok($ok, 'cppcheck');
+if (not $ok) {
+    diag($tags);
+}
diff --git a/t/cppcheck/cppcheck.supp b/t/cppcheck/cppcheck.supp
new file mode 100644
index 0000000..ed183fd
--- /dev/null
+++ b/t/cppcheck/cppcheck.supp
@@ -0,0 +1,29 @@
+//
+// Suppression file for cppcheck.
+///
+
+// We assume that the system has a sane NULL definition.
+varFuncNullUB
+
+// We do not always want to make variables pointers to const.
+constVariablePointer
+
+// TODO: While perhaps valid there are many to handle right away.
+constParameterCallback
+constParameterPointer
+
+// Ignore, this is an imported module.
+cstyleCast:lib/compat/gettext.h
+unusedStructMember:lib/compat/obstack.c
+nullPointerArithmetic:lib/compat/obstack.c
+
+// Ignore, the code is used only for its binary artifacts.
+uninitMemberVar:*/Dpkg_Shlibs/patterns.cpp
+unusedStructMember:*/Dpkg_Shlibs/patterns.cpp
+
+// Ignore, the code is testing whether the functions return.
+unreachableCode:lib/dpkg/t/t-ehandle.c
+
+// Ignore, the code is testing the macros.
+duplicateExpression:lib/dpkg/t/t-macros.c
+duplicateValueTernary:lib/dpkg/t/t-macros.c