1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
|
/* Any copyright is dedicated to the Public Domain.
* http://creativecommons.org/publicdomain/zero/1.0/ */
"use strict";
// ------------------------------------------------------------------------------
// Requirements
// ------------------------------------------------------------------------------
var rule = require("../lib/rules/prefer-boolean-length-check");
var RuleTester = require("eslint").RuleTester;
const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: "latest" } });
// ------------------------------------------------------------------------------
// Tests
// ------------------------------------------------------------------------------
function invalidError() {
return [{ messageId: "preferBooleanCheck", type: "BinaryExpression" }];
}
ruleTester.run("check-length", rule, {
valid: [
"if (foo.length && foo.length) {}",
"if (!foo.length) {}",
"if (foo.value == 0) {}",
"if (foo.value > 0) {}",
"if (0 == foo.value) {}",
"if (0 < foo.value) {}",
"var a = !!foo.length",
"function bar() { return !!foo.length }",
],
invalid: [
{
code: "if (foo.length == 0) {}",
output: "if (!foo.length) {}",
errors: invalidError(),
},
{
code: "if (foo.length > 0) {}",
output: "if (foo.length) {}",
errors: invalidError(),
},
{
code: "if (0 < foo.length) {}",
output: "if (foo.length) {}",
errors: invalidError(),
},
{
code: "if (0 == foo.length) {}",
output: "if (!foo.length) {}",
errors: invalidError(),
},
{
code: "if (foo && foo.length == 0) {}",
output: "if (foo && !foo.length) {}",
errors: invalidError(),
},
{
code: "if (foo.bar.length == 0) {}",
output: "if (!foo.bar.length) {}",
errors: invalidError(),
},
{
code: "var a = foo.length>0",
output: "var a = !!foo.length",
errors: invalidError(),
},
{
code: "function bar() { return foo.length>0 }",
output: "function bar() { return !!foo.length }",
errors: invalidError(),
},
{
code: "if (foo && bar.length>0) {}",
output: "if (foo && bar.length) {}",
errors: invalidError(),
},
{
code: "while (foo && bar.length>0) {}",
output: "while (foo && bar.length) {}",
errors: invalidError(),
},
{
code: "x = y && bar.length > 0",
output: "x = y && !!bar.length",
errors: invalidError(),
},
{
code: "function bar() { return x && foo.length > 0}",
output: "function bar() { return x && !!foo.length}",
errors: invalidError(),
},
],
});
|
