Adding upstream version 124.0.1.upstream/124.0.1

Signed-off-by: Daniel Baumann <daniel.baumann@progress-linux.org>

1 files changed, 36 insertions, 0 deletions

diff --git a/build/clang-plugin/NoNewThreadsChecker.cpp b/build/clang-plugin/NoNewThreadsChecker.cpp
new file mode 100644
index 0000000000..90c190f8d1
--- /dev/null
+++ b/build/clang-plugin/NoNewThreadsChecker.cpp
@@ -0,0 +1,36 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+#include "NoNewThreadsChecker.h"
+#include "CustomMatchers.h"
+
+void NoNewThreadsChecker::registerMatchers(MatchFinder *AstMatcher) {
+  // The checker looks for:
+  // -Instances of NS_NewNamedThread that aren't in allowed files
+  // -Instances of NS_NewNamedThread that use names that aren't recognized
+  AstMatcher->addMatcher(
+      callExpr(allOf(isFirstParty(),
+                     callee(functionDecl(hasName("NS_NewNamedThread"))),
+                     unless(isInAllowlistForThreads())))
+          .bind("funcCall"),
+      this);
+}
+
+void NoNewThreadsChecker::check(const MatchFinder::MatchResult &Result) {
+  const CallExpr *FuncCall = Result.Nodes.getNodeAs<CallExpr>("funcCall");
+
+  if (FuncCall) {
+    diag(FuncCall->getBeginLoc(),
+         "Thread name not recognized. Please use the background thread pool.",
+         DiagnosticIDs::Error)
+        << FuncCall->getDirectCallee()->getName();
+    diag(
+        FuncCall->getBeginLoc(),
+        "NS_NewNamedThread has been deprecated in favor of background "
+        "task dispatch via NS_DispatchBackgroundTask and "
+        "NS_CreateBackgroundTaskQueue. If you must create a new ad-hoc thread, "
+        "have your thread name added to ThreadAllows.txt.",
+        DiagnosticIDs::Note);
+  }
+}