Merging upstream version 125.0.1.

Signed-off-by: Daniel Baumann <daniel.baumann@progress-linux.org>

68 files changed, 182 insertions, 59 deletions

diff --git a/devtools/server/tests/xpcshell/registertestactors-lazy.js b/devtools/server/tests/xpcshell/registertestactors-lazy.js
index ef04e7a8d2..3ab7ebb1a8 100644
--- a/devtools/server/tests/xpcshell/registertestactors-lazy.js
+++ b/devtools/server/tests/xpcshell/registertestactors-lazy.js
@@ -21,13 +21,13 @@ const lazySpec = generateActorSpec({
 });
 
 class LazyActor extends Actor {
-  constructor(conn, id) {
+  constructor(conn) {
     super(conn, lazySpec);
 
     Services.obs.notifyObservers(null, "actor", "instantiated");
   }
 
-  hello(str) {
+  hello() {
     return "world";
   }
 }
diff --git a/devtools/server/tests/xpcshell/test_blackboxing-01.js b/devtools/server/tests/xpcshell/test_blackboxing-01.js
index 6c549b908e..981692dd6c 100644
--- a/devtools/server/tests/xpcshell/test_blackboxing-01.js
+++ b/devtools/server/tests/xpcshell/test_blackboxing-01.js
@@ -114,7 +114,7 @@ function evalCode() {
   Cu.evalInSandbox(
     "" + function runTest() { // line 1
       doStuff(                // line 2 - Break here
-        function (n) {        // line 3 - Step through `doStuff` to here
+        function () {        // line 3 - Step through `doStuff` to here
           (() => {})();       // line 4
           debugger;           // line 5
         }                     // line 6
diff --git a/devtools/server/tests/xpcshell/test_blackboxing-02.js b/devtools/server/tests/xpcshell/test_blackboxing-02.js
index 66efaee6c8..b713b33187 100644
--- a/devtools/server/tests/xpcshell/test_blackboxing-02.js
+++ b/devtools/server/tests/xpcshell/test_blackboxing-02.js
@@ -80,7 +80,7 @@ function evalCode(debuggee) {
   Cu.evalInSandbox(
     "" + function runTest() { // line 1
       doStuff(                // line 2
-        function(n) {         // line 3
+        function() {         // line 3
           debugger;           // line 5
         }                     // line 6
       );                      // line 7
diff --git a/devtools/server/tests/xpcshell/test_blackboxing-05.js b/devtools/server/tests/xpcshell/test_blackboxing-05.js
index 388c87da88..0a9bbbbdae 100644
--- a/devtools/server/tests/xpcshell/test_blackboxing-05.js
+++ b/devtools/server/tests/xpcshell/test_blackboxing-05.js
@@ -81,7 +81,7 @@ function evalCode(debuggee) {
     "" +
     function runTest() { // line 1
       doStuff(           // line 2
-        function(n) {    // line 3
+        function() {    // line 3
           debugger;      // line 4
         }                // line 5
       );                 // line 6
diff --git a/devtools/server/tests/xpcshell/test_breakpoint-03.js b/devtools/server/tests/xpcshell/test_breakpoint-03.js
index f598660a98..9b0dbe3c0b 100644
--- a/devtools/server/tests/xpcshell/test_breakpoint-03.js
+++ b/devtools/server/tests/xpcshell/test_breakpoint-03.js
@@ -50,7 +50,7 @@ add_task(
           Assert.equal(debuggee.b, undefined);
 
           // Remove the breakpoint.
-          bpClient.remove(function (response) {
+          bpClient.remove(function () {
             threadFront.resume().then(resolve);
           });
         });
diff --git a/devtools/server/tests/xpcshell/test_breakpoint-05.js b/devtools/server/tests/xpcshell/test_breakpoint-05.js
index f678b285b1..288f2d3a6e 100644
--- a/devtools/server/tests/xpcshell/test_breakpoint-05.js
+++ b/devtools/server/tests/xpcshell/test_breakpoint-05.js
@@ -35,7 +35,7 @@ add_task(
             Assert.equal(debuggee.b, undefined);
 
             // Remove the breakpoint.
-            bpClient.remove(function (response) {
+            bpClient.remove(function () {
               threadFront.resume().then(resolve);
             });
           });
diff --git a/devtools/server/tests/xpcshell/test_breakpoint-06.js b/devtools/server/tests/xpcshell/test_breakpoint-06.js
index 79ddcdc3d4..a2cdcd1340 100644
--- a/devtools/server/tests/xpcshell/test_breakpoint-06.js
+++ b/devtools/server/tests/xpcshell/test_breakpoint-06.js
@@ -35,7 +35,7 @@ add_task(
             Assert.equal(debuggee.b, undefined);
 
             // Remove the breakpoint.
-            bpClient.remove(function (response) {
+            bpClient.remove(function () {
               threadFront.resume().then(resolve);
             });
           });
diff --git a/devtools/server/tests/xpcshell/test_breakpoint-07.js b/devtools/server/tests/xpcshell/test_breakpoint-07.js
index e6391747bb..a6a1576c5c 100644
--- a/devtools/server/tests/xpcshell/test_breakpoint-07.js
+++ b/devtools/server/tests/xpcshell/test_breakpoint-07.js
@@ -35,7 +35,7 @@ add_task(
             Assert.equal(debuggee.b, undefined);
 
             // Remove the breakpoint.
-            bpClient.remove(function (response) {
+            bpClient.remove(function () {
               threadFront.resume().then(resolve);
             });
           });
diff --git a/devtools/server/tests/xpcshell/test_breakpoint-08.js b/devtools/server/tests/xpcshell/test_breakpoint-08.js
index bff0cc3b52..44a7c11803 100644
--- a/devtools/server/tests/xpcshell/test_breakpoint-08.js
+++ b/devtools/server/tests/xpcshell/test_breakpoint-08.js
@@ -43,7 +43,7 @@ add_task(
           Assert.equal(debuggee.b, undefined);
 
           // Remove the breakpoint.
-          response.bpClient.remove(function (response) {
+          response.bpClient.remove(function () {
             threadFront.resume().then(resolve);
           });
         });
diff --git a/devtools/server/tests/xpcshell/test_breakpoint-09.js b/devtools/server/tests/xpcshell/test_breakpoint-09.js
index 90b334102d..5dbf8be62a 100644
--- a/devtools/server/tests/xpcshell/test_breakpoint-09.js
+++ b/devtools/server/tests/xpcshell/test_breakpoint-09.js
@@ -43,7 +43,7 @@ add_task(
     await client.waitForRequestsToSettle();
 
     done = true;
-    threadFront.once("paused", function (packet) {
+    threadFront.once("paused", function () {
       // The breakpoint should not be hit again.
       threadFront.resume().then(function () {
         Assert.ok(false);
diff --git a/devtools/server/tests/xpcshell/test_breakpoint-11.js b/devtools/server/tests/xpcshell/test_breakpoint-11.js
index a29cd2f768..341f983c39 100644
--- a/devtools/server/tests/xpcshell/test_breakpoint-11.js
+++ b/devtools/server/tests/xpcshell/test_breakpoint-11.js
@@ -9,7 +9,7 @@
  */
 
 add_task(
-  threadFrontTest(async ({ threadFront, client, debuggee }) => {
+  threadFrontTest(async ({ threadFront, debuggee }) => {
     const packet = await executeOnNextTickAndWaitForPause(
       () => evaluateTestCode(debuggee),
       threadFront
diff --git a/devtools/server/tests/xpcshell/test_breakpoint-12.js b/devtools/server/tests/xpcshell/test_breakpoint-12.js
index 44b524f1cf..05de46bb6f 100644
--- a/devtools/server/tests/xpcshell/test_breakpoint-12.js
+++ b/devtools/server/tests/xpcshell/test_breakpoint-12.js
@@ -23,7 +23,7 @@ add_task(
         );
         const location = { line: debuggee.line0 + 3 };
 
-        source.setBreakpoint(location).then(function ([response, bpClient]) {
+        source.setBreakpoint(location).then(function ([response]) {
           // Check that the breakpoint has properly skipped forward one line.
           Assert.equal(response.actualLocation.source.actor, source.actor);
           Assert.equal(response.actualLocation.line, location.line + 1);
@@ -75,7 +75,7 @@ add_task(
             Assert.equal(debuggee.a, 1);
             Assert.equal(debuggee.b, undefined);
 
-            threadFront.once("paused", function (packet) {
+            threadFront.once("paused", function () {
               // We don't expect any more pauses after the breakpoint was hit once.
               Assert.ok(false);
             });
diff --git a/devtools/server/tests/xpcshell/test_breakpoint-14.js b/devtools/server/tests/xpcshell/test_breakpoint-14.js
index 835edb1385..aa4c92bdd4 100644
--- a/devtools/server/tests/xpcshell/test_breakpoint-14.js
+++ b/devtools/server/tests/xpcshell/test_breakpoint-14.js
@@ -10,7 +10,7 @@
  */
 
 add_task(
-  threadFrontTest(async ({ threadFront, client, debuggee }) => {
+  threadFrontTest(async ({ threadFront, debuggee }) => {
     const packet = await executeOnNextTickAndWaitForPause(
       () => evaluateTestCode(debuggee),
       threadFront
diff --git a/devtools/server/tests/xpcshell/test_breakpoint-16.js b/devtools/server/tests/xpcshell/test_breakpoint-16.js
index a42306eee1..6ca098cef9 100644
--- a/devtools/server/tests/xpcshell/test_breakpoint-16.js
+++ b/devtools/server/tests/xpcshell/test_breakpoint-16.js
@@ -9,7 +9,7 @@
  */
 
 add_task(
-  threadFrontTest(async ({ threadFront, client, debuggee }) => {
+  threadFrontTest(async ({ threadFront, debuggee }) => {
     const packet = await executeOnNextTickAndWaitForPause(
       () => evaluateTestCode(debuggee),
       threadFront
diff --git a/devtools/server/tests/xpcshell/test_client_request.js b/devtools/server/tests/xpcshell/test_client_request.js
index 837bee5047..5c19884824 100644
--- a/devtools/server/tests/xpcshell/test_client_request.js
+++ b/devtools/server/tests/xpcshell/test_client_request.js
@@ -203,7 +203,7 @@ function test_client_request_after_close() {
   });
 
   request.then(
-    response => {
+    () => {
       ok(false, "Request succeed even after client.close");
     },
     response => {
diff --git a/devtools/server/tests/xpcshell/test_conditional_breakpoint-04.js b/devtools/server/tests/xpcshell/test_conditional_breakpoint-04.js
index b270b92974..941b480347 100644
--- a/devtools/server/tests/xpcshell/test_conditional_breakpoint-04.js
+++ b/devtools/server/tests/xpcshell/test_conditional_breakpoint-04.js
@@ -9,7 +9,7 @@
  */
 
 add_task(
-  threadFrontTest(async ({ threadFront, debuggee, commands }) => {
+  threadFrontTest(async ({ threadFront, debuggee }) => {
     await threadFront.setBreakpoint(
       { sourceUrl: "conditional_breakpoint-04.js", line: 3 },
       { condition: "throw new Error()" }
diff --git a/devtools/server/tests/xpcshell/test_dbgglobal.js b/devtools/server/tests/xpcshell/test_dbgglobal.js
index 407e270da4..6e6f40bb5d 100644
--- a/devtools/server/tests/xpcshell/test_dbgglobal.js
+++ b/devtools/server/tests/xpcshell/test_dbgglobal.js
@@ -69,14 +69,14 @@ function run_test() {
           );
           client2.close();
         },
-        onTransportClosed(result) {
+        onTransportClosed() {
           client1.close();
         },
       };
       client2.ready();
     },
 
-    onTransportClosed(result) {
+    onTransportClosed() {
       do_test_finished();
     },
   };
diff --git a/devtools/server/tests/xpcshell/test_forwardingprefix.js b/devtools/server/tests/xpcshell/test_forwardingprefix.js
index e917350da5..fa9afbf2f0 100644
--- a/devtools/server/tests/xpcshell/test_forwardingprefix.js
+++ b/devtools/server/tests/xpcshell/test_forwardingprefix.js
@@ -51,7 +51,7 @@ function newConnection(prefix) {
 function createMainConnection() {
   ({ conn: gMainConnection, transport: gMainTransport } = newConnection());
   gClient = new DevToolsClient(gMainTransport);
-  gClient.connect().then(([type, traits]) => run_next_test());
+  gClient.connect().then(() => run_next_test());
 }
 
 /*
@@ -152,7 +152,7 @@ function createSubconnection1() {
   const { conn, transport } = newSubconnection("prefix1");
   gSubconnection1 = conn;
   transport.ready();
-  gClient.expectReply("prefix1/root", reply => run_next_test());
+  gClient.expectReply("prefix1/root", () => run_next_test());
 }
 
 // Establish forwarding, but don't put any actors in that server.
@@ -165,7 +165,7 @@ function createSubconnection2() {
   const { conn, transport } = newSubconnection("prefix2");
   gSubconnection2 = conn;
   transport.ready();
-  gClient.expectReply("prefix2/root", reply => run_next_test());
+  gClient.expectReply("prefix2/root", () => run_next_test());
 }
 
 function TestForwardPrefix12OnlyRoot() {
diff --git a/devtools/server/tests/xpcshell/test_framearguments-01.js b/devtools/server/tests/xpcshell/test_framearguments-01.js
index 524d43f58c..9f6f433e70 100644
--- a/devtools/server/tests/xpcshell/test_framearguments-01.js
+++ b/devtools/server/tests/xpcshell/test_framearguments-01.js
@@ -33,6 +33,8 @@ function evalCode(debuggee) {
   debuggee.eval(
     "(" +
       function () {
+        // These arguments are tested.
+        // eslint-disable-next-line no-unused-vars
         function stopMe(number, bool, string, null_, undef, object) {
           debugger;
         }
diff --git a/devtools/server/tests/xpcshell/test_framebindings-07.js b/devtools/server/tests/xpcshell/test_framebindings-07.js
index 77d43dfba8..ee655da07a 100644
--- a/devtools/server/tests/xpcshell/test_framebindings-07.js
+++ b/devtools/server/tests/xpcshell/test_framebindings-07.js
@@ -4,7 +4,7 @@
 "use strict";
 
 add_task(
-  threadFrontTest(async ({ threadFront, debuggee, client }) => {
+  threadFrontTest(async ({ threadFront, debuggee }) => {
     const packet = await executeOnNextTickAndWaitForPause(
       () => evalCode(debuggee),
       threadFront
diff --git a/devtools/server/tests/xpcshell/test_functiongrips-01.js b/devtools/server/tests/xpcshell/test_functiongrips-01.js
index 5abce26875..ccadeba11d 100644
--- a/devtools/server/tests/xpcshell/test_functiongrips-01.js
+++ b/devtools/server/tests/xpcshell/test_functiongrips-01.js
@@ -8,6 +8,8 @@ add_task(
     // Test named function
     function evalCode() {
       debuggee.eval(
+        // These arguments are tested.
+        // eslint-disable-next-line no-unused-vars
         function stopMe(arg1) {
           debugger;
         }.toString()
diff --git a/devtools/server/tests/xpcshell/test_getRuleText.js b/devtools/server/tests/xpcshell/test_getRuleText.js
index fe53dca158..bc89da974c 100644
--- a/devtools/server/tests/xpcshell/test_getRuleText.js
+++ b/devtools/server/tests/xpcshell/test_getRuleText.js
@@ -16,6 +16,25 @@ const TEST_DATA = [
     throws: true,
   },
   {
+    desc: "Null input",
+    input: null,
+    line: 1,
+    column: 1,
+    throws: true,
+  },
+  {
+    desc: "Missing loc",
+    input: "#id{color:red;background:yellow;}",
+    throws: true,
+  },
+  {
+    desc: "No opening bracket",
+    input: "/* hey */",
+    line: 1,
+    column: 1,
+    throws: true,
+  },
+  {
     desc: "Simplest test case",
     input: "#id{color:red;background:yellow;}",
     line: 1,
@@ -39,18 +58,6 @@ const TEST_DATA = [
     expected: { offset: 4, text: "color:red;background:yellow;" },
   },
   {
-    desc: "Null input",
-    input: null,
-    line: 1,
-    column: 1,
-    throws: true,
-  },
-  {
-    desc: "Missing loc",
-    input: "#id{color:red;background:yellow;}",
-    throws: true,
-  },
-  {
     desc: "Multi-lines CSS",
     input: [
       "/* this is a multi line css */",
@@ -61,7 +68,7 @@ const TEST_DATA = [
       " /*something else here */",
       "* {",
       "  color: purple;",
-      "}",
+      "}       ",
     ].join("\n"),
     line: 7,
     column: 1,
@@ -107,12 +114,60 @@ const TEST_DATA = [
     },
   },
   {
+    desc: "Attribute selector containing a { character",
+    input: `div[data-x="{"]{color: gold}`,
+    line: 1,
+    column: 1,
+    expected: {
+      offset: 16,
+      text: "color: gold",
+    },
+  },
+  {
     desc: "Rule contains no tokens",
     input: "div{}",
     line: 1,
     column: 1,
     expected: { offset: 4, text: "" },
   },
+  {
+    desc: "Rule contains invalid declaration",
+    input: `#id{color;}`,
+    line: 1,
+    column: 1,
+    expected: { offset: 4, text: "color;" },
+  },
+  {
+    desc: "Rule contains invalid declaration",
+    input: `#id{-}`,
+    line: 1,
+    column: 1,
+    expected: { offset: 4, text: "-" },
+  },
+  {
+    desc: "Rule contains nested rule",
+    input: `#id{background: gold; .nested{color:blue;} color: tomato;  }`,
+    line: 1,
+    column: 1,
+    expected: {
+      offset: 4,
+      text: "background: gold; .nested{color:blue;} color: tomato;  ",
+    },
+  },
+  {
+    desc: "Rule contains nested rule with invalid declaration",
+    input: `#id{.nested{color;}}`,
+    line: 1,
+    column: 1,
+    expected: { offset: 4, text: ".nested{color;}" },
+  },
+  {
+    desc: "Rule contains unicode chars",
+    input: `#id /*🙃*/ {content: "☃️";}`,
+    line: 1,
+    column: 1,
+    expected: { offset: 12, text: `content: "☃️";` },
+  },
 ];
 
 function run_test() {
diff --git a/devtools/server/tests/xpcshell/test_interrupt.js b/devtools/server/tests/xpcshell/test_interrupt.js
index 07593a7360..5431c8f508 100644
--- a/devtools/server/tests/xpcshell/test_interrupt.js
+++ b/devtools/server/tests/xpcshell/test_interrupt.js
@@ -4,7 +4,7 @@
 "use strict";
 
 add_task(
-  threadFrontTest(async ({ threadFront, debuggee, client, targetFront }) => {
+  threadFrontTest(async ({ threadFront }) => {
     const onPaused = waitForEvent(threadFront, "paused");
     await threadFront.interrupt();
     await onPaused;
diff --git a/devtools/server/tests/xpcshell/test_logpoint-01.js b/devtools/server/tests/xpcshell/test_logpoint-01.js
index a5cb4f2197..e2d3186d47 100644
--- a/devtools/server/tests/xpcshell/test_logpoint-01.js
+++ b/devtools/server/tests/xpcshell/test_logpoint-01.js
@@ -12,7 +12,7 @@ const Resources = require("resource://devtools/server/actors/resources/index.js"
 add_task(
   threadFrontTest(async ({ threadActor, threadFront, debuggee, client }) => {
     let lastMessage, lastExpression;
-    const targetActor = threadActor._parent;
+    const { targetActor } = threadActor;
     // Only Workers are evaluating through the WebConsoleActor.
     // Tabs will be evaluating directly via the frame object.
     targetActor._consoleActor = {
diff --git a/devtools/server/tests/xpcshell/test_logpoint-02.js b/devtools/server/tests/xpcshell/test_logpoint-02.js
index d84d3fc324..183478ee32 100644
--- a/devtools/server/tests/xpcshell/test_logpoint-02.js
+++ b/devtools/server/tests/xpcshell/test_logpoint-02.js
@@ -12,7 +12,7 @@ const Resources = require("resource://devtools/server/actors/resources/index.js"
 add_task(
   threadFrontTest(async ({ threadActor, threadFront, debuggee, client }) => {
     let lastMessage, lastExpression;
-    const targetActor = threadActor._parent;
+    const { targetActor } = threadActor;
     // Only Workers are evaluating through the WebConsoleActor.
     // Tabs will be evaluating directly via the frame object.
     targetActor._consoleActor = {
diff --git a/devtools/server/tests/xpcshell/test_logpoint-03.js b/devtools/server/tests/xpcshell/test_logpoint-03.js
index b5d4440889..0b6e37a9f6 100644
--- a/devtools/server/tests/xpcshell/test_logpoint-03.js
+++ b/devtools/server/tests/xpcshell/test_logpoint-03.js
@@ -10,9 +10,9 @@
 const Resources = require("resource://devtools/server/actors/resources/index.js");
 
 add_task(
-  threadFrontTest(async ({ threadActor, threadFront, debuggee, client }) => {
+  threadFrontTest(async ({ threadActor, threadFront, debuggee }) => {
     let lastMessage, lastExpression;
-    const targetActor = threadActor._parent;
+    const { targetActor } = threadActor;
     // Only Workers are evaluating through the WebConsoleActor.
     // Tabs will be evaluating directly via the frame object.
     targetActor._consoleActor = {
diff --git a/devtools/server/tests/xpcshell/test_longstringgrips-01.js b/devtools/server/tests/xpcshell/test_longstringgrips-01.js
index ac0b228c17..fc93a80495 100644
--- a/devtools/server/tests/xpcshell/test_longstringgrips-01.js
+++ b/devtools/server/tests/xpcshell/test_longstringgrips-01.js
@@ -66,6 +66,8 @@ function test_longstring_grip() {
   });
 
   gDebuggee.eval(
+    // These arguments are tested.
+    // eslint-disable-next-line no-unused-vars
     function stopMe(arg1) {
       debugger;
     }.toString()
diff --git a/devtools/server/tests/xpcshell/test_objectgrips-02.js b/devtools/server/tests/xpcshell/test_objectgrips-02.js
index 810a5009c0..71bf7d2c27 100644
--- a/devtools/server/tests/xpcshell/test_objectgrips-02.js
+++ b/devtools/server/tests/xpcshell/test_objectgrips-02.js
@@ -29,6 +29,8 @@ add_task(
 
 function evalCode(debuggee) {
   debuggee.eval(
+    // These arguments are tested.
+    // eslint-disable-next-line no-unused-vars
     function stopMe(arg1) {
       debugger;
     }.toString()
diff --git a/devtools/server/tests/xpcshell/test_objectgrips-03.js b/devtools/server/tests/xpcshell/test_objectgrips-03.js
index c8a51d41d3..b41b478f5d 100644
--- a/devtools/server/tests/xpcshell/test_objectgrips-03.js
+++ b/devtools/server/tests/xpcshell/test_objectgrips-03.js
@@ -44,6 +44,8 @@ add_task(
 
 function evalCode(debuggee) {
   debuggee.eval(
+    // These arguments are tested.
+    // eslint-disable-next-line no-unused-vars
     function stopMe(arg1) {
       debugger;
     }.toString()
diff --git a/devtools/server/tests/xpcshell/test_objectgrips-04.js b/devtools/server/tests/xpcshell/test_objectgrips-04.js
index d08705db3c..eb3fb06103 100644
--- a/devtools/server/tests/xpcshell/test_objectgrips-04.js
+++ b/devtools/server/tests/xpcshell/test_objectgrips-04.js
@@ -46,6 +46,8 @@ add_task(
 
 function evalCode(debuggee) {
   debuggee.eval(
+    // These arguments are tested.
+    // eslint-disable-next-line no-unused-vars
     function stopMe(arg1) {
       debugger;
     }.toString()
diff --git a/devtools/server/tests/xpcshell/test_objectgrips-05.js b/devtools/server/tests/xpcshell/test_objectgrips-05.js
index 4c6f0f107a..916c9db6df 100644
--- a/devtools/server/tests/xpcshell/test_objectgrips-05.js
+++ b/devtools/server/tests/xpcshell/test_objectgrips-05.js
@@ -38,6 +38,8 @@ add_task(
 
 function evalCode(debuggee) {
   debuggee.eval(
+    // These arguments are tested.
+    // eslint-disable-next-line no-unused-vars
     function stopMe(arg1) {
       debugger;
     }.toString()
diff --git a/devtools/server/tests/xpcshell/test_objectgrips-06.js b/devtools/server/tests/xpcshell/test_objectgrips-06.js
index ef3d2b5b66..e6c0f835a2 100644
--- a/devtools/server/tests/xpcshell/test_objectgrips-06.js
+++ b/devtools/server/tests/xpcshell/test_objectgrips-06.js
@@ -38,6 +38,8 @@ add_task(
 
 function evalCode(debuggee) {
   debuggee.eval(
+    // These arguments are tested.
+    // eslint-disable-next-line no-unused-vars
     function stopMe(arg1) {
       debugger;
     }.toString()
diff --git a/devtools/server/tests/xpcshell/test_objectgrips-07.js b/devtools/server/tests/xpcshell/test_objectgrips-07.js
index 2a3a0bf00e..4ccd711fc7 100644
--- a/devtools/server/tests/xpcshell/test_objectgrips-07.js
+++ b/devtools/server/tests/xpcshell/test_objectgrips-07.js
@@ -43,6 +43,8 @@ add_task(
 
 function evalCode(debuggee) {
   debuggee.eval(
+    // These arguments are tested.
+    // eslint-disable-next-line no-unused-vars
     function stopMe(arg1) {
       debugger;
     }.toString()
diff --git a/devtools/server/tests/xpcshell/test_objectgrips-08.js b/devtools/server/tests/xpcshell/test_objectgrips-08.js
index 1a37f19fb8..892368d7fe 100644
--- a/devtools/server/tests/xpcshell/test_objectgrips-08.js
+++ b/devtools/server/tests/xpcshell/test_objectgrips-08.js
@@ -36,6 +36,8 @@ add_task(
 
 function evalCode(debuggee) {
   debuggee.eval(
+    // These arguments are tested.
+    // eslint-disable-next-line no-unused-vars
     function stopMe(arg1) {
       debugger;
     }.toString()
diff --git a/devtools/server/tests/xpcshell/test_objectgrips-16.js b/devtools/server/tests/xpcshell/test_objectgrips-16.js
index 785c3bc36d..5e66aa700b 100644
--- a/devtools/server/tests/xpcshell/test_objectgrips-16.js
+++ b/devtools/server/tests/xpcshell/test_objectgrips-16.js
@@ -29,6 +29,8 @@ add_task(
 
     function eval_code() {
       debuggee.eval(
+        // These arguments are tested.
+        // eslint-disable-next-line no-unused-vars
         function stopMe(arg1) {
           debugger;
         }.toString()
diff --git a/devtools/server/tests/xpcshell/test_objectgrips-17.js b/devtools/server/tests/xpcshell/test_objectgrips-17.js
index edaea88eaa..ed90cc7ae6 100644
--- a/devtools/server/tests/xpcshell/test_objectgrips-17.js
+++ b/devtools/server/tests/xpcshell/test_objectgrips-17.js
@@ -288,6 +288,8 @@ async function run_tests_in_principal(
 ) {
   const { debuggee } = options;
   debuggee.eval(
+    // These arguments are tested.
+    // eslint-disable-next-line no-unused-vars
     function stopMe(arg1, arg2) {
       debugger;
     }.toString()
diff --git a/devtools/server/tests/xpcshell/test_objectgrips-18.js b/devtools/server/tests/xpcshell/test_objectgrips-18.js
index 90c38d99a9..9e169b596c 100644
--- a/devtools/server/tests/xpcshell/test_objectgrips-18.js
+++ b/devtools/server/tests/xpcshell/test_objectgrips-18.js
@@ -31,6 +31,8 @@ add_task(
 
     function eval_code() {
       debuggee.eval(
+        // These arguments are tested.
+        // eslint-disable-next-line no-unused-vars
         function stopMe(arg1) {
           debugger;
         }.toString()
diff --git a/devtools/server/tests/xpcshell/test_objectgrips-19.js b/devtools/server/tests/xpcshell/test_objectgrips-19.js
index 655c7d0f43..9ee92638bc 100644
--- a/devtools/server/tests/xpcshell/test_objectgrips-19.js
+++ b/devtools/server/tests/xpcshell/test_objectgrips-19.js
@@ -9,8 +9,10 @@ registerCleanupFunction(() => {
 });
 
 add_task(
-  threadFrontTest(async ({ threadFront, debuggee, client }) => {
+  threadFrontTest(async ({ threadFront, debuggee }) => {
     debuggee.eval(
+      // These arguments are tested.
+      // eslint-disable-next-line no-unused-vars
       function stopMe(arg1) {
         debugger;
       }.toString()
diff --git a/devtools/server/tests/xpcshell/test_objectgrips-20.js b/devtools/server/tests/xpcshell/test_objectgrips-20.js
index 5027ca31a7..f36ea20f7e 100644
--- a/devtools/server/tests/xpcshell/test_objectgrips-20.js
+++ b/devtools/server/tests/xpcshell/test_objectgrips-20.js
@@ -17,6 +17,8 @@ registerCleanupFunction(() => {
 add_task(
   threadFrontTest(async ({ threadFront, debuggee, client }) => {
     debuggee.eval(
+      // These arguments are tested.
+      // eslint-disable-next-line no-unused-vars
       function stopMe(arg1) {
         debugger;
       }.toString()
diff --git a/devtools/server/tests/xpcshell/test_objectgrips-21.js b/devtools/server/tests/xpcshell/test_objectgrips-21.js
index 88296f7786..daed1808c7 100644
--- a/devtools/server/tests/xpcshell/test_objectgrips-21.js
+++ b/devtools/server/tests/xpcshell/test_objectgrips-21.js
@@ -213,6 +213,8 @@ async function test_unsafe_grips(
   tests
 ) {
   debuggee.eval(
+    // These arguments are tested.
+    // eslint-disable-next-line no-unused-vars
     function stopMe(arg1, arg2) {
       debugger;
     }.toString()
diff --git a/devtools/server/tests/xpcshell/test_objectgrips-22.js b/devtools/server/tests/xpcshell/test_objectgrips-22.js
index 34264f5534..fd33030fef 100644
--- a/devtools/server/tests/xpcshell/test_objectgrips-22.js
+++ b/devtools/server/tests/xpcshell/test_objectgrips-22.js
@@ -40,6 +40,8 @@ add_task(
 
 function evalCode(debuggee) {
   debuggee.eval(
+    // These arguments are tested.
+    // eslint-disable-next-line no-unused-vars
     function stopMe(arg1) {
       debugger;
     }.toString()
diff --git a/devtools/server/tests/xpcshell/test_objectgrips-25.js b/devtools/server/tests/xpcshell/test_objectgrips-25.js
index f80572bb19..4fdce90805 100644
--- a/devtools/server/tests/xpcshell/test_objectgrips-25.js
+++ b/devtools/server/tests/xpcshell/test_objectgrips-25.js
@@ -12,6 +12,8 @@ registerCleanupFunction(() => {
 
 function evalCode(debuggee) {
   debuggee.eval(
+    // These arguments are tested.
+    // eslint-disable-next-line no-unused-vars
     function stopMe(obj) {
       debugger;
     }.toString()
diff --git a/devtools/server/tests/xpcshell/test_objectgrips-fn-apply-01.js b/devtools/server/tests/xpcshell/test_objectgrips-fn-apply-01.js
index f576f16a5e..a67b08b0d2 100644
--- a/devtools/server/tests/xpcshell/test_objectgrips-fn-apply-01.js
+++ b/devtools/server/tests/xpcshell/test_objectgrips-fn-apply-01.js
@@ -63,6 +63,8 @@ add_task(
 
 function evalCode(debuggee) {
   debuggee.eval(
+    // These arguments are tested.
+    // eslint-disable-next-line no-unused-vars
     function stopMe(arg1) {
       debugger;
     }.toString()
diff --git a/devtools/server/tests/xpcshell/test_objectgrips-fn-apply-02.js b/devtools/server/tests/xpcshell/test_objectgrips-fn-apply-02.js
index 743286281c..fda27f6874 100644
--- a/devtools/server/tests/xpcshell/test_objectgrips-fn-apply-02.js
+++ b/devtools/server/tests/xpcshell/test_objectgrips-fn-apply-02.js
@@ -41,6 +41,8 @@ add_task(
 
 function evalCode(debuggee) {
   debuggee.eval(
+    // These arguments are tested.
+    // eslint-disable-next-line no-unused-vars
     function stopMe(arg1) {
       debugger;
     }.toString()
diff --git a/devtools/server/tests/xpcshell/test_objectgrips-fn-apply-03.js b/devtools/server/tests/xpcshell/test_objectgrips-fn-apply-03.js
index 6a3e919661..69a317b5e0 100644
--- a/devtools/server/tests/xpcshell/test_objectgrips-fn-apply-03.js
+++ b/devtools/server/tests/xpcshell/test_objectgrips-fn-apply-03.js
@@ -38,6 +38,8 @@ add_task(
 
 function evalCode(debuggee) {
   debuggee.eval(
+    // These arguments are tested.
+    // eslint-disable-next-line no-unused-vars
     function stopMe(arg1) {
       debugger;
     }.toString()
diff --git a/devtools/server/tests/xpcshell/test_objectgrips-nested-promise.js b/devtools/server/tests/xpcshell/test_objectgrips-nested-promise.js
index b60b7328c2..e0de94d24f 100644
--- a/devtools/server/tests/xpcshell/test_objectgrips-nested-promise.js
+++ b/devtools/server/tests/xpcshell/test_objectgrips-nested-promise.js
@@ -38,6 +38,8 @@ add_task(
 
 function evalCode(debuggee) {
   debuggee.eval(
+    // These arguments are tested.
+    // eslint-disable-next-line no-unused-vars
     function stopMe(arg) {
       debugger;
     }.toString()
diff --git a/devtools/server/tests/xpcshell/test_objectgrips-nested-proxy.js b/devtools/server/tests/xpcshell/test_objectgrips-nested-proxy.js
index 5b0667c055..a5760f6144 100644
--- a/devtools/server/tests/xpcshell/test_objectgrips-nested-proxy.js
+++ b/devtools/server/tests/xpcshell/test_objectgrips-nested-proxy.js
@@ -37,6 +37,8 @@ add_task(
 
 function evalCode(debuggee) {
   debuggee.eval(
+    // These arguments are tested.
+    // eslint-disable-next-line no-unused-vars
     function stopMe(arg) {
       debugger;
     }.toString()
diff --git a/devtools/server/tests/xpcshell/test_objectgrips-property-value-01.js b/devtools/server/tests/xpcshell/test_objectgrips-property-value-01.js
index 69da96a741..c7588578f4 100644
--- a/devtools/server/tests/xpcshell/test_objectgrips-property-value-01.js
+++ b/devtools/server/tests/xpcshell/test_objectgrips-property-value-01.js
@@ -89,6 +89,8 @@ add_task(
 
 function evalCode(debuggee) {
   debuggee.eval(
+    // These arguments are tested.
+    // eslint-disable-next-line no-unused-vars
     function stopMe(arg1) {
       debugger;
     }.toString()
diff --git a/devtools/server/tests/xpcshell/test_objectgrips-property-value-02.js b/devtools/server/tests/xpcshell/test_objectgrips-property-value-02.js
index bc7337128c..6d00a6e04e 100644
--- a/devtools/server/tests/xpcshell/test_objectgrips-property-value-02.js
+++ b/devtools/server/tests/xpcshell/test_objectgrips-property-value-02.js
@@ -38,6 +38,8 @@ add_task(
 
 function evalCode(debuggee) {
   debuggee.eval(
+    // These arguments are tested.
+    // eslint-disable-next-line no-unused-vars
     function stopMe(arg1) {
       debugger;
     }.toString()
diff --git a/devtools/server/tests/xpcshell/test_objectgrips-sparse-array.js b/devtools/server/tests/xpcshell/test_objectgrips-sparse-array.js
index 76a6b32f4b..3448987420 100644
--- a/devtools/server/tests/xpcshell/test_objectgrips-sparse-array.js
+++ b/devtools/server/tests/xpcshell/test_objectgrips-sparse-array.js
@@ -32,6 +32,8 @@ add_task(
 
 function evalCode(debuggee) {
   debuggee.eval(
+    // These arguments are tested.
+    // eslint-disable-next-line no-unused-vars
     function stopMe(arr) {
       debugger;
     }.toString()
diff --git a/devtools/server/tests/xpcshell/test_pause_exceptions-04.js b/devtools/server/tests/xpcshell/test_pause_exceptions-04.js
index 6246b112e0..aa30002af8 100644
--- a/devtools/server/tests/xpcshell/test_pause_exceptions-04.js
+++ b/devtools/server/tests/xpcshell/test_pause_exceptions-04.js
@@ -12,7 +12,7 @@ const { waitForTick } = require("resource://devtools/shared/DevToolsUtils.js");
 
 add_task(
   threadFrontTest(
-    async ({ threadFront, client, debuggee, commands }) => {
+    async ({ threadFront, debuggee, commands }) => {
       let onResume = null;
       let packet = null;
 
diff --git a/devtools/server/tests/xpcshell/test_pauselifetime-02.js b/devtools/server/tests/xpcshell/test_pauselifetime-02.js
index e936df6177..08495229e6 100644
--- a/devtools/server/tests/xpcshell/test_pauselifetime-02.js
+++ b/devtools/server/tests/xpcshell/test_pauselifetime-02.js
@@ -47,6 +47,8 @@ function evaluateTestCode(debuggee) {
   debuggee.eval(
     "(" +
       function () {
+        // These arguments are tested.
+        // eslint-disable-next-line no-unused-vars
         function stopMe(obj) {
           debugger;
         }
diff --git a/devtools/server/tests/xpcshell/test_pauselifetime-03.js b/devtools/server/tests/xpcshell/test_pauselifetime-03.js
index 558ac8b910..f79ade2e7e 100644
--- a/devtools/server/tests/xpcshell/test_pauselifetime-03.js
+++ b/devtools/server/tests/xpcshell/test_pauselifetime-03.js
@@ -54,6 +54,8 @@ function evaluateTestCode(debuggee) {
   debuggee.eval(
     "(" +
       function () {
+        // These arguments are tested.
+        // eslint-disable-next-line no-unused-vars
         function stopMe(obj) {
           debugger;
         }
diff --git a/devtools/server/tests/xpcshell/test_pauselifetime-04.js b/devtools/server/tests/xpcshell/test_pauselifetime-04.js
index 7d226260f0..a699a96709 100644
--- a/devtools/server/tests/xpcshell/test_pauselifetime-04.js
+++ b/devtools/server/tests/xpcshell/test_pauselifetime-04.js
@@ -30,6 +30,8 @@ function evaluateTestCode(debuggee) {
   debuggee.eval(
     "(" +
       function () {
+        // These arguments are tested.
+        // eslint-disable-next-line no-unused-vars
         function stopMe(obj) {
           debugger;
         }
diff --git a/devtools/server/tests/xpcshell/test_promises_run_to_completion.js b/devtools/server/tests/xpcshell/test_promises_run_to_completion.js
index 4d1e8745fe..7147d77e0d 100644
--- a/devtools/server/tests/xpcshell/test_promises_run_to_completion.js
+++ b/devtools/server/tests/xpcshell/test_promises_run_to_completion.js
@@ -44,7 +44,7 @@ function test_promises_run_to_completion() {
   const log = [""];
   g.log = log;
 
-  dbg.onDebuggerStatement = function handleDebuggerStatement(frame) {
+  dbg.onDebuggerStatement = function handleDebuggerStatement() {
     dbg.onDebuggerStatement = undefined;
 
     // Exercise the promise machinery: resolve a promise and perform a microtask
@@ -63,7 +63,7 @@ function test_promises_run_to_completion() {
     force_microtask_checkpoint();
     log[0] += ")";
 
-    Promise.resolve(42).then(v => {
+    Promise.resolve(42).then(() => {
       // The microtask running this callback should be handled as we leave the
       // onDebuggerStatement Debugger callback, and should not be interleaved
       // with debuggee microtasks.
diff --git a/devtools/server/tests/xpcshell/test_restartFrame-01.js b/devtools/server/tests/xpcshell/test_restartFrame-01.js
index cb13ae2d7e..51fbe75510 100644
--- a/devtools/server/tests/xpcshell/test_restartFrame-01.js
+++ b/devtools/server/tests/xpcshell/test_restartFrame-01.js
@@ -8,7 +8,7 @@
  * restarted frame.
  */
 
-async function testFinish({ threadFront, devToolsClient }) {
+async function testFinish({ devToolsClient }) {
   await close(devToolsClient);
 
   do_test_finished();
diff --git a/devtools/server/tests/xpcshell/test_source-01.js b/devtools/server/tests/xpcshell/test_source-01.js
index 5cb7a6da52..cb57ad43e9 100644
--- a/devtools/server/tests/xpcshell/test_source-01.js
+++ b/devtools/server/tests/xpcshell/test_source-01.js
@@ -46,6 +46,8 @@ add_task(
 function evaluateTestCode(debuggee) {
   Cu.evalInSandbox(
     "" +
+      // These arguments are tested.
+      // eslint-disable-next-line no-unused-vars
       function stopMe(arg1) {
         debugger;
       },
diff --git a/devtools/server/tests/xpcshell/test_source-02.js b/devtools/server/tests/xpcshell/test_source-02.js
index 9cb88cb0e4..88e91ee6e3 100644
--- a/devtools/server/tests/xpcshell/test_source-02.js
+++ b/devtools/server/tests/xpcshell/test_source-02.js
@@ -52,6 +52,8 @@ add_task(
 function evaluateTestCode(debuggee) {
   Cu.evalInSandbox(
     "" +
+      // These arguments are tested.
+      // eslint-disable-next-line no-unused-vars
       function stopMe(arg1) {
         debugger;
       },
diff --git a/devtools/server/tests/xpcshell/test_source-03.js b/devtools/server/tests/xpcshell/test_source-03.js
index d0cd4839a0..bbee9d2949 100644
--- a/devtools/server/tests/xpcshell/test_source-03.js
+++ b/devtools/server/tests/xpcshell/test_source-03.js
@@ -51,7 +51,7 @@ add_task(
       // in the first global.
       let pausedOne = false;
       let onResumed = null;
-      threadFront.once("paused", function (packet) {
+      threadFront.once("paused", function () {
         pausedOne = true;
         onResumed = resume(threadFront);
       });
@@ -62,7 +62,7 @@ add_task(
       // Ensure that the breakpoint was properly applied to the JSScipt loaded
       // in the second global.
       let pausedTwo = false;
-      threadFront.once("paused", function (packet) {
+      threadFront.once("paused", function () {
         pausedTwo = true;
         onResumed = resume(threadFront);
       });
diff --git a/devtools/server/tests/xpcshell/test_source-04.js b/devtools/server/tests/xpcshell/test_source-04.js
index a3e3bef25f..fd3e8c339c 100644
--- a/devtools/server/tests/xpcshell/test_source-04.js
+++ b/devtools/server/tests/xpcshell/test_source-04.js
@@ -39,7 +39,7 @@ add_task(
       // in the first global.
       let pausedOne = false;
       let onResumed = null;
-      threadFront.once("paused", function (packet) {
+      threadFront.once("paused", function () {
         pausedOne = true;
         onResumed = resume(threadFront);
       });
@@ -61,7 +61,7 @@ add_task(
       // Ensure that the breakpoint was properly applied to the JSScipt loaded
       // in the second global.
       let pausedTwo = false;
-      threadFront.once("paused", function (packet) {
+      threadFront.once("paused", function () {
         pausedTwo = true;
         onResumed = resume(threadFront);
       });
diff --git a/devtools/server/tests/xpcshell/test_stepping-01.js b/devtools/server/tests/xpcshell/test_stepping-01.js
index 0c66404510..6231ed746e 100644
--- a/devtools/server/tests/xpcshell/test_stepping-01.js
+++ b/devtools/server/tests/xpcshell/test_stepping-01.js
@@ -8,7 +8,7 @@
  * going to the function b's call-site.
  */
 
-async function testFinish({ threadFront, devToolsClient }) {
+async function testFinish({ devToolsClient }) {
   await close(devToolsClient);
 
   do_test_finished();
diff --git a/devtools/server/tests/xpcshell/test_stepping-18.js b/devtools/server/tests/xpcshell/test_stepping-18.js
index e8581835d3..4961173074 100644
--- a/devtools/server/tests/xpcshell/test_stepping-18.js
+++ b/devtools/server/tests/xpcshell/test_stepping-18.js
@@ -8,7 +8,7 @@
  * going to the function b's call-site.
  */
 
-async function testFinish({ threadFront, devToolsClient }) {
+async function testFinish({ devToolsClient }) {
   await close(devToolsClient);
 
   do_test_finished();
diff --git a/devtools/server/tests/xpcshell/test_stepping-19.js b/devtools/server/tests/xpcshell/test_stepping-19.js
index 7ab21c7b66..c344816615 100644
--- a/devtools/server/tests/xpcshell/test_stepping-19.js
+++ b/devtools/server/tests/xpcshell/test_stepping-19.js
@@ -7,7 +7,7 @@
  * Check that step out stops at the async parent's frame.
  */
 
-async function testFinish({ threadFront, devToolsClient }) {
+async function testFinish({ devToolsClient }) {
   await close(devToolsClient);
 
   do_test_finished();
diff --git a/devtools/server/tests/xpcshell/test_threadlifetime-01.js b/devtools/server/tests/xpcshell/test_threadlifetime-01.js
index d2e8234fb9..d8b2e3c53b 100644
--- a/devtools/server/tests/xpcshell/test_threadlifetime-01.js
+++ b/devtools/server/tests/xpcshell/test_threadlifetime-01.js
@@ -45,6 +45,8 @@ function evaluateTestCode(debuggee) {
   debuggee.eval(
     "(" +
       function () {
+        // These arguments are tested.
+        // eslint-disable-next-line no-unused-vars
         function stopMe(arg1) {
           debugger;
           debugger;
diff --git a/devtools/server/tests/xpcshell/test_threadlifetime-02.js b/devtools/server/tests/xpcshell/test_threadlifetime-02.js
index c35350a48c..310ffe6b9f 100644
--- a/devtools/server/tests/xpcshell/test_threadlifetime-02.js
+++ b/devtools/server/tests/xpcshell/test_threadlifetime-02.js
@@ -62,6 +62,8 @@ function evaluateTestCode(debuggee) {
   debuggee.eval(
     "(" +
       function () {
+        // These arguments are tested.
+        // eslint-disable-next-line no-unused-vars
         function stopMe(arg1) {
           debugger;
           debugger;
diff --git a/devtools/server/tests/xpcshell/test_threadlifetime-04.js b/devtools/server/tests/xpcshell/test_threadlifetime-04.js
index 6b815c7933..a78b70cc66 100644
--- a/devtools/server/tests/xpcshell/test_threadlifetime-04.js
+++ b/devtools/server/tests/xpcshell/test_threadlifetime-04.js
@@ -48,6 +48,8 @@ function test_thread_lifetime() {
   gDebuggee.eval(
     "(" +
       function () {
+        // These arguments are tested.
+        // eslint-disable-next-line no-unused-vars
         function stopMe(arg1) {
           debugger;
         }
diff --git a/devtools/server/tests/xpcshell/test_wasm_source-01.js b/devtools/server/tests/xpcshell/test_wasm_source-01.js
index fe8e43e236..4f6561d88d 100644
--- a/devtools/server/tests/xpcshell/test_wasm_source-01.js
+++ b/devtools/server/tests/xpcshell/test_wasm_source-01.js
@@ -13,7 +13,7 @@ var gThreadFront;
 
 add_task(
   threadFrontTest(
-    async ({ threadFront, debuggee, client }) => {
+    async ({ threadFront, debuggee }) => {
       gThreadFront = threadFront;
       gDebuggee = debuggee;
 
@@ -90,7 +90,7 @@ const EXPECTED_CONTENT = String.fromCharCode(
 );
 
 function test_source() {
-  gThreadFront.once("paused", function (packet) {
+  gThreadFront.once("paused", function () {
     gThreadFront.getSources().then(function (response) {
       Assert.ok(!!response);
       Assert.ok(!!response.sources);
diff --git a/devtools/server/tests/xpcshell/testactors.js b/devtools/server/tests/xpcshell/testactors.js
index af208fe93e..bbcd8abe6e 100644
--- a/devtools/server/tests/xpcshell/testactors.js
+++ b/devtools/server/tests/xpcshell/testactors.js
@@ -166,7 +166,7 @@ class TestTargetActor extends protocol.Actor {
     this._extraActors.threadActor = this.threadActor;
     this.makeDebugger = makeDebugger.bind(null, {
       findDebuggees: () => [this._global],
-      shouldAddNewGlobalAsDebuggee: g => gAllowNewThreadGlobals,
+      shouldAddNewGlobalAsDebuggee: () => gAllowNewThreadGlobals,
     });
     this.dbg = this.makeDebugger();
     this.notifyResources = this.notifyResources.bind(this);
@@ -216,12 +216,12 @@ class TestTargetActor extends protocol.Actor {
     return { ...response, ...actors };
   }
 
-  detach(request) {
+  detach() {
     this.threadActor.destroy();
     return { type: "detached" };
   }
 
-  reload(request) {
+  reload() {
     this.sourcesManager.reset();
     this.threadActor.clearDebuggees();
     this.threadActor.dbg.addDebuggees();