1 files changed, 248 insertions, 0 deletions
diff --git a/devtools/client/framework/test/browser_toolbox_toolbar_reorder_with_hidden_extension.js b/devtools/client/framework/test/browser_toolbox_toolbar_reorder_with_hidden_extension.js
new file mode 100644
index 0000000000..6e7b44d5d3
--- /dev/null
+++ b/devtools/client/framework/test/browser_toolbox_toolbar_reorder_with_hidden_extension.js
@@ -0,0 +1,248 @@
+/* Any copyright is dedicated to the Public Domain.
+ * http://creativecommons.org/publicdomain/zero/1.0/ */
+
+"use strict";
+
+// Test for reordering with an hidden extension installed.
+
+const { Toolbox } = require("resource://devtools/client/framework/toolbox.js");
+
+const EXTENSION = "@reorder.test";
+
+const TEST_DATA = [
+  {
+    description: "Test that drags a tab to left beyond the extension's tab",
+    startingOrder: [
+      "inspector",
+      EXTENSION,
+      "webconsole",
+      "jsdebugger",
+      "styleeditor",
+      "performance",
+      "memory",
+      "netmonitor",
+      "storage",
+      "accessibility",
+      "application",
+    ],
+    dragTarget: "webconsole",
+    dropTarget: "inspector",
+    expectedOrder: [
+      "webconsole",
+      "inspector",
+      EXTENSION,
+      "jsdebugger",
+      "styleeditor",
+      "performance",
+      "memory",
+      "netmonitor",
+      "storage",
+      "accessibility",
+      "application",
+    ],
+  },
+  {
+    description: "Test that drags a tab to right beyond the extension's tab",
+    startingOrder: [
+      "inspector",
+      EXTENSION,
+      "webconsole",
+      "jsdebugger",
+      "styleeditor",
+      "performance",
+      "memory",
+      "netmonitor",
+      "storage",
+      "accessibility",
+      "application",
+    ],
+    dragTarget: "inspector",
+    dropTarget: "webconsole",
+    expectedOrder: [
+      EXTENSION,
+      "webconsole",
+      "inspector",
+      "jsdebugger",
+      "styleeditor",
+      "performance",
+      "memory",
+      "netmonitor",
+      "storage",
+      "accessibility",
+      "application",
+    ],
+  },
+  {
+    description:
+      "Test that drags a tab to left end, but hidden tab is left end",
+    startingOrder: [
+      EXTENSION,
+      "inspector",
+      "webconsole",
+      "jsdebugger",
+      "styleeditor",
+      "performance",
+      "memory",
+      "netmonitor",
+      "storage",
+      "accessibility",
+      "application",
+    ],
+    dragTarget: "webconsole",
+    dropTarget: "inspector",
+    expectedOrder: [
+      EXTENSION,
+      "webconsole",
+      "inspector",
+      "jsdebugger",
+      "styleeditor",
+      "performance",
+      "memory",
+      "netmonitor",
+      "storage",
+      "accessibility",
+      "application",
+    ],
+  },
+  {
+    description:
+      "Test that drags a tab to right end, but hidden tab is right end",
+    startingOrder: [
+      "inspector",
+      "webconsole",
+      "jsdebugger",
+      "styleeditor",
+      "performance",
+      "memory",
+      "netmonitor",
+      "storage",
+      "accessibility",
+      "application",
+      EXTENSION,
+    ],
+    dragTarget: "webconsole",
+    dropTarget: "application",
+    expectedOrder: [
+      "inspector",
+      "jsdebugger",
+      "styleeditor",
+      "performance",
+      "memory",
+      "netmonitor",
+      "storage",
+      "accessibility",
+      "application",
+      EXTENSION,
+      "webconsole",
+    ],
+  },
+];
+
+add_task(async function () {
+  // Enable the Application panel (atm it's only available on Nightly)
+  await pushPref("devtools.application.enabled", true);
+
+  registerCleanupFunction(() => {
+    Services.prefs.clearUserPref("devtools.toolbox.tabsOrder");
+  });
+
+  const extension = ExtensionTestUtils.loadExtension({
+    useAddonManager: "temporary",
+    manifest: {
+      devtools_page: "extension.html",
+      browser_specific_settings: {
+        gecko: { id: EXTENSION },
+      },
+    },
+    files: {
+      "extension.html": `<!DOCTYPE html>
+                         <html>
+                           <head>
+                             <meta charset="utf-8">
+                           </head>
+                           <body>
+                             <script src="extension.js"></script>
+                           </body>
+                         </html>`,
+      "extension.js": async () => {
+        // Don't call browser.devtools.panels.create since this need to be as hidden.
+        // eslint-disable-next-line
+        browser.test.sendMessage("devtools-page-ready");
+      },
+    },
+  });
+
+  await extension.startup();
+
+  const tab = await addTab("about:blank");
+  const toolbox = await openToolboxForTab(
+    tab,
+    "webconsole",
+    Toolbox.HostType.BOTTOM
+  );
+  await extension.awaitMessage("devtools-page-ready");
+
+  for (const {
+    description,
+    startingOrder,
+    dragTarget,
+    dropTarget,
+    expectedOrder,
+  } of TEST_DATA) {
+    info(description);
+    prepareTestWithHiddenExtension(toolbox, startingOrder);
+    await dndToolTab(toolbox, dragTarget, dropTarget);
+    assertToolTabPreferenceOrder(expectedOrder);
+  }
+
+  info("Test ordering preference after uninstalling hidden addon");
+  const startingOrder = [
+    "inspector",
+    EXTENSION,
+    "webconsole",
+    "jsdebugger",
+    "styleeditor",
+    "performance",
+    "memory",
+    "netmonitor",
+    "storage",
+    "accessibility",
+    "application",
+  ];
+  const dragTarget = "webconsole";
+  const dropTarget = "inspector";
+  const expectedOrder = [
+    "webconsole",
+    "inspector",
+    "jsdebugger",
+    "styleeditor",
+    "performance",
+    "memory",
+    "netmonitor",
+    "storage",
+    "accessibility",
+    "application",
+  ];
+  prepareTestWithHiddenExtension(toolbox, startingOrder);
+  await extension.unload();
+  await dndToolTab(toolbox, dragTarget, dropTarget);
+  assertToolTabPreferenceOrder(expectedOrder);
+});
+
+function prepareTestWithHiddenExtension(toolbox, startingOrder) {
+  Services.prefs.setCharPref(
+    "devtools.toolbox.tabsOrder",
+    startingOrder.join(",")
+  );
+
+  for (const id of startingOrder) {
+    if (id === EXTENSION) {
+      ok(
+        !getElementByToolId(toolbox, id),
+        "Hidden extension tab should not exist"
+      );
+    } else {
+      ok(getElementByToolId(toolbox, id), `Tab element should exist for ${id}`);
+    }
+  }
+}