summaryrefslogtreecommitdiffstats
path: root/devtools/client/memory
diff options
context:
space:
mode:
Diffstat (limited to 'devtools/client/memory')
-rw-r--r--devtools/client/memory/actions/census-display.js2
-rw-r--r--devtools/client/memory/actions/filter.js2
-rw-r--r--devtools/client/memory/actions/io.js6
-rw-r--r--devtools/client/memory/actions/label-display.js2
-rw-r--r--devtools/client/memory/actions/snapshot.js4
-rw-r--r--devtools/client/memory/actions/tree-map-display.js2
-rw-r--r--devtools/client/memory/actions/view.js4
-rw-r--r--devtools/client/memory/components/CensusTreeItem.js2
-rw-r--r--devtools/client/memory/components/DominatorTree.js6
-rw-r--r--devtools/client/memory/components/DominatorTreeItem.js2
-rw-r--r--devtools/client/memory/components/Individuals.js6
-rw-r--r--devtools/client/memory/components/TreeMap.js2
-rw-r--r--devtools/client/memory/components/tree-map/drag-zoom.js3
-rw-r--r--devtools/client/memory/models.js2
-rw-r--r--devtools/client/memory/reducers/allocations.js10
-rw-r--r--devtools/client/memory/reducers/individuals.js2
-rw-r--r--devtools/client/memory/test/browser/browser_memory_allocationStackDisplay_01.js2
-rw-r--r--devtools/client/memory/test/browser/browser_memory_allocationStackDisplay_02.js2
-rw-r--r--devtools/client/memory/test/browser/browser_memory_clear_snapshots.js2
-rw-r--r--devtools/client/memory/test/browser/browser_memory_diff_01.js2
-rw-r--r--devtools/client/memory/test/browser/browser_memory_displays_01.js2
-rw-r--r--devtools/client/memory/test/browser/browser_memory_dominator_trees_01.js2
-rw-r--r--devtools/client/memory/test/browser/browser_memory_filter_01.js2
-rw-r--r--devtools/client/memory/test/browser/browser_memory_individuals_01.js2
-rw-r--r--devtools/client/memory/test/browser/browser_memory_keyboard.js2
-rw-r--r--devtools/client/memory/test/browser/browser_memory_no_allocation_stacks.js2
-rw-r--r--devtools/client/memory/test/browser/browser_memory_no_auto_expand.js2
-rw-r--r--devtools/client/memory/test/browser/browser_memory_percents_01.js2
-rw-r--r--devtools/client/memory/test/browser/browser_memory_refresh_does_not_leak.js2
-rw-r--r--devtools/client/memory/test/browser/browser_memory_simple_01.js2
-rw-r--r--devtools/client/memory/test/browser/browser_memory_transferHeapSnapshot_e10s_01.js2
-rw-r--r--devtools/client/memory/test/browser/browser_memory_tree_map-01.js2
-rw-r--r--devtools/client/memory/test/browser/browser_memory_tree_map-02.js2
-rw-r--r--devtools/client/memory/utils.js2
34 files changed, 43 insertions, 50 deletions
diff --git a/devtools/client/memory/actions/census-display.js b/devtools/client/memory/actions/census-display.js
index d266fe04a5..9abd16d99b 100644
--- a/devtools/client/memory/actions/census-display.js
+++ b/devtools/client/memory/actions/census-display.js
@@ -10,7 +10,7 @@ const {
} = require("resource://devtools/client/memory/actions/refresh.js");
exports.setCensusDisplayAndRefresh = function (heapWorker, display) {
- return async function ({ dispatch, getState }) {
+ return async function ({ dispatch }) {
dispatch(setCensusDisplay(display));
await dispatch(refresh(heapWorker));
};
diff --git a/devtools/client/memory/actions/filter.js b/devtools/client/memory/actions/filter.js
index 1bc9fd35db..7f5295872d 100644
--- a/devtools/client/memory/actions/filter.js
+++ b/devtools/client/memory/actions/filter.js
@@ -26,7 +26,7 @@ const debouncedRefreshDispatcher = debounce(
);
exports.setFilterStringAndRefresh = function (filterString, heapWorker) {
- return ({ dispatch, getState }) => {
+ return ({ dispatch }) => {
dispatch(setFilterString(filterString));
debouncedRefreshDispatcher(dispatch, heapWorker);
};
diff --git a/devtools/client/memory/actions/io.js b/devtools/client/memory/actions/io.js
index c811478df5..bedd5d8bfc 100644
--- a/devtools/client/memory/actions/io.js
+++ b/devtools/client/memory/actions/io.js
@@ -25,7 +25,7 @@ const {
const VALID_EXPORT_STATES = [states.SAVED, states.READ];
exports.pickFileAndExportSnapshot = function (snapshot) {
- return async function ({ dispatch, getState }) {
+ return async function ({ dispatch }) {
const outputFile = await openFilePicker({
title: L10N.getFormatStr("snapshot.io.save.window"),
defaultName: PathUtils.filename(snapshot.path),
@@ -42,7 +42,7 @@ exports.pickFileAndExportSnapshot = function (snapshot) {
};
const exportSnapshot = (exports.exportSnapshot = function (snapshot, dest) {
- return async function ({ dispatch, getState }) {
+ return async function ({ dispatch }) {
dispatch({ type: actions.EXPORT_SNAPSHOT_START, snapshot });
assert(
@@ -62,7 +62,7 @@ const exportSnapshot = (exports.exportSnapshot = function (snapshot, dest) {
});
exports.pickFileAndImportSnapshotAndCensus = function (heapWorker) {
- return async function ({ dispatch, getState }) {
+ return async function ({ dispatch }) {
const input = await openFilePicker({
title: L10N.getFormatStr("snapshot.io.import.window"),
filters: [[L10N.getFormatStr("snapshot.io.filter"), "*.fxsnapshot"]],
diff --git a/devtools/client/memory/actions/label-display.js b/devtools/client/memory/actions/label-display.js
index c8a6db35ec..cd90fcff3b 100644
--- a/devtools/client/memory/actions/label-display.js
+++ b/devtools/client/memory/actions/label-display.js
@@ -14,7 +14,7 @@ const {
* current data.
*/
exports.setLabelDisplayAndRefresh = function (heapWorker, display) {
- return async function ({ dispatch, getState }) {
+ return async function ({ dispatch }) {
// Clears out all stored census data and sets the display.
dispatch(setLabelDisplay(display));
await dispatch(refresh(heapWorker));
diff --git a/devtools/client/memory/actions/snapshot.js b/devtools/client/memory/actions/snapshot.js
index 63885be251..21b54e9e28 100644
--- a/devtools/client/memory/actions/snapshot.js
+++ b/devtools/client/memory/actions/snapshot.js
@@ -727,7 +727,7 @@ const computeAndFetchDominatorTree = (exports.computeAndFetchDominatorTree =
return id;
},
- async task(heapWorker, id, removeFromCache, dispatch, getState) {
+ async task(heapWorker, id, removeFromCache, dispatch) {
const dominatorTreeId = await dispatch(
computeDominatorTree(heapWorker, id)
);
@@ -843,7 +843,7 @@ exports.clearSnapshots = function (heapWorker) {
* @param {snapshotModel} snapshot
*/
exports.deleteSnapshot = function (heapWorker, snapshot) {
- return async function ({ dispatch, getState }) {
+ return async function ({ dispatch }) {
dispatch({ type: actions.DELETE_SNAPSHOTS_START, ids: [snapshot.id] });
try {
diff --git a/devtools/client/memory/actions/tree-map-display.js b/devtools/client/memory/actions/tree-map-display.js
index e1c4a21132..38de0478c3 100644
--- a/devtools/client/memory/actions/tree-map-display.js
+++ b/devtools/client/memory/actions/tree-map-display.js
@@ -13,7 +13,7 @@ const {
* census.
*/
exports.setTreeMapAndRefresh = function (heapWorker, display) {
- return async function ({ dispatch, getState }) {
+ return async function ({ dispatch }) {
dispatch(setTreeMap(display));
await dispatch(refresh(heapWorker));
};
diff --git a/devtools/client/memory/actions/view.js b/devtools/client/memory/actions/view.js
index af1bc7b21a..5f1ab5c263 100644
--- a/devtools/client/memory/actions/view.js
+++ b/devtools/client/memory/actions/view.js
@@ -49,7 +49,7 @@ const popView = (exports.popView = function () {
* @param {HeapAnalysesClient} heapWorker
*/
exports.changeViewAndRefresh = function (view, heapWorker) {
- return async function ({ dispatch, getState }) {
+ return async function ({ dispatch }) {
dispatch(changeView(view));
await dispatch(refresh.refresh(heapWorker));
};
@@ -62,7 +62,7 @@ exports.changeViewAndRefresh = function (view, heapWorker) {
* @param {HeapAnalysesClient} heapWorker
*/
exports.popViewAndRefresh = function (heapWorker) {
- return async function ({ dispatch, getState }) {
+ return async function ({ dispatch }) {
dispatch(popView());
await dispatch(refresh.refresh(heapWorker));
};
diff --git a/devtools/client/memory/components/CensusTreeItem.js b/devtools/client/memory/components/CensusTreeItem.js
index 39fdbeb052..b3dd5545de 100644
--- a/devtools/client/memory/components/CensusTreeItem.js
+++ b/devtools/client/memory/components/CensusTreeItem.js
@@ -45,7 +45,7 @@ class CensusTreeItem extends Component {
this.toLabel = this.toLabel.bind(this);
}
- shouldComponentUpdate(nextProps, nextState) {
+ shouldComponentUpdate(nextProps) {
return (
this.props.item != nextProps.item ||
this.props.depth != nextProps.depth ||
diff --git a/devtools/client/memory/components/DominatorTree.js b/devtools/client/memory/components/DominatorTree.js
index 9c767cece7..3cb1f89856 100644
--- a/devtools/client/memory/components/DominatorTree.js
+++ b/devtools/client/memory/components/DominatorTree.js
@@ -44,7 +44,7 @@ class DominatorTreeSubtreeFetchingClass extends Component {
};
}
- shouldComponentUpdate(nextProps, nextState) {
+ shouldComponentUpdate(nextProps) {
return (
this.props.depth !== nextProps.depth ||
this.props.focused !== nextProps.focused
@@ -84,7 +84,7 @@ class DominatorTreeSiblingLinkClass extends Component {
};
}
- shouldComponentUpdate(nextProps, nextState) {
+ shouldComponentUpdate(nextProps) {
return (
this.props.depth !== nextProps.depth ||
this.props.focused !== nextProps.focused
@@ -129,7 +129,7 @@ class DominatorTree extends Component {
};
}
- shouldComponentUpdate(nextProps, nextState) {
+ shouldComponentUpdate(nextProps) {
// Safe to use referential equality here because all of our mutations on
// dominator tree models use immutableUpdate in a persistent manner. The
// exception to the rule are mutations of the expanded set, however we take
diff --git a/devtools/client/memory/components/DominatorTreeItem.js b/devtools/client/memory/components/DominatorTreeItem.js
index 59cb542a3a..88dddf0563 100644
--- a/devtools/client/memory/components/DominatorTreeItem.js
+++ b/devtools/client/memory/components/DominatorTreeItem.js
@@ -47,7 +47,7 @@ class DominatorTreeItem extends Component {
};
}
- shouldComponentUpdate(nextProps, nextState) {
+ shouldComponentUpdate(nextProps) {
return (
this.props.item != nextProps.item ||
this.props.depth != nextProps.depth ||
diff --git a/devtools/client/memory/components/Individuals.js b/devtools/client/memory/components/Individuals.js
index dd0e9acc81..ed48232c68 100644
--- a/devtools/client/memory/components/Individuals.js
+++ b/devtools/client/memory/components/Individuals.js
@@ -42,9 +42,9 @@ class Individuals extends Component {
autoExpandDepth: 0,
preventNavigationOnArrowRight: false,
focused: individuals.focused,
- getParent: node => null,
- getChildren: node => [],
- isExpanded: node => false,
+ getParent: () => null,
+ getChildren: () => [],
+ isExpanded: () => false,
onExpand: () => {},
onCollapse: () => {},
onFocus,
diff --git a/devtools/client/memory/components/TreeMap.js b/devtools/client/memory/components/TreeMap.js
index b9a3c39495..6dd404d3e9 100644
--- a/devtools/client/memory/components/TreeMap.js
+++ b/devtools/client/memory/components/TreeMap.js
@@ -38,7 +38,7 @@ class TreeMap extends Component {
return oldTreeMap !== newTreeMap;
}
- componentDidUpdate(prevProps) {
+ componentDidUpdate() {
this._stopVisualization();
if (this.props.treeMap && this.props.treeMap.report) {
diff --git a/devtools/client/memory/components/tree-map/drag-zoom.js b/devtools/client/memory/components/tree-map/drag-zoom.js
index 034017e086..f0f94a926a 100644
--- a/devtools/client/memory/components/tree-map/drag-zoom.js
+++ b/devtools/client/memory/components/tree-map/drag-zoom.js
@@ -295,10 +295,9 @@ function setScrollHandlers(container, dragZoom, emitChanged, update) {
* Account for the various mouse wheel event types, per pixel or per line
*
* @param {WheelEvent} event
- * @param {Window} window
* @return {Number} The scroll size in pixels
*/
-function getScrollDelta(event, window) {
+function getScrollDelta(event) {
if (event.deltaMode === LINE_SCROLL_MODE) {
// Update by a fixed arbitrary value to normalize scroll types
return event.deltaY * SCROLL_LINE_SIZE;
diff --git a/devtools/client/memory/models.js b/devtools/client/memory/models.js
index 83ed3641b0..9429fdae4a 100644
--- a/devtools/client/memory/models.js
+++ b/devtools/client/memory/models.js
@@ -289,7 +289,7 @@ const snapshotModel = (exports.snapshot = PropTypes.shape({
creationTime: PropTypes.number,
// The current state the snapshot is in.
// @see ./constants.js
- state: catchAndIgnore(function (snapshot, propName) {
+ state: catchAndIgnore(function (snapshot) {
const current = snapshot.state;
const shouldHavePath = [states.IMPORTING, states.SAVED, states.READ];
const shouldHaveCreationTime = [states.READ];
diff --git a/devtools/client/memory/reducers/allocations.js b/devtools/client/memory/reducers/allocations.js
index f019705560..895e61676d 100644
--- a/devtools/client/memory/reducers/allocations.js
+++ b/devtools/client/memory/reducers/allocations.js
@@ -9,10 +9,7 @@ const { actions } = require("resource://devtools/client/memory/constants.js");
const handlers = Object.create(null);
-handlers[actions.TOGGLE_RECORD_ALLOCATION_STACKS_START] = function (
- state,
- action
-) {
+handlers[actions.TOGGLE_RECORD_ALLOCATION_STACKS_START] = function (state) {
assert(
!state.togglingInProgress,
"Changing recording state must not be reentrant."
@@ -24,10 +21,7 @@ handlers[actions.TOGGLE_RECORD_ALLOCATION_STACKS_START] = function (
};
};
-handlers[actions.TOGGLE_RECORD_ALLOCATION_STACKS_END] = function (
- state,
- action
-) {
+handlers[actions.TOGGLE_RECORD_ALLOCATION_STACKS_END] = function (state) {
assert(
state.togglingInProgress,
"Should not complete changing recording state if we weren't changing " +
diff --git a/devtools/client/memory/reducers/individuals.js b/devtools/client/memory/reducers/individuals.js
index 9b5a2c89a5..57b096f870 100644
--- a/devtools/client/memory/reducers/individuals.js
+++ b/devtools/client/memory/reducers/individuals.js
@@ -38,7 +38,7 @@ handlers[actions.FOCUS_INDIVIDUAL] = function (individuals, { node }) {
return immutableUpdate(individuals, { focused: node });
};
-handlers[actions.FETCH_INDIVIDUALS_START] = function (individuals, action) {
+handlers[actions.FETCH_INDIVIDUALS_START] = function (individuals) {
assert(individuals, "Should have individuals");
return Object.freeze({
state: individualsState.FETCHING,
diff --git a/devtools/client/memory/test/browser/browser_memory_allocationStackDisplay_01.js b/devtools/client/memory/test/browser/browser_memory_allocationStackDisplay_01.js
index b526025b17..e145732b7a 100644
--- a/devtools/client/memory/test/browser/browser_memory_allocationStackDisplay_01.js
+++ b/devtools/client/memory/test/browser/browser_memory_allocationStackDisplay_01.js
@@ -20,7 +20,7 @@ const {
const TEST_URL =
"http://example.com/browser/devtools/client/memory/test/browser/doc_steady_allocation.html";
-this.test = makeMemoryTest(TEST_URL, async function ({ tab, panel }) {
+this.test = makeMemoryTest(TEST_URL, async function ({ panel }) {
const heapWorker = panel.panelWin.gHeapAnalysesClient;
const { getState, dispatch } = panel.panelWin.gStore;
const front = getState().front;
diff --git a/devtools/client/memory/test/browser/browser_memory_allocationStackDisplay_02.js b/devtools/client/memory/test/browser/browser_memory_allocationStackDisplay_02.js
index 34492187a2..b9c80c394c 100644
--- a/devtools/client/memory/test/browser/browser_memory_allocationStackDisplay_02.js
+++ b/devtools/client/memory/test/browser/browser_memory_allocationStackDisplay_02.js
@@ -20,7 +20,7 @@ const {
const TEST_URL =
"https://example.com/browser/devtools/client/memory/test/browser/doc_steady_allocation.html";
-this.test = makeMemoryTest("about:blank", async function ({ tab, panel }) {
+this.test = makeMemoryTest("about:blank", async function ({ panel }) {
const heapWorker = panel.panelWin.gHeapAnalysesClient;
const { getState, dispatch } = panel.panelWin.gStore;
const doc = panel.panelWin.document;
diff --git a/devtools/client/memory/test/browser/browser_memory_clear_snapshots.js b/devtools/client/memory/test/browser/browser_memory_clear_snapshots.js
index 52eecd2838..333459cc3e 100644
--- a/devtools/client/memory/test/browser/browser_memory_clear_snapshots.js
+++ b/devtools/client/memory/test/browser/browser_memory_clear_snapshots.js
@@ -13,7 +13,7 @@ const {
const TEST_URL =
"http://example.com/browser/devtools/client/memory/test/browser/doc_steady_allocation.html";
-this.test = makeMemoryTest(TEST_URL, async function ({ tab, panel }) {
+this.test = makeMemoryTest(TEST_URL, async function ({ panel }) {
const { gStore, document } = panel.panelWin;
const { getState } = gStore;
diff --git a/devtools/client/memory/test/browser/browser_memory_diff_01.js b/devtools/client/memory/test/browser/browser_memory_diff_01.js
index 7b6487565f..638586f667 100644
--- a/devtools/client/memory/test/browser/browser_memory_diff_01.js
+++ b/devtools/client/memory/test/browser/browser_memory_diff_01.js
@@ -13,7 +13,7 @@ const {
const TEST_URL =
"http://example.com/browser/devtools/client/memory/test/browser/doc_steady_allocation.html";
-this.test = makeMemoryTest(TEST_URL, async function ({ tab, panel }) {
+this.test = makeMemoryTest(TEST_URL, async function ({ panel }) {
const store = panel.panelWin.gStore;
const { getState } = store;
const doc = panel.panelWin.document;
diff --git a/devtools/client/memory/test/browser/browser_memory_displays_01.js b/devtools/client/memory/test/browser/browser_memory_displays_01.js
index 89296b77f4..7e9561796d 100644
--- a/devtools/client/memory/test/browser/browser_memory_displays_01.js
+++ b/devtools/client/memory/test/browser/browser_memory_displays_01.js
@@ -13,7 +13,7 @@ const {
changeView,
} = require("resource://devtools/client/memory/actions/view.js");
-this.test = makeMemoryTest(TEST_URL, async function ({ tab, panel }) {
+this.test = makeMemoryTest(TEST_URL, async function ({ panel }) {
const { gStore, document } = panel.panelWin;
const { dispatch } = panel.panelWin.gStore;
diff --git a/devtools/client/memory/test/browser/browser_memory_dominator_trees_01.js b/devtools/client/memory/test/browser/browser_memory_dominator_trees_01.js
index 1faaf365a1..39b984eadd 100644
--- a/devtools/client/memory/test/browser/browser_memory_dominator_trees_01.js
+++ b/devtools/client/memory/test/browser/browser_memory_dominator_trees_01.js
@@ -20,7 +20,7 @@ const {
const TEST_URL =
"http://example.com/browser/devtools/client/memory/test/browser/doc_big_tree.html";
-this.test = makeMemoryTest(TEST_URL, async function ({ tab, panel }) {
+this.test = makeMemoryTest(TEST_URL, async function ({ panel }) {
// Taking snapshots and computing dominator trees is slow :-/
requestLongerTimeout(4);
diff --git a/devtools/client/memory/test/browser/browser_memory_filter_01.js b/devtools/client/memory/test/browser/browser_memory_filter_01.js
index 00dcfdb951..7f2e39ac20 100644
--- a/devtools/client/memory/test/browser/browser_memory_filter_01.js
+++ b/devtools/client/memory/test/browser/browser_memory_filter_01.js
@@ -17,7 +17,7 @@ const {
const TEST_URL =
"http://example.com/browser/devtools/client/memory/test/browser/doc_steady_allocation.html";
-this.test = makeMemoryTest(TEST_URL, async function ({ tab, panel }) {
+this.test = makeMemoryTest(TEST_URL, async function ({ panel }) {
const heapWorker = panel.panelWin.gHeapAnalysesClient;
const store = panel.panelWin.gStore;
const { dispatch } = store;
diff --git a/devtools/client/memory/test/browser/browser_memory_individuals_01.js b/devtools/client/memory/test/browser/browser_memory_individuals_01.js
index f54154b949..7be5fb2ac4 100644
--- a/devtools/client/memory/test/browser/browser_memory_individuals_01.js
+++ b/devtools/client/memory/test/browser/browser_memory_individuals_01.js
@@ -17,7 +17,7 @@ const {
const TEST_URL =
"http://example.com/browser/devtools/client/memory/test/browser/doc_steady_allocation.html";
-this.test = makeMemoryTest(TEST_URL, async function ({ tab, panel }) {
+this.test = makeMemoryTest(TEST_URL, async function ({ panel }) {
const store = panel.panelWin.gStore;
const { dispatch } = store;
const doc = panel.panelWin.document;
diff --git a/devtools/client/memory/test/browser/browser_memory_keyboard.js b/devtools/client/memory/test/browser/browser_memory_keyboard.js
index 0fba33c456..642eacd43c 100644
--- a/devtools/client/memory/test/browser/browser_memory_keyboard.js
+++ b/devtools/client/memory/test/browser/browser_memory_keyboard.js
@@ -39,7 +39,7 @@ function waitUntilExpanded(store, node) {
);
}
-this.test = makeMemoryTest(TEST_URL, async function ({ tab, panel }) {
+this.test = makeMemoryTest(TEST_URL, async function ({ panel }) {
const heapWorker = panel.panelWin.gHeapAnalysesClient;
const store = panel.panelWin.gStore;
const { getState, dispatch } = store;
diff --git a/devtools/client/memory/test/browser/browser_memory_no_allocation_stacks.js b/devtools/client/memory/test/browser/browser_memory_no_allocation_stacks.js
index b8b09b35d0..086bc77ef5 100644
--- a/devtools/client/memory/test/browser/browser_memory_no_allocation_stacks.js
+++ b/devtools/client/memory/test/browser/browser_memory_no_allocation_stacks.js
@@ -17,7 +17,7 @@ const {
const TEST_URL =
"http://example.com/browser/devtools/client/memory/test/browser/doc_steady_allocation.html";
-this.test = makeMemoryTest(TEST_URL, async function ({ tab, panel }) {
+this.test = makeMemoryTest(TEST_URL, async function ({ panel }) {
const heapWorker = panel.panelWin.gHeapAnalysesClient;
const { getState, dispatch } = panel.panelWin.gStore;
const front = getState().front;
diff --git a/devtools/client/memory/test/browser/browser_memory_no_auto_expand.js b/devtools/client/memory/test/browser/browser_memory_no_auto_expand.js
index 9704d925d1..f4e9800f28 100644
--- a/devtools/client/memory/test/browser/browser_memory_no_auto_expand.js
+++ b/devtools/client/memory/test/browser/browser_memory_no_auto_expand.js
@@ -17,7 +17,7 @@ const {
const TEST_URL =
"http://example.com/browser/devtools/client/memory/test/browser/doc_steady_allocation.html";
-this.test = makeMemoryTest(TEST_URL, async function ({ tab, panel }) {
+this.test = makeMemoryTest(TEST_URL, async function ({ panel }) {
const heapWorker = panel.panelWin.gHeapAnalysesClient;
const { getState, dispatch } = panel.panelWin.gStore;
const front = getState().front;
diff --git a/devtools/client/memory/test/browser/browser_memory_percents_01.js b/devtools/client/memory/test/browser/browser_memory_percents_01.js
index c4bb254b07..8e9202b705 100644
--- a/devtools/client/memory/test/browser/browser_memory_percents_01.js
+++ b/devtools/client/memory/test/browser/browser_memory_percents_01.js
@@ -29,7 +29,7 @@ function checkCells(cells) {
}
}
-this.test = makeMemoryTest(TEST_URL, async function ({ tab, panel }) {
+this.test = makeMemoryTest(TEST_URL, async function ({ panel }) {
const heapWorker = panel.panelWin.gHeapAnalysesClient;
const { getState, dispatch } = panel.panelWin.gStore;
const front = getState().front;
diff --git a/devtools/client/memory/test/browser/browser_memory_refresh_does_not_leak.js b/devtools/client/memory/test/browser/browser_memory_refresh_does_not_leak.js
index e0ee1eee41..1ecb6275d4 100644
--- a/devtools/client/memory/test/browser/browser_memory_refresh_does_not_leak.js
+++ b/devtools/client/memory/test/browser/browser_memory_refresh_does_not_leak.js
@@ -53,7 +53,7 @@ const DESCRIPTION = {
},
};
-this.test = makeMemoryTest(TEST_URL, async function ({ tab, panel }) {
+this.test = makeMemoryTest(TEST_URL, async function ({ panel }) {
let front = panel.panelWin.gStore.getState().front;
const startWindows = await getWindowsInSnapshot(front);
diff --git a/devtools/client/memory/test/browser/browser_memory_simple_01.js b/devtools/client/memory/test/browser/browser_memory_simple_01.js
index a983e23395..acafb46ca1 100644
--- a/devtools/client/memory/test/browser/browser_memory_simple_01.js
+++ b/devtools/client/memory/test/browser/browser_memory_simple_01.js
@@ -14,7 +14,7 @@ const {
changeView,
} = require("resource://devtools/client/memory/actions/view.js");
-this.test = makeMemoryTest(TEST_URL, async function ({ tab, panel }) {
+this.test = makeMemoryTest(TEST_URL, async function ({ panel }) {
const { gStore, document } = panel.panelWin;
const { getState, dispatch } = gStore;
diff --git a/devtools/client/memory/test/browser/browser_memory_transferHeapSnapshot_e10s_01.js b/devtools/client/memory/test/browser/browser_memory_transferHeapSnapshot_e10s_01.js
index c647836332..169a968653 100644
--- a/devtools/client/memory/test/browser/browser_memory_transferHeapSnapshot_e10s_01.js
+++ b/devtools/client/memory/test/browser/browser_memory_transferHeapSnapshot_e10s_01.js
@@ -11,7 +11,7 @@
const TEST_URL = "data:text/html,<html><body></body></html>";
-this.test = makeMemoryTest(TEST_URL, async function ({ tab, panel }) {
+this.test = makeMemoryTest(TEST_URL, async function ({ panel }) {
const memoryFront = panel.panelWin.gStore.getState().front;
ok(memoryFront, "Should get the MemoryFront");
diff --git a/devtools/client/memory/test/browser/browser_memory_tree_map-01.js b/devtools/client/memory/test/browser/browser_memory_tree_map-01.js
index c65b7fc079..97e69f6f6d 100644
--- a/devtools/client/memory/test/browser/browser_memory_tree_map-01.js
+++ b/devtools/client/memory/test/browser/browser_memory_tree_map-01.js
@@ -12,7 +12,7 @@ const D3_SCRIPT =
'src="chrome://global/content/third_party/d3/d3.js">';
const TEST_URL = `data:text/html,<html><body>${D3_SCRIPT}</body></html>`;
-this.test = makeMemoryTest(TEST_URL, async function ({ tab, panel }) {
+this.test = makeMemoryTest(TEST_URL, async function ({ panel }) {
const document = panel.panelWin.document;
const window = panel.panelWin;
const div = document.createElement("div");
diff --git a/devtools/client/memory/test/browser/browser_memory_tree_map-02.js b/devtools/client/memory/test/browser/browser_memory_tree_map-02.js
index 890ede23b5..f48bb66c13 100644
--- a/devtools/client/memory/test/browser/browser_memory_tree_map-02.js
+++ b/devtools/client/memory/test/browser/browser_memory_tree_map-02.js
@@ -14,7 +14,7 @@ const PIXEL_SCROLL_MODE = 0;
const PIXEL_DELTA = 10;
const MAX_RAF_LOOP = 1000;
-this.test = makeMemoryTest(TEST_URL, async function ({ tab, panel }) {
+this.test = makeMemoryTest(TEST_URL, async function ({ panel }) {
const panelWin = panel.panelWin;
const panelDoc = panelWin.document;
const div = panelDoc.createElement("div");
diff --git a/devtools/client/memory/utils.js b/devtools/client/memory/utils.js
index 5d97663810..c16da9c14a 100644
--- a/devtools/client/memory/utils.js
+++ b/devtools/client/memory/utils.js
@@ -434,7 +434,7 @@ exports.openFilePicker = function ({ title, filters, defaultName, mode }) {
}
const fp = Cc["@mozilla.org/filepicker;1"].createInstance(Ci.nsIFilePicker);
- fp.init(window, title, fpMode);
+ fp.init(window.browsingContext, title, fpMode);
for (const filter of filters || []) {
fp.appendFilter(filter[0], filter[1]);