diff options
Diffstat (limited to 'dom/webgpu/tests/cts/checkout/docs/intro/developing.md')
| -rw-r--r-- | dom/webgpu/tests/cts/checkout/docs/intro/developing.md | 23 |
1 files changed, 16 insertions, 7 deletions
diff --git a/dom/webgpu/tests/cts/checkout/docs/intro/developing.md b/dom/webgpu/tests/cts/checkout/docs/intro/developing.md index 5b1aeed36d..0016c2c048 100644 --- a/dom/webgpu/tests/cts/checkout/docs/intro/developing.md +++ b/dom/webgpu/tests/cts/checkout/docs/intro/developing.md @@ -34,6 +34,11 @@ the standalone runner.) Note: The first load of a test suite may take some time as generating the test suite listing can take a few seconds. +## Documentation + +In addition to the documentation pages you're reading, there is TSDoc documentation. +Start at the [helper index](https://gpuweb.github.io/cts/docs/tsdoc/). + ## Standalone Test Runner / Test Plan Viewer **The standalone test runner also serves as a test plan viewer.** @@ -43,7 +48,7 @@ You can use this to preview how your test plan will appear. You can view different suites (webgpu, unittests, stress, etc.) or different subtrees of the test suite. -- `http://localhost:8080/standalone/` (defaults to `?runnow=0&worker=0&debug=0&q=webgpu:*`) +- `http://localhost:8080/standalone/` (defaults to `?runnow=0&debug=0&q=webgpu:*`) - `http://localhost:8080/standalone/?q=unittests:*` - `http://localhost:8080/standalone/?q=unittests:basic:*` @@ -51,7 +56,9 @@ The following url parameters change how the harness runs: - `runnow=1` runs all matching tests on page load. - `debug=1` enables verbose debug logging from tests. -- `worker=1` runs the tests on a Web Worker instead of the main thread. +- `worker=dedicated` (or `worker` or `worker=1`) runs the tests on a dedicated worker instead of the main thread. +- `worker=shared` runs the tests on a shared worker instead of the main thread. +- `worker=service` runs the tests on a service worker instead of the main thread. - `power_preference=low-power` runs most tests passing `powerPreference: low-power` to `requestAdapter` - `power_preference=high-performance` runs most tests passing `powerPreference: high-performance` to `requestAdapter` @@ -112,15 +119,17 @@ Opening a pull request will automatically notify reviewers. To make the review process smoother, once a reviewer has started looking at your change: - Avoid major additions or changes that would be best done in a follow-up PR. -- Avoid rebases (`git rebase`) and force pushes (`git push -f`). These can make - it difficult for reviewers to review incremental changes as GitHub often cannot +- Avoid deleting commits that have already been reviewed, which occurs when using + rebases (`git rebase`) and force pushes (`git push -f`). These can make + it difficult for reviewers to review incremental changes as GitHub usually cannot view a useful diff across a rebase. If it's necessary to resolve conflicts with upstream changes, use a merge commit (`git merge`) and don't include any - consequential changes in the merge, so a reviewer can skip over merge commits + unnecessary changes in the merge, so that a reviewer can skip over merge commits when working through the individual commits in the PR. -- When you address a review comment, mark the thread as "Resolved". -Pull requests will (usually) be landed with the "Squash and merge" option. + The "Create a merge commit" merge option is disabled, so `main` history always + remains linear (no merge commits). PRs are usually landed using "Squash and merge". +- When you address a review comment, mark the thread as "Resolved". ### TODOs |