summaryrefslogtreecommitdiffstats
path: root/third_party/libwebrtc/pc/rtc_stats_collector.cc
diff options
context:
space:
mode:
Diffstat (limited to 'third_party/libwebrtc/pc/rtc_stats_collector.cc')
-rw-r--r--third_party/libwebrtc/pc/rtc_stats_collector.cc26
1 files changed, 5 insertions, 21 deletions
diff --git a/third_party/libwebrtc/pc/rtc_stats_collector.cc b/third_party/libwebrtc/pc/rtc_stats_collector.cc
index a5a3067fa1..a49e8ef0b2 100644
--- a/third_party/libwebrtc/pc/rtc_stats_collector.cc
+++ b/third_party/libwebrtc/pc/rtc_stats_collector.cc
@@ -72,7 +72,7 @@ namespace {
const char kDirectionInbound = 'I';
const char kDirectionOutbound = 'O';
-const char* kAudioPlayoutSingletonId = "AP";
+static constexpr char kAudioPlayoutSingletonId[] = "AP";
// TODO(https://crbug.com/webrtc/10656): Consider making IDs less predictable.
std::string RTCCertificateIDFromFingerprint(const std::string& fingerprint) {
@@ -164,19 +164,6 @@ std::string RTCMediaSourceStatsIDFromKindAndAttachment(
return sb.str();
}
-const char* CandidateTypeToRTCIceCandidateType(const cricket::Candidate& c) {
- if (c.is_local())
- return "host";
- if (c.is_stun())
- return "srflx";
- if (c.is_prflx())
- return "prflx";
- if (c.is_relay())
- return "relay";
- RTC_DCHECK_NOTREACHED();
- return nullptr;
-}
-
const char* DataStateToRTCDataChannelState(
DataChannelInterface::DataState state) {
switch (state) {
@@ -961,12 +948,10 @@ const std::string& ProduceIceCandidateStats(Timestamp timestamp,
if (is_local) {
candidate_stats->network_type =
NetworkTypeToStatsType(candidate.network_type());
- const std::string& candidate_type = candidate.type();
const std::string& relay_protocol = candidate.relay_protocol();
const std::string& url = candidate.url();
- if (candidate_type == cricket::RELAY_PORT_TYPE ||
- (candidate_type == cricket::PRFLX_PORT_TYPE &&
- !relay_protocol.empty())) {
+ if (candidate.is_relay() ||
+ (candidate.is_prflx() && !relay_protocol.empty())) {
RTC_DCHECK(relay_protocol.compare("udp") == 0 ||
relay_protocol.compare("tcp") == 0 ||
relay_protocol.compare("tls") == 0);
@@ -974,7 +959,7 @@ const std::string& ProduceIceCandidateStats(Timestamp timestamp,
if (!url.empty()) {
candidate_stats->url = url;
}
- } else if (candidate_type == cricket::STUN_PORT_TYPE) {
+ } else if (candidate.is_stun()) {
if (!url.empty()) {
candidate_stats->url = url;
}
@@ -1000,8 +985,7 @@ const std::string& ProduceIceCandidateStats(Timestamp timestamp,
candidate_stats->address = candidate.address().ipaddr().ToString();
candidate_stats->port = static_cast<int32_t>(candidate.address().port());
candidate_stats->protocol = candidate.protocol();
- candidate_stats->candidate_type =
- CandidateTypeToRTCIceCandidateType(candidate);
+ candidate_stats->candidate_type = candidate.type_name();
candidate_stats->priority = static_cast<int32_t>(candidate.priority());
candidate_stats->foundation = candidate.foundation();
auto related_address = candidate.related_address();