From a90a5cba08fdf6c0ceb95101c275108a152a3aed Mon Sep 17 00:00:00 2001 From: Daniel Baumann Date: Wed, 12 Jun 2024 07:35:37 +0200 Subject: Merging upstream version 127.0. Signed-off-by: Daniel Baumann --- dom/canvas/CanvasImageCache.cpp | 64 ++++++++++++++++++++++++++++------------- 1 file changed, 44 insertions(+), 20 deletions(-) (limited to 'dom/canvas/CanvasImageCache.cpp') diff --git a/dom/canvas/CanvasImageCache.cpp b/dom/canvas/CanvasImageCache.cpp index 358e057265..cef9f1ee2d 100644 --- a/dom/canvas/CanvasImageCache.cpp +++ b/dom/canvas/CanvasImageCache.cpp @@ -9,7 +9,6 @@ #include "imgIRequest.h" #include "mozilla/dom/Element.h" #include "nsTHashtable.h" -#include "mozilla/dom/HTMLCanvasElement.h" #include "nsContentUtils.h" #include "mozilla/Preferences.h" #include "mozilla/UniquePtr.h" @@ -26,11 +25,11 @@ using namespace gfx; * due to CORS security. */ struct ImageCacheKey { - ImageCacheKey(imgIContainer* aImage, HTMLCanvasElement* aCanvas, + ImageCacheKey(imgIContainer* aImage, CanvasRenderingContext2D* aContext, BackendType aBackendType) - : mImage(aImage), mCanvas(aCanvas), mBackendType(aBackendType) {} + : mImage(aImage), mContext(aContext), mBackendType(aBackendType) {} nsCOMPtr mImage; - HTMLCanvasElement* mCanvas; + CanvasRenderingContext2D* mContext; BackendType mBackendType; }; @@ -41,7 +40,7 @@ struct ImageCacheKey { struct ImageCacheEntryData { ImageCacheEntryData(const ImageCacheEntryData& aOther) : mImage(aOther.mImage), - mCanvas(aOther.mCanvas), + mContext(aOther.mContext), mBackendType(aOther.mBackendType), mSourceSurface(aOther.mSourceSurface), mSize(aOther.mSize), @@ -49,7 +48,7 @@ struct ImageCacheEntryData { mCropRect(aOther.mCropRect) {} explicit ImageCacheEntryData(const ImageCacheKey& aKey) : mImage(aKey.mImage), - mCanvas(aKey.mCanvas), + mContext(aKey.mContext), mBackendType(aKey.mBackendType) {} nsExpirationState* GetExpirationState() { return &mState; } @@ -57,7 +56,7 @@ struct ImageCacheEntryData { // Key nsCOMPtr mImage; - HTMLCanvasElement* mCanvas; + CanvasRenderingContext2D* mContext; BackendType mBackendType; // Value RefPtr mSourceSurface; @@ -79,13 +78,13 @@ class ImageCacheEntry : public PLDHashEntryHdr { ~ImageCacheEntry() = default; bool KeyEquals(KeyTypePointer key) const { - return mData->mImage == key->mImage && mData->mCanvas == key->mCanvas && + return mData->mImage == key->mImage && mData->mContext == key->mContext && mData->mBackendType == key->mBackendType; } static KeyTypePointer KeyToPointer(KeyType& key) { return &key; } static PLDHashNumber HashKey(KeyTypePointer key) { - return HashGeneric(key->mImage.get(), key->mCanvas, key->mBackendType); + return HashGeneric(key->mImage.get(), key->mContext, key->mBackendType); } enum { ALLOW_MEMMOVE = true }; @@ -152,7 +151,7 @@ class ImageCache final : public nsExpirationTracker { AllCanvasImageCacheKey(aObject->mImage, aObject->mBackendType)); // Deleting the entry will delete aObject since the entry owns aObject. - mCache.RemoveEntry(ImageCacheKey(aObject->mImage, aObject->mCanvas, + mCache.RemoveEntry(ImageCacheKey(aObject->mImage, aObject->mContext, aObject->mBackendType)); } @@ -264,11 +263,33 @@ static already_AddRefed GetImageContainer(dom::Element* aImage) { return imgContainer.forget(); } +void CanvasImageCache::NotifyCanvasDestroyed( + CanvasRenderingContext2D* aContext) { + MOZ_ASSERT(aContext); + + if (!NS_IsMainThread() || !gImageCache) { + return; + } + + for (auto i = gImageCache->mCache.Iter(); !i.Done(); i.Next()) { + ImageCacheEntryData* data = i.Get()->mData.get(); + if (data->mContext == aContext) { + gImageCache->RemoveObject(data); + gImageCache->mAllCanvasCache.RemoveEntry( + AllCanvasImageCacheKey(data->mImage, data->mBackendType)); + i.Remove(); + } + } +} + void CanvasImageCache::NotifyDrawImage( - Element* aImage, HTMLCanvasElement* aCanvas, DrawTarget* aTarget, + Element* aImage, CanvasRenderingContext2D* aContext, DrawTarget* aTarget, SourceSurface* aSource, const IntSize& aSize, const IntSize& aIntrinsicSize, const Maybe& aCropRect) { - if (!aTarget) { + MOZ_ASSERT(NS_IsMainThread()); + MOZ_ASSERT(aContext); + + if (!aTarget || !aContext) { return; } @@ -285,7 +306,7 @@ void CanvasImageCache::NotifyDrawImage( BackendType backendType = aTarget->GetBackendType(); AllCanvasImageCacheKey allCanvasCacheKey(imgContainer, backendType); - ImageCacheKey canvasCacheKey(imgContainer, aCanvas, backendType); + ImageCacheKey canvasCacheKey(imgContainer, aContext, backendType); ImageCacheEntry* entry = gImageCache->mCache.PutEntry(canvasCacheKey); if (entry) { @@ -311,6 +332,8 @@ void CanvasImageCache::NotifyDrawImage( SourceSurface* CanvasImageCache::LookupAllCanvas(Element* aImage, DrawTarget* aTarget) { + MOZ_ASSERT(NS_IsMainThread()); + if (!gImageCache || !aTarget) { return nullptr; } @@ -329,12 +352,13 @@ SourceSurface* CanvasImageCache::LookupAllCanvas(Element* aImage, return entry->mSourceSurface; } -SourceSurface* CanvasImageCache::LookupCanvas(Element* aImage, - HTMLCanvasElement* aCanvas, - DrawTarget* aTarget, - IntSize* aSizeOut, - IntSize* aIntrinsicSizeOut, - Maybe* aCropRectOut) { +SourceSurface* CanvasImageCache::LookupCanvas( + Element* aImage, CanvasRenderingContext2D* aContext, DrawTarget* aTarget, + IntSize* aSizeOut, IntSize* aIntrinsicSizeOut, + Maybe* aCropRectOut) { + MOZ_ASSERT(NS_IsMainThread()); + MOZ_ASSERT(aContext); + if (!gImageCache || !aTarget) { return nullptr; } @@ -351,7 +375,7 @@ SourceSurface* CanvasImageCache::LookupCanvas(Element* aImage, // optimized surface given to a Skia backend would cause a readback. For // details, see bug 1794442. ImageCacheEntry* entry = gImageCache->mCache.GetEntry( - ImageCacheKey(imgContainer, aCanvas, aTarget->GetBackendType())); + ImageCacheKey(imgContainer, aContext, aTarget->GetBackendType())); if (!entry) { return nullptr; } -- cgit v1.2.3