From fbaf0bb26397aa498eb9156f06d5a6fe34dd7dd8 Mon Sep 17 00:00:00 2001 From: Daniel Baumann Date: Fri, 19 Apr 2024 03:14:29 +0200 Subject: Merging upstream version 125.0.1. Signed-off-by: Daniel Baumann --- testing/talos/talos/allowlist.py | 2 +- testing/talos/talos/bootstrap.js | 10 +++++----- testing/talos/talos/pageloader/chrome/a11y.js | 2 +- testing/talos/talos/pageloader/chrome/lh_hero.js | 4 ++-- testing/talos/talos/pageloader/chrome/lh_moz.js | 2 +- testing/talos/talos/pageloader/chrome/pageloader.js | 15 ++++++--------- testing/talos/talos/pageloader/chrome/tscroll.js | 2 +- testing/talos/talos/results.py | 2 +- testing/talos/talos/run_tests.py | 4 +++- .../talos/talos/startup_test/sessionrestore/addon/api.js | 2 +- .../startup_test/startup_about_home_paint/addon/api.js | 2 +- testing/talos/talos/talos-powers/api.js | 8 ++++---- .../talos/talos-powers/chrome/talos-powers-content.js | 10 +++++----- testing/talos/talos/tests/cpstartup/extension/api.js | 2 +- .../talos/talos/tests/cpstartup/extension/framescript.js | 2 +- .../devtools/addon/content/actors/DampLoadChild.sys.mjs | 2 +- .../talos/tests/devtools/addon/content/damp-tests.js | 3 +++ testing/talos/talos/tests/devtools/addon/content/damp.js | 2 +- .../tests/devtools/addon/content/tests/debugger/custom.js | 4 ++-- .../addon/content/tests/debugger/debugger-helpers.js | 8 +------- .../talos/tests/devtools/addon/content/tests/head.js | 2 +- .../addon/content/tests/netmonitor/netmonitor-helpers.js | 2 +- .../tests/devtools/addon/content/tests/server/actor.js | 2 +- .../tests/devtools/addon/content/tests/server/protocol.js | 2 +- .../addon/content/tests/toolbox/panels-in-background.js | 2 +- testing/talos/talos/tests/tabpaint/api.js | 4 ++-- testing/talos/talos/tests/tabpaint/framescript.js | 6 +++--- testing/talos/talos/tests/tabpaint/tabpaint.html | 2 +- .../tests/tabswitch/actors/TalosTabSwitchChild.sys.mjs | 2 +- .../tests/tabswitch/content/tabswitch-content-process.js | 2 +- testing/talos/talos/tests/video/video_playback.html | 2 +- .../talos/tests/webgl/benchmarks/terrain/perftest.html | 4 ++-- testing/talos/talos/webextensions/dummy/background.js | 12 ++++++------ testing/talos/talos/xtalos/etlparser.py | 6 +++--- testing/talos/talos/xtalos/xperf_analyzer.py | 4 ++-- 35 files changed, 69 insertions(+), 73 deletions(-) (limited to 'testing/talos') diff --git a/testing/talos/talos/allowlist.py b/testing/talos/talos/allowlist.py index 195d85b6e1..7ec737d927 100644 --- a/testing/talos/talos/allowlist.py +++ b/testing/talos/talos/allowlist.py @@ -85,7 +85,7 @@ class Allowlist: if len(parts) >= 2: filename = "%s%s" % (parts[0], new_name) - return filename.strip("/\\\ \t") + return filename.strip("/\\\\ \t") def check(self, test, file_name_index, event_source_index=None): errors = {} diff --git a/testing/talos/talos/bootstrap.js b/testing/talos/talos/bootstrap.js index 7acad7ea90..22749a28fb 100644 --- a/testing/talos/talos/bootstrap.js +++ b/testing/talos/talos/bootstrap.js @@ -27,7 +27,7 @@ const windowTracker = { Services.ww.registerNotification(this); }, - async observe(window, topic, data) { + async observe(window, topic) { if (topic === "domwindowopened") { await new Promise(resolve => window.addEventListener("DOMWindowCreated", resolve, { once: true }) @@ -50,13 +50,13 @@ function readSync(uri) { return new TextDecoder().decode(buffer); } -function startup(data, reason) { +function startup(data) { Services.scriptloader.loadSubScript( data.resourceURI.resolve("content/initialize_browser.js") ); windowTracker.init(); } -function shutdown(data, reason) {} -function install(data, reason) {} -function uninstall(data, reason) {} +function shutdown() {} +function install() {} +function uninstall() {} diff --git a/testing/talos/talos/pageloader/chrome/a11y.js b/testing/talos/talos/pageloader/chrome/a11y.js index 3541076ee7..981a1700ac 100644 --- a/testing/talos/talos/pageloader/chrome/a11y.js +++ b/testing/talos/talos/pageloader/chrome/a11y.js @@ -55,7 +55,7 @@ ensureAccessibleTreeForNode(node); } - addEventListener("DOMContentLoaded", e => { + addEventListener("DOMContentLoaded", () => { Cu.exportFunction(initAccessibility, content, { defineAs: "initAccessibility", }); diff --git a/testing/talos/talos/pageloader/chrome/lh_hero.js b/testing/talos/talos/pageloader/chrome/lh_hero.js index 6705b6d53c..55f28e2333 100644 --- a/testing/talos/talos/pageloader/chrome/lh_hero.js +++ b/testing/talos/talos/pageloader/chrome/lh_hero.js @@ -8,8 +8,8 @@ function _contentHeroHandler(isload) { var obs = null; var el = content.window.document.querySelector("[elementtiming]"); if (el) { - function callback(entries, observer) { - entries.forEach(entry => { + function callback(entries) { + entries.forEach(() => { sendAsyncMessage("PageLoader:LoadEvent", { time: content.window.performance.now(), name: "tphero", diff --git a/testing/talos/talos/pageloader/chrome/lh_moz.js b/testing/talos/talos/pageloader/chrome/lh_moz.js index 46d4a74a7c..8879d172e2 100644 --- a/testing/talos/talos/pageloader/chrome/lh_moz.js +++ b/testing/talos/talos/pageloader/chrome/lh_moz.js @@ -9,7 +9,7 @@ function _contentPaintHandler() { if (utils.isMozAfterPaintPending) { addEventListener( "MozAfterPaint", - function afterpaint(e) { + function afterpaint() { removeEventListener("MozAfterPaint", afterpaint, true); sendAsyncMessage("PageLoader:LoadEvent", {}); }, diff --git a/testing/talos/talos/pageloader/chrome/pageloader.js b/testing/talos/talos/pageloader/chrome/pageloader.js index 839901fb8e..6b1f89f71d 100644 --- a/testing/talos/talos/pageloader/chrome/pageloader.js +++ b/testing/talos/talos/pageloader/chrome/pageloader.js @@ -241,7 +241,7 @@ async function plInit() { // pages should be able to load in the same mode as the initial page - due // to this reinitialization on the switch. let tab = gBrowser.selectedTab; - tab.addEventListener("TabRemotenessChange", function (evt) { + tab.addEventListener("TabRemotenessChange", function () { loadFrameScripts(tab.linkedBrowser); }); loadFrameScripts(tab.linkedBrowser); @@ -300,7 +300,7 @@ function plLoadPage() { } let tab = gBrowser.selectedTab; - tab.addEventListener("TabRemotenessChange", evt => { + tab.addEventListener("TabRemotenessChange", () => { addMsgListeners(tab.linkedBrowser); }); addMsgListeners(tab.linkedBrowser); @@ -581,13 +581,10 @@ function waitForPDFPaint() { function forceContentGC() { return new Promise(resolve => { let mm = browserWindow.gBrowser.selectedBrowser.messageManager; - mm.addMessageListener( - "Talos:ForceGC:OK", - function onTalosContentForceGC(msg) { - mm.removeMessageListener("Talos:ForceGC:OK", onTalosContentForceGC); - resolve(); - } - ); + mm.addMessageListener("Talos:ForceGC:OK", function onTalosContentForceGC() { + mm.removeMessageListener("Talos:ForceGC:OK", onTalosContentForceGC); + resolve(); + }); mm.sendAsyncMessage("Talos:ForceGC"); }); } diff --git a/testing/talos/talos/pageloader/chrome/tscroll.js b/testing/talos/talos/pageloader/chrome/tscroll.js index 7f64b8c474..e354a474fb 100644 --- a/testing/talos/talos/pageloader/chrome/tscroll.js +++ b/testing/talos/talos/pageloader/chrome/tscroll.js @@ -267,7 +267,7 @@ function testScroll(target, stepSize, opt_reportFunc, opt_numSteps) { TalosPowersParent.exec("stopFrameTimeRecording", handle, cb, win); } - return new Promise(function (resolve, reject) { + return new Promise(function (resolve) { setSmooth(); var handle = -1; diff --git a/testing/talos/talos/results.py b/testing/talos/talos/results.py index 801c18a0cc..fe4ab60e52 100755 --- a/testing/talos/talos/results.py +++ b/testing/talos/talos/results.py @@ -311,7 +311,7 @@ class BrowserLogResults(object): # regular expression for responsiveness results RESULTS_RESPONSIVENESS_REGEX = re.compile( - "MOZ_EVENT_TRACE\ssample\s\d*?\s(\d*\.?\d*)$", re.DOTALL | re.MULTILINE + r"MOZ_EVENT_TRACE\ssample\s\d*?\s(\d*\.?\d*)$", re.DOTALL | re.MULTILINE ) # classes for results types diff --git a/testing/talos/talos/run_tests.py b/testing/talos/talos/run_tests.py index 8213c92897..1d3333e3a8 100755 --- a/testing/talos/talos/run_tests.py +++ b/testing/talos/talos/run_tests.py @@ -54,7 +54,9 @@ def set_tp_preferences(test, browser_config): "of cycles, please disregard reported numbers" ) for cycle_var in ["tppagecycles", "tpcycles", "cycles"]: - if test[cycle_var] > 2: + if test["name"] == "tp5o_scroll" and test[cycle_var] > 1: + test[cycle_var] = 1 + elif test[cycle_var] > 2: test[cycle_var] = 2 CLI_bool_options = [ diff --git a/testing/talos/talos/startup_test/sessionrestore/addon/api.js b/testing/talos/talos/startup_test/sessionrestore/addon/api.js index f621894623..87f0d46aee 100644 --- a/testing/talos/talos/startup_test/sessionrestore/addon/api.js +++ b/testing/talos/talos/startup_test/sessionrestore/addon/api.js @@ -28,7 +28,7 @@ this.sessionrestore = class extends ExtensionAPI { this.run(); } - observe(subject, topic, data) { + observe(subject, topic) { if (topic == "browser-idle-startup-tasks-finished") { this.promiseIdleFinished.resolve(); } diff --git a/testing/talos/talos/startup_test/startup_about_home_paint/addon/api.js b/testing/talos/talos/startup_test/startup_about_home_paint/addon/api.js index 14887aa112..9367dec45e 100644 --- a/testing/talos/talos/startup_test/startup_about_home_paint/addon/api.js +++ b/testing/talos/talos/startup_test/startup_about_home_paint/addon/api.js @@ -27,7 +27,7 @@ this.startup_about_home_paint = class extends ExtensionAPI { }); } - observe(subject, topic, data) { + observe(subject, topic) { if (topic == "browser-idle-startup-tasks-finished") { this.checkForTelemetry(); } diff --git a/testing/talos/talos/talos-powers/api.js b/testing/talos/talos/talos-powers/api.js index cb0ddaccef..c6b7611976 100644 --- a/testing/talos/talos/talos-powers/api.js +++ b/testing/talos/talos/talos-powers/api.js @@ -371,7 +371,7 @@ TalosPowersService.prototype = { }, */ ParentExecServices: { - ping(arg, callback, win) { + ping(arg, callback) { callback(); }, @@ -387,15 +387,15 @@ TalosPowersService.prototype = { callback(rv); }, - requestDumpCoverageCounters(arg, callback, win) { + requestDumpCoverageCounters(arg, callback) { PerTestCoverageUtils.afterTest().then(callback); }, - requestResetCoverageCounters(arg, callback, win) { + requestResetCoverageCounters(arg, callback) { PerTestCoverageUtils.beforeTest().then(callback); }, - dumpAboutSupport(arg, callback, win) { + dumpAboutSupport(arg, callback) { const { Troubleshoot } = ChromeUtils.importESModule( "resource://gre/modules/Troubleshoot.sys.mjs" ); diff --git a/testing/talos/talos/talos-powers/chrome/talos-powers-content.js b/testing/talos/talos/talos-powers/chrome/talos-powers-content.js index 4b7276e7a5..79e1742d1a 100644 --- a/testing/talos/talos/talos-powers/chrome/talos-powers-content.js +++ b/testing/talos/talos/talos-powers/chrome/talos-powers-content.js @@ -35,7 +35,7 @@ addMessageListener("TalosContentProfiler:Response", msg => { addEventListener( "TalosPowersContentForceCCAndGC", - e => { + () => { Cu.forceGC(); Cu.forceCC(); Cu.forceShrinkingGC(); @@ -46,7 +46,7 @@ addEventListener( addEventListener( "TalosPowersContentFocus", - e => { + () => { if ( content.location.protocol != "file:" && content.location.hostname != "localhost" && @@ -72,7 +72,7 @@ addEventListener( addEventListener( "TalosPowersContentGetStartupInfo", - e => { + () => { sendAsyncMessage("TalosPowersContent:GetStartupInfo"); addMessageListener( "TalosPowersContent:GetStartupInfo:Result", @@ -103,7 +103,7 @@ addEventListener( addEventListener( "TalosPowersContentDumpConsole", - e => { + () => { var messages; try { messages = Services.console.getMessageArray(); @@ -147,7 +147,7 @@ addEventListener( */ addEventListener( "TalosPowersWebRenderCapture", - e => { + () => { if (content && content.windowUtils) { content.windowUtils.wrCapture(); } else { diff --git a/testing/talos/talos/tests/cpstartup/extension/api.js b/testing/talos/talos/tests/cpstartup/extension/api.js index 8b5e7438ce..7a881ef66f 100644 --- a/testing/talos/talos/tests/cpstartup/extension/api.js +++ b/testing/talos/talos/tests/cpstartup/extension/api.js @@ -116,7 +116,7 @@ this.cpstartup = class extends ExtensionAPI { removeTab(tab) { return new Promise(resolve => { let browser = tab.linkedBrowser; - let observer = (subject, topic, data) => { + let observer = subject => { if (subject === browser) { Services.obs.removeObserver(observer, BROWSER_FLUSH_TOPIC); resolve(); diff --git a/testing/talos/talos/tests/cpstartup/extension/framescript.js b/testing/talos/talos/tests/cpstartup/extension/framescript.js index 972f938881..ad09e24cb1 100644 --- a/testing/talos/talos/tests/cpstartup/extension/framescript.js +++ b/testing/talos/talos/tests/cpstartup/extension/framescript.js @@ -7,7 +7,7 @@ addEventListener( "CPStartup:Ping", - e => { + () => { let evt = new content.CustomEvent("CPStartup:Pong", { bubbles: true }); content.dispatchEvent(evt); }, diff --git a/testing/talos/talos/tests/devtools/addon/content/actors/DampLoadChild.sys.mjs b/testing/talos/talos/tests/devtools/addon/content/actors/DampLoadChild.sys.mjs index 1f7db91c4b..5ef462c7f8 100644 --- a/testing/talos/talos/tests/devtools/addon/content/actors/DampLoadChild.sys.mjs +++ b/testing/talos/talos/tests/devtools/addon/content/actors/DampLoadChild.sys.mjs @@ -5,7 +5,7 @@ /* eslint-disable no-restricted-globals */ export class DampLoadChild extends JSWindowActorChild { - handleEvent(evt) { + handleEvent() { this.sendAsyncMessage("DampLoadChild:PageShow", { browsingContext: this.browsingContext, }); diff --git a/testing/talos/talos/tests/devtools/addon/content/damp-tests.js b/testing/talos/talos/tests/devtools/addon/content/damp-tests.js index 4a7a6fe78d..d55af15efd 100644 --- a/testing/talos/talos/tests/devtools/addon/content/damp-tests.js +++ b/testing/talos/talos/tests/devtools/addon/content/damp-tests.js @@ -5,6 +5,7 @@ "use strict"; const isWindows = Services.appinfo.OS === "WINNT"; +const isMacOS = Services.appinfo.OS === "Darwin"; // DAMP is split in sub-suites to run the tests faster on continuous integration. // See the initial patches in Bug 1749928 if we need to add more suites. @@ -232,6 +233,8 @@ module.exports = { { name: "browser-toolbox", path: "toolbox/browser-toolbox.js", + // Bug 1881503 - disabled toolbox/browser-toolbox on windows and mac for causing permafails + disabled: isWindows || isMacOS, }, { name: "server.protocoljs", diff --git a/testing/talos/talos/tests/devtools/addon/content/damp.js b/testing/talos/talos/tests/devtools/addon/content/damp.js index 9f710763d1..cad8c8433d 100644 --- a/testing/talos/talos/tests/devtools/addon/content/damp.js +++ b/testing/talos/talos/tests/devtools/addon/content/damp.js @@ -216,7 +216,7 @@ Damp.prototype = { return tab; }, - async testTeardown(url) { + async testTeardown() { // Disable closing animation to avoid intermittents and prevent having to wait for // animation's end. (See bug 1480953) this._win.gBrowser.removeCurrentTab({ animate: false }); diff --git a/testing/talos/talos/tests/devtools/addon/content/tests/debugger/custom.js b/testing/talos/talos/tests/devtools/addon/content/tests/debugger/custom.js index d0815bd514..3f2f8bc6e2 100644 --- a/testing/talos/talos/tests/devtools/addon/content/tests/debugger/custom.js +++ b/testing/talos/talos/tests/devtools/addon/content/tests/debugger/custom.js @@ -145,7 +145,7 @@ async function stepDebuggerAndLog(dbg, tab, testFunction) { } } -async function testProjectSearch(dbg, tab) { +async function testProjectSearch(dbg) { dump("Executing project search\n"); const test = runTest(`custom.jsdebugger.project-search.DAMP`); const firstSearchResultTest = runTest( @@ -216,7 +216,7 @@ async function testPreview(dbg, tab, testFunction) { await garbageCollect(); } -async function testOpeningLargeMinifiedFile(dbg, tab) { +async function testOpeningLargeMinifiedFile(dbg) { const fileFirstMinifiedChars = `(()=>{var e,t,n,r,o={82603`; dump("Open minified.js (large minified file)\n"); diff --git a/testing/talos/talos/tests/devtools/addon/content/tests/debugger/debugger-helpers.js b/testing/talos/talos/tests/devtools/addon/content/tests/debugger/debugger-helpers.js index ee1e52ed00..53ad52e65e 100644 --- a/testing/talos/talos/tests/devtools/addon/content/tests/debugger/debugger-helpers.js +++ b/testing/talos/talos/tests/devtools/addon/content/tests/debugger/debugger-helpers.js @@ -352,13 +352,7 @@ async function removeBreakpoints(dbg) { } exports.removeBreakpoints = removeBreakpoints; -async function pauseDebugger( - dbg, - tab, - testFunction, - { line, file }, - pauseOptions -) { +async function pauseDebugger(dbg, tab, testFunction, { line, file }) { const { getSelectedLocation, isMapScopesEnabled } = dbg.selectors; const state = dbg.store.getState(); diff --git a/testing/talos/talos/tests/devtools/addon/content/tests/head.js b/testing/talos/talos/tests/devtools/addon/content/tests/head.js index 559ca21d2d..910cbe1e30 100644 --- a/testing/talos/talos/tests/devtools/addon/content/tests/head.js +++ b/testing/talos/talos/tests/devtools/addon/content/tests/head.js @@ -114,7 +114,7 @@ function waitForDOMPredicate( return Promise.resolve(rv); } return new Promise(resolve => { - const observer = new target.ownerGlobal.MutationObserver(mutations => { + const observer = new target.ownerGlobal.MutationObserver(() => { rv = predicate(); if (rv) { resolve(rv); diff --git a/testing/talos/talos/tests/devtools/addon/content/tests/netmonitor/netmonitor-helpers.js b/testing/talos/talos/tests/devtools/addon/content/tests/netmonitor/netmonitor-helpers.js index 4b860bfd1b..f981c399f6 100644 --- a/testing/talos/talos/tests/devtools/addon/content/tests/netmonitor/netmonitor-helpers.js +++ b/testing/talos/talos/tests/devtools/addon/content/tests/netmonitor/netmonitor-helpers.js @@ -45,7 +45,7 @@ async function waitForAllRequestsFinished( let payloadReady = 0; let resolveWithLessThanMaxRequestsTimer = null; - function onPayloadReady(_, id) { + function onPayloadReady() { payloadReady++; dump(`Waiting for ${maxExpectedRequests - payloadReady} requests\n`); maybeResolve(); diff --git a/testing/talos/talos/tests/devtools/addon/content/tests/server/actor.js b/testing/talos/talos/tests/devtools/addon/content/tests/server/actor.js index 7180365c40..e27059d420 100644 --- a/testing/talos/talos/tests/devtools/addon/content/tests/server/actor.js +++ b/testing/talos/talos/tests/devtools/addon/content/tests/server/actor.js @@ -12,7 +12,7 @@ class DampTestActor extends Actor { super(conn, dampTestSpec); } - testMethod(arg, { option }, arraySize) { + testMethod(arg, { option }) { // Emit an event with second argument's option. this.emit("testEvent", option); diff --git a/testing/talos/talos/tests/devtools/addon/content/tests/server/protocol.js b/testing/talos/talos/tests/devtools/addon/content/tests/server/protocol.js index 7cbd58d9dd..8aae57618a 100644 --- a/testing/talos/talos/tests/devtools/addon/content/tests/server/protocol.js +++ b/testing/talos/talos/tests/devtools/addon/content/tests/server/protocol.js @@ -67,7 +67,7 @@ module.exports = async function () { bigObject["attribute-" + i] = bigString; } - let bigArray = Array.from({ length: ARRAY_SIZE }, (_, i) => bigObject); + let bigArray = Array.from({ length: ARRAY_SIZE }, _ => bigObject); // Open against options to avoid noise from tools let toolbox = await openToolbox("options"); diff --git a/testing/talos/talos/tests/devtools/addon/content/tests/toolbox/panels-in-background.js b/testing/talos/talos/tests/devtools/addon/content/tests/toolbox/panels-in-background.js index 852e65467b..7f27560a85 100644 --- a/testing/talos/talos/tests/devtools/addon/content/tests/toolbox/panels-in-background.js +++ b/testing/talos/talos/tests/devtools/addon/content/tests/toolbox/panels-in-background.js @@ -40,7 +40,7 @@ function waitForPayload(count, panelWin) { return new Promise(resolve => { let payloadReady = 0; - function onPayloadReady(_, id) { + function onPayloadReady() { payloadReady++; maybeResolve(); } diff --git a/testing/talos/talos/tests/tabpaint/api.js b/testing/talos/talos/tests/tabpaint/api.js index abf64c6fe4..990267bdc2 100644 --- a/testing/talos/talos/tests/tabpaint/api.js +++ b/testing/talos/talos/tests/tabpaint/api.js @@ -160,7 +160,7 @@ this.tabpaint = class extends ExtensionAPI { * Resolves once the tab has been fully removed. Resolves * with the time (in ms) it took to open the tab from content. */ - async openTabFromContent(gBrowser) { + async openTabFromContent() { TalosParentProfiler.subtestStart("TabPaint Content Start"); let start_time = Cu.now(); @@ -200,7 +200,7 @@ this.tabpaint = class extends ExtensionAPI { TalosParentProfiler.mark("Tabpaint: Remove Tab"); return new Promise(resolve => { let browser = tab.linkedBrowser; - let observer = (subject, topic, data) => { + let observer = subject => { if (subject === browser) { Services.obs.removeObserver(observer, BROWSER_FLUSH_TOPIC); resolve(); diff --git a/testing/talos/talos/tests/tabpaint/framescript.js b/testing/talos/talos/tests/tabpaint/framescript.js index 2d4d7149fc..3e209205b8 100644 --- a/testing/talos/talos/tests/tabpaint/framescript.js +++ b/testing/talos/talos/tests/tabpaint/framescript.js @@ -3,7 +3,7 @@ (function () { addEventListener( "load", - loadevt => { + () => { if (!content.location.pathname.endsWith("target.html")) { return; } @@ -62,7 +62,7 @@ addEventListener( "TabPaint:Ping", - e => { + () => { let evt = new content.CustomEvent("TabPaint:Pong", { bubbles: true }); content.dispatchEvent(evt); }, @@ -79,7 +79,7 @@ true ); - addMessageListener("TabPaint:OpenFromContent", msg => { + addMessageListener("TabPaint:OpenFromContent", () => { let evt = new content.CustomEvent("TabPaint:OpenFromContent", { bubbles: true, }); diff --git a/testing/talos/talos/tests/tabpaint/tabpaint.html b/testing/talos/talos/tests/tabpaint/tabpaint.html index 0ab7242304..b0329b5a9f 100644 --- a/testing/talos/talos/tests/tabpaint/tabpaint.html +++ b/testing/talos/talos/tests/tabpaint/tabpaint.html @@ -13,7 +13,7 @@ function init() { tpRecordTime([fromParent, fromContent].join(","), 0, "tabpaint-from-parent, tabpaint-from-content"); }, {once: true}); - window.addEventListener("TabPaint:OpenFromContent", (event) => { + window.addEventListener("TabPaint:OpenFromContent", () => { let target = document.getElementById("target"); //win.performance.now() + win.performance.timing.navigationStart gives the UNIX timestamp. diff --git a/testing/talos/talos/tests/tabswitch/actors/TalosTabSwitchChild.sys.mjs b/testing/talos/talos/tests/tabswitch/actors/TalosTabSwitchChild.sys.mjs index 5b27d677e3..bf456012f3 100644 --- a/testing/talos/talos/tests/tabswitch/actors/TalosTabSwitchChild.sys.mjs +++ b/testing/talos/talos/tests/tabswitch/actors/TalosTabSwitchChild.sys.mjs @@ -21,7 +21,7 @@ export class TalosTabSwitchChild extends RemotePageChild { super.actorCreated(); } - handleEvent(event) {} + handleEvent() {} receiveMessage(message) { if (message.name == "GarbageCollect") { diff --git a/testing/talos/talos/tests/tabswitch/content/tabswitch-content-process.js b/testing/talos/talos/tests/tabswitch/content/tabswitch-content-process.js index 53c4935953..b0cc7f47e3 100644 --- a/testing/talos/talos/tests/tabswitch/content/tabswitch-content-process.js +++ b/testing/talos/talos/tests/tabswitch/content/tabswitch-content-process.js @@ -27,7 +27,7 @@ const TPSProcessScript = { chan.originalURI = aURI; return chan; } - getURIFlags(aURI) { + getURIFlags() { return ( Ci.nsIAboutModule.ALLOW_SCRIPT | Ci.nsIAboutModule.URI_MUST_LOAD_IN_CHILD | diff --git a/testing/talos/talos/tests/video/video_playback.html b/testing/talos/talos/tests/video/video_playback.html index 99bec7c6c1..53922ba4d7 100644 --- a/testing/talos/talos/tests/video/video_playback.html +++ b/testing/talos/talos/tests/video/video_playback.html @@ -39,7 +39,7 @@ function content_focused() { runTest(); } -function fullscreen(event) { +function fullscreen() { if ((document.fullscreenElement && document.fullscreenElement !== null) || document.mozFullScreen) { startTest(); diff --git a/testing/talos/talos/tests/webgl/benchmarks/terrain/perftest.html b/testing/talos/talos/tests/webgl/benchmarks/terrain/perftest.html index a472162552..fc78c1d75c 100644 --- a/testing/talos/talos/tests/webgl/benchmarks/terrain/perftest.html +++ b/testing/talos/talos/tests/webgl/benchmarks/terrain/perftest.html @@ -188,7 +188,7 @@ const WARMUP_TIMESTAMPS = 30; // Must be at least 2 const MEASURED_FRAMES = 100; - var gDoneCallback = function placeholder(intervals) {}; + var gDoneCallback = function placeholder() {}; var gCurrentTimestamp = 0; var gResultTimestamps = []; @@ -202,7 +202,7 @@ }); } - function draw(timestamp) { + function draw() { // It's possible that under some implementations (even if not our current one), // the rAF callback arg will be in some way "optimized", e.g. always point to the // estimated next vsync timestamp, in order to allow the callee to have less diff --git a/testing/talos/talos/webextensions/dummy/background.js b/testing/talos/talos/webextensions/dummy/background.js index 1b20f85cfa..d04a71d616 100644 --- a/testing/talos/talos/webextensions/dummy/background.js +++ b/testing/talos/talos/webextensions/dummy/background.js @@ -19,7 +19,7 @@ browser.webRequest.onBeforeRequest.addListener( let filter = browser.webRequest.filterResponseData(details.requestId); - filter.onstop = event => { + filter.onstop = () => { filter.close(); }; filter.ondata = event => { @@ -48,7 +48,7 @@ browser.webRequest.onHeadersReceived.addListener( ["blocking", "responseHeaders"] ); -browser.webRequest.onErrorOccurred.addListener(details => {}, { +browser.webRequest.onErrorOccurred.addListener(() => {}, { urls: ["https://*/*", "http://*/*"], }); @@ -73,7 +73,7 @@ browser.tabs.onUpdated.addListener((tabId, changed, tab) => { }); }); -browser.tabs.onActivated.addListener(({ tabId, windowId }) => { +browser.tabs.onActivated.addListener(({ tabId }) => { browser.pageAction.show(tabId); }); @@ -81,8 +81,8 @@ browser.tabs.onCreated.addListener(tab => { browser.pageAction.show(tab.id); }); -browser.tabs.onRemoved.addListener((tabId, removeInfo) => {}); +browser.tabs.onRemoved.addListener(() => {}); -browser.tabs.onAttached.addListener((tabId, attachInfo) => {}); +browser.tabs.onAttached.addListener(() => {}); -browser.tabs.onDetached.addListener((tabId, detachInfo) => {}); +browser.tabs.onDetached.addListener(() => {}); diff --git a/testing/talos/talos/xtalos/etlparser.py b/testing/talos/talos/xtalos/etlparser.py index 5bbfa913f5..ddb14e0df8 100644 --- a/testing/talos/talos/xtalos/etlparser.py +++ b/testing/talos/talos/xtalos/etlparser.py @@ -221,7 +221,7 @@ def trackProcess(row, firstFirefoxPID): parentPID = int(row[PARENT_PID_INDEX]) if parentPID == firstFirefoxPID: proc = row[PROCESS_INDEX] - gBrowserPID = int(re.search("^.* \(\s*(\d+)\)$", proc).group(1)) + gBrowserPID = int(re.search(r"^.* \(\s*(\d+)\)$", proc).group(1)) def getBrowserPID(): @@ -232,7 +232,7 @@ def getBrowserPID(): def trackThread(row, browserPID): event, proc, tid = row[EVENTNAME_INDEX], row[PROCESS_INDEX], row[THREAD_ID_INDEX] if event in ["T-DCStart", "T-Start"]: - procName, procID = re.search("^(.*) \(\s*(\d+)\)$", proc).group(1, 2) + procName, procID = re.search(r"^(.*) \(\s*(\d+)\)$", proc).group(1, 2) if procID == str(browserPID): imgIdx = getIndex(event, IMAGEFUNC_COL) img = re.match("([^!]+)!", row[imgIdx]).group(1) @@ -267,7 +267,7 @@ def trackThreadNetIO(row, io, stage): gConnectionIDs[connID] = tid origThread = gConnectionIDs[connID] if origThread in gThreads: - match = re.match("[\w-]+\/([\w-]+)?", event) + match = re.match(r"[\w-]+\/([\w-]+)?", event) if not match: raise xtalos.XTalosError( "Could not find a regular expression match for event: {}".format(event) diff --git a/testing/talos/talos/xtalos/xperf_analyzer.py b/testing/talos/talos/xtalos/xperf_analyzer.py index 833dc9960a..e66fd5494b 100644 --- a/testing/talos/talos/xtalos/xperf_analyzer.py +++ b/testing/talos/talos/xtalos/xperf_analyzer.py @@ -671,7 +671,7 @@ class SessionStoreWindowRestored(ClassicEvent): class ProcessStart(XPerfEvent): cmd_line_index = None process_index = None - extractor = re.compile("^(.+) \(\s*(\d+)\)$") + extractor = re.compile(r"^(.+) \(\s*(\d+)\)$") def __init__(self, leafname): super(ProcessStart, self).__init__("P-Start") @@ -746,7 +746,7 @@ class ThreadStart(XPerfEvent): process_index = None tid_index = None - pid_extractor = re.compile("^.+ \(\s*(\d+)\)$") + pid_extractor = re.compile(r"^.+ \(\s*(\d+)\)$") def __init__(self): super(ThreadStart, self).__init__("T-Start") -- cgit v1.2.3