From: Andreas Pehrson Date: Fri, 19 Feb 2021 13:45:00 +0100 Subject: Bug 1654112 - libwebrtc: Add a REMB on/off switch to VideoReceiveStream. r=ng Differential Revision: https://phabricator.services.mozilla.com/D105774 Mercurial Revision: https://hg.mozilla.org/mozilla-central/rev/7330681cf4de6d8dd868cc661cbdd6679bbc07b3 --- call/video_receive_stream.h | 3 +++ video/rtp_video_stream_receiver2.cc | 3 +-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/call/video_receive_stream.h b/call/video_receive_stream.h index 95f1a47f4e..a1fc204e7c 100644 --- a/call/video_receive_stream.h +++ b/call/video_receive_stream.h @@ -210,6 +210,9 @@ class VideoReceiveStreamInterface : public MediaReceiveStreamInterface { // disabled. KeyFrameReqMethod keyframe_method = KeyFrameReqMethod::kPliRtcp; + // See draft-alvestrand-rmcat-remb for information. + bool remb = false; + bool tmmbr = false; // See LntfConfig for description. diff --git a/video/rtp_video_stream_receiver2.cc b/video/rtp_video_stream_receiver2.cc index 9a38097a93..d12e833cab 100644 --- a/video/rtp_video_stream_receiver2.cc +++ b/video/rtp_video_stream_receiver2.cc @@ -296,9 +296,8 @@ RtpVideoStreamReceiver2::RtpVideoStreamReceiver2( frames_decryptable_(false), absolute_capture_time_interpolator_(clock) { packet_sequence_checker_.Detach(); - constexpr bool remb_candidate = true; if (packet_router_) - packet_router_->AddReceiveRtpModule(rtp_rtcp_.get(), remb_candidate); + packet_router_->AddReceiveRtpModule(rtp_rtcp_.get(), config_.rtp.remb); RTC_DCHECK(config_.rtp.rtcp_mode != RtcpMode::kOff) << "A stream should not be configured with RTCP disabled. This value is "