From: Byron Campen Date: Thu, 20 Jul 2023 14:24:00 +0000 Subject: Bug 1838080: Work around a race in ChannelSendFrameTransformerDelegate. r=pehrsons,webrtc-reviewers This variable can be null when a ChannelSendFrameTransformerDelegate is in use, because that does an async dispatch to the encoder queue in the handling for transformed frames. If this is unset while that dispatch is in flight, we nullptr crash. Differential Revision: https://phabricator.services.mozilla.com/D180735 Mercurial Revision: https://hg.mozilla.org/mozilla-central/rev/56555ecee7f36ae73abff1cbbd06807c2b65fc19 --- audio/channel_send.cc | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/audio/channel_send.cc b/audio/channel_send.cc index b8aa573a53..ae264a4c77 100644 --- a/audio/channel_send.cc +++ b/audio/channel_send.cc @@ -285,12 +285,16 @@ class RtpPacketSenderProxy : public RtpPacketSender { void EnqueuePackets( std::vector> packets) override { MutexLock lock(&mutex_); - rtp_packet_pacer_->EnqueuePackets(std::move(packets)); + if (rtp_packet_pacer_) { + rtp_packet_pacer_->EnqueuePackets(std::move(packets)); + } } void RemovePacketsForSsrc(uint32_t ssrc) override { MutexLock lock(&mutex_); - rtp_packet_pacer_->RemovePacketsForSsrc(ssrc); + if (rtp_packet_pacer_) { + rtp_packet_pacer_->RemovePacketsForSsrc(ssrc); + } } private: