1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
|
Getting reviews
===============
Thorough code reviews are one of Mozilla's ways of ensuring code quality.
Every patch must be reviewed by the module owner of the code, or one of their designated peers.
To request a review, you will need to specify a review group (starts with #). If there is not, you should select one or more usernames either when you submit the patch, or afterward in the UI.
If you have a mentor, the mentor can usually either also review or find a suitable reviewer on your behalf.
For example, the syntax to request review from a group should be:
.. code-block::
Bug xxxx - explain what you are doing and why r?#group-name
or
Bug xxxx - explain what you are doing and why r?developer-nickname
Getting attention: If a reviewer doesn't respond within a week, or so of the review request:
* Contact the reviewer directly (either via e-mail or on Matrix).
* Join developers on `Mozilla's Matrix server <https://chat.mozilla.org>`_, and ask if anyone knows why a review may be delayed. Please link to the bug too.
* If the review is still not addressed, mail the reviewer directly, asking if/when they'll have time to review the patch, or might otherwise be able to review it.
For simple documentation changes, reviews are not required.
For more information about the review process, see the :ref:`Code Review FAQ`.
Review groups
-------------
.. list-table::
:header-rows: 1
* - Name
- Owns
- Members
* - #anti-tracking
- `Core: Anti-Tracking </mots/index.html#core-anti-tracking>`__
- `Member list <https://phabricator.services.mozilla.com/project/members/157/>`__
* - #build or #firefox-build-system-reviewers
- The configure & build system
- `Member list <https://phabricator.services.mozilla.com/project/members/20/>`__
* - #cookies
- `Core: Cookies </mots/index.html#core-cookies>`__
- `Member list <https://phabricator.services.mozilla.com/project/members/177/>`__
* - #desktop-theme-reviewers
- User interface CSS
- `Member list <https://phabricator.services.mozilla.com/project/members/141/>`__
* - #devtools-reviewers
- Firefox DevTools
- `Member list <https://phabricator.services.mozilla.com/project/members/153/>`__
* - #dom-workers-and-storage-reviewers
- DOM Workers & Storage
- `Member list <https://phabricator.services.mozilla.com/project/members/115/>`__
* - #fluent-reviewers
- Changes to Fluent (FTL) files (translation).
- `Member list <https://phabricator.services.mozilla.com/project/members/105/>`__
* - #firefox-source-docs-reviewers
- Documentation files and its build
- `Member list <https://phabricator.services.mozilla.com/project/members/118/>`__
* - #firefox-ux-team
- User experience (UX)
- `Member list <https://phabricator.services.mozilla.com/project/members/91/>`__
* - #firefox-svg-reviewers
- SVG-related changes
- `Member list <https://phabricator.services.mozilla.com/project/members/97/>`__
* - #geckoview-reviewers
- Changes to GeckoView
- `Member list <https://phabricator.services.mozilla.com/project/members/92/>`__
* - #gfx-reviewers
- Changes to Graphics code
- `Member list <https://phabricator.services.mozilla.com/project/members/122/>`__
* - #webgpu-reviewers
- Changes to WebGPU code
- `Member list <https://phabricator.services.mozilla.com/project/members/170/>`__
* - #intermittent-reviewers
- Test manifest changes
- `Member list <https://phabricator.services.mozilla.com/project/members/110/>`__
* - #layout-reviewers
- Layout changes.
- `Member list <https://phabricator.services.mozilla.com/project/members/126/>`__
* - #linter-reviewers
- tools/lint/*
- `Member list <https://phabricator.services.mozilla.com/project/members/119/>`__
* - #mac-reviewers
- Changes to Mac-specific code
- `Member list <https://phabricator.services.mozilla.com/project/members/149/>`__
* - #mozbase
- Changes to Mozbase
- `Member list <https://phabricator.services.mozilla.com/project/members/113/>`__
* - #mozbase-rust
- Changes to Mozbase in Rust
- `Member list <https://phabricator.services.mozilla.com/project/members/114/>`__
* - #necko-reviewers
- Changes to network code (aka necko, aka netwerk)
- `Member list <https://phabricator.services.mozilla.com/project/members/127/>`__
* - #nss-reviewers
- Changes to Network Security Services (NSS)
- `Member list <https://phabricator.services.mozilla.com/project/members/156/>`__
* - #perftest-reviewers
- Perf Tests
- `Member list <https://phabricator.services.mozilla.com/project/members/102/>`__
* - #permissions or #permissions-reviewers
- `Permissions </mots/index.html#core-permissions>`__
- `Member list <https://phabricator.services.mozilla.com/project/members/158/>`__
* - #places-reviewers
- `Bookmarks & History (Places) </mots/index.html#bookmarks-history>`__
- `Member list <https://phabricator.services.mozilla.com/project/members/186/>`__
* - #platform-i18n-reviewers
- Platform Internationalization
- `Member list <https://phabricator.services.mozilla.com/project/members/150/>`__
* - #preferences-reviewers
- Firefox for Desktop Preferences (Options) user interface
- `Member list <https://phabricator.services.mozilla.com/project/members/132/>`__
* - #remote-debugging-reviewers
- Remote Debugging UI & tools
- `Member list <https://phabricator.services.mozilla.com/project/members/108/>`__
* - #search-reviewers
- Search Reviewers (search parts of `Search and Address Bar </mots/index.html#search-and-address-bar>`__)
- `Member list <https://phabricator.services.mozilla.com/project/members/169/>`__
* - #spidermonkey-reviewers
- SpiderMonkey JS/Wasm Engine
- `Member list <https://phabricator.services.mozilla.com/project/members/173/>`__
* - #static-analysis-reviewers
- Changes related to Static Analysis
- `Member list <https://phabricator.services.mozilla.com/project/members/120/>`__
* - #style or #firefox-style-system-reviewers
- Firefox style system (servo, layout/style).
- `Member list <https://phabricator.services.mozilla.com/project/members/90/>`__
* - #webcompat-reviewers
- System addons maintained by the Web Compatibility team
- `Member list <https://phabricator.services.mozilla.com/project/members/124/>`__
* - #webdriver-reviewers
- Marionette and geckodriver (including MozBase Rust), and Remote Protocol with WebDriver BiDi, and CDP.
- `Member list <https://phabricator.services.mozilla.com/project/members/103/>`__
* - #webidl
- Changes related to WebIDL
- `Member list <https://phabricator.services.mozilla.com/project/members/112/>`__
* - #xpcom-reviewers
- Changes related to XPCOM
- `Member list <https://phabricator.services.mozilla.com/project/members/125/>`__
* - #media-playback-reviewers
- `Media playback <https://wiki.mozilla.org/Modules/All#Media_Playback>`__
- `Member list <https://phabricator.services.mozilla.com/project/profile/159/>`__
* - #cubeb-reviewers
- Changes related to cubeb, Gecko's audio input/output library and associated projects (audioipc, cubeb-rs, rust cubeb backends)
- `Member list <https://phabricator.services.mozilla.com/project/profile/129/>`__
To create a new group, fill a `new bug in Conduit::Administration <https://bugzilla.mozilla.org/enter_bug.cgi?product=Conduit&component=Administration>`__.
See `bug 1613306 <https://bugzilla.mozilla.org/show_bug.cgi?id=1613306>`__ as example.
|
