1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
|
import {
range,
reorder,
ReorderOrder,
kReorderOrderKeys,
assert,
} from '../../../../../common/util/util.js';
import { GPUConst } from '../../../../constants.js';
import {
kMaximumLimitBaseParams,
makeLimitTestGroup,
kBindGroupTests,
getPerStageWGSLForBindingCombinationStorageTextures,
getPipelineTypeForBindingCombination,
BindingCombination,
LimitsRequest,
} from './limit_utils.js';
const kExtraLimits: LimitsRequest = {
maxBindingsPerBindGroup: 'adapterLimit',
maxBindGroups: 'adapterLimit',
};
const limit = 'maxStorageTexturesPerShaderStage';
export const { g, description } = makeLimitTestGroup(limit);
function createBindGroupLayout(
device: GPUDevice,
visibility: number,
order: ReorderOrder,
numBindings: number
) {
return device.createBindGroupLayout({
entries: reorder(
order,
range(numBindings, i => ({
binding: i,
visibility,
storageTexture: { format: 'rgba8unorm' },
}))
),
});
}
g.test('createBindGroupLayout,at_over')
.desc(
`
Test using at and over ${limit} limit in createBindGroupLayout
Note: We also test order to make sure the implementation isn't just looking
at just the last entry.
`
)
.params(
kMaximumLimitBaseParams
.combine('visibility', [
GPUConst.ShaderStage.FRAGMENT,
GPUConst.ShaderStage.COMPUTE,
GPUConst.ShaderStage.FRAGMENT | GPUConst.ShaderStage.COMPUTE,
])
.combine('order', kReorderOrderKeys)
)
.fn(async t => {
const { limitTest, testValueName, visibility, order } = t.params;
await t.testDeviceWithRequestedMaximumLimits(
limitTest,
testValueName,
async ({ device, testValue, shouldError }) => {
t.skipIf(
t.adapter.limits.maxBindingsPerBindGroup < testValue,
`maxBindingsPerBindGroup = ${t.adapter.limits.maxBindingsPerBindGroup} which is less than ${testValue}`
);
await t.expectValidationError(
() => createBindGroupLayout(device, visibility, order, testValue),
shouldError
);
},
kExtraLimits
);
});
g.test('createPipelineLayout,at_over')
.desc(
`
Test using at and over ${limit} limit in createPipelineLayout
Note: We also test order to make sure the implementation isn't just looking
at just the last entry.
`
)
.params(
kMaximumLimitBaseParams
.combine('visibility', [
GPUConst.ShaderStage.FRAGMENT,
GPUConst.ShaderStage.COMPUTE,
GPUConst.ShaderStage.FRAGMENT | GPUConst.ShaderStage.COMPUTE,
])
.combine('order', kReorderOrderKeys)
)
.fn(async t => {
const { limitTest, testValueName, visibility, order } = t.params;
await t.testDeviceWithRequestedMaximumLimits(
limitTest,
testValueName,
async ({ device, testValue, shouldError, actualLimit }) => {
const maxBindingsPerBindGroup = Math.min(
t.device.limits.maxBindingsPerBindGroup,
actualLimit
);
const kNumGroups = Math.ceil(testValue / maxBindingsPerBindGroup);
// Not sure what to do in this case but best we get notified if it happens.
assert(kNumGroups <= t.device.limits.maxBindGroups);
const bindGroupLayouts = range(kNumGroups, i => {
const numInGroup = Math.min(
testValue - i * maxBindingsPerBindGroup,
maxBindingsPerBindGroup
);
return createBindGroupLayout(device, visibility, order, numInGroup);
});
await t.expectValidationError(
() => device.createPipelineLayout({ bindGroupLayouts }),
shouldError
);
},
kExtraLimits
);
});
g.test('createPipeline,at_over')
.desc(
`
Test using createRenderPipeline(Async) and createComputePipeline(Async) at and over ${limit} limit
Note: We also test order to make sure the implementation isn't just looking
at just the last entry.
`
)
.params(
kMaximumLimitBaseParams
.combine('async', [false, true] as const)
.combine('bindingCombination', ['fragment', 'compute'] as BindingCombination[])
.combine('order', kReorderOrderKeys)
.combine('bindGroupTest', kBindGroupTests)
)
.fn(async t => {
const { limitTest, testValueName, async, bindingCombination, order, bindGroupTest } = t.params;
const pipelineType = getPipelineTypeForBindingCombination(bindingCombination);
await t.testDeviceWithRequestedMaximumLimits(
limitTest,
testValueName,
async ({ device, testValue, actualLimit, shouldError }) => {
t.skipIf(
bindGroupTest === 'sameGroup' && testValue > device.limits.maxBindingsPerBindGroup,
`can not test ${testValue} bindings in same group because maxBindingsPerBindGroup = ${device.limits.maxBindingsPerBindGroup}`
);
if (bindingCombination === 'fragment') {
return;
}
const code = getPerStageWGSLForBindingCombinationStorageTextures(
bindingCombination,
order,
bindGroupTest,
(i, j) => `var u${j}_${i}: texture_storage_2d<rgba8unorm, write>`,
(i, j) => `textureStore(u${j}_${i}, vec2u(0), vec4f(1));`,
device.limits.maxBindGroups,
testValue
);
const module = device.createShaderModule({ code });
await t.testCreatePipeline(
pipelineType,
async,
module,
shouldError,
`actualLimit: ${actualLimit}, testValue: ${testValue}\n:${code}`
);
},
kExtraLimits
);
});
|
