1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
|
const builtin = 'extractBits';
export const description = `
Validation tests for the ${builtin}() builtin.
`;
import { makeTestGroup } from '../../../../../../common/framework/test_group.js';
import { keysOf, objectsToRecord } from '../../../../../../common/util/data_tables.js';
import {
Type,
kConcreteIntegerScalarsAndVectors,
kFloatScalarsAndVectors,
u32,
} from '../../../../../util/conversion.js';
import { ShaderValidationTest } from '../../../shader_validation_test.js';
import {
fullRangeForType,
kConstantAndOverrideStages,
stageSupportsType,
validateConstOrOverrideBuiltinEval,
} from './const_override_validation.js';
export const g = makeTestGroup(ShaderValidationTest);
const kValuesTypes = objectsToRecord(kConcreteIntegerScalarsAndVectors);
g.test('values')
.desc(
`
Validates that constant evaluation and override evaluation of ${builtin}() never errors on valid inputs
`
)
.params(u =>
u
.combine('stage', kConstantAndOverrideStages)
.combine('type', keysOf(kValuesTypes))
.filter(u => stageSupportsType(u.stage, kValuesTypes[u.type]))
.beginSubcases()
.expand('value', u => fullRangeForType(kValuesTypes[u.type]))
.combineWithParams([
{ offset: 0, count: 0 },
{ offset: 0, count: 31 },
{ offset: 0, count: 32 },
{ offset: 4, count: 0 },
{ offset: 4, count: 27 },
{ offset: 4, count: 28 },
{ offset: 16, count: 0 },
{ offset: 16, count: 15 },
{ offset: 16, count: 16 },
{ offset: 32, count: 0 },
] as const)
)
.fn(t => {
const expectedResult = true; // extractBits() should never error
validateConstOrOverrideBuiltinEval(
t,
builtin,
expectedResult,
[
kValuesTypes[t.params.type].create(t.params.value),
u32(t.params.offset),
u32(t.params.count),
],
t.params.stage
);
});
g.test('count_offset')
.desc(
`
Validates that count and offset must be smaller than the size of the primitive.
`
)
.params(u =>
u
.combine('stage', kConstantAndOverrideStages)
.beginSubcases()
.combineWithParams([
// offset + count < 32
{ offset: 0, count: 31 },
{ offset: 1, count: 30 },
{ offset: 31, count: 0 },
{ offset: 30, count: 1 },
// offset + count == 32
{ offset: 0, count: 32 },
{ offset: 1, count: 31 },
{ offset: 16, count: 16 },
{ offset: 31, count: 1 },
{ offset: 32, count: 0 },
// offset + count > 32
{ offset: 2, count: 31 },
{ offset: 31, count: 2 },
// offset > 32
{ offset: 33, count: 0 },
{ offset: 33, count: 1 },
// count > 32
{ offset: 0, count: 33 },
{ offset: 1, count: 33 },
] as const)
)
.fn(t => {
validateConstOrOverrideBuiltinEval(
t,
builtin,
/* expectedResult */ t.params.offset + t.params.count <= 32,
[u32(1), u32(t.params.offset), u32(t.params.count)],
t.params.stage
);
});
interface Argument {
/** Argument as a string. */
readonly arg: string;
/** Is this a valid argument type. Note that all args must be valid for the call to be valid. */
readonly pass: boolean;
/** Additional setup code necessary for this arg in the function scope. */
readonly preamble?: string;
}
function typesToArguments(types: readonly Type[], pass: boolean): Record<string, Argument> {
return types.reduce(
(res, type) => ({
...res,
[type.toString()]: { arg: type.create(0).wgsl(), pass },
}),
{}
);
}
// u32 is included here to confirm that validation is failing due to a type issue and not something else.
const kInputArgTypes: { readonly [name: string]: Argument } = {
...typesToArguments([Type.u32], true),
...typesToArguments([...kFloatScalarsAndVectors, Type.bool, Type.mat2x2f], false),
alias: { arg: 'u32_alias(1)', pass: true },
vec_bool: { arg: 'vec2<bool>(false,true)', pass: false },
atomic: { arg: 'a', pass: false },
array: {
preamble: 'var arry: array<u32, 5>;',
arg: 'arry',
pass: false,
},
array_runtime: { arg: 'k.arry', pass: false },
struct: {
preamble: 'var x: A;',
arg: 'x',
pass: false,
},
enumerant: { arg: 'read_write', pass: false },
ptr: {
preamble: `var<function> f = 1u;
let p: ptr<function, u32> = &f;`,
arg: 'p',
pass: false,
},
ptr_deref: {
preamble: `var<function> f = 1u;
let p: ptr<function, u32> = &f;`,
arg: '*p',
pass: true,
},
sampler: { arg: 's', pass: false },
texture: { arg: 't', pass: false },
};
g.test('typed_arguments')
.desc(
`
Test compilation validation of ${builtin} with variously typed arguments
- For failing input types, just use the same type for offset and count to reduce combinations.
`
)
.params(u =>
u
.combine('input', keysOf(kInputArgTypes))
.beginSubcases()
.combine('offset', keysOf(kInputArgTypes))
.expand('count', u => (kInputArgTypes[u.input].pass ? keysOf(kInputArgTypes) : [u.offset]))
)
.fn(t => {
const input = kInputArgTypes[t.params.input];
const offset = kInputArgTypes[t.params.offset];
const count = kInputArgTypes[t.params.count];
t.expectCompileResult(
input.pass && offset.pass && count.pass,
`alias u32_alias = u32;
@group(0) @binding(0) var s: sampler;
@group(0) @binding(1) var t: texture_2d<f32>;
var<workgroup> a: atomic<u32>;
struct A {
i: u32,
}
struct B {
arry: array<u32>,
}
@group(0) @binding(3) var<storage> k: B;
@vertex
fn main() -> @builtin(position) vec4<f32> {
${input.preamble ? input.preamble : ''}
${offset.preamble && offset !== input ? offset.preamble : ''}
${count.preamble && count !== input && count !== offset ? count.preamble : ''}
_ = ${builtin}(${input.arg},${offset.arg},${count.arg});
return vec4<f32>(.4, .2, .3, .1);
}`
);
});
g.test('must_use')
.desc(`Result of ${builtin} must be used`)
.params(u => u.combine('use', [true, false]))
.fn(t => {
const use_it = t.params.use ? '_ = ' : '';
t.expectCompileResult(t.params.use, `fn f() { ${use_it}${builtin}(1u,0u,1u); }`);
});
|
