1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
|
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*-
* vim: set ts=8 sts=2 et sw=2 tw=80:
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "gc/ParallelMarking.h"
#include "gc/GCLock.h"
#include "gc/ParallelWork.h"
#include "vm/GeckoProfiler.h"
#include "vm/HelperThreadState.h"
#include "vm/Runtime.h"
using namespace js;
using namespace js::gc;
using mozilla::Maybe;
using mozilla::TimeDuration;
using mozilla::TimeStamp;
class AutoAddTimeDuration {
TimeStamp start;
TimeDuration& result;
public:
explicit AutoAddTimeDuration(TimeDuration& result)
: start(TimeStamp::Now()), result(result) {}
~AutoAddTimeDuration() { result += TimeSince(start); }
};
ParallelMarker::ParallelMarker(GCRuntime* gc) : gc(gc) {}
size_t ParallelMarker::workerCount() const { return gc->markers.length(); }
bool ParallelMarker::mark(SliceBudget& sliceBudget) {
MOZ_ASSERT(workerCount() <= gc->getMaxParallelThreads());
if (markOneColor(MarkColor::Black, sliceBudget) == NotFinished) {
return false;
}
MOZ_ASSERT(!hasWork(MarkColor::Black));
if (markOneColor(MarkColor::Gray, sliceBudget) == NotFinished) {
return false;
}
MOZ_ASSERT(!hasWork(MarkColor::Gray));
// Handle any delayed marking, which is not performed in parallel.
if (gc->hasDelayedMarking()) {
gc->markAllDelayedChildren(ReportMarkTime);
}
return true;
}
bool ParallelMarker::markOneColor(MarkColor color, SliceBudget& sliceBudget) {
// Run a marking slice and return whether the stack is now empty.
if (!hasWork(color)) {
return true;
}
gcstats::AutoPhase ap(gc->stats(), gcstats::PhaseKind::PARALLEL_MARK);
MOZ_ASSERT(workerCount() <= MaxParallelWorkers);
mozilla::Maybe<ParallelMarkTask> tasks[MaxParallelWorkers];
for (size_t i = 0; i < workerCount(); i++) {
GCMarker* marker = gc->markers[i].get();
tasks[i].emplace(this, marker, color, sliceBudget);
// Attempt to populate empty mark stacks.
//
// TODO: When tuning for more than two markers we may need to adopt a more
// sophisticated approach.
if (!marker->hasEntriesForCurrentColor() && gc->marker().canDonateWork()) {
GCMarker::moveWork(marker, &gc->marker());
}
}
AutoLockHelperThreadState lock;
// There should always be enough parallel tasks to run our marking work.
MOZ_RELEASE_ASSERT(gc->maxParallelThreads >= workerCount());
MOZ_ASSERT(activeTasks == 0);
for (size_t i = 0; i < workerCount(); i++) {
ParallelMarkTask& task = *tasks[i];
if (task.hasWork()) {
incActiveTasks(&task, lock);
}
gc->startTask(task, lock);
}
for (size_t i = 0; i < workerCount(); i++) {
gc->joinTask(*tasks[i], lock);
}
#ifdef DEBUG
MOZ_ASSERT(waitingTasks.ref().isEmpty());
MOZ_ASSERT(waitingTaskCount == 0);
MOZ_ASSERT(activeTasks == 0);
#endif
return !hasWork(color);
}
bool ParallelMarker::hasWork(MarkColor color) const {
for (const auto& marker : gc->markers) {
if (marker->hasEntries(color)) {
return true;
}
}
return false;
}
ParallelMarkTask::ParallelMarkTask(ParallelMarker* pm, GCMarker* marker,
MarkColor color, const SliceBudget& budget)
: GCParallelTask(pm->gc, gcstats::PhaseKind::PARALLEL_MARK, GCUse::Marking),
pm(pm),
marker(marker),
color(*marker, color),
budget(budget) {
marker->enterParallelMarkingMode(pm);
}
ParallelMarkTask::~ParallelMarkTask() {
MOZ_ASSERT(!isWaiting.refNoCheck());
marker->leaveParallelMarkingMode();
}
bool ParallelMarkTask::hasWork() const {
return marker->hasEntriesForCurrentColor();
}
void ParallelMarkTask::recordDuration() {
// Record times separately to avoid double counting when these are summed.
gc->stats().recordParallelPhase(gcstats::PhaseKind::PARALLEL_MARK_MARK,
markTime.ref());
gc->stats().recordParallelPhase(gcstats::PhaseKind::PARALLEL_MARK_WAIT,
waitTime.ref());
TimeDuration other = duration() - markTime.ref() - waitTime.ref();
if (other < TimeDuration::Zero()) {
other = TimeDuration::Zero();
}
gc->stats().recordParallelPhase(gcstats::PhaseKind::PARALLEL_MARK_OTHER,
other);
}
void ParallelMarkTask::run(AutoLockHelperThreadState& lock) {
for (;;) {
if (hasWork()) {
if (!tryMarking(lock)) {
return;
}
} else {
if (!requestWork(lock)) {
return;
}
}
}
MOZ_ASSERT(!isWaiting);
}
bool ParallelMarkTask::tryMarking(AutoLockHelperThreadState& lock) {
MOZ_ASSERT(hasWork());
MOZ_ASSERT(marker->isParallelMarking());
// Mark until budget exceeded or we run out of work.
bool finished;
{
AutoUnlockHelperThreadState unlock(lock);
AutoAddTimeDuration time(markTime.ref());
finished = marker->markCurrentColorInParallel(budget);
}
MOZ_ASSERT_IF(finished, !hasWork());
pm->decActiveTasks(this, lock);
return finished;
}
bool ParallelMarkTask::requestWork(AutoLockHelperThreadState& lock) {
MOZ_ASSERT(!hasWork());
if (!pm->hasActiveTasks(lock)) {
return false; // All other tasks are empty. We're finished.
}
budget.forceCheck();
if (budget.isOverBudget()) {
return false; // Over budget or interrupted.
}
// Add ourselves to the waiting list and wait for another task to give us
// work. The task with work calls ParallelMarker::donateWorkFrom.
waitUntilResumed(lock);
return true;
}
void ParallelMarkTask::waitUntilResumed(AutoLockHelperThreadState& lock) {
GeckoProfilerRuntime& profiler = gc->rt->geckoProfiler();
if (profiler.enabled()) {
profiler.markEvent("Parallel marking wait start", "");
}
pm->addTaskToWaitingList(this, lock);
// Set isWaiting flag and wait for another thread to clear it and resume us.
MOZ_ASSERT(!isWaiting);
isWaiting = true;
AutoAddTimeDuration time(waitTime.ref());
do {
MOZ_ASSERT(pm->hasActiveTasks(lock));
resumed.wait(lock);
} while (isWaiting);
MOZ_ASSERT(!pm->isTaskInWaitingList(this, lock));
if (profiler.enabled()) {
profiler.markEvent("Parallel marking wait end", "");
}
}
void ParallelMarkTask::resume() {
{
AutoLockHelperThreadState lock;
MOZ_ASSERT(isWaiting);
isWaiting = false;
// Increment the active task count before donateWorkFrom() returns so this
// can't reach zero before the waiting task runs again.
if (hasWork()) {
pm->incActiveTasks(this, lock);
}
}
resumed.notify_all();
}
void ParallelMarkTask::resumeOnFinish(const AutoLockHelperThreadState& lock) {
MOZ_ASSERT(isWaiting);
MOZ_ASSERT(!hasWork());
isWaiting = false;
resumed.notify_all();
}
void ParallelMarker::addTaskToWaitingList(
ParallelMarkTask* task, const AutoLockHelperThreadState& lock) {
MOZ_ASSERT(!task->hasWork());
MOZ_ASSERT(hasActiveTasks(lock));
MOZ_ASSERT(!isTaskInWaitingList(task, lock));
MOZ_ASSERT(waitingTaskCount < workerCount() - 1);
waitingTasks.ref().pushBack(task);
waitingTaskCount++;
}
#ifdef DEBUG
bool ParallelMarker::isTaskInWaitingList(
const ParallelMarkTask* task, const AutoLockHelperThreadState& lock) const {
// The const cast is because ElementProbablyInList is not const.
return const_cast<ParallelMarkTaskList&>(waitingTasks.ref())
.ElementProbablyInList(const_cast<ParallelMarkTask*>(task));
}
#endif
void ParallelMarker::incActiveTasks(ParallelMarkTask* task,
const AutoLockHelperThreadState& lock) {
MOZ_ASSERT(task->hasWork());
MOZ_ASSERT(activeTasks < workerCount());
activeTasks++;
}
void ParallelMarker::decActiveTasks(ParallelMarkTask* task,
const AutoLockHelperThreadState& lock) {
MOZ_ASSERT(activeTasks != 0);
activeTasks--;
if (activeTasks == 0) {
while (!waitingTasks.ref().isEmpty()) {
ParallelMarkTask* task = waitingTasks.ref().popFront();
MOZ_ASSERT(waitingTaskCount != 0);
waitingTaskCount--;
task->resumeOnFinish(lock);
}
}
}
void ParallelMarker::donateWorkFrom(GCMarker* src) {
if (!gHelperThreadLock.tryLock()) {
return;
}
// Check there are tasks waiting for work while holding the lock.
if (waitingTaskCount == 0) {
gHelperThreadLock.unlock();
return;
}
// Take the first waiting task off the list.
ParallelMarkTask* waitingTask = waitingTasks.ref().popFront();
waitingTaskCount--;
// |task| is not running so it's safe to move work to it.
MOZ_ASSERT(waitingTask->isWaiting);
gHelperThreadLock.unlock();
// Move some work from this thread's mark stack to the waiting task.
MOZ_ASSERT(!waitingTask->hasWork());
GCMarker::moveWork(waitingTask->marker, src);
gc->stats().count(gcstats::COUNT_PARALLEL_MARK_INTERRUPTIONS);
GeckoProfilerRuntime& profiler = gc->rt->geckoProfiler();
if (profiler.enabled()) {
profiler.markEvent("Parallel marking donated work", "");
}
// Resume waiting task.
waitingTask->resume();
}
|