1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
|
add_task(async function invalid_input_rejects() {
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(),
/Should be provided a valid tree object./
);
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(null),
/Should be provided a valid tree object./
);
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree("foo"),
/Should be provided a valid tree object./
);
// All subsequent tests pass a valid parent guid.
let guid = PlacesUtils.bookmarks.unfiledGuid;
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree({ guid, children: [] }),
/Should have a non-zero number of children to insert./
);
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree({ guid }),
/Should have a non-zero number of children to insert./
);
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree({ children: [{}], guid }),
/The following properties were expected: url/
);
// Reuse another variable to make this easier to read:
let tree = { guid, children: [{ guid: "test" }] };
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(tree),
/Invalid value for property 'guid'/
);
tree.children = [{ guid: null }];
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(tree),
/Invalid value for property 'guid'/
);
tree.children = [{ guid: 123 }];
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(tree),
/Invalid value for property 'guid'/
);
tree.children = [{ dateAdded: -10 }];
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(tree),
/Invalid value for property 'dateAdded'/
);
tree.children = [{ dateAdded: "today" }];
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(tree),
/Invalid value for property 'dateAdded'/
);
tree.children = [{ dateAdded: Date.now() }];
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(tree),
/Invalid value for property 'dateAdded'/
);
tree.children = [{ dateAdded: new Date(NaN) }];
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(tree),
/Invalid value for property 'dateAdded'/
);
tree.children = [{ lastModified: -10 }];
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(tree),
/Invalid value for property 'lastModified'/
);
tree.children = [{ lastModified: "today" }];
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(tree),
/Invalid value for property 'lastModified'/
);
tree.children = [{ lastModified: Date.now() }];
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(tree),
/Invalid value for property 'lastModified'/
);
let time = Date.now();
let future = new Date(time + 86400000);
tree.children = [{ dateAdded: future, lastModified: time }];
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(tree),
/Invalid value for property 'dateAdded'/
);
let past = new Date(time - 86400000);
tree.children = [{ lastModified: past }];
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(tree),
/Invalid value for property 'lastModified'/
);
tree.children = [{ type: -1 }];
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(tree),
/Invalid value for property 'type'/
);
tree.children = [{ type: 100 }];
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(tree),
/Invalid value for property 'type'/
);
tree.children = [{ type: "bookmark" }];
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(tree),
/Invalid value for property 'type'/
);
tree.children = [{ type: PlacesUtils.bookmarks.TYPE_BOOKMARK, title: -1 }];
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(tree),
/Invalid value for property 'title'/
);
tree.children = [{ type: PlacesUtils.bookmarks.TYPE_BOOKMARK, url: 10 }];
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(tree),
/Invalid value for property 'url'/
);
let treeWithBrokenURL = {
children: [
{ type: PlacesUtils.bookmarks.TYPE_BOOKMARK, url: "http://te st" },
],
guid: PlacesUtils.bookmarks.unfiledGuid,
};
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(treeWithBrokenURL),
/Invalid value for property 'url'/
);
let longurl = "http://www.example.com/" + "a".repeat(65536);
let treeWithLongURL = {
children: [{ type: PlacesUtils.bookmarks.TYPE_BOOKMARK, url: longurl }],
guid: PlacesUtils.bookmarks.unfiledGuid,
};
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(treeWithLongURL),
/Invalid value for property 'url'/
);
let treeWithLongURI = {
children: [
{
type: PlacesUtils.bookmarks.TYPE_BOOKMARK,
url: NetUtil.newURI(longurl),
},
],
guid: PlacesUtils.bookmarks.unfiledGuid,
};
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(treeWithLongURI),
/Invalid value for property 'url'/
);
let treeWithOtherBrokenURL = {
children: [{ type: PlacesUtils.bookmarks.TYPE_BOOKMARK, url: "te st" }],
guid: PlacesUtils.bookmarks.unfiledGuid,
};
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(treeWithOtherBrokenURL),
/Invalid value for property 'url'/
);
});
add_task(async function invalid_properties_for_bookmark_type() {
let folderWithURL = {
children: [
{ type: PlacesUtils.bookmarks.TYPE_FOLDER, url: "http://www.moz.com/" },
],
guid: PlacesUtils.bookmarks.unfiledGuid,
};
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(folderWithURL),
/Invalid value for property 'url'/
);
let separatorWithURL = {
children: [
{
type: PlacesUtils.bookmarks.TYPE_SEPARATOR,
url: "http://www.moz.com/",
},
],
guid: PlacesUtils.bookmarks.unfiledGuid,
};
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(separatorWithURL),
/Invalid value for property 'url'/
);
let separatorWithTitle = {
children: [{ type: PlacesUtils.bookmarks.TYPE_SEPARATOR, title: "test" }],
guid: PlacesUtils.bookmarks.unfiledGuid,
};
await Assert.throws(
() => PlacesUtils.bookmarks.insertTree(separatorWithTitle),
/Invalid value for property 'title'/
);
});
add_task(async function create_separator() {
let [bm] = await PlacesUtils.bookmarks.insertTree({
children: [
{
type: PlacesUtils.bookmarks.TYPE_SEPARATOR,
},
],
guid: PlacesUtils.bookmarks.unfiledGuid,
});
checkBookmarkObject(bm);
Assert.equal(bm.parentGuid, PlacesUtils.bookmarks.unfiledGuid);
Assert.equal(bm.index, 0);
Assert.equal(bm.dateAdded, bm.lastModified);
Assert.equal(bm.type, PlacesUtils.bookmarks.TYPE_SEPARATOR);
Assert.strictEqual(bm.title, "");
});
add_task(async function create_plain_bm() {
let [bm] = await PlacesUtils.bookmarks.insertTree({
children: [
{
url: "http://www.example.com/",
title: "Test",
},
],
guid: PlacesUtils.bookmarks.unfiledGuid,
});
checkBookmarkObject(bm);
Assert.equal(bm.parentGuid, PlacesUtils.bookmarks.unfiledGuid);
Assert.equal(bm.index, 1);
Assert.equal(bm.dateAdded, bm.lastModified);
Assert.equal(bm.type, PlacesUtils.bookmarks.TYPE_BOOKMARK);
Assert.equal(bm.title, "Test");
Assert.equal(bm.url.href, "http://www.example.com/");
});
add_task(async function create_folder() {
let [bm] = await PlacesUtils.bookmarks.insertTree({
children: [
{
type: PlacesUtils.bookmarks.TYPE_FOLDER,
title: "Test",
},
],
guid: PlacesUtils.bookmarks.unfiledGuid,
});
checkBookmarkObject(bm);
Assert.equal(bm.parentGuid, PlacesUtils.bookmarks.unfiledGuid);
Assert.equal(bm.index, 2);
Assert.equal(bm.dateAdded, bm.lastModified);
Assert.equal(bm.type, PlacesUtils.bookmarks.TYPE_FOLDER);
Assert.equal(bm.title, "Test");
});
add_task(async function create_in_tags() {
await Assert.throws(
() =>
PlacesUtils.bookmarks.insertTree({
children: [
{
type: PlacesUtils.bookmarks.TYPE_BOOKMARK,
url: "http://www.example.com/",
title: "Test adding a tag",
},
],
guid: PlacesUtils.bookmarks.tagsGuid,
}),
/Can't use insertTree to insert tags/
);
let guidForTag = (
await PlacesUtils.bookmarks.insert({
title: "test-tag",
url: "http://www.unused.com/",
parentGuid: PlacesUtils.bookmarks.tagsGuid,
})
).guid;
await Assert.rejects(
PlacesUtils.bookmarks.insertTree({
children: [
{
type: PlacesUtils.bookmarks.TYPE_BOOKMARK,
url: "http://www.example.com/",
title: "Test adding an item to a tag",
},
],
guid: guidForTag,
}),
/Can't use insertTree to insert tags/
);
await PlacesUtils.bookmarks.remove(guidForTag);
await PlacesTestUtils.promiseAsyncUpdates();
});
add_task(async function insert_into_root() {
await Assert.throws(
() =>
PlacesUtils.bookmarks.insertTree({
children: [
{
type: PlacesUtils.bookmarks.TYPE_BOOKMARK,
url: "http://www.example.com/",
title: "Test inserting into root",
},
],
guid: PlacesUtils.bookmarks.rootGuid,
}),
/Can't insert into the root/
);
});
add_task(async function tree_where_separator_or_folder_has_kids() {
await Assert.throws(
() =>
PlacesUtils.bookmarks.insertTree({
children: [
{
type: PlacesUtils.bookmarks.TYPE_SEPARATOR,
children: [
{
type: PlacesUtils.bookmarks.TYPE_BOOKMARK,
url: "http://www.example.com/",
title: "Test inserting into separator",
},
],
},
],
guid: PlacesUtils.bookmarks.unfiledGuid,
}),
/Invalid value for property 'children'/
);
await Assert.throws(
() =>
PlacesUtils.bookmarks.insertTree({
children: [
{
type: PlacesUtils.bookmarks.TYPE_BOOKMARK,
children: [
{
type: PlacesUtils.bookmarks.TYPE_BOOKMARK,
url: "http://www.example.com/",
title: "Test inserting into separator",
},
],
},
],
guid: PlacesUtils.bookmarks.unfiledGuid,
}),
/Invalid value for property 'children'/
);
});
add_task(async function create_hierarchy() {
let obsInvoked = 0;
let listener = events => {
for (let event of events) {
obsInvoked++;
Assert.greater(event.id, 0, "Should have a valid itemId");
}
};
PlacesUtils.observers.addListener(["bookmark-added"], listener);
let bms = await PlacesUtils.bookmarks.insertTree({
children: [
{
type: PlacesUtils.bookmarks.TYPE_FOLDER,
title: "Root item",
children: [
{
url: "http://www.example.com/1",
title: "BM 1",
},
{
url: "http://www.example.com/2",
title: "BM 2",
},
{
title: "Sub",
type: PlacesUtils.bookmarks.TYPE_FOLDER,
children: [
{
title: "Sub BM 1",
url: "http://www.example.com/sub/1",
},
{
title: "Sub BM 2",
url: "http://www.example.com/sub/2",
},
],
},
],
},
],
guid: PlacesUtils.bookmarks.unfiledGuid,
});
await PlacesFrecencyRecalculator.recalculateAnyOutdatedFrecencies();
PlacesUtils.observers.removeListener(["bookmark-added"], listener);
let parentFolder = null,
subFolder = null;
let prevBM = null;
for (let bm of bms) {
checkBookmarkObject(bm);
if (prevBM && prevBM.parentGuid == bm.parentGuid) {
Assert.equal(prevBM.index + 1, bm.index, "Indices should be subsequent");
Assert.equal(
(await PlacesUtils.bookmarks.fetch(bm.guid)).index,
bm.index,
"Index reflects inserted index"
);
}
prevBM = bm;
if (bm.type == PlacesUtils.bookmarks.TYPE_BOOKMARK) {
Assert.greater(
await PlacesTestUtils.getDatabaseValue("moz_places", "frecency", {
url: bm.url,
}),
0,
"Check frecency has been updated for bookmark " + bm.url
);
}
if (bm.title == "Root item") {
Assert.equal(bm.parentGuid, PlacesUtils.bookmarks.unfiledGuid);
parentFolder = bm;
} else if (!bm.title.startsWith("Sub BM")) {
Assert.equal(bm.parentGuid, parentFolder.guid);
if (bm.type == PlacesUtils.bookmarks.TYPE_FOLDER) {
subFolder = bm;
}
} else {
Assert.equal(bm.parentGuid, subFolder.guid);
}
}
Assert.equal(obsInvoked, bms.length);
Assert.equal(obsInvoked, 6);
});
add_task(async function insert_many_non_nested() {
let obsInvoked = 0;
let listener = events => {
for (let event of events) {
obsInvoked++;
Assert.greater(event.id, 0, "Should have a valid itemId");
}
};
PlacesUtils.observers.addListener(["bookmark-added"], listener);
let bms = await PlacesUtils.bookmarks.insertTree({
children: [
{
url: "http://www.example.com/1",
title: "Item 1",
},
{
url: "http://www.example.com/2",
title: "Item 2",
},
{
url: "http://www.example.com/3",
title: "Item 3",
},
{
type: PlacesUtils.bookmarks.TYPE_SEPARATOR,
},
{
title: "Item 4",
url: "http://www.example.com/4",
},
{
title: "Item 5",
url: "http://www.example.com/5",
},
],
guid: PlacesUtils.bookmarks.unfiledGuid,
});
await PlacesFrecencyRecalculator.recalculateAnyOutdatedFrecencies();
PlacesUtils.observers.removeListener(["bookmark-added"], listener);
let startIndex = -1;
for (let bm of bms) {
checkBookmarkObject(bm);
if (startIndex == -1) {
startIndex = bm.index;
} else {
Assert.equal(++startIndex, bm.index, "Indices should be subsequent");
}
Assert.equal(
(await PlacesUtils.bookmarks.fetch(bm.guid)).index,
bm.index,
"Index reflects inserted index"
);
if (bm.type == PlacesUtils.bookmarks.TYPE_BOOKMARK) {
Assert.greater(
await PlacesTestUtils.getDatabaseValue("moz_places", "frecency", {
url: bm.url,
}),
0,
"Check frecency has been updated for bookmark " + bm.url
);
}
Assert.equal(bm.parentGuid, PlacesUtils.bookmarks.unfiledGuid);
}
Assert.equal(obsInvoked, bms.length);
Assert.equal(obsInvoked, 6);
});
add_task(async function create_in_folder() {
let mozFolder = await PlacesUtils.bookmarks.insert({
parentGuid: PlacesUtils.bookmarks.menuGuid,
type: PlacesUtils.bookmarks.TYPE_FOLDER,
title: "Mozilla",
});
let notifications = [];
let listener = events => {
for (let event of events) {
notifications.push({
itemId: event.id,
parentId: event.parentId,
index: event.index,
title: event.title,
guid: event.guid,
parentGuid: event.parentGuid,
});
}
};
PlacesUtils.observers.addListener(["bookmark-added"], listener);
let bms = await PlacesUtils.bookmarks.insertTree({
children: [
{
url: "http://getfirefox.com",
title: "Get Firefox!",
},
{
type: PlacesUtils.bookmarks.TYPE_FOLDER,
title: "Community",
children: [
{
url: "http://getthunderbird.com",
title: "Get Thunderbird!",
},
{
url: "https://www.seamonkey-project.org",
title: "SeaMonkey",
},
],
},
],
guid: mozFolder.guid,
});
await PlacesTestUtils.promiseAsyncUpdates();
PlacesUtils.observers.removeListener(["bookmark-added"], listener);
let mozFolderId = await PlacesTestUtils.promiseItemId(mozFolder.guid);
let commFolderId = await PlacesTestUtils.promiseItemId(bms[1].guid);
deepEqual(notifications, [
{
itemId: await PlacesTestUtils.promiseItemId(bms[0].guid),
parentId: mozFolderId,
index: 0,
title: "Get Firefox!",
guid: bms[0].guid,
parentGuid: mozFolder.guid,
},
{
itemId: commFolderId,
parentId: mozFolderId,
index: 1,
title: "Community",
guid: bms[1].guid,
parentGuid: mozFolder.guid,
},
{
itemId: await PlacesTestUtils.promiseItemId(bms[2].guid),
parentId: commFolderId,
index: 0,
title: "Get Thunderbird!",
guid: bms[2].guid,
parentGuid: bms[1].guid,
},
{
itemId: await PlacesTestUtils.promiseItemId(bms[3].guid),
parentId: commFolderId,
index: 1,
title: "SeaMonkey",
guid: bms[3].guid,
parentGuid: bms[1].guid,
},
]);
});
|