summaryrefslogtreecommitdiffstats
path: root/tools/coccinelle/zprivs.cocci
blob: 11628a7eae754c90c64be5cb9ddabd29b93dd1b2 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
@@
identifier change;
identifier end;
expression E, f, g;
iterator name frr_with_privs;
@@

- if (E.change(ZPRIVS_RAISE))
-   f;
+ frr_with_privs(&E) {
  <+...
-   goto end;
+   break;
  ...+>
- end:
- if (E.change(ZPRIVS_LOWER))
-   g;
+ }

@@
identifier change, errno, safe_strerror, exit;
expression E, f1, f2, f3, ret, fn;
iterator name frr_with_privs;
@@

  if (E.change(ZPRIVS_RAISE))
    f1;
  ...
  if (...) {
-   int save_errno = errno;
    ...
-   if (E.change(ZPRIVS_LOWER))
-     f2;
    ...
-   safe_strerror(save_errno)
+   safe_strerror(errno)
    ...
    \( return ret; \| exit(ret); \)
  }
  ...
  if (E.change(ZPRIVS_LOWER))
    f3;

@@
identifier change;
expression E, f1, f2, f3, ret;
iterator name frr_with_privs;
@@

  if (E.change(ZPRIVS_RAISE))
    f1;
  ...
  if (...) {
    ...
-   if (E.change(ZPRIVS_LOWER))
-     f2;
    ...
    return ret;
  }
  ...
  if (E.change(ZPRIVS_LOWER))
    f3;

@@
identifier change;
expression E, f, g;
iterator name frr_with_privs;
@@

- if (E.change(ZPRIVS_RAISE))
-   f;
+ frr_with_privs(&E) {
  ...
- if (E.change(ZPRIVS_LOWER))
-   g;
+ }