diff options
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 3218 |
1 files changed, 2936 insertions, 282 deletions
@@ -1,79 +1,1744 @@ -2024-02-25 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [db4def46b0453cc22e2d0305797cf981b68ef5ac] +2024-03-22 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [d56cc158d8a96260b836f100ef4b4ef25d6f1a01] - Version 24.2.1.2, tag libreoffice-24.2.1.2 + Version 24.2.2.2, tag libreoffice-24.2.2.2 -2024-02-25 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [b39375c15f7b160378ec9e160307646a7a9544d4] +2024-03-22 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [928e2cf2dcbe5c86ae8b8b795f2df55e4c051461] - bump product version to 24.2.1.2 + bump product version to 24.2.2.2 - Change-Id: Ie23a07309fd7206ff34c718329d6f7921dfd1578 + Change-Id: I30ccd4f800b01758ddd21afc46f73d708d810568 -2024-02-25 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [9cfb2071ab4c3bc5e12de06cbd75b9dd52768638] +2024-03-22 Patrick Luby <guibmacdev@gmail.com> [9012b402ec25c5eb17400f93ffdc73e3db3a122a] - update credits + tdf#152524 fix crash by changing the macOS fork() and exec() process - Change-Id: Ie2fc3de7861b870d5a4b2aa9943af7401f21a1b7 - (cherry picked from commit fe47872aa8380567af7f453b9d3466cf7acd0d12) - (cherry picked from commit 2a18ca440961210b8f71cbabc2cf205d194169ef) + This fix backports commit 839cf255e2670fdf8e974af38432aacf63be4e90 + and commit 3c6c5ef5d1c4f555b465bf56cf9d99e4d67224cc. + + Change-Id: I5dd397a1ab624a048c8892c870b991b381a94f9c + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165178 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + Reviewed-by: Patrick Luby <guibomacdev@gmail.com> + Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> -2024-02-25 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [a9320e6b296855d06bbba5d8181c3a79d9001a3a] +2024-03-22 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [3cf709baeb1e502cfe546b3216e848d3b47a3ede] Update git submodules - * Update translations from branch 'libreoffice-24-2-1' - to cf2a5781160bbbd4c98d5cfbcac2a9b256f71cf4 - - update translations for 24.2.1 rc2 + * Update translations from branch 'libreoffice-24-2-2' + to 4eb6115303693019b82e06cda258ff1b8b5bfc71 + - update translations for 24.2.2 rc2 and force-fix errors using pocheck - Change-Id: I529205bfbe25f3e4a843743d37ba26c23b626a84 - (cherry picked from commit e674dbc9fb3e9fbbeefa4d4db7e5f98f0c057bbe) + Change-Id: I75a9cc68d9f9d7712b58dfc521173323c3775208 + (cherry picked from commit d3abafd51ff477a324a0c0342fb1e02c78c93f6c) -2024-02-25 Michael Stahl <michael.stahl@allotropia.de> [9b82cdec8ea09e56f2b2189b73fbdd1c803f8210] +2024-03-22 Michael Stahl <michael.stahl@allotropia.de> [3146edaf76f4533f5872dc687a76a55c691ce4e9] - libxml2: upgrade to release 2.12.5 + tdf#157241 sw: assert when importing ToX in table in rhbz589883-2.docx - Fixes CVE-2024-25062 + ndtbl.cxx:1417: SwNodes::TextToTable(): Assertion `!rNode.IsSectionNode()' failed. - Change-Id: I0e98fd919328e9633a602c4872de0b06eb972cc0 - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163734 - Tested-by: Jenkins + (regression from commit 62cb3b8b8d6106c6aeb073b12d84973a107182ef) + + Change-Id: Iec12282573cb914d1924f4da4a28e26e01b866df + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165164 + Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> - (cherry picked from commit 4c3ee61e3eda0cbfd812443f80af89aa3a24ac73) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163754 + (cherry picked from commit df6fdb0041f8bfd251a4b03030b8bc47f0614c36) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165173 + Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163790 - Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165193 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> -2024-02-25 Caolán McNamara <caolan.mcnamara@collabora.com> [cd074fc3d883b148418235009ef721b35b24deb9] +2024-03-22 Michael Stahl <michael.stahl@allotropia.de> [8506ffb5cef6e18c01350874231e66080efbaf5e] - upgrade libxml2, libxslt & liblangtag + tdf#157241 sw: fix crash on RTF paste or insert of nested tables - what I'm really after is some vexating not-reproducible oss-fuzz msan - warnings when using libxml2 in the fodt2pdf fuzzer. So lets upgrade - libxml2 to the latest, which requires bumping libxslt, and then requires - a newer liblangtag because of no longer implicit includes that it - depended on. + The problem is that there are tables with only empty cell frames in the + layout, which causes a crash in IsAllHiddenCell() added in commit + ab7893544dc6be6dc192dffefd57cd5ddd421c35. - xmlKeepBlanksDefaultValue and xmlSubstituteEntitiesDefault are - deprecated, we should get around to updating those uses + This happens because first inner tables are created, with layout frames + because the layout already exists. - Change-Id: I8fda0dffda0a7ea65407d246a3121875cb8ad4a4 - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161598 + Then when SwNodes::TextToTable() is called for the outer table, it + deletes the SwTextFrames, but not the SwTabFrames/SwCellFrames, so they + remain uselessly in the layout. + + Delete these too, they will be recreated when the frame for the outer + table is created. + + Also the transfer of any existing break to the outer table was missing. + + Change-Id: Idc2bc1d4c6572702510ae4355e4015c42770eb3e + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164788 Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 62cb3b8b8d6106c6aeb073b12d84973a107182ef) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164813 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> - (cherry picked from commit 6875c975f80d8b813b1829a530162869a1e2d92e) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163752 + (cherry picked from commit df5bb0c4343b4a090de3343c7d454a93099989c0) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165003 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-03-22 Michael Stahl <michael.stahl@allotropia.de> [9b4c239b51244dfb28a6822e2046c72e8f937227] + + sw: GetSelectableFromAny() broken for SwXTextRange + + The function unnecessarily uses an intermediate XUnoTunnel variable to + handle SwXTextRange, but the implementation of XUnoTunnel was removed. + + (regression from commit 635448a996714a81cb15b41ac4bb0c73cabfb74f) + + Change-Id: I90dd7acbd259e8ca562a534ad0bc9a5b85356553 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165162 + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 8f2de92b3da99346f7282e623d47912f40f92b7b) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165180 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-03-22 Mike Kaganski <mike.kaganski@collabora.com> [df684c9d68fb130295c5a667fa6fcb6de3068fd2] + + tdf#160149: save and restore the whole set of tab's conditional formats + + ... instead of restoring it only for a range, and then have troubles + deciding how to join the range's formatting with the rest of tab's + formatting. + + Change-Id: Ie422893c7847b1473a86c0cd8fc3916144eb24ae + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164937 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit c492de66a077f3a2a960209b0b8b278b3901f361) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164888 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-03-22 Taichi Haradaguchi <20001722@ymail.ne.jp> [314286d59b3d24e700def6f817224770573579ad] + + Expat: upgrade to release 2.6.2 + + Fixes CVE-2024-28757 + + Change-Id: Id85044fa9d8eda922425e580e9d6979f6563e98a + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165129 + Tested-by: Taichi Haradaguchi <20001722@ymail.ne.jp> + Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> + (cherry picked from commit 370ca73a45b291e172918b4c8fcbc37ccaa434cf) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165176 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-03-22 Oliver Specht <oliver.specht@cib.de> [67e35d0159d30829c7672f3d4d33de2e85cd6626] + + Revert "tdf#159730 add compatibility option in RTF import" + + This reverts commit 3b04e74503ec6d07dc4befdb756e6abdc3de4e58. + + Reason for revert: The compatibility option is the wrong approach. This results in wrong line calculation as seen in tdf#159730#c6. + The problem that really needs to be fixed is the 9pt attribute of the hidden line breaks in the first paragraph that are used to calculate the height of the first paragraph. + Only the 1pt font attribute of the remaining visible space should define the line height. + + Change-Id: I6e0a1a499adaf2df9f68afbcfd6afcd6677e8f76 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165006 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 44e4ada23dfc8655ec7ddccfd027f02d22684d60) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165119 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-03-22 Michael Stahl <michael.stahl@allotropia.de> [7eeaa3f188f8a3c24d2c7a5fe90d97de4708bfc8] + + python3: upgrade to release 3.8.19 + + Fixes CVE-2023-6597 and also CVE-2024-0450 + + Change-Id: Iebca2608e16a966356736201c63f1be5185430d4 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165053 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 0633e4b4205334dd65ec64d7f3e306ee125e31be) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165111 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-03-22 Armin Le Grand (allotropia) <armin.le.grand.extern@allotropia.de> [c5b878a7c55f7e6f8d3a66fa9728c8fca5d0e13b] + + tdf#158783 Correct compares of SwTOXMark Items + + That item was never 'pooled', so operator== was not really + ever used. It just compared the 'type', so pretty many + instances were assumed to be equal, what is wrong. + We discussed to implement it (there is quite some content), + but we came to the point that it's only safe to say + instances are equal when same instance -> fallback to ptr + compare. + This came into play since I identified/changed many (160?) + places where SfxPoolItems were ptr-compared when doing that + paradigm change in Items. This leads to the two methods + 'areSfxPoolItemPtrsEqual' which just makes ptr compare and + 'SfxPoolItem::areSame' which also will use op==. For the + initial adaption I chose the wrong function adapting + places where SwTOXMark were involved. + + Change-Id: I7df029ad4542719681b1455de17ed5990d248395 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161963 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + Tested-by: Armin Le Grand <Armin.Le.Grand@me.com> + (cherry picked from commit d22a86089edfcadbef5231525a2947b954f4784e) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164996 + Tested-by: Jenkins + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + (cherry picked from commit a48ee46a085abfa04779ece38c08dddb5bf017ea) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165004 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-03-22 Michael Weghorn <m.weghorn@posteo.de> [17fe161389df04b16a4c61bf089a3ce113ea22e7] + + tdf#159915 qt: Force Qt::HighDpiScaleFactorRoundingPolicy::Round + + For now, force `Qt::HighDpiScaleFactorRoundingPolicy::Round` + for the HighDPI-scale factor rounding policy [1], which is the default + for Qt 5, while Qt 6 defaults to `Qt::HighDpiScaleFactorRoundingPolicy::PassThrough` + (see [2]), which resulted in broken rendering (e.g. "Help" -> "About" + dialog not showing the whole content) when fractional display scaling like 150 % + is configured in the KDE Plasma display settings (in contrast to manually setting the + `QT_SCALE_FACTOR=1.5` env variable to apply scaling, which was working + fine). + + Quoting from [3]: + + > The two principal options are whether fractional scale factors should be + > rounded to an integer or not. Keeping the scale factor as-is will make + > the user interface size match the OS setting exactly, but may cause + > painting errors, for example with the Windows style. + + Manually setting the env variable `QT_SCALE_FACTOR_ROUNDING_POLICY="Round"` + has the same effect (and can be used with LO versions not yet + containing this fix). + + (There might be a way to adjust the way that scaling happens + to make other policies work, but for now, just hard-code to + the policy that is known to work.) + + [1] https://doc.qt.io/qt-6/qt.html#HighDpiScaleFactorRoundingPolicy-enum + [2] https://doc.qt.io/qt-6/highdpi.html#environment-variable-reference + [3] https://doc.qt.io/qt-6/qguiapplication.html#setHighDpiScaleFactorRoundingPolicy + + Change-Id: I8eb6911d4dd5faf00912b8f15a58e0bdace1995a + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164768 + Tested-by: Jenkins + Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> + (cherry picked from commit 07688e864c913e005dcae366cf10702404a73d80) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164744 + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + (cherry picked from commit 7989a04cee3b614d493a5acbd1ff0363596efc00) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164816 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-03-20 Mike Kaganski <mike.kaganski@collabora.com> [a541f33b30e4c95ef69128e60ba4cc86ba8d585e] + + tdf#160117: check bAnyCondition + + Commit edbc3a09edcf58a4738b4648811a065f3f55bc7c (sc: Don't end + handleConditionalFormat early, 2023-11-02) intended to allow to apply + several different categories of conditions to the same cell: e.g., + color scale or databar, in addition to the normal style application + depending on a condition. + + This change fixes a regression, when the found matching condition did + not stop search for the matching conditions to apply a style. + + Change-Id: Ia4cf1dd35a964c6ca523050dc727184ca22a8dfd + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164687 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit 61580fcbd10bad2e0aab663d4c8fe43c1e01f92c) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164736 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> + Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + +2024-03-19 Julien Nabet <serval2412@yahoo.fr> [40f6e9a45edae06556e1d1a26237dc2ab12bc0ca] + + tdf#159373: band-aid for crash in: ScTable::HasAttrib + + band-aid because as Eike indicated in https://bugs.documentfoundation.org/show_bug.cgi?id=159373#c8 + "Question remains why this PostPaint() is called at all for an invalid range.." + + Change-Id: Ie44378119202addd8ddb46f0be4b0124be9fd48b + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164354 + Tested-by: Jenkins + Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163789 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164644 + (cherry picked from commit 2bb8b6df61d3fd27d38a9ac1724295b885e5e919) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164627 + Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> + Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + +2024-03-19 Michael Stahl <michael.stahl@allotropia.de> [6a9feb0bba19bcff87e0e1a16fcd03ad3a390dfa] + + tdf#157241 sw: layout: inconsistent conditions in lcl_RecalcSplitLine() + + A mistake, when checking before the condition is "if (pTab == &rTab)" + but when checking after it is "if (pTab)" - the latter is correct as the + former is checked *inside* the block, after resolving to top-level table. + + This caused erroneously setting rIsFootnoteGrowth = true in + SwTabFrame::MakeAll() of tab 939 in the bugdoc, when in fact the footnote + container shrunk from 5 to 2 footnotes. + + (regression from commit c303981cfd95ce1c3881366023d5495ae2edce97) + + Change-Id: Ib4cad9fef0e500ebe7a3636c2371a4108b32fb5f + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164717 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 7d3b439de357c8e97c0a73f6f63e67ec980e432d) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164733 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + (cherry picked from commit 3ea0c848b490f5b6f5f3860a9036ce25754a1f17) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164740 + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> + Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-03-19 Julien Nabet <serval2412@yahoo.fr> [545179ee711381b641dd6a34e46722353f2b2488] + + tdf#160095: fix crash when using ALT+RETURN twice + + Change-Id: Idc4c84039115c8d88418246a17e281c26fb49b70 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164592 + Tested-by: Jenkins + Reviewed-by: Julien Nabet <serval2412@yahoo.fr> + (cherry picked from commit 82e6236cd6ba6f45aa913a3be606e6b00f81fe07) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164614 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + (cherry picked from commit ad5bd68124f5cd63c1ac9f2b92b25d6a02ecfb97) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164624 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> + Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-03-19 Sarper Akdemir <sarper.akdemir.extern@allotropia.de> [aa371949ae72e84379ae811e469d9ec34bab6ec5] + + tdf#159931: pptx export: export each used slide layout for a master + + attempts to fix the slideLayout reference related regression + from Idb6b88ebe87a83818d8eb27a1fa087652a002c0c. + + To correctly export the all used slideLayout instances for a + given master, iterate through sdr::PageUsers of that master + and figure out all used layouts. + + Change-Id: I0f58befac1ba4d5ec01aeedbb5f611c83683dcf8 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164468 + Tested-by: Jenkins + Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> + Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de> + (cherry picked from commit a35831becee3781daf8628c48944660d31d84d8b) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164495 + (cherry picked from commit ebd9530b458cbc37a7b2b1da077435f2b33081ba) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164629 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> + Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-03-19 Stephan Bergmann <stephan.bergmann@allotropia.de> [c84f5898db8083fdc631a8871d0fef5eb4dd4197] + + Blind fix for Linux 32-bit builds + + ...which, according to + <https://lists.freedesktop.org/archives/libreoffice/2024-March/091666.html> "32 + bit build failure (smb, narrowing)", started to fail with + + > /<<PKGBUILDDIR>>/sal/osl/unx/file.cxx: In function ‘void osl_file_adjustLockFlags(const rtl::OString&, int*, sal_uInt32*)’: + > /<<PKGBUILDDIR>>/sal/osl/unx/file.cxx:71:26: error: narrowing conversion of ‘4283649346’ from ‘unsigned int’ to ‘int’ [-Wnarrowing] + > 71 | #define CIFS_SUPER_MAGIC 0xFF534D42 + > | ^~~~~~~~~~ + > /<<PKGBUILDDIR>>/sal/osl/unx/file.cxx:795:14: note: in expansion of macro ‘CIFS_SUPER_MAGIC’ + > 795 | case CIFS_SUPER_MAGIC: + > | ^~~~~~~~~~~~~~~~ + + etc. My Fedora 39 "Linux man-pages 6.05" statfs(2) man page explains about the + struct statfs f_type field of __fsword_t type: "The __fsword_t type used for + various fields in the statfs structure definition is a glibc internal type, not + intended for public use. This leaves the programmer in a bit of a conundrum + when trying to copy or compare these fields to local variables in a program. + Using unsigned int for such variables suffices on most systems." But the + underlying __FSWORD_T_TYPE looks like it is actually defined as a signed type in + /usr/include/bits/typesizes.h. + + Change-Id: Ida3ae84031c4e48b0d6e69d76b66b4e4facfa1ae + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164561 + Tested-by: René Engelhard <rene@debian.org> + Reviewed-by: René Engelhard <rene@debian.org> + Tested-by: Jenkins + Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> + (cherry picked from commit 0f5dfaebd61b9cabbe9762865563c2296ebb0112) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164504 + (cherry picked from commit 25c2c7aeeeebd2ce1d3067e2b8f95d0729f462a5) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164611 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + +2024-03-19 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [958be2ba8986f94e866a457eff96fd7aee497752] + + update credits + + Change-Id: I72d86d1a7dcadf3e015b5f9a3eb98d56fb9a49c5 + (cherry picked from commit a1fbfbabbf65bbddd99e1e660ea5435abc8d9ca9) + (cherry picked from commit 6485c324e911bebb4c8f8a50d0f51a6b156bd01d) + +2024-03-18 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [24ab022c4d6a14acd55e2b54c90b4d512146e4dc] + + Update git submodules + + * Update translations from branch 'libreoffice-24-2-2' + to 7b1c0310be9eafb46f9f5750bb89c44bc211513f + - bump copyright year for sl translation + + Change-Id: I7211f904b9b3822e5c45bc4c3c7a3b0512853185 + (cherry picked from commit 14ff5e76dedc18f32051747acc540dd2856c770e) + + - update translations for 24-2 and force-fix errors using pocheck + + Change-Id: I964bed068dfa7396512c1742c73c674caa96669c + (cherry picked from commit 4d541d2bb86ca82b4fd161c6851bd4a2f965608a) + +2024-03-18 Julien Nabet <serval2412@yahoo.fr> [32db1b0cc61c9457411accf2e7832507c2836fdd] + + tdf#160180: bump copyright year to 2024 + + Change-Id: I466b8f86e8a53a238ed2ce2d2b053dc519ff8eed + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164794 + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + Tested-by: Julien Nabet <serval2412@yahoo.fr> + (cherry picked from commit 94da114cd86e3bcd8b6235566ca5f926f09d4b18) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164748 + Tested-by: Jenkins + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + (cherry picked from commit 52084113d5c284e2eca364191a96d38490580b49) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164883 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-03-17 Patrick Luby <guibmacdev@gmail.com> [0ffcf99d3e05cf6405d3aa5fbea281a6b5632c9a] + + tdf#160036 Enable SKSL when using Skia/Raster + + Starting with the upgrade of Skia from m111 to m116, SKSL is disabled + by default for Skia/Raster so define SK_RASTER_PIPELINE_OPS_ALL to + enable it. + + Change-Id: Ibd10efa0540f1e87123c341b529c8e3931e1a8fb + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164933 + Tested-by: Jenkins + Reviewed-by: Patrick Luby <guibomacdev@gmail.com> + (cherry picked from commit 22dbaf45fb378107ad7daa0d7894939d6e0c7ee3) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164877 + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + Tested-by: Patrick Luby <guibomacdev@gmail.com> + +2024-03-15 Fridrich Strba <fridrich_strba@opensuse.org> [78629e74e1e046a9ae4945088e2f7afde6db88d6] + + Fix build with autoconf 2.72 + + This commit http://git.savannah.gnu.org/gitweb/ + ?p=autoconf.git;a=commitdiff; + h=cf09f48841b66fe76f606dd6018bb3a93242a7c9 + changed the internal cache variable name and its content + + The effects show later in message like + /tmp/ccyB6wS6.ltrans9.ltrans.o: in function `comphelper::DocPasswordHelper::decryptGpgSession(com::sun::star::uno::Sequence<com::sun::star::uno::Sequence<com::sun::star::beans::NamedValue> > const&)': + /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/docpasswordhelper.cxx:705:(.text+0x4fb7): undefined reference to `GpgME::Data::seek(long, int)' + /usr/bin/ld.bfd: /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/docpasswordhelper.cxx:716:(.text+0x5402): undefined reference to `GpgME::Data::seek(long, int)' + /usr/bin/ld.bfd: /tmp/ccyB6wS6.ltrans13.ltrans.o: in function `comphelper::OStorageHelper::CreateGpgPackageEncryptionData()': + /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/storagehelper.cxx:507:(.text+0x64e3): undefined reference to `GpgME::Data::seek(long, int)' + /usr/bin/ld.bfd: /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/storagehelper.cxx:520:(.text+0x6583): undefined reference to `GpgME::Data::seek(long, int)' + collect2: error: ld returned 1 exit status + + Where the type 'off_t' at the time of inclusion of the header and + at the time of compilation of the library differ. + + Change-Id: Ie0486dbc869e84f5fb2688473334cfe464abd570 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164704 + Tested-by: Jenkins + Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164715 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164764 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + Reviewed-by: Michael Meeks <michael.meeks@collabora.com> + Tested-by: Stephan Bergmann <stephan.bergmann@allotropia.de> + +2024-03-09 Patrick Luby <guibmacdev@gmail.com> [c4d42d7ffca8c8e1bfc6d23d5ca3b7553be5e78e] + + tdf#159996 use transparent alpha mask for output device + + Since commit 81994cb2b8b32453a92bcb011830fcb884f22ff3, fixed text + needs to be drawn to an output device with a transparent alpha + mask. + + Change-Id: I2036e8c6c9133b1caceb24aeca40f04524c16b23 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164556 + Tested-by: Jenkins + Reviewed-by: Patrick Luby <guibomacdev@gmail.com> + (cherry picked from commit 73c14fcf97a1dcc9c95c98f9223449957b0b4963) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164500 + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + +2024-03-07 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [195856d74dc68d2d74dfb221a3affadf259ea0d0] + + bump product version to 24.2.2.1.0+ + + Change-Id: Ifc53da11118fcbe937df38723adb164846261b6e + +2024-03-07 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [b8424dde35e5169c1c7ac1ec59df9d63d232572c] + + Branch libreoffice-24-2-2 + + This is 'libreoffice-24-2-2' - the stable branch for the 24.2.2 release. + Only very safe changes, reviewed by three people are allowed. + + If you want to commit more complicated fix for the next 24.2.x release, + please use the 'libreoffice-24-2' branch. + + If you want to build something cool, unstable, and risky, use master. + +2024-03-07 Julien Nabet <serval2412@yahoo.fr> [c899c2e463c61d056e68efd180e0a596c7569a1e] + + tdf#159955: fix custom page number + + Change-Id: I1a56a4ba266dfb3c21e3b77263ecaa44b4e6dad5 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164210 + Tested-by: Jenkins + Reviewed-by: Julien Nabet <serval2412@yahoo.fr> + (cherry picked from commit d440dcfcaf688544a7a6d8bc478048159e5200f0) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164197 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-03-07 Caolán McNamara <caolan.mcnamara@collabora.com> [1db98f80722235140eae61f8fd966880a6c31fbe] + + Breeze scrollbars clipped, allocated space not wide/tall enough + + https: //github.com/flathub/org.libreoffice.LibreOffice/issues/247 + Change-Id: If04d4dd8b9608fc7c3a10bf36bad287cf183c2d2 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164389 + Tested-by: Jenkins + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-03-07 Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> [2bf9246a0388c1d3002f4fa90ba759d7d119cdbf] + + tdf#83720 Pivot Table: Data field should always at last place + + In the pivot table dialog we should always put the "Data" field to + the last place or the cell formats won't be shown correct in the + pivot table. + + Change-Id: If4befe4fff1e6f04d9b709615a1955e3b5f4b4cc + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164161 + Tested-by: Jenkins + Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> + (cherry picked from commit 78065e3798439dd790d1be5ac5c219477285c888) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164126 + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-03-07 Rafael Lima <rafael.palma.lima@gmail.com> [fa8351c50bd8f14830a461c09805e43c6fdb065d] + + tdf#158735 Save solver settings for DEPS and SCO as well + + When bug tdf#38948 was originally fixed, the solvers DEPS and SCO were not considered. This caused a regression, because setting engine options for these solvers made them never be saved, even in its own sheet. + + This patch fixes that by incorporating the engine options for DEPS and SCO. + + Change-Id: I93af712f91da2f7b1ac57ed74f6c2c2d7d411bba + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164376 + Tested-by: Jenkins + Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> + (cherry picked from commit 04d884cc99eb66679fb254129b54488bd40e5abf) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164385 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-03-07 Miklos Vajna <vmiklos@collabora.com> [58b5f3399e1c4ce56180cb49c5d228ca92ccc8d3] + + Related: tdf#150408 DOC filter: handle legal numbering + + The bugdoc's 2nd para started with 'Sect I.01', while Word rendered this + as 'Sect 1.01'. + + The reason for this difference is that there is an "is legal" boolean + property on the numbering that we ignored from [MS-DOC] during + import/export. + + Fix the problem by WW8ListManager::ReadLVL() and + WW8AttributeOutput::NumberingLevel() to handle this, building on top of + the existing DOCX work. + + RTF still needs doing. + + Change-Id: I57ec402c1dd829251afa639ddfa7fc6620da1125 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164000 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + Tested-by: Jenkins + (cherry picked from commit a73b3994fb6a2cc10b2d65cbaad201762610cecc) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163973 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> -2024-02-25 Xisco Fauli <xiscofauli@libreoffice.org> [2967b5776b26644de416253da2fdbc8fcfb18c71] +2024-03-07 Michael Stahl <michael.stahl@allotropia.de> [b84f10d5eadeecc668e29159c0485376466b7f54] + + sw: UITest_writer_tests8 test_tdf150443 more tolerant + + This fails on Fedora 39, also in the libreoffice-24-2 branch, with: + self.assertEqual(get_state_as_dict(xWriterEdit)["CurrentPage"], "4") + AssertionError: '5' != '4' + + Presumably a font substitution changing metrics problem, as "NexusSansOT" + is not found. + + It looks like the exact page doesn't matter for the test. + + Change-Id: I62eadb8321352ea47a0f8f83ab91fd50ff01f7e4 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164353 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 0b21e2a404c114529376dc50764dc0286dafc745) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164364 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-03-07 Mike Kaganski <mike.kaganski@collabora.com> [6ebe0eceb1ae4a3e544c733be37e5f02c5f46e80] + + tdf160017: make sure to emit the closing tags in correct order + + This reimplements how the starts and ends of attributes are stored in + HTMLEndPosLst. Instead of a plain list, now it is a sorted map, with + positions as keys, and a vector of HTMLStartEndPos* as values. + + In commit b94b1fe936ddc4a9b86fbeb9c9c6ab0fca52f0bc (CharBrd 9.1: HTML + filters, 2013-09-08), the character borders attributes started to be + set in a special order, in front of the position's other attributes, + to allow merging them. But that created a problem of knowing in which + order to close respective tags. + + The change here sorts the closing tags for the current node only when + writing them. At this point, it is possible to consider the opening + positions correctly. + + Change-Id: I466ffa1c0eb28874ded003035e0cf772e31585b3 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164325 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164357 + +2024-03-07 Laurent Balland <laurent.balland@mailo.fr> [60e0ebe633b1dee8bb2a66b9d133f5303749d8d5] + + tdf#129701 Skip empty cell: treat last column + + When pasting data as text, with "Skip empty cells" not checked, empty + cells in the last column of the source do not empty cells in + destination, because there is nothing anymore to paste and while loop + stops. + This commit adds a flag to check if the last cell of each line is empty, + and treat it if "Skip empty cells" is not checked. + + Add UITest to Copy data with empty cells; + Paste Unformatted text, without "Skip empty cells"; + Check data with empty cells in last column. + + Change-Id: Idec823fb1c27b803f49c6d13d6c757ef0f41e437 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160951 + Tested-by: Jenkins + Reviewed-by: Laurent Balland <laurent.balland@mailo.fr> + (cherry picked from commit e66ffda7c7f1e78dbca082ff7549ded121dc7356) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163536 + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-03-07 Michael Stahl <michael.stahl@allotropia.de> [b20f17ce082f30b0a2afd0d311f63f6b2ad8a99a] + + tdf#159502 remove --without-system-libxml from LibreOfficeLinux.conf + + configure.ac explicitly excludes libxml from --without-system-libs but + this distro-config "helpfully" adds it explicitly, when the system + already contains a usable libxml/libxslt anyway. + + Change-Id: I79d65d9ed9185277ffde8624efc152b290a6ffb3 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163438 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 6f6364e572a0570fb097fec098314bffadc5b474) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163409 + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-03-07 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [7bde6b742e81a5658ca2826e3ad65e06e49c36b4] + + Update git submodules + + * Update translations from branch 'libreoffice-24-2' + to 6ca0f042bc33814b015b346f2710218222f7cd1b + - update translations for 24.2.2 rc1 + + and force-fix errors using pocheck + + Change-Id: I9719c836bf763473f9a85cfced566b4cba514c13 + +2024-03-05 Fridrich Štrba <fridrich.strba@bluewin.ch> [aa438e3b00ad1377a6451d88e71b6370a0a210d9] + + Allow building with Java 8 + + Change-Id: Ib1af1a98993aabb8a03f4ef19d8da4d9a71fdbc0 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164226 + Tested-by: Jenkins + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + (cherry picked from commit 4267c7124876b9213b3169a55731d260c8c63f7c) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164233 + Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + Reviewed-by: Hossein <hossein@libreoffice.org> + Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-03-05 Xisco Fauli <xiscofauli@libreoffice.org> [49cf2346861791b519f97b07a5973c1410e15a6a] + + tdf#150443: replace missing fonts in testfile + + This commit reverts 0b21e2a404c114529376dc50764dc0286dafc745 + "sw: UITest_writer_tests8 test_tdf150443 more tolerant" + + Change-Id: If83a7b0a8dc2289aba3201edfdf19d0ca839459a + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164392 + Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Tested-by: Jenkins + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164410 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-03-05 Caolán McNamara <caolan.mcnamara@collabora.com> [1b030b6938352c4babcbf56d598c07efa714f103] + + GLib-GObject-CRITICAL **: gsignal.c:2778: instance X has no handler with id Y + + Change-Id: I4fbbd4af0ed1605874e2ef2694ecda0a9e107a07 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164370 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-03-05 Mike Kaganski <mike.kaganski@collabora.com> [81c8c95b480ac32a18f8d7d0f4a0e3671b5b8b2b] + + tdf#153706: do not add categories, when source data doesn't have them + + lcl_AllOperator is used in XChartDocument::attachData implementation. + When a data without existing categories is passed there, like an XY + scatter, lcl_AllOperator used to force creation of the categories in + the target, by returning 'true' unconditionally from setsCategories. + This meant, that a new sequence of numbers starting from 1 was used + as X values, and the old X data was interpreted as an extra Y series. + + This changes lcl_AllOperator::setsCategories to try to check if its + data actually contains categories. Thus, XChartDocument::attachData + will use categories either when the chart already uses categories, + and ChartDataWrapper::applyData detects that using a call to + DataSourceHelper::detectRangeSegmentation; or when the new data has + it; but not when neither had it. When it's not possible to detect if + there were categories in the new data (e.g., with user data), old + behavior is used, setting categories. + + It could be an alternative to detect the chart type using + xOldDoc->getDiagram()->getDiagramType() == "com.sun.star.chart.XYDiagram" + in XChartDocument::attachData; and then decide to force the creation + or not. But it seems hackish, and not really universal: other chart + types must be tested (bubble?), no idea how to handle hypothetical + cases when applied data contains categories in case of XY chart, etc. + + Change-Id: I86b34f6799c30b103f7fc6b2faf6ec255a9d137b + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164298 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164279 + +2024-03-05 Mike Kaganski <mike.kaganski@collabora.com> [44141fbb32c181a1fea2730b194b2664521d0a79] + + tdf#99969: make sure to copy the chart source ranges to clipboard + + ... even when they are outside of the copied cell range. Otherwise, + it is impossible to transfer the missing data when switching to + own data on paste. + + The copy of the missing ranges avoids copying cell attributes, for + performance reasons, but also to avoid overwriting the attributes + of already copied cells. Otherwise, ScDrawLayer::CopyToClip would + need the bKeepScenarioFlags, or the CopyToClipContext used in the + caller ScDocument::CopyToClip, for consistent copy; or a method to + avoid overwriting already copied cells (this change simply copies + all chart ranges, withiut checking if they were copied already). + + Change-Id: Id02e0c20517e7e8a17bb0a31d1b230196cda1a58 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164294 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164397 + +2024-03-05 Mike Kaganski <mike.kaganski@collabora.com> [4b862fc40dc61570b7fb79b29066f8ce260e467b] + + Simplify a bit + + Change-Id: I5022d82e556f7cfb09f0dee397d93dd7514a22e5 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164202 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164396 + +2024-03-05 Mike Kaganski <mike.kaganski@collabora.com> [c3b5f1a25a7436841307da79474749830a055490] + + Simplify a bit + + Change-Id: I5909dfc0f19b13d53d370f78a5e2853b95f0c1a9 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164201 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164402 + +2024-03-05 Miklos Vajna <vmiklos@collabora.com> [172931eccfc3469e3dc05737d6290fbdf2a957b4] + + tdf#159483 sc HTML copy: handle data-sheets-formula attribute + + When a formula cell gets copied from Calc to google docs, only the + formula result was copied, not the formula. + + There is a data-sheets-formula attribute on <td> that can describe the + formula we have. + + Fix the problem by extending ScHTMLExport::WriteCell() to emit that. + + This is more or less the export equivalent of commit + 7812adb2ed11a3e08be24d3f2f94d14bfd740c55 (tdf#159483 sc HTML paste: + handle data-sheets-formula attribute, 2024-02-12). + + Change-Id: Iab373ce8a028deb6a2874a8c690e928edf5d79f4 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164363 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + Tested-by: Jenkins + (cherry picked from commit 2efe362c99a9fa6e9a71b9b675b025c64b6c7f9d) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164375 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-03-04 Regina Henschel <rb.henschel@t-online.de> [5ad993b4167fb93f565dc1bce6eb1057e60f62f3] + + tdf#160003 use correct sheet in clipboard for test + + ..whether a page anchored object is contained in the to be copied area. + + Change-Id: I816e342770332e6d751b57a38e5ebabe33feb16a + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164307 + Tested-by: Jenkins + Reviewed-by: Regina Henschel <rb.henschel@t-online.de> + (cherry picked from commit 199523b553957936dc31b8c3556ef2e47c6bc3a1) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164373 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-03-04 Miklos Vajna <vmiklos@collabora.com> [69f4c84a5183d1a76ada9a8ed19de43b09130792] + + tdf#159483 sc HTML copy: handle data-sheets-value attribute for the num case + + Type 1000 and 2000 into cells in Calc, format them as e.g. a HUF + currency, the resulting formatted strings can be copied to google + sheets, but the SUM() on them will be 0 (and not 3000). + + Our own import knows how to read metadata to get the original float + value, but our exporter didn't emit these. + + Fix the problem by adding support for non-boolean float values + number + formats in the HTML export. + + This is more or less export equivalent of commit + 789964785a61daab5f8065f006dd7aaf843c7236 (tdf#159483 sc HTML import: + handle data-sheets-value attribute for the num case, 2024-02-09). + + Change-Id: I5acb3724367ce38bd96056dbe4f846cd7bbc5fe2 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164213 + Tested-by: Jenkins + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + (cherry picked from commit 17581e684ca701bfd96ed2bf16aa14c3903b74d4) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164278 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-03-04 Caolán McNamara <caolan.mcnamara@collabora.com> [e05179628e3d6855451bcd7e861b25b25ce765d0] + + Resolves: tdf#159854 Trigger text is black on dark grey in Animation sidebar + + in dark mode + + Change-Id: I2cbf9b7d14a501c309a02dd3080511f527f9e1d1 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164276 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-03-04 Patrick Luby <guibmacdev@gmail.com> [30862f999acc54e2690d28f97b95764f664c1f5a] + + tdf#159515 rename impGetTransparence() to impGetAlpha() + + Commit 81994cb2b8b32453a92bcb011830fcb884f22ff3 makes + impGetTransparence() return alpha instead of transparence. So, + rename the function and skip reverting the result to obtain the + alpha value. + + Change-Id: Ied3bf8ae4a0de2ae36074dba9f78ccc93480b15a + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164322 + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + Reviewed-by: Patrick Luby <guibomacdev@gmail.com> + Tested-by: Patrick Luby <guibomacdev@gmail.com> + (cherry picked from commit b4caea04cb63cbdc25bab871a5b20aa16e2f3a77) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164371 + Tested-by: Jenkins + +2024-03-04 Noel Grandin <noelgrandin@gmail.com> [10346f5ff6f0ab6e3b2deb709e4f3e9cc49bf80c] + + tdf#159817 tdf#159802 Form controls coordinates wrong when export to pdf + + This reverts the following commits: + d408fe5cd45c9594feecec727ab2f73c66e361d0 "unnecessary LogicToPixel in CheckBox::Draw" + 7441aaa4c5b2215e369c62e22af098184e8ce807 "unnecessary LogicToPixel in RadioButton::Draw" + a2dacae0c8acfad8a5e5a16c766ee740ec202c5e "unnecessary LogicToPixel in ComboBox::Draw" + f73e8c895e24fda10931ecf344a1a0dd8bcdf92c "unnecessary LogicToPixel in TabPage::Draw" + + I am fairly sure this code that I am restoring is dodgy, + and I am just papering over some other bug somewhere, but + I can't seem to see where that is. + + Change-Id: I0f9088e43b0e3af74fd5ff9d297008ee23a3facb + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164313 + Tested-by: Jenkins + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164328 + +2024-03-04 Caolán McNamara <caolan.mcnamara@collabora.com> [c586333a1824b23b5cbde9416f5858ced0acd7a7] + + cid#1592908 Dereference null return value + + and + + cid#1592910 Dereference null return value + + Change-Id: I7524c3e91447f4421083dfda10d3dd1c3a6e482d + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164301 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-03-04 Xisco Fauli <xiscofauli@libreoffice.org> [6eb331934f27993db83a2175d22bdd554a775ad8] + + tdf#159968: Support overflow:visible in marker element + + Change-Id: I4ea648cf94a4bb321a78843a9898769a69c5630d + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164224 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + (cherry picked from commit eaf9befee8073916f6b22dd600e54073504154b7) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164198 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-03-03 Caolán McNamara <caolan.mcnamara@collabora.com> [289772c27fd523df545262614fb31d90314326df] + + Resolves: tdf#159879 Crash when closing "3D View" dialog + + Change-Id: I9c116007afe9cea97b597933ad8483dce25c3707 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164274 + Tested-by: Jenkins + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + +2024-03-03 Caolán McNamara <caolan.mcnamara@collabora.com> [d768e6e376b7828e3a306a97b789a76f85f9f3b9] + + Resolves: tdf#159696 Small capitals with 'Individual words' underlining + + Change-Id: I79af3f74ef384f734273b00bddbcfed8952a3ad2 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164275 + Tested-by: Jenkins + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + +2024-03-01 Oliver Specht <oliver.specht@cib.de> [51f872cbc1291123401cf22f27a7185801660e4a] + + tdf#146356 insert new paragraph before table of contents + + Alt+Enter inserts the new paragraph before the content section + of a table of contents. + At the same time protected indexes now also have the header + protected. + + Change-Id: Iff267691d96796158c1593c4269b76226840c952 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164050 + Tested-by: Jenkins + Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit aebdc79dbc5bf059ee0921a00d2795e526a52c42) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164128 + +2024-03-01 Taichi Haradaguchi <20001722@ymail.ne.jp> [539909be1436f7402c9d4718b58d99fcd2f28a75] + + GPGME: upgrade to release 1.23.2 + + Change-Id: I56c419fbbe615ef57b7d8117ccdc32f0daddf95f + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163840 + Tested-by: Jenkins + Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> + (cherry picked from commit c9d3e68481e4db0e732b9186b75b582a5b41271b) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163980 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-03-01 Xisco Fauli <xiscofauli@libreoffice.org> [e5e6de02c36f9efb8b078512d72ac9229fe02e86] + + tdf#157158: always paint the arrow black + + The background doesn't change so do not change the arrow color either + + Change-Id: I7a5f80e639570e94975b7e033619783d24c95a6f + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163737 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + Tested-by: Jenkins + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + (cherry picked from commit c4553ae6e06ce84c2f477ec85bc2056645eb4833) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163755 + +2024-03-01 Michael Stahl <michael.stahl@allotropia.de> [3fbc5a9dfebb94e893d98d3c00bcf0805b79ba37] + + tdf#153196 writerfilter: fix page style for even/odd section break + + This is a bit of a special case, where the first section starts with an + evenPage break (\sbkeven), which causes a Left-only page style to be + created. + + In completeCopyHeaderFooter(), the HeaderTextFirst and FooterTextFirst + are copied from the source style to the Left-only page style, but then + they also need to be deleted from the source style, because the + Left-only page style is the one that is used for the first page of the + section, and the source style is used for the subsequent pages. + + Additionally, when there is *only* a "first" header/footer, and no + previous section has one to inherit, Word will not display a + header/footer at all on subsequent pages; a PageStyle will always have a + header/footer if it has a HeaderTextFirst/FooterTextFirst. + + In this case, delete the header/footer from the source style. + + Unfortunately exporting this doesn't work ideally, a spurious evenPage + footer will be created, both due to the FooterShare being automatically + reset for no obvious reason in ItemSetToPageDesc(), and + setProperty("FooterIsShared", true) "stashing" the left footer since + commit b802ab694a8a7357d4657f3e11b571144fa7c7bf. + + (presumably regression from commit b32881b6723072c8d1a652ea147d12e75766d504) + + Change-Id: Ie4f9c49605df690e9705e14777c0e4bcb0dfad8e + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163668 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 340f8ea4ae7f11b4d3a95499188a29fe801867cf) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163673 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-03-01 Michael Stahl <michael.stahl@allotropia.de> [5cef8d6e09f852671a412e39f8a3d4729302e28c] + + tdf#158597 writerfilter,sw: fix toggle properties in ListAutoFormat + + ... for DOCX import. + + These can be set both via paragraph style and via character style in the + w:pPr/w:rPr, so use the applyToggleAttributes(). + + Adding a test for this requires adding the "CharStyleName" property to + GetAutoCharStylePropertyMap(). + + Change-Id: I9701d5ac82ec3e7757650c08861791dc398a1a77 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163386 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit ff9be3fd30ead41359734f9281b034a988d71196) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163449 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-03-01 Michael Stahl <michael.stahl@allotropia.de> [7f939fee0ee20a63272267fbf6cecdb034e1bbd6] + + tdf#159502 libxml2: apply Solaris ld patch only on Solaris + + Diverging from upstream by inventing a LIBXML2_GLOBAL_VARIABLES version + should only be done if actually required. + + Change-Id: I1520ca5078dc24ffd83e927f9c857d625e71749b + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163455 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit eebdda4e221327cae5a9177893394819ca510d5f) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163490 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-02-29 Xisco Fauli <xiscofauli@libreoffice.org> [0ddfc1c31b7d9d2a3977e0e9cbf59b9dcf2044ee] + + tdf#159420: Show empty option even if empty is filtered out + + in other columns + + Regression from 89e032e9c4c51f52680c7d8bacf59ab2a34f2180 + "tdf#158314: show Empty and Error entries as non-selected and inactive... + ...when hidden by autofilter." + + The mbHasEmpties variable was added in + 9c1826d98065c30411cbf2e731560165ca2b7668 + "sc-perf: do not add a million empty filter entries just to sort and + discard" + + Change-Id: Ie0d81fd57f68038fac62cb6a3442e93ed547167a + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162752 + Tested-by: Jenkins + Reviewed-by: Kevin Suo <suokunlong@126.com> + (cherry picked from commit 98b4ba33a0a698e738db46d5916063de6e74fb96) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164120 + +2024-02-29 Stephan Bergmann <stephan.bergmann@allotropia.de> [c458c1709e35b6ba9bc5c326e1d24ba71ae51a18] + + Try to appease Flathub linter + + ...which caused a recent + <https://buildbot.flathub.org/#/builders/33/builds/12708> test build to fail + with + + > { + > "errors": [ + > "appstream-failed-validation" + > ], + > "warnings": [ + > "appstream-screenshot-missing-caption" + > ], + > "appstream": [ + > "E: org.libreoffice.LibreOffice.desktop:~: desktop-app-launchable-omitted" + > ], + > "message": "Please consult the documentation at https://docs.flathub.org/docs/for-app-authors/linter" + > } + + Change-Id: I3655d3985c70780e5980bec2d4753120fb302f1a + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164134 + Tested-by: Jenkins + Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> + (cherry picked from commit beccfbbb7e896266be3c6c1a9dddaf68fd33ae9e) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164117 + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + +2024-02-29 Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> [b3223e1f236e450fcbb71c415dc64dbd10a7ae0a] + + sc: Handle xls documents with unknown DRM encryption better + + If we can't decrypt the document, don't set the SotStorage to + an empty SvRef. It is possible the document contains a "fallback" + un-encrypted document, which we can show. This is typical for some + Excel add-ons, which encrypt the document, but also add a part + that is un-encrypted to write the instructions on how to get the + add-on. + + Change-Id: I6079786b1d0dce3a819a70e057699d0a461a5be5 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163511 + Tested-by: Jenkins + Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> + (cherry picked from commit 1e1072afa3726266f83d7ef8895ed406580a3450) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163535 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + +2024-02-29 Michael Weghorn <m.weghorn@posteo.de> [1c64b4ebd16ee301bcfaa12c659e7baad7b8e519] + + tdf#159735 a11y: Dispose win accessible with VCLXWindow + + `Window::dispose` takes care of disposing its + accessible as well. + + However, `VCLXWindow::dispose` was explicitly unsetting + the accessible before disposing its `vcl::Window`, resulting + in it not getting disposed, in turn resulting in a crash on exit + for the tdf#159735 case. + + Potentially related: + + commit 5aa60be574ece81b27c8f63e6e809871c694dba0 + Date: Wed May 12 11:33:06 2021 +0200 + + fix leak in VCLXWindow + + which is a little tricky because dispose() can be called from either + side (vcl::Window or VCLXWindow) + + Before that commit, setting a nullptr accessible happened + in the `VCLXWindow` dtor, which is meant to get called after + the `vcl::Window` got disposed in `VCLXWindow::dispose`. + (In the Linux bibisect repo, the commit before that one is fine + and at that commit, the tdf#159735 comment 5 scenario even + crashes in step 3 already.) + + Don't unset the `vcl::Window`'s accessible any more in + `VCLXWindow::dispose`, but do that after disposing it in + `vcl::Window::dispose` instead, which seems to be the + natural place to do that anyway. + + Backtrace of crash: + + Thread 1 received signal SIGSEGV, Segmentation fault. + 0x00007fd754ae6fe9 in comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener>::disposeAndClear (this=0x7ffccdc2b5b8, rGuard=..., rEvt=...) at include/comphelper/interfacecontainer4.hxx:397 + 397 aIt.next()->disposing(rEvt); + (gdb) bt + #0 0x00007fd754ae6fe9 in comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener>::disposeAndClear(std::unique_lock<std::mutex>&, com::sun::star::lang::EventObject const&) + (this=0x7ffccdc2b5b8, rGuard=..., rEvt=...) at include/comphelper/interfacecontainer4.hxx:397 + #1 0x00007fd754ae6014 in comphelper::AccessibleEventNotifier::revokeClientNotifyDisposing(unsigned int, com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&) + (_nClient=28, _rxEventSource=uno::Reference to (accessibility::AccessibleListBox *) 0x55bf49c0ad00) at .../libreoffice/comphelper/source/misc/accessibleeventnotifier.cxx:204 + #2 0x00007fd754ae1424 in comphelper::OCommonAccessibleComponent::disposing() (this=0x55bf49c0ad00) at .../libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:61 + #3 0x00007fd74e884512 in VCLXAccessibleComponent::disposing() (this=0x55bf49c0ad00) at .../libreoffice/toolkit/source/awt/vclxaccessiblecomponent.cxx:376 + #4 0x00007fd6a3d506b7 in accessibility::AccessibleListBox::disposing() (this=0x55bf49c0ad00) at .../libreoffice/accessibility/source/extended/accessiblelistbox.cxx:246 + #5 0x00007fd75453f544 in cppu::WeakComponentImplHelperBase::dispose() (this=0x55bf49c0ad00) at .../libreoffice/cppuhelper/source/implbase.cxx:104 + #6 0x00007fd6a3d45fd5 in cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessibleContext2, com::sun::star::accessibility::XAccessibleEventBroadcaster>::dispose() (this=0x55bf49c0ad00) + at include/cppuhelper/compbase.hxx:90 + #7 0x00007fd75453f1fe in cppu::WeakComponentImplHelperBase::release() (this=0x55bf49c0ad00) at .../libreoffice/cppuhelper/source/implbase.cxx:79 + #8 0x00007fd6a3d47d85 in cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessibleContext2, com::sun::star::accessibility::XAccessibleEventBroadcaster>::release() (this=0x55bf49c0ad00) + at include/cppuhelper/compbase.hxx:86 + #9 0x00007fd6a3d47ca5 in cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent, com::sun::star::accessibility::XAccessibleExtendedComponent>::release() (this=0x55bf49c0ad00) at include/cppuhelper/implbase.hxx:171 + #10 0x00007fd6a3d47c85 in cppu::ImplInheritanceHelper<comphelper::OAccessibleExtendedComponentHelper, com::sun::star::lang::XServiceInfo>::release() (this=0x55bf49c0ad00) at include/cppuhelper/implbase.hxx:171 + #11 0x00007fd6a3d45f55 in cppu::ImplInheritanceHelper<VCLXAccessibleComponent, com::sun::star::accessibility::XAccessible, com::sun::star::accessibility::XAccessibleSelection>::release() (this=0x55bf49c0ad00) + at include/cppuhelper/implbase.hxx:171 + #12 0x00007fd74282e13e in com::sun::star::uno::Reference<com::sun::star::uno::XInterface>::~Reference() (this=0x55bf49c0e860) at include/com/sun/star/uno/Reference.hxx:114 + #13 0x00007fd7428524c5 in std::destroy_at<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >(com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*) (__location=0x55bf49c0e860) + at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:88 + #14 0x00007fd7428524a5 in std::_Destroy<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >(com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*) (__pointer=0x55bf49c0e860) + at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:149 + #15 0x00007fd742852477 in std::_Destroy_aux<false>::__destroy<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*>(com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*, com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*) (__first=0x55bf49c0e860, __last=0x55bf49c0e868) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:163 + #16 0x00007fd74285243d in std::_Destroy<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*>(com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*, com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*) (__first=0x55bf49c0e860, __last=0x55bf49c0e868) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:195 + #17 0x00007fd742852379 in std::_Destroy<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*, com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >(com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*, com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*, std::allocator<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >&) (__first=0x55bf49c0e860, __last=0x55bf49c0e868) + at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/alloc_traits.h:948 + #18 std::__cxx1998::vector<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, std::allocator<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> > >::~vector() (this=0x55bf4d1120f8) + at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_vector.h:732 + #19 0x00007fd74285231d in std::__debug::vector<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, std::allocator<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> > >::~vector() (this=0x55bf4d1120e0) + at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/debug/vector:230 + #20 0x00007fd7428522f5 in o3tl::sorted_vector<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, std::less<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >, o3tl::find_unique>::~sorted_vector() + (this=0x55bf4d1120e0) at include/o3tl/sorted_vector.hxx:47 + #21 0x00007fd74284f83d in DocumentFocusListener::~DocumentFocusListener() (this=0x55bf4d1120b0) at vcl/inc/unx/gtk/gtkdata.hxx:221 + #22 0x00007fd74284f869 in DocumentFocusListener::~DocumentFocusListener() (this=0x55bf4d1120b0) at vcl/inc/unx/gtk/gtkdata.hxx:221 + #23 0x00007fd7546453a0 in cppu::OWeakObject::release() (this=0x55bf4d1120b0) at .../libreoffice/cppuhelper/source/weak.cxx:230 + #24 0x00007fd742834415 in cppu::WeakImplHelper<com::sun::star::accessibility::XAccessibleEventListener>::release() (this=0x55bf4d1120b0) at include/cppuhelper/implbase.hxx:115 + #25 0x00007fd754aec91e in com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>::~Reference() (this=0x55bf4896c088) at include/com/sun/star/uno/Reference.hxx:114 + #26 0x00007fd754aec8e5 in std::destroy_at<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> >(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*) + (__location=0x55bf4896c088) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:88 + #27 0x00007fd754aec8c5 in std::_Destroy<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> >(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*) + (__pointer=0x55bf4896c088) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:149 + #28 0x00007fd754aec897 in std::_Destroy_aux<false>::__destroy<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*>(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*, com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*) (__first=0x55bf4896c088, __last=0x55bf4896c090) + at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:163 + #29 0x00007fd754aec85d in std::_Destroy<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*>(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*, com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*) (__first=0x55bf4896c080, __last=0x55bf4896c090) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:195 + #30 0x00007fd754aec799 in std::_Destroy<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*, com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> >(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*, com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> >&) (__first=0x55bf4896c080, __last=0x55bf4896c090) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/alloc_traits.h:948 + --Type <RET> for more, q to quit, c to continue without paging-- + #31 std::__cxx1998::vector<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> > >::~vector() + (this=0x55bf49866bc8) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_vector.h:732 + #32 0x00007fd754aec73d in std::__debug::vector<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> > >::~vector() (this=0x55bf49866bb0) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/debug/vector:230 + #33 0x00007fd754aec715 in o3tl::cow_wrapper<std::__debug::vector<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> > >, o3tl::ThreadSafeRefCountingPolicy>::impl_t::~impl_t() (this=0x55bf49866bb0) at include/o3tl/cow_wrapper.hxx:176 + #34 0x00007fd754aec6e4 in o3tl::cow_wrapper<std::__debug::vector<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> > >, o3tl::ThreadSafeRefCountingPolicy>::release() (this=0x55bf49b28380) at include/o3tl/cow_wrapper.hxx:207 + #35 0x00007fd754aec675 in o3tl::cow_wrapper<std::__debug::vector<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> > >, o3tl::ThreadSafeRefCountingPolicy>::~cow_wrapper() (this=0x55bf49b28380) at include/o3tl/cow_wrapper.hxx:271 + #36 0x00007fd754ae6ae5 in comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener>::~OInterfaceContainerHelper4() (this=0x55bf49b28380) at include/comphelper/interfacecontainer4.hxx:126 + #37 0x00007fd754ae7c49 in std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >::~pair() (this=0x55bf49b28378) + at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_pair.h:187 + #38 0x00007fd754ae7c25 in std::destroy_at<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> > >(std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >*) (__location=0x55bf49b28378) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:88 + #39 0x00007fd754ae7b4b in std::allocator_traits<std::allocator<std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false> > >::destroy<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> > >(std::allocator<std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false> >&, std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >*) + (__a=..., __p=0x55bf49b28378) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/alloc_traits.h:560 + #40 std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false> > >::_M_deallocate_node(std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false>*) + (this=0x7fd754d2aaa8 <(anonymous namespace)::gaClients+40>, __n=0x55bf49b28370) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/hashtable_policy.h:2011 + #41 0x00007fd754ae7ab5 in std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false> > >::_M_deallocate_nodes(std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false>*) + (this=0x7fd754d2aaa8 <(anonymous namespace)::gaClients+40>, __n=0x0) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/hashtable_policy.h:2033 + #42 0x00007fd754ae79df in std::_Hashtable<unsigned int, std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, std::allocator<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> > >, std::__detail::_Select1st, std::equal_to<unsigned int>, std::hash<unsigned int>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::clear() (this=0x7fd754d2aaa8 <(anonymous namespace)::gaClients+40>) + at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/hashtable.h:2524 + #43 0x00007fd754af6415 in std::__cxx1998::unordered_map<unsigned int, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener>, std::hash<unsigned int>, std::equal_to<unsigned int>, std::allocator<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> > > >::clear() (this=0x7fd754d2aaa8 <(anonymous namespace)::gaClients+40>) + at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/unordered_map.h:798 + #44 0x00007fd754ae778d in std::__debug::unordered_map<unsigned int, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener>, std::hash<unsigned int>, std::equal_to<unsigned int>, std::allocator<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> > > >::clear() (this=0x7fd754d2aa80 <(anonymous namespace)::gaClients>) + at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/debug/unordered_map:234 + #45 0x00007fd754ae6640 in comphelper::AccessibleEventNotifier::shutdown() () at .../libreoffice/comphelper/source/misc/accessibleeventnotifier.cxx:268 + #46 0x00007fd74d3c5e41 in DeInitVCL() () at .../libreoffice/vcl/source/app/svmain.cxx:619 + #47 0x00007fd74d3c4031 in ImplSVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:254 + #48 0x00007fd74d3c5f79 in SVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:261 + #49 0x00007fd7565a4ba3 in soffice_main() () at .../libreoffice/desktop/source/app/sofficemain.cxx:94 + #50 0x000055bf472e7a5d in sal_main () at .../libreoffice/desktop/source/app/main.c:51 + #51 0x000055bf472e7a37 in main (argc=3, argv=0x7ffccdc2c9a8) at .../libreoffice/desktop/source/app/main.c:49 + + Change-Id: I251b2f97184e0492f02eb772e5906847f9249506 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164090 + Tested-by: Jenkins + Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> + (cherry picked from commit 2ea7cdf9876ce2de61458982247ab6861e1aac2f) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163988 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-02-29 Michael Weghorn <m.weghorn@posteo.de> [5cb1fa2a98f61f161ff8b3c19919dad539b36d87] + + tdf#159910 a11y: Dispose VCLXAccessibleList children + + In `VCLXAccessibleList::HandleChangedItemList`, + don't just clear the vector of list items, but + dispose them first. + + To avoid code duplication, extract a helper method + from `VCLXAccessibleList::disposing` which already + disposes the children since + + commit 51de048ae97cbd371457dbc07120e30db9ee4187 + Author: Michael Weghorn <m.weghorn@posteo.de> + Date: Mon Sep 4 17:19:03 2023 +0200 + + tdf#157088 a11y: Dispose list items with list + + This fixes a similar crash/assert on exit, seen after using the + Navigator in Writer (in particular the combo/listboxes in + there) with the qt6 VCL plugin and the Orca screen reader + running. + + stderr showed this: + + soffice.bin: .../libreoffice/comphelper/source/misc/accessibleeventnotifier.cxx:142: bool (anonymous namespace)::implLookupClient(const AccessibleEventNotifier::TClientId, ClientMap::iterator &): Assertion `rClients.end() != rPos && "AccessibleEventNotifier::implLookupClient: invalid client id " "(did you register your client?)!"' failed. + Aborted + + Backtrace: + + 1 __pthread_kill_implementation pthread_kill.c 44 0x7f0e1a4a816c + 2 __pthread_kill_internal pthread_kill.c 78 0x7f0e1a4a81cf + 3 __GI_raise raise.c 26 0x7f0e1a45a472 + 4 __GI_abort abort.c 79 0x7f0e1a4444b2 + 5 __assert_fail_base assert.c 92 0x7f0e1a4443d5 + 6 __assert_fail assert.c 101 0x7f0e1a4533a2 + 7 (anonymous namespace)::implLookupClient accessibleeventnotifier.cxx 140 0x7f0e18ce59ac + 8 comphelper::AccessibleEventNotifier::revokeClientNotifyDisposing accessibleeventnotifier.cxx 185 0x7f0e18ce5e68 + 9 VCLXAccessibleListItem::disposing vclxaccessiblelistitem.cxx 164 0x7f0ddf7d237f + 10 cppu::WeakComponentImplHelperBase::dispose implbase.cxx 104 0x7f0e1873f544 + 11 cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessible, com::sun::star::accessibility::XAccessibleContext, com::sun::star::accessibility::XAccessibleComponent, com::sun::star::accessibility::XAccessibleEventBroadcaster, com::sun::star::accessibility::XAccessibleText, com::sun::star::lang::XServiceInfo>::dispose compbase.hxx 90 0x7f0ddf7cb7c5 + 12 cppu::WeakComponentImplHelperBase::release implbase.cxx 79 0x7f0e1873f1fe + 13 cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessible, com::sun::star::accessibility::XAccessibleContext, com::sun::star::accessibility::XAccessibleComponent, com::sun::star::accessibility::XAccessibleEventBroadcaster, com::sun::star::accessibility::XAccessibleText, com::sun::star::lang::XServiceInfo>::release compbase.hxx 86 0x7f0ddf7cd0c5 + 14 com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible>::~Reference Reference.hxx 114 0x7f0e06bbccbe + 15 QtAccessibleWidget::~QtAccessibleWidget QtAccessibleWidget.hxx 39 0x7f0e06bd618d + 16 QtAccessibleWidget::~QtAccessibleWidget QtAccessibleWidget.hxx 39 0x7f0e06bd6219 + 17 QAccessibleCache::deleteInterface qaccessiblecache.cpp 173 0x7f0e05545319 + 18 QAccessibleCache::~QAccessibleCache qaccessiblecache.cpp 31 0x7f0e0554492a + 19 QAccessibleCache::~QAccessibleCache qaccessiblecache.cpp 32 0x7f0e055449b0 + 20 cleanupAccessibleCache qaccessiblecache.cpp 24 0x7f0e05544896 + 21 qt_call_post_routines qcoreapplication.cpp 332 0x7f0e05faf826 + 22 QApplication::~QApplication qapplication.cpp 665 0x7f0e0419e24a + 23 QApplication::~QApplication qapplication.cpp 722 0x7f0e0419e55c + 24 std::default_delete<QApplication>::operator() unique_ptr.h 99 0x7f0e06c5d63c + 25 std::__uniq_ptr_impl<QApplication, std::default_delete<QApplication>>::reset unique_ptr.h 211 0x7f0e06c5df7c + 26 std::unique_ptr<QApplication, std::default_delete<QApplication>>::reset unique_ptr.h 509 0x7f0e06c58bfd + 27 QtInstance::~QtInstance QtInstance.cxx 305 0x7f0e06c51184 + 28 QtInstance::~QtInstance QtInstance.cxx 302 0x7f0e06c51279 + 29 DestroySalInstance salplug.cxx 368 0x7f0e114c0a18 + 30 DeInitVCL svmain.cxx 625 0x7f0e115c5e7d + 31 ImplSVMain svmain.cxx 254 0x7f0e115c4031 + 32 SVMain svmain.cxx 261 0x7f0e115c5f79 + 33 soffice_main sofficemain.cxx 94 0x7f0e1a7a4ba3 + 34 sal_main main.c 51 0x559ce9c67a5d + 35 main main.c 49 0x559ce9c67a37 + + Change-Id: Ic5121645a6920a8ac35154dda1dcfa1974ab9d4a + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164062 + Tested-by: Jenkins + Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> + (cherry picked from commit b5f943fabbd73aa8a0c972ca8c37d6fda56a7385) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163983 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-02-29 Miklos Vajna <vmiklos@collabora.com> [ab51c235672dd6da2feafbe3f26625ee14889bf9] + + Related: tdf#158986 sw floattable, RTF import: use more setNeedPar() + + See + <https://gerrit.libreoffice.org/c/core/+/163844/1#message-ea0bfde78fa24ad83e5c153ecaddbf897a89f547>, + this keeps the bug fixed but is a better version, as pointed out by + Michael S: + + > there was a bug where dispatching PAR here caused a deferred page + > break to be lost, which was fixed by calling setNeedPar(true) instead. + + (cherry picked from commit c98ff922831f56253af2a050b8e07cfc89b7a387) + + Change-Id: Ibe6e4c14286d40d3066ce9cb7fac9f6847fb81dd + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164095 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-02-29 Miklos Vajna <vmiklos@collabora.com> [0ed1604de9448e0898a6894d9a8262272aea4766] + + tdf#158986 sw floattable: fix RTF import of table followed by \sect + + The bugdoc had a floating table, immediately followed by a section + break. The floating table went to the second page, should be on the + first page. + + The trouble is that RTF's section break is just a special symbol, so we + can have a section break right after a floating table. This is in + constrast with DOCX where a non-last section break is a paragraph + property, so it's guaranteed to have at least a paragraph start after a + floating table and before a section break, which can nicely serve as an + anchor point for the floating table. + + Fix the problem similar to what the OOXML tokenizer did in a similar + case in commit 01ad8ec4bb5425446e95dbada81de435646824b4 (sw floattable: + fix lost tables around a floating table from DOCX, 2023-06-05), by + injecting a paragraph before the section break. + + Handling this at a tokenizer level seems to be the right place, since + the DOCX version of the same document was already imported OK. + + Change-Id: Ic945c472c08ba872a5c46e2b8f75e919678aa0a0 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163929 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + Tested-by: Jenkins + (cherry picked from commit b7c4c4d45f44a26283678f3dc32982b3a728c614) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163844 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-02-28 Heiko Tietze <tietze.heiko@gmail.com> [9b0ec6639e7218b93551fc680b0929a73ac1fd90] + + Resolves tdf#131550 - Suppress Donate/Involve infobar if another is visible + + Change-Id: I013f0a1f0aa020f10d6beb21940959508eba4547 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164082 + Tested-by: Jenkins + Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> + (cherry picked from commit 607740654f2264e13469e4da1d020448217d7222) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164114 + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + +2024-02-28 Mike Kaganski <mike.kaganski@collabora.com> [153b3bae5ea6d0d59cf80c1ca1c32df8bfef57ef] + + tdf#159938: only apply wrap when the content was modified + + Change-Id: I2f18739239401085a06bbdce6623a484c13d680b + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164091 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit f0d8f72eb3447b705d1dcdc35a6f3c66a880ab7e) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164111 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-28 Mike Kaganski <mike.kaganski@collabora.com> [97d37a63a9adaff2256944189b9454373d192dcb] + + tdf#157135 workaround: restore and update windows-no-utf8-locales.patch.0 + + This partially reverts commit ed259e5efe432386b54c553cbc644b3b64976852 + (Upgrade external/boost to latest Boost 1.81.0, 2023-01-05), which had + dropped the patch previously introduced with commit + f046fed2782f0d4244aff719ba70a56399a2583a (Don't ever attempt to initialise + a std::locale with a UTF-8 locale on Windows, 2018-05-17). + + It seems that there is a nightmare going on in MSVCRT, and tdf#157135 + is caused by dome MS bug. The problem happens in a deeply nested call + to mbstowcs_s (several levels deep from std::locale constructor with + name of "en_US.UTF-8"), which gets a non-null wcstr and sizeInWords + equal to zero, which generates an invalid argument handler, resulting + in a failed assertion "(pwcs == nullptr && sizeInWords == 0) || (pwcs + != nullptr && sizeInWords > 0)" in _mbstowcs_internal from + minkernel\crts\ucrt\src\appcrt\convert\mbstowcs.cpp:245, and a crash. + The crashreporter initiates, but since it tries to use CRT itself, + which is in fastfail mode, it hangs. + + The patch that is restored here was intended for something different; + but it happily workarounds the nightmare. Until the proper fix found, + let it be. + + Change-Id: Ic978f87e2e7b81fc2e1cd182a4247084ad016a9f + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164068 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit 072a25e1ef4815bbef4f18f59f025862a0d8e876) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163984 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-02-27 Mike Kaganski <mike.kaganski@collabora.com> [dfbe587e1ef565225ceb4a66c23c76ae0e3a8329] + + tdf#159908: return early to avoid nullptr dereference + + When aLvalue is not a variable, its GetRealVar() returns nullptr. + That was dereferenced unconditionally later in the check of the + variable after NEXT. + + Change-Id: Ia46f23a7e720431bf62ace998848b684aa8449e8 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164002 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit 8bbfbe92c01bff38ed2241da56560b84f7954beb) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163975 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-02-27 Khaled Hosny <khaled@libreoffice.org> [fb3b8d1c82dbbccf0bc456662a2a2d7e24da5fdd] + + tdf#159251: Revert "vcl: Allow pushing/popping OutputDevice’s RTLEnabled + + ...state" + + This reverts commit 611694b707eb43e4c0f20b781f6869016a3ba099. + + Change-Id: I044e6a1fb08f482c6b494e87f9c23e2303b97fd1 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163951 + Tested-by: Jenkins + Reviewed-by: خالد حسني <khaled@libreoffice.org> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164019 + +2024-02-27 Khaled Hosny <khaled@libreoffice.org> [672378476d214290a10cdaaa03f591bdd4a8ecf5] + + tdf#159251: Don’t use vcl::PushFlags::RTLENABLED + + I’m going to remove it. + + Change-Id: I23af5c67633069b7bb6b15c88bdea757815816ce + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163950 + Tested-by: Jenkins + Reviewed-by: خالد حسني <khaled@libreoffice.org> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164018 + +2024-02-27 Khaled Hosny <khaled@libreoffice.org> [9393b6fcd08db7cb7776388393bb42d318b8a87b] + + tdf#159251: Blind fix + + Hopefully fixes regression introduced in: + + commit 611694b707eb43e4c0f20b781f6869016a3ba099 + Author: Khaled Hosny <khaled@libreoffice.org> + Date: Thu Aug 17 17:39:29 2023 +0300 + + vcl: Allow pushing/popping OutputDevice’s RTLEnabled state + + Change-Id: I9236bd6951d83a512390934127031204d94d14bb + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163877 + Tested-by: Jenkins + Reviewed-by: خالد حسني <khaled@libreoffice.org> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164017 + +2024-02-27 Michael Stahl <michael.stahl@allotropia.de> [a06a5905df7af2f6b69133e419dbfa99d232ab02] + + tdf#147731 sw: fix memory leak in SwDoc::CopyPageDesc() + + Commit 963de9feb37105560fde14b44d992e47f341bb5b "sw: fix issue with + copying stashed frame format" fixed the actual bug here, but introduced + a new memory leak. + + This causes an assert in CppunitTest_uiwriter3: + cppunittester: svl/source/items/itempool.cxx:779: void SfxItemPool::Remove(const SfxPoolItem&): Assertion `rItem.GetRefCount() && "RefCount == 0, Remove impossible"' failed. + + The assert happens only when this is backported to the libreoffice-7-6 + branch, because commit ab7c81f55621d7b0d1468c63305163016dd78837 "ITEM: + Get away from classic 'poolable' Item flag" removed the assert. + + The problem is that a SwFormatFrameSize inside a footer SwFrameFormat is + leaked 4 times, because 4 SwFrameFormats are leaked; the leak is that + SwDoc::CopyPageDesc() creates a new pNewFormat, passed it to + StashFrameFormat(), which copies it but doesn't free it. + + There is also a usage of std::shared_ptr here that is very questionable; + SwFrameFormat should never be shared between different SwPageDesc. + + (regression from commit b802ab694a8a7357d4657f3e11b571144fa7c7bf) + + Change-Id: I44133bc5e6789a51ce064f1aa5ea8b325224365b + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163854 + Tested-by: Jenkins + Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> + (cherry picked from commit 5c4ae1b19c51dcd62dad8e1d3e8beb87a0311352) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163846 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-27 Justin Luth <jluth@mail.com> [759c9ea8e66b5fc1a362cf914055ac498fbbd80a] + + tdf#159865 Revert "tdf#136905 NBB: let ValueSetWithTextControl set optimal" + + ...height + + This reverts my 24.2 commit 1876feb8a8805b2f80537e2828c152ccbdf67fe2. + + Change-Id: I70c3668393a13992f9ce489e86b07860218445b6 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163954 + Tested-by: Justin Luth <jluth@mail.com> + Reviewed-by: Justin Luth <jluth@mail.com> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163961 + Tested-by: Jenkins + +2024-02-26 Julien Nabet <serval2412@yahoo.fr> [0e803a23b8a1c4c66cdd3cef00252867ba9a1193] + + tdf#159862: set SearchWildcard to false changes SearchRegularExpression value + + Like this since 2016 with 3a0abd3019ec3ca29b8f1378cdb32ebf741e6306 + add SvxSearchItem::GetWildcard() SetWildcard() + + Change-Id: Id988a6e58488af6b1f274a318e9d1f52c7a8b169 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163876 + Reviewed-by: Julien Nabet <serval2412@yahoo.fr> + Tested-by: Jenkins + (cherry picked from commit d05e863c69b5611964a4a2eb242ee9566cfb659e) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163836 + Reviewed-by: Eike Rathke <erack@redhat.com> + +2024-02-26 Khaled Hosny <khaled@libreoffice.org> [4f4003ea7d9292d4b57ff88f6f44bed31337f0a5] + + tdf#124591: upgrade NotoKufiArabic to v2.109 + + https://github.com/notofonts/arabic/releases/tag/NotoKufiArabic-v2.109 + + Change-Id: Ifc6d9b6ec3e41dac27406b7582734c2cfd173a5a + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163878 + Tested-by: خالد حسني <khaled@libreoffice.org> + Reviewed-by: خالد حسني <khaled@libreoffice.org> + (cherry picked from commit a7e2f44d64e729027fac0cfeaa896d5d76385a6a) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163842 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-26 Xisco Fauli <xiscofauli@libreoffice.org> [cc2a6503e62103e8767108d064774639d1d9f34f] + + Revert "tdf#159752: Add missing NotoSans/NotoSerif fonts back" + + This reverts commit aa49b95cd1bb2baa357c9aac7e5d046630ffac85. + + Reason for revert: https://bugs.documentfoundation.org/show_bug.cgi?id=159752#c8 + + Change-Id: I3f62e179240419d6cc19d9db2bf6d07673d48e05 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163838 + Tested-by: Jenkins + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + (cherry picked from commit 4114b916102d7df76f7a59b4d82435d9ab0ffec6) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163841 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-25 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [2a18ca440961210b8f71cbabc2cf205d194169ef] + + update credits + + Change-Id: Ie2fc3de7861b870d5a4b2aa9943af7401f21a1b7 + (cherry picked from commit fe47872aa8380567af7f453b9d3466cf7acd0d12) + +2024-02-25 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [f386442d0c067cc070626ee228ed6f885244dc0c] + + Update git submodules + + * Update translations from branch 'libreoffice-24-2' + to e674dbc9fb3e9fbbeefa4d4db7e5f98f0c057bbe + - update translations for 24.2.1 rc2 + + and force-fix errors using pocheck + + Change-Id: I529205bfbe25f3e4a843743d37ba26c23b626a84 + +2024-02-23 Justin Luth <jluth@mail.com> [bb207d7816c2d32d02ee11ff784d405d2bb5de0f] + + tdf#159824 MCGR rtf export: don't lose gradient's axial-ness + + This fixes alg's 7.6 regression from + commit bb198176684c3d9377e26c04a29ec66deb811949 + + Found when trying to import these strung-out-linears + as real axials. + + make CppunitTest_sw_rtfexport \ + CPPUNIT_TEST_NAME=testTdf159824_axialGradient + + Change-Id: I220f1bf689b4b219bc0ae187e95aedb1a29a7233 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163705 + Tested-by: Jenkins + Reviewed-by: Justin Luth <jluth@mail.com> + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + (cherry picked from commit 9ba68c769d41d1075152a22bf37e78fb9320317b) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163769 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-02-23 Xisco Fauli <xiscofauli@libreoffice.org> [3a423e3a288a9a5b10af6119e58123649f38e6a3] + + libpng: upgrade to 1.6.42 + + Change-Id: I03fccf59bb1c2fa51478e812e629ff2ffac0e893 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163593 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + (cherry picked from commit 7b2ddc88019852b7731b888e7b8eb669e760a8d7) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163830 + Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> + +2024-02-23 Xisco Fauli <xiscofauli@libreoffice.org> [73bec7219024319caf9898b7d2ab94feeb877a62] + + tdf#159752: Add missing NotoSans/NotoSerif fonts back + + They were dropped in 69943f33bf219558d6b219f0eaeda1e25e487b05 + "tdf#124591: Update Noto Sans to v2.012" and + 96aba2de78ffa641f6c0c898b99158715b2f2703 + "tdf#124591: Update Noto Serif to v2.012" + for no apparent reason. + Re-add them since they are still available upstream + + Change-Id: Ifd5eb72bd95be96f2ff965b17846cf76aacb0c7d + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163833 + Tested-by: Jenkins + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-02-23 Oliver Specht <oliver.specht@cib.de> [e3fed54f866ac6880c9977d800aa455d3d37de5d] + + tdf#159793 Save printer paper tray in RTF and DOCX + + Saves the paper tray id as w:paperSrc w:first and w:other in docx + and \binfsxn and \binsxn in RTF + Change-Id: I79004f54aba3b6609d7921afacf815726f7f2678 + + Change-Id: Ie3c11fffa6a133250b7db69b4e845bccaa8e2280 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163654 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 8b191a6566065438417665af32fa30f8346ad4df) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163831 + +2024-02-23 Jaume Pujantell <jaume.pujantell@collabora.com> [ccda2c60affd2c10f4a23046e3a9332265b357af] + + libvisio: read and use simple solid fill styles + + Implemented the reading of simple solid fills from the fill styles list + in a vsdx theme. And it's use with the quick style fill matrix value. + + This patch includes an alternative fix to tdf#77915 so the previous patch + is no longer needed. + + Change-Id: Iccfe915c90bcb1280cfcbfa4920d2989d18518ee + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163581 + Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> + Reviewed-by: Andras Timar <andras.timar@collabora.com> + (cherry picked from commit fb9ca6bba9bc3ce9feb9a066636dcd986dca096b) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163544 + Tested-by: Jenkins + (cherry picked from commit 043e090069b3bd4c660743f6f639d002f403a7b8) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163546 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-02-23 Xisco Fauli <xiscofauli@libreoffice.org> [74a12bcb96d8e602006be933d29ccc3c7238740d] tdf#159743: Revert all Shortcut modifications in German UI @@ -101,100 +1766,60 @@ Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> - Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163809 - Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> - Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> -2024-02-25 Michael Stahl <michael.stahl@allotropia.de> [96861294836862f8a051a9d6dd390ab15c0460e4] +2024-02-22 Michael Stahl <michael.stahl@allotropia.de> [ca089311678ca6f84771c145178bf4153243ed45] - tdf#159519 comphelper,package: do not store document without SHA256 - - The problem is that on Windows 7 the password-encrypted documents are - stored unencrypted, without any error message. - - This is due to defensive programming in - OStorageHelper::CreatePackageEncryptionData(), which happily continues - if creating the SHA256 hash fails, which is the one required for storing - anything newer than ODF 1.1. - - Also, the poorly named ZipPackage::GetEncryptionKey() should check for - consistency, the expectation is that either there's no encryption key - (empty sequence), or the expected one is in the sequence. - - Creating the SHA256 uses the crypto::NSSInitializer component, which is - in xsec_xmlsec.dll, which is linked to libxmlsec-mscng.dll, which is - linked to Win32 bcrypt.dll, which doesn't have BCryptKeyDerivation on - Windows 7; to reproduce elsewhere, rm instdir/program/libxsec_xmlsec.so + libxml2: upgrade to release 2.12.5 - (regression from commit 26bf26272bf525b59b4a4ce18b3ce14c1febfd7b - and (due to revert) commit bfd479abf0d1d8ce36c3b0dcc6c824216f88a95b) + Fixes CVE-2024-25062 - Change-Id: I0b22e20f6d4d0b1a12ed7d99fac7b5243910f9ba - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163708 + Change-Id: I0e98fd919328e9633a602c4872de0b06eb972cc0 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163734 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> - (cherry picked from commit 58c31ded0264103769595a1b25739b0e8df571cd) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163750 + (cherry picked from commit 4c3ee61e3eda0cbfd812443f80af89aa3a24ac73) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163753 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> - (cherry picked from commit 003f2ac9fcac9be5156adf280beaf4e2aa499ea5) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163762 - Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> - Reviewed-by: Hossein <hossein@libreoffice.org> - Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> - Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> -2024-02-25 Mike Kaganski <mike.kaganski@collabora.com> [a224f85c9bb9ab0a2e5a833dcb5ebb3eab4d7ea3] +2024-02-22 Patrick Luby <guibmacdev@gmail.com> [618e977e7f6973bf36bf83c04f7802cb83f8064a] - tdf#159302: Another UNO property "BaseLine" needs to use mm/100s + tdf#159529 clear hb_ot_face_t data after fetching 'sbix' and 'glyf' tables - Change-Id: I6688577a41590624f1e1f08112f1308e810a7e37 - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163333 + The 'sbix' and 'glyf' tables can be very large for color emoji fonts + so clear any cached data in hb_ot_face_t after fetching that table's + extents. + + Change-Id: Id5deda9114b7199a4194ff16879e5791acd1cd82 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163674 Tested-by: Jenkins - Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> - (cherry picked from commit b6ef30d1b049977beb23d28a07d77012fa1daf47) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163339 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + (cherry picked from commit af47a78e11d4819bb4b1ae1a1277babd10d815b7) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163620 + Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> - (cherry picked from commit df41d922ef7e6c99f72d65dad04b56c82a79ae30) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163340 - Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> - Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> - Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> -2024-02-25 Julien Nabet <serval2412@yahoo.fr> [6d69bfd42eb5ecb06a0a2b4dec8819fb6d1561f2] +2024-02-22 Caolán McNamara <caolan.mcnamara@collabora.com> [050a2db3964d5f02e2dd149cb7f76342457a6719] - tdf#159707: fix crash when changing to edit mode (calc) - - bt: - 0x00007f9eb4b902f2 in com::sun::star::uno::Reference<com::sun::star::frame::XModel>::operator->() const (this=0x55b8c2b54888) at include/com/sun/star/uno/Reference.h:387 - 0x00007f9eb4c03584 in ScVbaEventsHelper::notifyEvent(com::sun::star::document::EventObject const&) (this=0x55b8c2b54840, rEvent=...) at /home/julien/lo/libreoffice/sc/source/ui/vba/vbaeventshelper.cxx:605 - 0x00007f9ef464bd3c in (anonymous namespace)::NotifySingleListenerIgnoreRE<com::sun::star::document::XEventListener, com::sun::star::document::EventObject>::operator()(com::sun::star::uno::Reference<com::sun::star::document::XEventListener> const&) const (this=0x7ffc5044dfc0, listener=uno::Reference to (ScVbaEventsHelper *) 0x55b8c2b54870) at /home/julien/lo/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:3293 - 0x00007f9ef463b8aa in comphelper::OInterfaceContainerHelper3<com::sun::star::document::XEventListener>::forEach<(anonymous namespace)::NotifySingleListenerIgnoreRE<com::sun::star::document::XEventListener, com::sun::star::document::EventObject> >((anonymous namespace)::NotifySingleListenerIgnoreRE<com::sun::star::document::XEventListener, com::sun::star::document::EventObject> const&) - (this=0x55b8c2735c18, func=...) at include/comphelper/interfacecontainer3.hxx:279 - 0x00007f9ef463b010 in SfxBaseModel::postEvent_Impl(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::frame::XController2> const&, com::sun::star::uno::Any const&) - (this=0x55b8c2308ae0, aName="OnUnload", xController=empty uno::Reference, supplement=uno::Any(void)) at /home/julien/lo/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:3338 - 0x00007f9ef463a089 in SfxBaseModel::Notify(SfxBroadcaster&, SfxHint const&) (this=0x55b8c2308ae0, rBC=..., rHint=...) at /home/julien/lo/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:2960 + upgrade libxml2, libxslt & liblangtag - See full bt here: - https://bugs.documentfoundation.org/attachment.cgi?id=192546 + what I'm really after is some vexating not-reproducible oss-fuzz msan + warnings when using libxml2 in the fodt2pdf fuzzer. So lets upgrade + libxml2 to the latest, which requires bumping libxslt, and then requires + a newer liblangtag because of no longer implicit includes that it + depended on. - Regression from: - https://git.libreoffice.org/core/+/d2fccf0117a37f8aab8bb50ece419987f06af6b9%5E%21 - "cool#6893 improve listeners in SfxBaseModel" + xmlKeepBlanksDefaultValue and xmlSubstituteEntitiesDefault are + deprecated, we should get around to updating those uses - Change-Id: I372808dade20c47275ab599054d8e9572dc3da4d - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163356 - Reviewed-by: Julien Nabet <serval2412@yahoo.fr> - Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + Change-Id: I8fda0dffda0a7ea65407d246a3121875cb8ad4a4 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161598 Tested-by: Jenkins - (cherry picked from commit 6c6b580428bc527da9af82da743616787617b39b) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163345 - Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> - Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> - Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> - Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + (cherry picked from commit 6875c975f80d8b813b1829a530162869a1e2d92e) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163751 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> -2024-02-25 Michael Stahl <michael.stahl@allotropia.de> [016b75f8289276468cde320067ae3519fdeb94f4] +2024-02-22 Michael Stahl <michael.stahl@allotropia.de> [cac153edee56ac2e57e60de1d0f77265ed48bd91] tdf#159519 libxmlsec: avoid linking function not existent in Windows 7 @@ -215,54 +1840,99 @@ (cherry picked from commit 0690f3b7b981417a7b1f2fffd87c593a2a2a15d5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163740 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> - (cherry picked from commit aacb4fce006b537dade0417c0637fd584f7f2c2a) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163761 - Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> - Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> - Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> -2024-02-23 Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> [8d52be7d87c3be4a4792a0fab36835a8a2680e59] +2024-02-22 Michael Stahl <michael.stahl@allotropia.de> [003f2ac9fcac9be5156adf280beaf4e2aa499ea5] - Fix typo: I10N -> L10N + tdf#159519 comphelper,package: do not store document without SHA256 - Change-Id: I20a0eb54a85a9dea5c7d4cd91ff3632574b14802 - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160714 - Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + The problem is that on Windows 7 the password-encrypted documents are + stored unencrypted, without any error message. + + This is due to defensive programming in + OStorageHelper::CreatePackageEncryptionData(), which happily continues + if creating the SHA256 hash fails, which is the one required for storing + anything newer than ODF 1.1. + + Also, the poorly named ZipPackage::GetEncryptionKey() should check for + consistency, the expectation is that either there's no encryption key + (empty sequence), or the expected one is in the sequence. + + Creating the SHA256 uses the crypto::NSSInitializer component, which is + in xsec_xmlsec.dll, which is linked to libxmlsec-mscng.dll, which is + linked to Win32 bcrypt.dll, which doesn't have BCryptKeyDerivation on + Windows 7; to reproduce elsewhere, rm instdir/program/libxsec_xmlsec.so + + (regression from commit 26bf26272bf525b59b4a4ce18b3ce14c1febfd7b + and (due to revert) commit bfd479abf0d1d8ce36c3b0dcc6c824216f88a95b) + + Change-Id: I0b22e20f6d4d0b1a12ed7d99fac7b5243910f9ba + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163708 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 58c31ded0264103769595a1b25739b0e8df571cd) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163750 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-22 Miklos Vajna <vmiklos@collabora.com> [b973805565be06aac4422fbb7af530fe8ee04bd0] + + tdf#159815 DOCX import: fix redlined to-char image followed by inline SDT + + The 2nd para of the bugdoc has a leading word, then a redlined anchored + shape, finally a redlined checkbox content control. The Writer import + result's content control starts at para start, while it should only + start after the anchored shape. + + What happens is that writerfilter::dmapper::DomainMapper_Impl::PushSdt() + gets called to remember the SDT start, then + DomainMapper_Impl::applyToggleAttributes() deletes some content since + commit 8726cf692299ea262a7455adcf6ec25451c7869d (tdf#142700 DOCX: fix + lost track changes of images, 2021-07-08), which invalidates the SDT + start position, finally PopSdt gets called, but that fails because our + start position is no longer valid. This used to abort the import + process. Since commit 1b0f67018fa1d514ebca59e081efdd24c1d7811b (docx + import: correct redline content-controls, 2024-02-20), the import + finishes the but start of the SDT is incorrect: it's at the para start, + while it should start in the middle of the paragraph. The direct reason + for the invalidation is a call to SwXTextRange::Impl::Notify(), which is + from a content deletion from applyToggleAttributes(). + + Fix the problem by not deleting content when we're past PushSdt() and we + haven't called PopSdt(): extract the redlined anchored shape code into a + new DomainMapper_Impl::MergeAtContentImageRedlineWithNext() and call + that also in DomainMapper_Impl::PushSdt() early, so it won't be called + when we're in the middle of an SDT. + + This way createTextCursorByRange() should not fail, so warn in case it + still fails in DomainMapper_Impl::PopSdt(). + + Change-Id: Ic4198804a92088ec268203d44c0da2d6997754b7 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163678 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163481 - Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> - Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> - Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163808 - Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163689 -2024-02-22 Regina Henschel <rb.henschel@t-online.de> [f09fbbd8ae57d59c6ca264b042927330249ce163] +2024-02-22 Balazs Varga <balazs.varga.extern@allotropia.de> [64248c5d42bbf46eeb4c41e79dd0b5e4a360e280] - tdf#156993 use correct count for ViewContactOfSdrPage + tdf#158360 - sw, ooxml import - fix insertTextPortion crash - The count is used as upper limit in a for-loop in - ViewObjectContact::getPrimitive2DSequenceSubHierarchy(). - That calls ViewContactOfSdrPage::GetViewContact(). - With the wrong count the case 10 was not reached and thus the helplines - were not drawn. + Before this patch da8dead8e9282010893cbd12519e107baf03cd1a + SvxUnoTextBase::insertTextPortion returned an empty XTextRange + in case of texts in comment. (SwTextAPIObject) Lets use + finishParagraphInsert which also give back an empty XTextRange. - Change-Id: If606bbb718b1f78a874862217d1e03b02287e848 - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163192 + regression from commit: da8dead8e9282010893cbd12519e107baf03cd1a + (tdf#73537 - sc: show author and creation date in calc comments) + + Change-Id: I0b33e5b3cae32718a62a7be04b9a88562f85652c + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163670 Tested-by: Jenkins - Reviewed-by: Regina Henschel <rb.henschel@t-online.de> - (cherry picked from commit 56517d8a38459f5a9e67327c1ac0dc8bcd07bcb8) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163180 - Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> - (cherry picked from commit 0f6e36496a1b398c5df1c8eb0570d5945d024e78) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163183 - Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> - Tested-by: Hossein <hossein@libreoffice.org> - Reviewed-by: Hossein <hossein@libreoffice.org> - Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> - Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> + (cherry picked from commit 7cf3d5e3073dc5cffc64b6d9b32513e90087a3d4) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163626 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> -2024-02-22 Miklos Vajna <vmiklos@collabora.com> [5572a3fe4f567f9167efe2d291af5d7d1c414d9e] +2024-02-21 Miklos Vajna <vmiklos@collabora.com> [866e411950645f0b5e8d473adbf6c3505119f9da] sw: fix crash in SwSpellDialogChildWindow::LockFocusNotification() @@ -289,135 +1959,197 @@ (cherry picked from commit d505b8d2730b93cea8d2dcf2656af37c6c8cc580) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163615 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> - (cherry picked from commit f6aa72589e0f20694c58af7a098558adb5c02abc) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163627 - Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> - Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> - Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> -2024-02-22 Noel Grandin <noel.grandin@collabora.co.uk> [5bd591dc06f174486a75991e785ae95fd99382c8] +2024-02-21 Miklos Vajna <vmiklos@collabora.com> [fd83dcf65fdc3ad41781ee30cf6f0777feb7e3bf] - tdf#159666 Crash when table and line object are selected at the same time + tdf#159483 sc HTML copy: handle data-sheets-value attribute for the bool case - before - commit e3077168072452fb8f1c0a8afb2992877cb96d1c - Author: Noel Grandin <noel.grandin@collabora.co.uk> - Date: Thu Jun 17 09:49:37 2021 +0200 - loplugin:finalclasses - the cast in - const SdrEdgeObj* pEdge = static_cast<SdrEdgeObj*>(m_pObj); - would incorrectly cast a SdrTableObj, but it happened to do nothing - problematic. + Similar to commit f8c95cf93ce9ab8b9b78f3af03411d0cc2e195ba (tdf#159483 + sc HTML import: handle data-sheets-value attribute for the bool case, + 2024-02-08). - After the above commit, the vtable layout changed and it started - crashing. - - Work around it by use dynamic_cast and ignoring objects that are not - SdrEdgeObj. - - Change-Id: Ibe03d4935b8eeb182e037b1648d841e26fa23ed4 - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163242 + Change-Id: I25ce8c81bd906ac0fb912e125e061516a604e786 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163419 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins - Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> - (cherry picked from commit bac09f76fd903c109b591a7bc15883e5653715ee) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163187 + (cherry picked from commit 411158832462b1077a8f5dc6379f2056f2338249) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163405 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> - (cherry picked from commit 12b25cb35eb9cbb08363f4bd45e9190d3ef674b5) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163270 - Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> - Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> - Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> -2024-02-22 Taichi Haradaguchi <20001722@ymail.ne.jp> [d8b1133a8fb9ddee010a9a38a25453f3b245ea9f] +2024-02-21 Mike Kaganski <mike.kaganski@collabora.com> [344c18c8e54a4382f7b990b58ed4c083d0568f74] - Expat: upgrade to release 2.6.0 + tdf#159813, tdf#159816: Use correct copied PaM - Fixes CVE-2023-52425 and CVE-2023-52426. + This fixes both the assertion in CopyFlyInFlyImpl (tdf#159813) and + crash in BigPtrArray::operator[] (tdf#159816). - Change-Id: Id135bbaea893a83129bdbee44948c09322a64c07 - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163146 + Change-Id: Ia3424e3a58c7d8fb3e1257dcdbf062fb893da8db + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163683 Tested-by: Jenkins - Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> - (cherry picked from commit b7e4078033b064bfc3847db0916a4df389117817) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163392 - Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> - (cherry picked from commit 66022adfa09662a082272f42bf0c34582abf38b1) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163397 - Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> - Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> - Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163698 -2024-02-22 Noel Grandin <noelgrandin@gmail.com> [7564f8651012ed0cbfbe6d37cd4effba308a2cd4] +2024-02-21 Oliver Specht <oliver.specht@cib.de> [9d0b8f692737e63614594d5f2c545d6e81b69fbb] - tdf#101313 Copy-paste table from writer to calc + tdf#159797 replace dash also between sentences - With Merged Cells from Writer to Calc, - Cells Placed in Wrong Position (Wrong cell offsets). + Autocorrection replaces " - " with " <enDash/emDash> " also after + dot, question mark and exclamation mark. - regression from - commit ed24564ce11683731b820c29d5a46e073ab7a2a7 - Author: Noel Grandin <noel@peralex.com> - Date: Thu Jul 19 15:22:31 2012 +0200 - SV_DECL_VARARR_SORT(ScRTFColTwips) o3tl::sorted_vector - - Change-Id: I8c90c19f6a27a368fd5807b3eaab84ce820e26e5 - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163518 + Change-Id: Iad4b6c6073ab90b0c86514b8683dd2a07197f59d + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163659 Tested-by: Jenkins - Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> - (cherry picked from commit 4df426e429e1aed92f074d8acd3ba3a5ec335ba9) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163532 - (cherry picked from commit b5a5cae0e78e989c421a376bb55a724981c74d87) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163545 - Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> - Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> - Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> - Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> + (cherry picked from commit 95017739a05c4f515fc42caebfd1e01e8a9ba160) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163625 + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> -2024-02-22 Patrick Luby <guibmacdev@gmail.com> [e0fd2489d5dd4b8b2bd41f6e42cfe64817a578da] +2024-02-21 Ashod Nakashian <ashod.nakashian@collabora.co.uk> [19883f7c86882f0367d072a0af034810c636c208] - tdf#159529 clear hb_ot_face_t data after fetching 'sbix' and 'glyf' tables + docx import: correct redline content-controls - The 'sbix' and 'glyf' tables can be very large for color emoji fonts - so clear any cached data in hb_ot_face_t after fetching that table's - extents. + When inserting and deleting content-controls + with change-tracking enabled, we hit a few + corner-cases that we need to handle more + smartly. - Change-Id: Id5deda9114b7199a4194ff16879e5791acd1cd82 - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163674 + First, we shouldn't redline the controls + themselves, just the placeholder text. + Second, we have to take special care + to create valid XML structure with + the redline tags. + + Includes unit-test that reproduces the + issues and verifies that both saving + and loading work as expected. + + Change-Id: I6af4d0d2c3f0661e7990d5414cc93effc96f0469 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163647 Tested-by: Jenkins - Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> - (cherry picked from commit af47a78e11d4819bb4b1ae1a1277babd10d815b7) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163622 - Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> - Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> - Reviewed-by: Patrick Luby <guibomacdev@gmail.com> - Tested-by: Patrick Luby <guibomacdev@gmail.com> + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163688 -2024-02-22 Balazs Varga <balazs.varga.extern@allotropia.de> [0a300e60ed73f76eeb61035086df6cf857a2fa85] +2024-02-21 Ashod Nakashian <ashod.nakashian@collabora.co.uk> [bfd6be7ebaeb1d53dbb51eea53e05beabe3487ec] - tdf#158360 - sw, ooxml import - fix insertTextPortion crash + sw: do not redline ContentControl items - Before this patch da8dead8e9282010893cbd12519e107baf03cd1a - SvxUnoTextBase::insertTextPortion returned an empty XTextRange - in case of texts in comment. (SwTextAPIObject) Lets use - finishParagraphInsert which also give back an empty XTextRange. + When we redline the ContentControl item + itself, we break docx XML. Instead, we + only need to redline the placeholder, + which we already do. - regression from commit: da8dead8e9282010893cbd12519e107baf03cd1a - (tdf#73537 - sc: show author and creation date in calc comments) + This simply disables redlining when + inserting the ContentControl item + while leaving it otherwise enabled + while inserting the placeholder. - Change-Id: I0b33e5b3cae32718a62a7be04b9a88562f85652c - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163670 + Before: + + <w:body> + <w:p> + <w:pPr> + <w:pStyle w:val="Normal"/> + <w:rPr></w:rPr> + </w:pPr> + ==> <w:ins w:id="-1" w:author="Unknown Author" w:date="2024-01-24T19:43:08Z"> + <w:sdt> + <w:sdtPr> + <w12:checkbox> + <w12:checked w14:val="0"/> + <w12:checkedState w14:val="2612"/> + <w12:uncheckedState w14:val="2610"/> + </w12:checkbox> + </w:sdtPr> + <w:sdtContent> + <w:r> + <w:rPr></w:rPr> + </w:r> + ==> </w:ins> + ==> <w:ins w:id="0" w:author="Unknown Author" w:date="2024-01-24T19:43:08Z"> + <w:r> + <w:rPr></w:rPr> + <w:t>☐</w:t> + </w:r> + ==> </w:ins> + <w:r> + <w:rPr></w:rPr> + </w:r> + </w:sdtContent> + </w:sdt> + </w:p> + </w:body> + + The first <w:ins> and its closing tag + is not seen in the reference docx + file, and we can see that it's invalid + XML here. + + After: + <w:body> + <w:p> + <w:pPr> + <w:pStyle w:val="Normal"/> + <w:rPr></w:rPr> + </w:pPr> + <w:sdt> + <w:sdtPr> + <w12:checkbox> + <w12:checked w14:val="0"/> + <w12:checkedState w14:val="2612"/> + <w12:uncheckedState w14:val="2610"/> + </w12:checkbox> + </w:sdtPr> + <w:sdtContent> + <w:r> + <w:rPr></w:rPr> + </w:r> + ==> <w:ins w:id="0" w:author="Unknown Author" w:date="2024-01-24T19:43:08Z"> + <w:r> + <w:rPr></w:rPr> + <w:t>☐</w:t> + </w:r> + ==> </w:ins> + <w:r> + <w:rPr></w:rPr> + </w:r> + </w:sdtContent> + </w:sdt> + </w:p> + </w:body> + + Only the valid <w:ins> around the + placeholder exists. + + Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk> + Change-Id: I1404e41aec3b5efdc2e4115236102ffa2733b15c + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162802 Tested-by: Jenkins - Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> - (cherry picked from commit 7cf3d5e3073dc5cffc64b6d9b32513e90087a3d4) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163626 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> - (cherry picked from commit 64248c5d42bbf46eeb4c41e79dd0b5e4a360e280) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163629 - Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> - Tested-by: Michael Stahl <michael.stahl@allotropia.de> - Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163687 -2024-02-21 Baole Fang <baole.fang@gmail.com> [613135cef0b6b2cc9d01d9a7126fb6707fd473f0] +2024-02-21 Patrick Luby <guibmacdev@gmail.com> [0060f63d88425149bb37331eb31d0f90372a2957] + + tdf#126638 dispatch key shortcut events to modal windows + + Some modal windows, such as the native Open and Save dialogs, + return NO from -[NSWindow performKeyEquivalent:]. Fortunately, + the main menu's -[NSMenu performKeyEquivalent:] is then called + so we can catch and redirect any modal window's key shortcut + events without triggering the modal window's "disallowed + action" beep. + + Change-Id: Ib1fff68ab159361ceb847881e3a4da4736a33f51 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163605 + Tested-by: Jenkins + Reviewed-by: Patrick Luby <guibomacdev@gmail.com> + (cherry picked from commit 64ca3756416f0355b2008f39120e68ac42269784) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163618 + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + +2024-02-20 Baole Fang <baole.fang@gmail.com> [9d48831793cdbf93975b71083fbcc9577c17fceb] tdf#159678: Fix heading dropdown list @@ -428,12 +2160,209 @@ (cherry picked from commit 694b9b6422ee27da13ad455174cde50b1a673ac7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163406 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> - (cherry picked from commit 9d48831793cdbf93975b71083fbcc9577c17fceb) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163617 + +2024-02-20 Miklos Vajna <vmiklos@collabora.com> [287d13d643bb98416baaf52179c1b32e70f2d269] + + tdf#159285 sw floattable: fix loop with inner table wrapped by inner table + + Regression from 868140fcc1311259b9d5f666637b33d226511a53 (tdf#60558 sw + floattable: allow wrap of table on the right of a floattable, + 2023-12-05), the bugdoc layout looped on load. + + Somehow the big while() loop in SwTabFrame::MakeAll() never finishes: it + always tries again but can't reach a state where all of frame area + position, frame area size and frame print area is valid. + + Fix the problem by going back to the old behavior (floating table is + wrapped by text frames, not by table frames) for the nested table case: + that keeps the old tdf#60558 use-case working and fixes the new + tdf#159285 use-case. + + At some point it would be useful to support the combination of nested + floating tables and the "floating table wrapped by table" combination, + but that will be a new layout feature. + + Change-Id: Ia3fdbd08de87e13ddef086ae1339e79a8833674d + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163630 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + Tested-by: Jenkins + (cherry picked from commit 2da4acdbf8c5a8ba3ef51e5f5dc3439716e71a91) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163612 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-02-20 Oliver Specht <oliver.specht@cib.de> [02ecd57a8364b4ca049c59a978c3b16c0389a6cd] + + tdf#159730 add compatibility option in RTF import + + Set IgnoreTabsAndBlanksForLineCalculation in RTF import to improve formatting. + + Change-Id: If0129f748c48400f1dd882672b5779f62e685ecd + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163429 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + Tested-by: Jenkins + (cherry picked from commit 3b04e74503ec6d07dc4befdb756e6abdc3de4e58) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163614 + +2024-02-20 Mike Kaganski <mike.kaganski@collabora.com> [42170a562a60fc878290a4efd5e6f39292e36ca3] + + tdf#159769: always make sure that default temporary directory exists + + This basically undoes commit 4743a32b4f991c57e4b8a66adf035b1808ca793a + (only need to create the folder for temp files once, 2022-05-18). To + avoid the overhead in TempFileFast, it now uses a new function to get + the path, which doesn't check that path exists. + + Change-Id: I9c910a55dc4992058a7168690561b02d682b5e56 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163576 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit 0b58f1a41bf8d58426f16e47f86d313172ad4585) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163541 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-02-20 Caolán McNamara <caolan.mcnamara@collabora.com> [7f27c90c12fbfc779771dc32362a60160bd99386] + + tdf#155961 put some spacing to the right of the "more options" toolbar + + the gtk overlay scrolling is all very pretty, but you can't click things + underneath, and there is no discoverable way to dismiss the scrollbar + to get "under" it, move this widget to the left a little to try and get + it outside the hotzone for the overlay scrolling. + + Change-Id: Ic9d48be4a29754e9aff0f29dbe32bea762b6cc09 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163543 + Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> - Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> -2024-02-20 Mike Kaganski <mike.kaganski@collabora.com> [adc2e086e7cbba4bb256a03df189a2e8ce273393] +2024-02-19 Kevin Ottens <kevin.ottens@enioka.com> [a8814b5921676b1c01a19b0af243712c55fb0307] + + tdf#55004 Fix backup copy creation for files on mounted samba shares + + There is an unfortunate interaction between file locking and backup + creation at save time. + + openFilePath has logic to lock a file when opening. This goes through + fcntl to set a write lock on the file. Later on, when the user wants to + save changes, a backup copy might be created (very likely now since this + is the defaults in the settings). To create this backup, the file is + opened again for reading. Unfortunately this open call fails due to the + lock (even though it is a write lock). + + This commit changes the behavior. osl_file_adjustLockFlags now checks if + the file is on a mounted samba share. If that's the case we force the + osl_File_OpenFlag_NoLock flag. No issue is then exhibited at backup + creation, allowing the save to proceed properly. + + Change-Id: Ieab252f9f68598834e13339fc5fcea440f0a4c2f + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162935 + Tested-by: Jenkins + Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> + (cherry picked from commit 63efbc8ad8aae12b54e649c1495d1233c1a9b33f) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163549 + +2024-02-19 Justin Luth <justin.luth@collabora.com> [38ff7cd25af90dcde19f33aaede23935df6758d8] + + tdf#153761 vml export: avoid corrupt docx: don't write empty r:id + + For the benefit of MSO, do not write r:id="", + since MSO refuses to open such a document. + + Change-Id: I21887021c747fc9a9764befc7081e21d99e47545 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163523 + Tested-by: Jenkins + Reviewed-by: Justin Luth <jluth@mail.com> + (cherry picked from commit 5132255021aa61f8a1fa7d8de820cb3528699812) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163542 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-19 Mike Kaganski <mike.kaganski@collabora.com> [a0485be018a68c96329a2fd30d59cdf07cb36363] + + tdf#159565: make sure to handle leading hidden section correctly + + Change-Id: I41c7d2b6e765f03c72a968fd05e8de7047f1ce41 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163371 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163478 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-02-19 Mike Kaganski <mike.kaganski@collabora.com> [ff7f1b59e22092d8548459e75fe912db852f056f] + + tdf#159565 prerequisite: make hidden sections have zero-height frames + + As mentioned in commit bb733957dd39e6f0b9d80bb59eb0177188794797 (tdf#114973 + sw: enable SelectAll with hidden para at start/end, 2023-01-27), the hidden + sections didn't have frames. That prevented correct handling of the case + when such a frame was in the beginning of the document. + + This change re-implements the hidden section to use 0-height frames, like + hidden paragraphs, as a pre-requisite for a follow-up change. + + Some layout breakages noticed while working on this are unit-tested now. + + This change needed to handle the case when the first section is hidden, and + then goes a page break with page style. In this case, the page style must + apply to the very first page of the document. Implementing this now, when + the frame that defines the page style is not the first in the document, I + accidentally fixed also the previously broken case when the first paragraph + was hidden. Now the page style defined in the second paragraph's page break + will apply correctly. + + This change makes hidden sections break outer section's frames. This means + that when text borders are shown, there will be an artifact in the place of + the hidden sections (a horizontal line breaking outer frame). I suppose + it's not a problem, actually helping to see the layout better, so in line + with the "show text borders" helper functionality. If this proves to be + problematic, this can be handled specially in a follow-up. + + Change-Id: I14ebf0559b463186aba28902cd10c5cc978ba456 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163151 + Tested-by: Mike Kaganski <mike.kaganski@collabora.com> + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163477 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-02-19 Kris van der Merwe <kris@vandermerwe.co.nz> [71954c821b41c0e4c2eb617d9d2a7afa0435c2b6] + + Update git submodules + + * Update dictionaries from branch 'libreoffice-24-2' + to a62f9b3e6b2de1366d826a5bacf19ae63e527ead + - Updated Afrikaans dictionary + + Change-Id: Ief9cb53fdcbf794d1c54f4f5008f80b9975453d8 + Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/163265 + Tested-by: Andras Timar <andras.timar@collabora.com> + Reviewed-by: Andras Timar <andras.timar@collabora.com> + (cherry picked from commit 55f4731d574aeec252379ac66326bcea6df2f823) + Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/163280 + Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + +2024-02-17 Noel Grandin <noelgrandin@gmail.com> [b5a5cae0e78e989c421a376bb55a724981c74d87] + + tdf#101313 Copy-paste table from writer to calc + + With Merged Cells from Writer to Calc, + Cells Placed in Wrong Position (Wrong cell offsets). + + regression from + commit ed24564ce11683731b820c29d5a46e073ab7a2a7 + Author: Noel Grandin <noel@peralex.com> + Date: Thu Jul 19 15:22:31 2012 +0200 + SV_DECL_VARARR_SORT(ScRTFColTwips) o3tl::sorted_vector + + Change-Id: I8c90c19f6a27a368fd5807b3eaab84ce820e26e5 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163518 + Tested-by: Jenkins + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + (cherry picked from commit 4df426e429e1aed92f074d8acd3ba3a5ec335ba9) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163532 + +2024-02-16 Mike Kaganski <mike.kaganski@collabora.com> [64e5c8dbc6210f61d7d3904c40940a97fa5247fa] OpenSSL: upgrade to 3.0.13 @@ -444,13 +2373,8 @@ (cherry picked from commit 4897792975453024db8369c3d8c5f2e65c956d73) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163497 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> - (cherry picked from commit 391d04f9f7b879dd4dfb4c770881196cbd73cb54) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163531 - Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> - Tested-by: Michael Stahl <michael.stahl@allotropia.de> - Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> -2024-02-17 Michael Stahl <michael.stahl@allotropia.de> [1742ce27ded54cc541356ae0a7b429a120341b70] +2024-02-16 Michael Stahl <michael.stahl@allotropia.de> [ff1ab3915a68b34fa5569c9dcbc4c2a16ed94944] nss: upgrade to release 3.98 @@ -480,12 +2404,21 @@ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163504 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-16 Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> [684729cbd565129cdc6d3be09a864551fc6908c6] + + Fix typo: I10N -> L10N + + Change-Id: I20a0eb54a85a9dea5c7d4cd91ff3632574b14802 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160714 + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + Tested-by: Jenkins Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163520 - Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> - Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163481 + Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> + Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> -2024-02-17 Andras Timar <andras.timar@collabora.com> [743c626c7ebd04d06a4c8e71c21a7589dfa8ddd9] +2024-02-16 Andras Timar <andras.timar@collabora.com> [74486211adfb81a8b4d23c51457ff62acd804956] nss: upgrade to release 3.97 @@ -496,35 +2429,756 @@ (cherry picked from commit f25b7efba56757b085f7a836f57d9c2fc8fd14b8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163407 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> - (cherry picked from commit 74486211adfb81a8b4d23c51457ff62acd804956) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163498 - Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> -2024-02-15 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [675ca3a30cb414d702a1023ec0b583522c20caf2] +2024-02-16 Michael Weghorn <m.weghorn@posteo.de> [cc88d26c8ebcf1dd828469eead40d7747f2b9129] + + tdf#92389 sw a11y: Use SolarMutex in SidebarWinAccessibleContext + + Hold the SolarMutex instead of of using a custom mutex, + since `SwAccessibleMap` methods that get called require + the SolarMutex to be held. + + Fixes a crash/assert when interacting with Writer comments + using the mouse while the Orca screen reader is running + when using the qt6 VCL plugin. + + Backtrace: + + Thread 1 received signal SIGABRT, Aborted. + __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44 + 44 ./nptl/pthread_kill.c: No such file or directory. + (gdb) bt + #0 __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44 + #1 0x00007f0a462a81cf in __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78 + #2 0x00007f0a4625a472 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26 + #3 0x00007f0a462444b2 in __GI_abort () at ./stdlib/abort.c:79 + #4 0x00007f0a462443d5 in __assert_fail_base + (fmt=0x7f0a463b8dc8 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=assertion@entry=0x7f0a3d775838 "ImplGetSVData()->mpDefInst->GetYieldMutex()->IsCurrentThread() && \"SolarMutex not owned!\"", file=file@entry=0x7f0a3d7757f0 ".../libreoffice/vcl/source/app/dbggui.cxx", line=line@entry=35, function=function@entry=0x7f0a3d7757cc "void ImplDbgTestSolarMutex()") at ./assert/assert.c:92 + #5 0x00007f0a462533a2 in __assert_fail + (assertion=0x7f0a3d775838 "ImplGetSVData()->mpDefInst->GetYieldMutex()->IsCurrentThread() && \"SolarMutex not owned!\"", file=0x7f0a3d7757f0 ".../libreoffice/vcl/source/app/dbggui.cxx", line=35, function=0x7f0a3d7757cc "void ImplDbgTestSolarMutex()") at ./assert/assert.c:101 + #6 0x00007f0a3ca733b4 in ImplDbgTestSolarMutex() () at .../libreoffice/vcl/source/app/dbggui.cxx:35 + #7 0x00007f0a452ccfbb in DbgTestSolarMutex() () at .../libreoffice/tools/source/debug/debug.cxx:54 + #8 0x00007f09f8fd3903 in SwAccessibleMap::GetContext(SwFrame const*, bool) (this=0x55fa8fd89930, pFrame=0x55fa8ecddb00, bCreate=false) at .../libreoffice/sw/source/core/access/accmap.cxx:1777 + #9 0x00007f09f906f684 in sw::sidebarwindows::(anonymous namespace)::SidebarWinAccessibleContext::getAccessibleParent() (this=0x55fa8f83e600) at .../libreoffice/sw/source/uibase/docvw/SidebarWinAcc.cxx:65 + #10 0x00007f0a31e6244c in QtAccessibleWidget::parent() const (this=0x7f0a280b6150) at .../libreoffice/vcl/qt6/../qt5/QtAccessibleWidget.cxx:322 + #11 0x00007f0a3095b51a in AtSpiAdaptor::accessibleInterface(QAccessibleInterface*, QString const&, QDBusMessage const&, QDBusConnection const&) (this=0x55fa884876c0, interface=0x7f0a280b6150, function=..., message=..., connection=...) + at .../qt5/qtbase/src/gui/accessible/linux/atspiadaptor.cpp:1592 + #12 0x00007f0a30959934 in AtSpiAdaptor::handleMessage(QDBusMessage const&, QDBusConnection const&) (this=0x55fa884876c0, message=..., connection=...) + at .../qt5/qtbase/src/gui/accessible/linux/atspiadaptor.cpp:1460 + #13 0x00007f0a2ee88ad3 in QDBusConnectionPrivate::activateObject(QDBusConnectionPrivate::ObjectTreeNode&, QDBusMessage const&, int) (this=0x7f0a28010b60, node=..., msg=..., pathStartPos=27) + at .../qt5/qtbase/src/dbus/qdbusintegrator.cpp:1448 + #14 0x00007f0a2ee897b8 in QDBusActivateObjectEvent::placeMetaCall(QObject*) (this=0x7f0a280b8400) at .../qt5/qtbase/src/dbus/qdbusintegrator.cpp:1604 + #15 0x00007f0a31445095 in QObject::event(QEvent*) (this=0x55fa884876c0, e=0x7f0a280b8400) at .../qt5/qtbase/src/corelib/kernel/qobject.cpp:1447 + #16 0x00007f0a2f5a696c in QApplicationPrivate::notify_helper(QObject*, QEvent*) (this=0x55fa872f63e0, receiver=0x55fa884876c0, e=0x7f0a280b8400) at .../qt5/qtbase/src/widgets/kernel/qapplication.cpp:3298 + #17 0x00007f0a2f5a677d in QApplication::notify(QObject*, QEvent*) (this=0x55fa873956b0, receiver=0x55fa884876c0, e=0x7f0a280b8400) at .../qt5/qtbase/src/widgets/kernel/qapplication.cpp:3249 + #18 0x00007f0a313b1162 in QCoreApplication::notifyInternal2(QObject*, QEvent*) (receiver=0x55fa884876c0, event=0x7f0a280b8400) at .../qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1138 + #19 0x00007f0a313b1d0b in QCoreApplication::sendEvent(QObject*, QEvent*) (receiver=0x55fa884876c0, event=0x7f0a280b8400) at .../qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1581 + #20 0x00007f0a313b33c4 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) (receiver=0x0, event_type=0, data=0x55fa87311df0) at .../qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1936 + #21 0x00007f0a313b255e in QCoreApplication::sendPostedEvents(QObject*, int) (receiver=0x0, event_type=0) at .../qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1770 + #22 0x00007f0a318384ac in postEventSourceDispatch(GSource*, GSourceFunc, gpointer) (s=0x55fa873b8c20) at .../qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:244 + #23 0x00007f0a38d111f4 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0 + #24 0x00007f0a38d14317 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0 + #25 0x00007f0a38d14930 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0 + #26 0x00007f0a31838d41 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) (this=0x55fa873987a0, flags=...) at .../qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:394 + #27 0x00007f0a30b5c418 in QPAEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) (this=0x55fa873987a0, flags=...) at .../qt5/qtbase/src/gui/platform/unix/qeventdispatcher_glib.cpp:87 + #28 0x00007f0a31ed9a40 in QtInstance::ImplYield(bool, bool) (this=0x55fa873d30f0, bWait=true, bHandleAllCurrentEvents=false) at .../libreoffice/vcl/qt6/../qt5/QtInstance.cxx:453 + #29 0x00007f0a31ed9b69 in QtInstance::DoYield(bool, bool) (this=0x55fa873d30f0, bWait=true, bHandleAllCurrentEvents=false) at .../libreoffice/vcl/qt6/../qt5/QtInstance.cxx:464 + #30 0x00007f0a3cb39434 in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at .../libreoffice/vcl/source/app/svapp.cxx:390 + #31 0x00007f0a3cb3a1d2 in Application::Yield() () at .../libreoffice/vcl/source/app/svapp.cxx:474 + #32 0x00007f0a3cb39127 in Application::Execute() () at .../libreoffice/vcl/source/app/svapp.cxx:368 + #33 0x00007f0a46437216 in desktop::Desktop::Main() (this=0x7ffd0478dce0) at .../libreoffice/desktop/source/app/app.cxx:1614 + #34 0x00007f0a3cb585f6 in ImplSVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:229 + #35 0x00007f0a3cb5890b in SVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:261 + #36 0x00007f0a464a4367 in soffice_main() () at .../libreoffice/desktop/source/app/sofficemain.cxx:94 + #37 0x000055fa860a09d4 in sal_main () at .../libreoffice/desktop/source/app/main.c:51 + #38 0x000055fa860a09ba in main (argc=3, argv=0x7ffd0478df08) at .../libreoffice/desktop/source/app/main.c:49 + + Change-Id: If6df884fe94b2aac74be1b9fb13356bf765119d2 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163379 + Tested-by: Jenkins + Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> + (cherry picked from commit 512b09ec51cfbe9bb0ce1a7f229b443dc427f6f3) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163404 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-16 Xisco Fauli <xiscofauli@libreoffice.org> [8274e0161e79e7029968f6adab1085fa6059899a] + + zlib: upgrade to 1.3.1 + + Change-Id: I339b4e9c94ea50b3ddb41dfdac0e48d27939bc74 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163432 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + (cherry picked from commit 636c8cdf330f7dcd6aebe19df6790b4a78ec667e) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163398 + Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> + +2024-02-15 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [17f1d7c3705a40a5b982ee213c6d95762c546751] update credits Change-Id: I8c189f3708898087560255fbf353ac88e1dad432 (cherry picked from commit a21fb5bd8896ee8b82adf21f3e00cecaa521052f) - (cherry picked from commit 17f1d7c3705a40a5b982ee213c6d95762c546751) -2024-02-09 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [4ac28ff6b015da09c3b8ba8ffc91179666836147] +2024-02-15 Michael Weghorn <m.weghorn@posteo.de> [8bd9f9fb1e31740eee922e6832030ef8d404e61c] - bump product version to 24.2.1.1.0+ + scp2: Take ENABLE_{KF,QT}6 into account + + The qt6 and kf6 VCL plugins are also part + of the kde install set, so take + `ENABLE_QT6` and `ENABLE_KF6` into + account when deciding whether to install + it. + + This makes packaging these VCL plugins work + when building with `--enable-qt6` and/or + `--enable-kf6`, but without `--enable-qt5` + and `--enable-kf5`. + + Command that can be used for testing: + + make DESTDIR=/tmp/dummy distro-pack-install -o build -o check + + (Then, check whether the "installation" in /tmp/dummy + contains the VCL plugins as expected.) - Change-Id: I644fcefec24622bd690b0af6712a467ef506a1c3 + Thanks to Andreas Sturmlechner for reporting + the issue on IRC #libreoffice-dev on 2024-02-12. + + Change-Id: Ieea67468e3388f8b7b66f53221574c6225516b44 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163313 + Tested-by: Jenkins + Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> + (cherry picked from commit b57013086fa71f398ade34154f2f46b7ac6a79a9) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163341 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> -2024-02-09 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [0376ed9695b18d925e3af1dfb4fd76068a6e01ec] +2024-02-15 Michael Weghorn <m.weghorn@posteo.de> [eb9db0cd2f25a20e0efd756af3e34d4fb09b8e39] - Branch libreoffice-24-2-1 + tdf#125934 qt: Support module-specific window icons on Wayland - This is 'libreoffice-24-2-1' - the stable branch for the 24.2.1 release. - Only very safe changes, reviewed by three people are allowed. + As discussed in QTBUG-77182 [1], Qt currently doesn't provide + API to directly set the app_id for a single window/toplevel on Wayland, + but the one set for the application is used when the window gets shown. - If you want to commit more complicated fix for the next 24.2.x release, - please use the 'libreoffice-24-2' branch. + Make use of that by temporarily setting the app's desktop file + name and doing a hide/show cycle in `QtFrame::SetIcon` on + Wayland. - If you want to build something cool, unstable, and risky, use master. + A big thanks for David Redondo for mentioning that possibility + in QTBUG-77182! + + An alternative would be to use private Qt API and low-level wayland API to + set the app_id directly, s. discussion in QTBUG-77182. + + [1] https://bugreports.qt.io/browse/QTBUG-77182 + + Change-Id: I2a93cd39756e2ebf55b91486927d73d3896245b3 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163249 + Tested-by: Jenkins + Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> + (cherry picked from commit 413138c9178d4def463c4844297832b75dcea689) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163273 + Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-02-15 Patrick Luby <guibmacdev@gmail.com> [7fb33dc1e9ab0c2f48b7d5424e5bca5e9a14f709] + + tdf#155710 handle conversion failures due to non-UTF8 strings + + Windows and Linux paths can be passed as parameters to this function + and those paths may not always be UTF8 encoded like macOS paths. + + Change-Id: I83f5ab491d3c0ddd938e512fbab3213af9ea16fd + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163223 + Tested-by: Jenkins + Reviewed-by: Patrick Luby <guibomacdev@gmail.com> + (cherry picked from commit fa1b6aa517966991ce1a1d0135bd5dfae331ab9a) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163176 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-02-15 Michael Stahl <michael.stahl@allotropia.de> [7e7b0230aa56e38f03d3d2563568a4cd2a5a6bb6] + + tdf#155663 writerfilter: RTF import: don't lose \piccrop* + + For DOCX the a:srcRect is imported in oox module in BlipFillContext and + set on the XShape; obviously that doesn't work for RTF. + + The crop was already taken into account in + RTFDocumentImpl::resolvePict(), but only to set the size of the picture; + to actually set a crop effect, set shape's "GraphicsCrop" property + in dmapper::GraphicImport::lcl_attribute(). + + Change-Id: Ib12853724744542a09b0073fefc42ad32bb2ff19 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163310 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 47f50af3f057bac1739b7d17d781c0b1d05faa95) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163330 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-02-15 Taichi Haradaguchi <20001722@ymail.ne.jp> [5c785764f1b7bbf43e894d23f33eb43dc5f187b9] + + Expat: upgrade to release 2.6.0 + + Fixes CVE-2023-52425 and CVE-2023-52426. + + Change-Id: Id135bbaea893a83129bdbee44948c09322a64c07 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163146 + Tested-by: Jenkins + Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> + (cherry picked from commit b7e4078033b064bfc3847db0916a4df389117817) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163392 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-15 Jaume Pujantell <jaume.pujantell@collabora.com> [0655736b20fd84e6948d21c31fe388dc83801ad3] + + tdf#159704 svx: preserve text when getting grpahic from sdrobject + + When getting a Graphic object from an SdrGrafObj with text the text was lost. + + Change-Id: I3a8316511e502b832b65dc72faebaf8c00923c38 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163293 + Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + (cherry picked from commit d0241915eba35c9dc0cc42f322df798a270db00f) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163342 + Tested-by: Jenkins + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163377 + +2024-02-15 Miklos Vajna <vmiklos@collabora.com> [28cc9382de067f647e9dde59834b137816574c3a] + + tdf#159483 sc HTML export: handle data-sheets-value attribute for the text case + + HTML pasting "'01" from google sheets to Calc worked already, but + HTML copying from Calc still converted 01 to 1. + + What's required is to emit a general marker in the HTML output and then + the correct data-sheets-value attribute on the relevant <td> element. + + Add a way to inject a marker in ScHTMLExport::WriteBody() (so + data-sheets-* is considered at all) and extend + ScHTMLExport::WriteCell() to write the data-sheets-value attribute for + the text case as a start. + + Other types like booleans are not yet handled at export time. + + Change-Id: Ib66e92c84235797cb4731e73d0a5b6286b6f3ab3 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163328 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + Tested-by: Jenkins + (cherry picked from commit 4e2a4fbeb7c44cc47b3cf803cbcc6cba63b3d481) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163347 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-15 Xisco Fauli <xiscofauli@libreoffice.org> [a04a555497b054e83bc7c8462ba342286508d3a5] + + UnoApiXmlTest: factor out common code + + Change-Id: I5c7f76b61a0dab8b4ebd1ac4680a7c25f982680c + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163307 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163376 + +2024-02-14 Julien Nabet <serval2412@yahoo.fr> [39fa034db32fa07a7f2a7afe77f7d1c047b5cad8] + + tdf#159707: fix crash when changing to edit mode (calc) + + bt: + 0x00007f9eb4b902f2 in com::sun::star::uno::Reference<com::sun::star::frame::XModel>::operator->() const (this=0x55b8c2b54888) at include/com/sun/star/uno/Reference.h:387 + 0x00007f9eb4c03584 in ScVbaEventsHelper::notifyEvent(com::sun::star::document::EventObject const&) (this=0x55b8c2b54840, rEvent=...) at /home/julien/lo/libreoffice/sc/source/ui/vba/vbaeventshelper.cxx:605 + 0x00007f9ef464bd3c in (anonymous namespace)::NotifySingleListenerIgnoreRE<com::sun::star::document::XEventListener, com::sun::star::document::EventObject>::operator()(com::sun::star::uno::Reference<com::sun::star::document::XEventListener> const&) const (this=0x7ffc5044dfc0, listener=uno::Reference to (ScVbaEventsHelper *) 0x55b8c2b54870) at /home/julien/lo/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:3293 + 0x00007f9ef463b8aa in comphelper::OInterfaceContainerHelper3<com::sun::star::document::XEventListener>::forEach<(anonymous namespace)::NotifySingleListenerIgnoreRE<com::sun::star::document::XEventListener, com::sun::star::document::EventObject> >((anonymous namespace)::NotifySingleListenerIgnoreRE<com::sun::star::document::XEventListener, com::sun::star::document::EventObject> const&) + (this=0x55b8c2735c18, func=...) at include/comphelper/interfacecontainer3.hxx:279 + 0x00007f9ef463b010 in SfxBaseModel::postEvent_Impl(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::frame::XController2> const&, com::sun::star::uno::Any const&) + (this=0x55b8c2308ae0, aName="OnUnload", xController=empty uno::Reference, supplement=uno::Any(void)) at /home/julien/lo/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:3338 + 0x00007f9ef463a089 in SfxBaseModel::Notify(SfxBroadcaster&, SfxHint const&) (this=0x55b8c2308ae0, rBC=..., rHint=...) at /home/julien/lo/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:2960 + + See full bt here: + https://bugs.documentfoundation.org/attachment.cgi?id=192546 + + Regression from: + https://git.libreoffice.org/core/+/d2fccf0117a37f8aab8bb50ece419987f06af6b9%5E%21 + "cool#6893 improve listeners in SfxBaseModel" + + Change-Id: I372808dade20c47275ab599054d8e9572dc3da4d + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163356 + Reviewed-by: Julien Nabet <serval2412@yahoo.fr> + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + Tested-by: Jenkins + (cherry picked from commit 6c6b580428bc527da9af82da743616787617b39b) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163344 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-14 Mike Kaganski <mike.kaganski@collabora.com> [df41d922ef7e6c99f72d65dad04b56c82a79ae30] + + tdf#159302: Another UNO property "BaseLine" needs to use mm/100s + + Change-Id: I6688577a41590624f1e1f08112f1308e810a7e37 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163333 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit b6ef30d1b049977beb23d28a07d77012fa1daf47) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163339 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-14 Oliver Specht <oliver.specht@cib.de> [f5c3296eca92e8dd6b3bdf7410dd5a636a197d10] + + tdf#63259 rotate case also at start/end of a word + + Rotate either rotates the selection or the word the cursor is directly before, + inside or directly after + + Change-Id: Ia21e3120d2b00978b9f4ce06738b42e90d2ada62 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162256 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 3d01c4ee56e0435815977b1717c84b1a2c233bfc) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163338 + Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> + +2024-02-13 Michael Weghorn <m.weghorn@posteo.de> [9de87f990e6d9e48495bd6970a25eb1823d5b2ef] + + kf6: Add missing include path to fix build + + Many thanks to Andreas Sturmlechner for pointing + this out on #libreoffice-dev on 2024-02-12: + + > [10:27] <asturm> michaelweghorn: I also had to apply a trivial + > openmandriva patch to get it to build in the first place, + > https://github.com/gentoo/gentoo/blob/master/app-office/libreoffice/files/libreoffice-24.2-kf6-buildfix.patch + + Change-Id: If86220e258336d84ffc30fd5da0f5d99dda59aff + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163237 + Tested-by: Jenkins + Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> + (cherry picked from commit 30ec42fad4c0c61de93bea23e9f7d98acc6db0e6) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163272 + Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> + +2024-02-13 Miklos Vajna <vmiklos@collabora.com> [2ec403de8f74699130cc80e1eda7862cb123cbfd] + + tdf#159483 sc HTML paste: handle data-sheets- attributes on a span + + Copy multiple cells, including a formula from google sheets to Calc, the + formula is handled as a formula by the HTML paste. Do the same for a + single cell, then only the result is pasted. + + The trouble is that the data-sheets-* attributes appear on <td> elements + for multiple cells, but they appear on a <span> for a single cell. + + Fix the problem by extending ScHTMLLayoutParser::ProcToken() to handle + the HtmlTokenId::SPAN_ON token and share the code between the <td> and + <span> handler, so this markup works in both cases. + + Note that this is the paste handler, the no changes to the normal HTML + import are made for now. + + Change-Id: Id749df9062d8fcb9a2f0acd928585a304efaae28 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163291 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + Tested-by: Jenkins + (cherry picked from commit c0da56cb3e9f9678cae7142dee03fb706a2aebd9) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163289 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-13 Miklos Vajna <vmiklos@collabora.com> [c50b5b648d157e940b17e36de7c529c4ceeafd84] + + tdf#159453 sw floattable: fix unexpected overlap of in-header fly and body text + + Regression from commit e2076cf7a92694bc94bdc9f3173c2bddbe881a89 + (tdf#155682 sw floattable: fix DOCX with big pictures causes endless + loop, 2023-10-25), the bugdoc's body text was wrapping around the + floating table from the header, while the expectation was that the top + of the body frame is below the bottom of the header frame. + + It seems IsFollowingTextFlow is only needed when the relation of the + floating table is not "page", and this bugdoc has has an examplicit + vertical relation of page. + + Solve the problem by limiting the IsFollowingTextFlow=true request for + the floating table to the VertOrientRelation=page case, which fixes the + bugdoc and keeps the old use-case working. + + The doc model for the new bugdoc now matches the WW8 import result. + + Change-Id: Ia3da65cd52d70b357e448a26a50ffb92a39795e6 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163290 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + Tested-by: Jenkins + (cherry picked from commit f74a6ef94ac957e4c146fc9923d30ce6bd31b5ce) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163286 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-13 Mike Kaganski <mike.kaganski@collabora.com> [6d87919d0e3a3e0c5febda19cd30da73813f0965] + + tdf#159689: trailing newline before "endstream" must not count in Length + + Change-Id: Ic1e636c9d4e5a531113f26e147427fb75ce3591c + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163185 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit 5121c1f8a3dc1e326a4195393f463f5c0383859b) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163281 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-12 Xisco Fauli <xiscofauli@libreoffice.org> [98af2dc233f6ac154afe4a8e53ff97062577c21c] + + tdf#159666: sd_uiimpress: Add unittest + + Change-Id: Id5e35e1514695bffeced718d48dcfeffc4a4d4d9 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163271 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-12 Noel Grandin <noel.grandin@collabora.co.uk> [bcf75e6f07daa7e5444071d87b469f443aa7ef83] + + tdf#159666 Crash when table and line object are selected at the same time + + before + commit e3077168072452fb8f1c0a8afb2992877cb96d1c + Author: Noel Grandin <noel.grandin@collabora.co.uk> + Date: Thu Jun 17 09:49:37 2021 +0200 + loplugin:finalclasses + the cast in + const SdrEdgeObj* pEdge = static_cast<SdrEdgeObj*>(m_pObj); + would incorrectly cast a SdrTableObj, but it happened to do nothing + problematic. + + After the above commit, the vtable layout changed and it started + crashing. + + Work around it by use dynamic_cast and ignoring objects that are not + SdrEdgeObj. + + Change-Id: Ibe03d4935b8eeb182e037b1648d841e26fa23ed4 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163242 + Tested-by: Jenkins + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + (cherry picked from commit bac09f76fd903c109b591a7bc15883e5653715ee) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163187 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-12 Miklos Vajna <vmiklos@collabora.com> [0e6c93253c4ec5ef2e9c72a12c0331ff5a5e8051] + + tdf#159483 sc HTML paste: handle data-sheets-formula attribute + + When a formula cell gets copied from google docs, the value of the <td> + element only contains the formula result. This means once value cells + and formula cells gets copied together, the pasted formula cell won't + updated anymore when the input values change. + + Turns out there is a data-sheets-formula attribute on <td> that contains + the formula, it seems it uses the R1C1 format. + + Fix the problem by extending ScHTMLLayoutParser::TableDataOn() to parse + this attribute and set a formula on the target cell (rather than a + value) if the formula is available. + + This required also extending ScEEImport a bit, since the HTML paste + builds on top of the RTF one in Calc. + + Change-Id: I720df96ce74a5e865b7329d06f3b719551f31b96 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163234 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + Tested-by: Jenkins + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163246 + +2024-02-12 Miklos Vajna <vmiklos@collabora.com> [bffed7030955240b516e3ebb06b1772cffe27295] + + tdf#159483 sc HTML import: handle data-sheets-value attribute for the num case + + E.g. have "1,000.00" and "2,000.00" in two cells, paste that into calc, + and try to do a SUM() on them, which will fail because the cell content + is text. + + Just data-sheets-value itself would not be good solution, because then + we would lose the number format, so the paste result would be like 1000, + which is bad for readability if you don't want further operations on the + value. + + Fix the problem by also parsing the data-sheets-numberformat attribute, + so far what's clear is that the "2" JSON key there provides a number + format string which matches the syntax of Excel/Calc. + + This gives the best of the two worlds: the output looks like the + original, but SUM() works on the cells as well. + + Change-Id: Ic7c09ba55a51852f285ad0c05ed42c6771b0f500 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163152 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + Tested-by: Jenkins + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163245 + +2024-02-12 Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> [12c69942fb80fcd4cd4a5a4ca4c76f1e050ca20c] + + sc: pivot table not correct when data and PT cache is not in sync + + It can happen that the pivot table is not updated and the sheet + data is changed so much that it doesn't match the pivot table + cached definitions. This is a perfectly valid scenario and + nothing should be wrong (the pivot table can just be updated + once loaded). + + At XLSX import we should always check the cached definitions, + because the pivot table description is made using the cached data, + not the actual data. + + The issue can occur when looking up the name of a PT field we + however didn't check the cached definition but checked the + sheet data, so because the indices changed so much (many columns + were removed in the sheet data) we can not find the actual field + name. The solution is simple - get the field name from the cached + pivot table definition. + + Change-Id: I3b5b33f33f3c484f0b66b97ac97200d9913edcfe + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163197 + Tested-by: Jenkins + Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> + (cherry picked from commit 9af4b5254cbe6a6770ebe78ba14074266b05471e) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163178 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-12 Xisco Fauli <xiscofauli@libreoffice.org> [57f365222bc6d99f2314b95e14381422b4b9c40f] + + CppunitTest_sw_a11y: disable second test on Win ( 24.2 only ) + + Similar to 968e815ec7fb2ff11bfae2c027fe26c45d4bcee0 + "CppunitTest_sw_a11y: disable test on Win ( 24.2 only )" + + Change-Id: Id3abf22351b06cdaaccbe4dcb5243f946eb2e73a + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163244 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-12 Michael Stahl <michael.stahl@allotropia.de> [14d1ec9a26248f2023a697fc4458ec6422a2ae71] + + tdf#158983 writerfilter: RTF import: fix page breaks and shape anchors + + Somehow, not sure why, the added import of \wrapdefault in commit + 86c0f58b6f9f392865196606173d1b98a6897f32 caused the page break in + fdo55504-1.rtf to get lost. + + The first problem is that there is a \sbknone before the first \sect - + this should not have any effect before \sect because \sbk* affect the + *previous* section break, but it's not an option to simply ignore it + (even if it works for this bugdoc) because it may be that there is no + \sectd after \sect and then it will have an effect for the later + section. + + The problem was in handling \page: here the premature \sbknone caused a + sectBreak() which ate the page break; ignore it here by checking + m_bHadSect. + + The second problem then was that now all but the first shape were + anchored on page 2. + + This was because RTFDocumentImpl::beforePopState() for \shape of the 1st + shape called parBreak() and that set the bIsFirstParaInSection flag. + + This flag prevented DomainMapper::lcl_utext() in the + "if (m_pImpl->isBreakDeferred(PAGE_BREAK)) if (GetSplitPgBreakAndParaMark())" + branch from inserting another paragraph break that is necessary to + preserve the already inserted shapes anchored to the 2nd paragraph on + page 1. + + (This is how it works for the equivalent DOCX document, with settings.xml + edited to add w:splitPgBreakAndParaMark and remove "compatibilityMode" + etc. because Word 2013 doesn't set these correctly.) + + The consequence is that when the second SwTextNode is converted to a + text frame, all the shape anchors move to the next paragraph, the one + with the RES_BREAK on it. + + Fix this by limiting the parBreak() handling in + RTFDocumentImpl::beforePopState() to when the shape is a SwGrfNode, + which is the scenario in the commit 0d9132c5046e15540abc20e45d64080708626441 + "fdo#47036 fix RTF import of shapes inside text frames at the start of the doc" + - the testFdo47036 fails if the block is removed completely. + + This caused 2 test failures, but both cases look the same as in Word + 2013 now: + + Test name: (anonymous namespace)::testTdf158826_extraCR::Load_Verify_Reload_Verify + An uncaught exception of type com.sun.star.uno.RuntimeException + - unsatisfied query for interface of type com.sun.star.text.XTextTable! + + rtfexport2.cxx:537:Assertion + Test name: (anonymous namespace)::testFdo47495::Load_Verify_Reload_Verify + equality assertion failed + - Expected: 2 + - Actual : 1 + + Change-Id: I43fa9431721650a6d748d1f4bda9aeaa7a9c6b45 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163200 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 582ef812702413dbe7fb0f132bca3e3e4c2e1d40) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163181 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-12 Mike Kaganski <mike.kaganski@collabora.com> [3af133c23544839bcad6592c910e5f04e8f85c38] + + tdf#159438: when there's no frame, close previous bookmark first + + Commit 260d6cc6471444b4ef20ed6673831b0b12f96333 (INTEGRATION: CWS mtg2 + (1.30.120); FILE MERGED, 2005-12-21) for #i58438# made sure to process + previously opened bookmarks that close at this node, before opening + the bookmarks that start here. + + Commit 76a4305d1e90b6617054dd33036e64f005dbcf04 (sw: fix inconsistent + bookmark behavior around at-char/as-char anchored frames, 2017-12-21) + re-introduced the problem accidentally: it only intended to handle + case when there is an anchored frame here. + + This change re-instates the correct order (close bookmarks first; then + process collapsed ones; then open new bookmarks) in case there's no + anchored frames here. + + To avoid a problem when a non-collapsed bookmark starts and ends at + the same point (e.g., its text was deleted), it gets converted to + collapsed in lcl_FillBookmark. Thus, testRemoveBookmarkText was fixed + in sw/qa/extras/uiwriter/uiwriter4.cxx. There is no reason to keep + the separate -begin/-end elements, especially since on the following + open/save round-trip, it will become collapsed anyway. + + Change-Id: Ib555a76f6f776001e12908a1299c24eebf591f6b + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162743 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162804 + +2024-02-12 Michael Weghorn <m.weghorn@posteo.de> [0750cacbb165b733ab76bb54a6c0116e8266a01f] + + tdf#158947 sw: Don't unrelatedly overwrite system clipboard on paste + + In `SwTransferable::RemoveDDELinkFormat`, only update the + clipboard content with this `SwTransferable` after removing + the `SotClipboardFormatId::LINK` from the supported formats + if the `SwTransferable` was the clipboard content before + already. + + Doing so always would unrelatedly overwrite what was previously + copied from another application to the clipboard for the + tdf#158947 scenario of pasting clipboard content of another + application over a selection when using the Qt-based VCL plugins + on Wayland (s. backtrace below that shows how the clipboard content + was overwritten, frame #17 is the method changed in this + commit). + + My assumption why the clipboard content is explicitly overwritten + at all is to make sure that the system clipboard on some platforms + gets notified about the change in supported formats/mime + types after removing one. But that isn't necessary when the + transfer data modified here aren't the current clipboard content + in the first place. + + Backtrace for how clipboard content was previously overwritten + for the tdf#158947 scenario with the qt6 VCL plugin on Wayland: + + ~"#0 QtClipboard::handleChanged(QClipboard::Mode) (this=0x557f90457770, aMode=QClipboard::Clipboard) at .../libreoffice/vcl/qt6/../qt5/QtClipboard.cxx:156\n" + ~"#1 0x00007f26f08844ff in QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<QClipboard::Mode>, void, void (QtClipboard::*)(QClipboard::Mode)>::call(void (QtClipboard::*)(QClipboard::Mode), QtClipboard*, void**)::{lambda()#1}::operator()() const (__closure=0x7ffe889a2c20) at .../qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:153\n" + ~"#2 0x00007f26f0884ffb in QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<QClipboard::Mode>, void, void (QtClipboard::*)(QClipboard::Mode)>::call(void (QtClipboard::*)(QClipboard::Mode), QtClipboard*, void**)::{lambda()#1}>(void**, QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<QClipboard::Mode>, void, void (QtClipboard::*)(QClipboard::Mode)>::call(void (QtClipboard::*)(QClipboard::Mode), QtClipboard*, void**)::{lambda()#1}&&) (args=0x7ffe889a2ed0, fn=...) at .../qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:72\n" + ~"#3 0x00007f26f088456f in QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<QClipboard::Mode>, void, void (QtClipboard::*)(QClipboard::Mode)>::call(void (QtClipboard::*)(QClipboard::Mode), QtClipboard*, void**) (f=(void (QtClipboard::*)(QtClipboard * const, QClipboard::Mode)) 0x7f26f087a76e <QtClipboard::handleChanged(QClipboard::Mode)>, o=0x557f90457770, arg=0x7ffe889a2ed0) at .../qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:152\n" + ~"#4 0x00007f26f08833de in QtPrivate::FunctionPointer<void (QtClipboard::*)(QClipboard::Mode)>::call<QtPrivate::List<QClipboard::Mode>, void>(void (QtClipboard::*)(QClipboard::Mode), QtClipboard*, void**) (f=(void (QtClipboard::*)(QtClipboard * const, QClipboard::Mode)) 0x7f26f087a76e <QtClipboard::handleChanged(QClipboard::Mode)>, o=0x557f90457770, arg=0x7ffe889a2ed0) at .../qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:200\n" + ~"#5 0x00007f26f0881f71 in QtPrivate::QCallableObject<void (QtClipboard::*)(QClipboard::Mode), QtPrivate::List<QClipboard::Mode>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) (which=1, this_=0x557f904555f0, r=0x557f90457770, a=0x7ffe889a2ed0, ret=0x0) at .../qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:571\n" + ~"#6 0x00007f26efdb863f in QtPrivate::QSlotObjectBase::call(QObject*, void**) (this=0x557f904555f0, r=0x557f90457770, a=0x7ffe889a2ed0) at .../qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:487\n" + ~"#7 0x00007f26efe5772e in doActivate<false>(QObject*, int, void**) (sender=0x557f8d510fd0, signal_index=3, argv=0x7ffe889a2ed0) at .../qt5/qtbase/src/corelib/kernel/qobject.cpp:4116\n" + ~"#8 0x00007f26efe4cdef in QMetaObject::activate(QObject*, QMetaObject const*, int, void**) (sender=0x557f8d510fd0, m=0x7f26efa47cc0 <QClipboard::staticMetaObject>, local_signal_index=0, argv=0x7ffe889a2ed0) at .../qt5/qtbase/src/corelib/kernel/qobject.cpp:4176\n" + ~"#9 0x00007f26eede9fcc in QClipboard::changed(QClipboard::Mode) (this=0x557f8d510fd0, _t1=QClipboard::Clipboard) at .../qt5/qtbase/src/gui/Gui_autogen/include/moc_qclipboard.cpp:182\n" + ~"#10 0x00007f26eede9bc1 in QClipboard::emitChanged(QClipboard::Mode) (this=0x557f8d510fd0, mode=QClipboard::Clipboard) at .../qt5/qtbase/src/gui/kernel/qclipboard.cpp:558\n" + ~"#11 0x00007f26eee4ed69 in QPlatformClipboard::emitChanged(QClipboard::Mode) (this=0x557f88019c20, mode=QClipboard::Clipboard) at .../qt5/qtbase/src/gui/kernel/qplatformclipboard.cpp:89\n" + ~"#12 0x00007f26ed78809e in QtWaylandClient::QWaylandClipboard::setMimeData(QMimeData*, QClipboard::Mode) (this=0x557f88019c20, data=0x557f8fb87930, mode=QClipboard::Clipboard) at .../qt5/qtwayland/src/client/qwaylandclipboard.cpp:89\n" + ~"#13 0x00007f26eede99de in QClipboard::setMimeData(QMimeData*, QClipboard::Mode) (this=0x557f8d510fd0, src=0x557f8fb87930, mode=QClipboard::Clipboard) at .../qt5/qtbase/src/gui/kernel/qclipboard.cpp:447\n" + ~"#14 0x00007f26f087a5b5 in QtClipboard::setContents(com::sun::star::uno::Reference<com::sun::star::datatransfer::XTransferable> const&, com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboardOwner> const&) (this=0x557f8d50cbb0, xTrans=uno::Reference to (SwTransferable *) 0x557f90440118, xClipboardOwner=uno::Reference to (SwTransferable *) 0x557f90440120) at .../libreoffice/vcl/qt6/../qt5/QtClipboard.cxx:137\n" + ~"#15 0x00007f26fb05bacc in TransferableHelper::CopyToClipboard(com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboard> const&) const (this=0x557f904400f0, rClipboard=uno::Reference to (QtClipboard *) 0x557f8d50cc10) at .../libreoffice/vcl/source/treelist/transfer.cxx:942\n" + ~"#16 0x00007f26fb05bc77 in TransferableHelper::CopyToClipboard(vcl::Window*) const (this=0x557f904400f0, pWindow=0x557f8932d1f0) at .../libreoffice/vcl/source/treelist/transfer.cxx:957\n" + ~"#17 0x00007f26b5130940 in SwTransferable::RemoveDDELinkFormat(vcl::Window&) (this=0x557f904400f0, rWin=...) at .../libreoffice/sw/source/uibase/dochdl/swdtflvr.cxx:385\n" + ~"#18 0x00007f26b51440ab in SwTransferDdeLink::DataChanged(rtl::OUString const&, com::sun::star::uno::Any const&) (this=0x557f8fb864e0) at .../libreoffice/sw/source/uibase/dochdl/swdtflvr.cxx:4447\n" + ~"#19 0x00007f270120fa0e in sfx2::SvLinkSource::NotifyDataChanged() (this=0x557f8fb8bbe0) at .../libreoffice/sfx2/source/appl/linksrc.cxx:291\n" + ~"#20 0x00007f26b43210ba in SwServerObject::SendDataChanged(SwPaM const&) (this=0x557f8fb8bbe0, rRange=SwPaM = {...}) at .../libreoffice/sw/source/core/doc/swserv.cxx:177\n" + ~"#21 0x00007f26b43217c2 in SwDataChanged::~SwDataChanged() (this=0x7ffe889a3520, __in_chrg=<optimized out>) at .../libreoffice/sw/source/core/doc/swserv.cxx:308\n" + ~"#22 0x00007f26b4233c8b in sw::DocumentContentOperationsManager::DeleteRangeImplImpl(SwPaM&, SwDeleteFlags) (this=0x557f8d2b8000, rPam=SwPaM = {...}, flags=SwDeleteFlags::Default) at .../libreoffice/sw/source/core/doc/DocumentContentOperationsManager.cxx:4474\n" + ~"#23 0x00007f26b4233826 in sw::DocumentContentOperationsManager::DeleteRangeImpl(SwPaM&, SwDeleteFlags) (this=0x557f8d2b8000, rPam=SwPaM = {...}, flags=SwDeleteFlags::Default) at .../libreoffice/sw/source/core/doc/DocumentContentOperationsManager.cxx:4419\n" + ~"#24 0x00007f26b4233681 in sw::DocumentContentOperationsManager::DeleteAndJoinImpl(SwPaM&, SwDeleteFlags) (this=0x557f8d2b8000, rPam=SwPaM = {...}, flags=SwDeleteFlags::Default) at .../libreoffice/sw/source/core/doc/DocumentContentOperationsManager.cxx:4391\n" + ~"#25 0x00007f26b421edb7 in (anonymous namespace)::lcl_DoWithBreaks(sw::DocumentContentOperationsManager&, SwPaM&, SwDeleteFlags, bool (sw::DocumentContentOperationsManager::*)(sw::DocumentContentOperationsManager* const, SwPaM&, SwDeleteFlags)) (rDocumentContentOperations=..., rPam=SwPaM = {...}, flags=SwDeleteFlags::Default, pFunc=(bool (sw::DocumentContentOperationsManager::*)(sw::DocumentContentOperationsManager * const, SwPaM &, SwDeleteFlags)) 0x7f26b4233632 <sw::DocumentContentOperationsManager::DeleteAndJoinImpl(SwPaM&, SwDeleteFlags)>) at .../libreoffice/sw/source/core/doc/DocumentContentOperationsManager.cxx:681\n" + ~"#26 0x00007f26b42279df in sw::DocumentContentOperationsManager::DeleteAndJoin(SwPaM&, SwDeleteFlags) (this=0x557f8d2b8000, rPam=SwPaM = {...}, flags=SwDeleteFlags::Default) at .../libreoffice/sw/source/core/doc/DocumentContentOperationsManager.cxx:2367\n" + ~"#27 0x00007f26b44a71f6 in SwEditShell::DeleteSel(SwPaM&, bool, bool, bool*) (this=0x557f8d51b300, rPam=SwPaM = {...}, isArtificialSelection=false, goLeft=false, pUndo=0x7ffe889a3be6) at .../libreoffice/sw/source/core/edit/eddel.cxx:122\n" + ~"#28 0x00007f26b44a7671 in SwEditShell::Delete(bool, bool) (this=0x557f8d51b300, isArtificialSelection=false, goLeft=false) at .../libreoffice/sw/source/core/edit/eddel.cxx:164\n" + ~"#29 0x00007f26b5604933 in SwWrtShell::DelRight(bool) (this=0x557f8d51b300, isReplaceHeuristic=false) at .../libreoffice/sw/source/uibase/wrtsh/delete.cxx:312\n" + ~"#30 0x00007f26b512fe14 in (anonymous namespace)::SwTrnsfrActionAndUndo::SwTrnsfrActionAndUndo(SwWrtShell*, bool, SwPasteContext*) (this=0x557f9045b020, pS=0x557f8d51b300, bDelSel=true, pContext=0x7ffe889a4220) at .../libreoffice/sw/source/uibase/dochdl/swdtflvr.cxx:236\n" + ~"#31 0x00007f26b51377c1 in SwTransferable::PasteData(TransferableDataHelper const&, SwWrtShell&, unsigned char, SotExchangeActionFlags, SotClipboardFormatId, SotExchangeDest, bool, bool, Point const*, signed char, bool, RndStdIds, bool, SwPasteContext*, PasteTableType) (rData=..., rSh=..., nAction=36 '$', nActionFlags=(SotExchangeActionFlags::InsertImageMap | SotExchangeActionFlags::InsertTargetUrl), nFormat=SotClipboardFormatId::HTML, nDestination=SotExchangeDest::SWDOC_FREE_AREA, bIsPasteFormat=false, bIsDefault=false, pPt=0x0, nDropAction=0 '\\000', bPasteSelection=false, nAnchorType=RndStdIds::FLY_AT_PARA, bIgnoreComments=false, pContext=0x7ffe889a4220, ePasteTable=PasteTableType::PASTE_DEFAULT) at .../libreoffice/sw/source/uibase/dochdl/swdtflvr.cxx:1768\n" + ~"#32 0x00007f26b5137333 in SwTransferable::Paste(SwWrtShell&, TransferableDataHelper&, RndStdIds, bool, PasteTableType) (rSh=..., rData=..., nAnchorType=RndStdIds::FLY_AT_PARA, bIgnoreComments=false, ePasteTable=PasteTableType::PASTE_DEFAULT) at .../libreoffice/sw/source/uibase/dochdl/swdtflvr.cxx:1687\n" + ~"#33 0x00007f26b52d29e9 in SwBaseShell::ExecClpbrd(SfxRequest&) (this=0x557f8db64330, rReq=...) at .../libreoffice/sw/source/uibase/shells/basesh.cxx:365\n" + ~"#34 0x00007f26b52d1681 in SfxStubSwBaseShellExecClpbrd(SfxShell*, SfxRequest&) (pShell=0x557f8db64330, rReq=...) at .../libreoffice/workdir/SdiTarget/sw/sdi/swslots.hxx:2219\n" + ~"#35 0x00007f27012d14dc in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) (this=0x557f8d4f46b0, rShell=..., rSlot=..., rReq=..., bRecord=true) at .../libreoffice/sfx2/source/control/dispatch.cxx:254\n" + ~"#36 0x00007f27012d4b34 in SfxDispatcher::Execute_(SfxShell&, SfxSlot const&, SfxRequest&, SfxCallMode) (this=0x557f8d4f46b0, rShell=..., rSlot=..., rReq=..., eCallMode=SfxCallMode::RECORD) at .../libreoffice/sfx2/source/control/dispatch.cxx:753\n" + ~"#37 0x00007f27012c05d4 in SfxBindings::Execute_Impl(SfxRequest&, SfxSlot const*, SfxShell*) (this=0x557f8d503240, aReq=..., pSlot=0x7f26b6cf5360 <aSwBaseShellSlots_Impl+1440>, pShell=0x557f8db64330) at .../libreoffice/sfx2/source/control/bindings.cxx:1057\n" + ~"#38 0x00007f270139813d in SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) (this=0x557f8db682a0, aURL=..., aArgs=empty uno::Sequence, rListener=empty uno::Reference) at .../libreoffice/sfx2/source/control/unoctitm.cxx:688\n" + ~"#39 0x00007f2701395dbf in SfxOfficeDispatch::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x557f8db68200, aURL=..., aArgs=empty uno::Sequence) at .../libreoffice/sfx2/source/control/unoctitm.cxx:250\n" + ~"#40 0x00007f26fe03d948 in svt::(anonymous namespace)::AsyncAccelExec::impl_ts_asyncCallback(LinkParamNone*) (this=0x557f8fb8e070) at .../libreoffice/svtools/source/misc/acceleratorexecute.cxx:508\n" + ~"#41 0x00007f26fe03d869 in svt::(anonymous namespace)::AsyncAccelExec::LinkStubimpl_ts_asyncCallback(void*, LinkParamNone*) (instance=0x557f8fb8e070, data=0x0) at .../libreoffice/svtools/source/misc/acceleratorexecute.cxx:500\n" + ~"#42 0x00007f26fab0db3b in Link<LinkParamNone*, void>::Call(LinkParamNone*) const (this=0x557f8fb8e110, data=0x0) at .../libreoffice/include/tools/link.hxx:111\n" + ~"#43 0x00007f26fb469f3d in vcl::EventPoster::DoEvent_Impl(void*) (this=0x557f8fb8e108) at .../libreoffice/vcl/source/helper/evntpost.cxx:52\n" + ~"#44 0x00007f26fb469f05 in vcl::EventPoster::LinkStubDoEvent_Impl(void*, void*) (instance=0x557f8fb8e108, data=0x0) at .../libreoffice/vcl/source/helper/evntpost.cxx:48\n" + ~"#45 0x00007f26fadc2373 in Link<void*, void>::Call(void*) const (this=0x7f26e80153b8, data=0x0) at .../libreoffice/include/tools/link.hxx:111\n" + ~"#46 0x00007f26fadbf458 in ImplHandleUserEvent(ImplSVEvent*) (pSVEvent=0x7f26e80153b0) at .../libreoffice/vcl/source/window/winproc.cxx:2287\n" + ~"#47 0x00007f26fadc1385 in ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) (_pWindow=0x557f897d0e90, nEvent=SalEvent::UserEvent, pEvent=0x7f26e80153b0) at .../libreoffice/vcl/source/window/winproc.cxx:2851\n" + ~"#48 0x00007f26f08b6bae in SalFrame::CallCallback(SalEvent, void const*) const (this=0x557f8800cf80, nEvent=SalEvent::UserEvent, pEvent=0x7f26e80153b0) at .../libreoffice/vcl/inc/salframe.hxx:310\n" + ~"#49 0x00007f26f08d9dbf in QtInstance::ProcessEvent(SalUserEventList::SalUserEvent) (this=0x557f88020780, aEvent=...) at .../libreoffice/vcl/qt6/../qt5/QtInstance.cxx:516\n" + ~"#50 0x00007f26fb47b97f in operator()() const (__closure=0x7ffe889a50e0) at .../libreoffice/vcl/source/app/salusereventlist.cxx:119\n" + ~"#51 0x00007f26fb47bc53 in SalUserEventList::DispatchUserEvents(bool) (this=0x557f880207b8, bHandleAllCurrentEvents=false) at .../libreoffice/vcl/source/app/salusereventlist.cxx:120\n" + ~"#52 0x00007f26f08d98a4 in QtInstance::ImplYield(bool, bool) (this=0x557f88020780, bWait=true, bHandleAllCurrentEvents=false) at .../libreoffice/vcl/qt6/../qt5/QtInstance.cxx:442\n" + ~"#53 0x00007f26f08d9a4f in QtInstance::DoYield(bool, bool) (this=0x557f88020780, bWait=true, bHandleAllCurrentEvents=false) at .../libreoffice/vcl/qt6/../qt5/QtInstance.cxx:464\n" + ~"#54 0x00007f26fb5390d0 in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at .../libreoffice/vcl/source/app/svapp.cxx:390\n" + ~"#55 0x00007f26fb539e6e in Application::Yield() () at .../libreoffice/vcl/source/app/svapp.cxx:474\n" + ~"#56 0x00007f26fb538dc3 in Application::Execute() () at .../libreoffice/vcl/source/app/svapp.cxx:368\n" + ~"#57 0x00007f2704e371b6 in desktop::Desktop::Main() (this=0x7ffe889a5c10) at .../libreoffice/desktop/source/app/app.cxx:1614\n" + ~"#58 0x00007f26fb558292 in ImplSVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:229\n" + ~"#59 0x00007f26fb5585a7 in SVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:261\n" + ~"#60 0x00007f2704ea4307 in soffice_main() () at .../libreoffice/desktop/source/app/sofficemain.cxx:94\n" + ~"#61 0x0000557f862d19d4 in sal_main () at .../libreoffice/desktop/source/app/main.c:51\n" + ~"#62 0x0000557f862d19ba in main (argc=3, argv=0x7ffe889a5e38) at .../libreoffice/desktop/source/app/main.c:49\n" + 2906^done + (gdb) + + Change-Id: I1f517d441eeb3e77e969062b884d9a425038b22a + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163202 + Tested-by: Jenkins + Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> + (cherry picked from commit cb9513c74502144a480494e0c6a32ac6173ae0a3) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163179 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-02-12 Regina Henschel <rb.henschel@t-online.de> [f05bc0cf6c9fdba682a0aee4e3a06b093ae345da] + + tdf#156993 use correct count for ViewContactOfSdrPage + + The count is used as upper limit in a for-loop in + ViewObjectContact::getPrimitive2DSequenceSubHierarchy(). + That calls ViewContactOfSdrPage::GetViewContact(). + With the wrong count the case 10 was not reached and thus the helplines + were not drawn. + + Change-Id: If606bbb718b1f78a874862217d1e03b02287e848 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163192 + Tested-by: Jenkins + Reviewed-by: Regina Henschel <rb.henschel@t-online.de> + (cherry picked from commit 56517d8a38459f5a9e67327c1ac0dc8bcd07bcb8) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163180 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-09 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [46169670ef4031888e143823b263577296d7867f] + + bump product version to 24.2.2.0.0+ + + Change-Id: Ie3111656db10fd1237fafbf96d7cdd46385811b0 2024-02-09 Noel Grandin <noel.grandin@collabora.co.uk> [6b7a23022a4d2471df7b458f3ac61c8b768ea896] |