summaryrefslogtreecommitdiffstats
path: root/compilerplugins/clang/store/revisibility.cxx
diff options
context:
space:
mode:
Diffstat (limited to 'compilerplugins/clang/store/revisibility.cxx')
-rw-r--r--compilerplugins/clang/store/revisibility.cxx89
1 files changed, 89 insertions, 0 deletions
diff --git a/compilerplugins/clang/store/revisibility.cxx b/compilerplugins/clang/store/revisibility.cxx
new file mode 100644
index 0000000000..727d7094a0
--- /dev/null
+++ b/compilerplugins/clang/store/revisibility.cxx
@@ -0,0 +1,89 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include "plugin.hxx"
+
+// Find function declarations that redundantly re-specify a visibility attribute
+// (via SAL_DLLPUBLIC_EXPORT etc.) that was already specified with a previous
+// declaration of that function. But MSVC wants consistency of __declspec
+// across friend declarations, so just ignore those for now.
+
+namespace {
+
+bool hasExplicitVisibilityAttr(Decl const * decl) {
+ VisibilityAttr const * attr = decl->getAttr<VisibilityAttr>();
+ return attr != nullptr && !attr->isInherited();
+}
+
+bool isFriendDecl(Decl const * decl) {
+ return decl->getFriendObjectKind() != Decl::FOK_None;
+}
+
+class ReVisibility:
+ public loplugin::FilteringPlugin<ReVisibility>
+{
+public:
+ explicit ReVisibility(InstantiationData const & data): FilteringPlugin(data) {}
+
+ void run() override
+ { TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); }
+
+ bool VisitFunctionDecl(FunctionDecl const * decl);
+};
+
+bool ReVisibility::VisitFunctionDecl(FunctionDecl const * decl) {
+ if (!ignoreLocation(decl) && hasExplicitVisibilityAttr(decl)
+ && !isFriendDecl(decl))
+ {
+ Decl const * first = nullptr;
+ for (Decl const * p = decl;;) {
+ p = p->getPreviousDecl();
+ if (p == nullptr) {
+ break;
+ }
+ first = p;
+ if (hasExplicitVisibilityAttr(p) && !isFriendDecl(p)) {
+ report(
+ DiagnosticsEngine::Warning,
+ "Redundant visibility re-declaration",
+ decl->getAttr<VisibilityAttr>()->getLocation())
+ << decl->getAttr<VisibilityAttr>()->getRange();
+ report(
+ DiagnosticsEngine::Note,
+ "Previous visibility declaration is here",
+ p->getAttr<VisibilityAttr>()->getLocation())
+ << p->getAttr<VisibilityAttr>()->getRange();
+ return true;
+ }
+ }
+ if (decl->isThisDeclarationADefinition() && first != nullptr
+ && !(getFilenameOfLocation(
+ compiler.getSourceManager().getSpellingLoc(
+ decl->getLocation()))
+ .startswith(SRCDIR "/libreofficekit/")))
+ {
+ report(
+ DiagnosticsEngine::Warning,
+ "Visibility declaration on definition, not first declaration",
+ decl->getAttr<VisibilityAttr>()->getLocation())
+ << decl->getAttr<VisibilityAttr>()->getRange();
+ report(
+ DiagnosticsEngine::Note, "First declaration is here",
+ first->getLocation())
+ << first->getSourceRange();
+ }
+ }
+ return true;
+}
+
+loplugin::Plugin::Registration<ReVisibility> X("revisibility");
+
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */