diff options
Diffstat (limited to 'compilerplugins/clang/unnecessarycatchthrow.cxx')
-rw-r--r-- | compilerplugins/clang/unnecessarycatchthrow.cxx | 91 |
1 files changed, 91 insertions, 0 deletions
diff --git a/compilerplugins/clang/unnecessarycatchthrow.cxx b/compilerplugins/clang/unnecessarycatchthrow.cxx new file mode 100644 index 0000000000..0a8265b170 --- /dev/null +++ b/compilerplugins/clang/unnecessarycatchthrow.cxx @@ -0,0 +1,91 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#ifndef LO_CLANG_SHARED_PLUGINS + +#include <cassert> +#include <string> +#include <iostream> +#include <fstream> +#include <set> + +#include <clang/AST/CXXInheritance.h> +#include "plugin.hxx" + +/** +look for unnecessary blocks that just catch and rethrow: + try { + stuff + } catch (exception const &) { + throw; + } +*/ + +namespace { + +class UnnecessaryCatchThrow: + public loplugin::FilteringPlugin<UnnecessaryCatchThrow> +{ +public: + explicit UnnecessaryCatchThrow(loplugin::InstantiationData const & data): FilteringPlugin(data) {} + + virtual void run() override + { + TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); + } + + bool VisitCXXTryStmt(CXXTryStmt const *); +}; + +bool UnnecessaryCatchThrow::VisitCXXTryStmt(CXXTryStmt const * tryStmt) +{ + if (ignoreLocation(tryStmt)) + return true; + if (tryStmt->getNumHandlers() != 1) + return true; + auto catchStmt = tryStmt->getHandler(0); + auto compoundStmt = dyn_cast<CompoundStmt>(catchStmt->getHandlerBlock()); + if (!compoundStmt || compoundStmt->size() != 1) + return true; + auto throwExpr = dyn_cast<CXXThrowExpr>(compoundStmt->body_front()); + if (!throwExpr) + return true; + auto subExpr = throwExpr->getSubExpr(); + if (subExpr) + { + if (auto cxxConstructExpr = dyn_cast<CXXConstructExpr>(subExpr)) { + if (!cxxConstructExpr->getConstructor()->isCopyConstructor()) + return true; + if (!cxxConstructExpr->getConstructor()->getParent()->hasAttr<FinalAttr>()) + return true; + if (cxxConstructExpr->getNumArgs() != 1) + return true; + subExpr = cxxConstructExpr->getArg(0); + } + auto declRefExpr = dyn_cast<DeclRefExpr>(subExpr->IgnoreImpCasts()); + if (!declRefExpr) + return true; + if (declRefExpr->getDecl() != catchStmt->getExceptionDecl()) + return true; + } + + report( DiagnosticsEngine::Warning, "unnecessary catch and throw", + catchStmt->getBeginLoc()) + << catchStmt->getSourceRange(); + return true; +} + + +loplugin::Plugin::Registration< UnnecessaryCatchThrow > unnecessarycatchthrow("unnecessarycatchthrow"); + +} // namespace + +#endif // LO_CLANG_SHARED_PLUGINS + +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ |