From e3cf16e6fbf8d39cad8762f002b6db1d4f61ed36 Mon Sep 17 00:00:00 2001 From: Daniel Baumann Date: Sat, 4 May 2024 07:03:24 +0200 Subject: Merging upstream version 4:24.2.3. Signed-off-by: Daniel Baumann --- ChangeLog | 2825 ++++++++++++++++++++++++++++++++++++++++++++++++++++++------- 1 file changed, 2539 insertions(+), 286 deletions(-) (limited to 'ChangeLog') diff --git a/ChangeLog b/ChangeLog index 03fbc2d4a1..d745cd5be8 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,62 +1,1983 @@ -2024-03-22 Christian Lohmaier [d56cc158d8a96260b836f100ef4b4ef25d6f1a01] +2024-04-29 Christian Lohmaier [433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba] - Version 24.2.2.2, tag libreoffice-24.2.2.2 + Version 24.2.3.2, tag libreoffice-24.2.3.2 -2024-03-22 Christian Lohmaier [928e2cf2dcbe5c86ae8b8b795f2df55e4c051461] +2024-04-29 Christian Lohmaier [890ac6263b2f3348ddfe11075c921d8454bc2826] - bump product version to 24.2.2.2 + bump product version to 24.2.3.2 - Change-Id: I30ccd4f800b01758ddd21afc46f73d708d810568 + Change-Id: Ie10184cc8b4b860b20a270f8845d1059ce93a6d8 -2024-03-22 Patrick Luby [9012b402ec25c5eb17400f93ffdc73e3db3a122a] +2024-04-29 Christian Lohmaier [ab4fd05c26289147ac1cab686a93a84fda85be5f] + + update credits + + Change-Id: I92481956d041c4a5077aa7a56af2df3ab72fd9bf + (cherry picked from commit e729fec8a9e73e9d013cb634d4bcbd8c43be4200) + (cherry picked from commit 6b20b3abc70c210ae52ecde24076ad08c4594fe0) + +2024-04-29 Julien Nabet [467b70a96820c70916015bb3386f219432e9c915] + + tdf#159625: fix "allow to split paragraph" + + 2 pbs here: + 1) bug described in the bugtracker, the uncheck isn't kept + => just remove all the buggy GetOldItem stuff + 2) after unchecked the option then saving the file and reloading the file, the option is still checked + => change the buggy + rOutSet->Put( SvxFormatSplitItem( eState == TRISTATE_FALSE, _nWhich ) ); + to + rOutSet->Put( SvxFormatSplitItem( eState == TRISTATE_TRUE, _nWhich ) ); + + In fact, I just mimicked the code used for "keep paragraphs" which works well. + + Also change the QA test since "allow to split paragraph" is checked by default + so if the QA simulates a click on it, we expect the value to be false when dialog is opened again + + Change-Id: I947feb02e0c282304621a252ad5e4c168c1d295a + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166774 + Tested-by: Jenkins + Reviewed-by: Julien Nabet + (cherry picked from commit 83236587bfca52513515b0b7a7dbfa18eed11503) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166725 + Reviewed-by: Noel Grandin + Reviewed-by: Xisco Fauli + (cherry picked from commit cf370be03dfc6eb2cd4643548f2f25ad3bfc6612) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166843 + Tested-by: Christian Lohmaier + Reviewed-by: Christian Lohmaier + +2024-04-29 Caolán McNamara [cc4225317a5da0a883e1a58150f92802e16ac7aa] + + SfxViewFrame::Current() dereferenced without null check + + found with msvc -analyze and _Ret_maybenull_ + + Change-Id: Ia377822e93448dc61acd1482d34167c35a46836b + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166705 + Tested-by: Jenkins + Reviewed-by: Caolán McNamara + (cherry picked from commit 95d3e0d478686c7fa84f0bb8c466a1082333a47b) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166830 + Reviewed-by: Xisco Fauli + (cherry picked from commit b18b3b51a7d397a16e85bf8ba83b27193c7cc8c5) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166841 + Tested-by: Christian Lohmaier + Reviewed-by: Christian Lohmaier + +2024-04-29 Julien Nabet [bb71d3949bbccc6c731933e2cd1e32b9b1080ddc] + + tdf#160827: fix crash when retrieving _MarkAsFinal value (docx) (take 2) + + Change-Id: I3f2ad56a205877be54b0dbfe361b76db3436f5ca + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166798 + Reviewed-by: Noel Grandin + Reviewed-by: Julien Nabet + Tested-by: Jenkins + (cherry picked from commit 45d2d90d2354a6a32297cde52c0041915499b19b) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166726 + Reviewed-by: Xisco Fauli + (cherry picked from commit 2ed402dada3b8b64c6f23cf5afc068848ab1a528) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166839 + Reviewed-by: Christian Lohmaier + Tested-by: Christian Lohmaier + +2024-04-29 Patrick Luby [77c26dae7c984f5c60206091f87897079c8a5d93] + + tdf#153306 prevent subpixel shifting of X coordinate + + HACK: for some unknown reason, if the X coordinate of the + path's bounds is more than 1024, SkBlendMode::kExclusion will + shift by about a half a pixel to the right with Skia/Metal on + a Retina display. Weirdly, if the same polygon is repeatedly + drawn, the total shift is cumulative so if the drawn polygon + is more than a few pixels wide, the blinking cursor in Writer + will exhibit this bug but only for one thin vertical slice at + a time. Apparently, shifting drawing a very tiny amount to + the left seems to be enough to quell this runaway cumulative + X coordinate shift. + + Change-Id: Ic1ac8a390df51c4aa1cc3183590dce72059af6b6 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166766 + Reviewed-by: Patrick Luby + Tested-by: Jenkins + (cherry picked from commit 05d3a99aa687ee4e1706f9403651379b7ebdad89) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166723 + Tested-by: Christian Lohmaier + Reviewed-by: Christian Lohmaier + +2024-04-29 Michael Stahl [0d37975ae718e1baa312616dfbbd71496e077a49] + + sw: workaround crash in IsAllHiddenRow() + + Not sure why but somehow still crashes in the code added in commit + ab7893544dc6be6dc192dffefd57cd5ddd421c35 + + https://crashreport.libreoffice.org/stats/crash_details/912e7417-5e04-4279-bbaf-380234f4cd33 + + Change-Id: I23b7ecdd83009cfe6584866ed72102d8f2179f86 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166010 + Tested-by: Michael Stahl + Reviewed-by: Michael Stahl + (cherry picked from commit 44ff9907eb1f2851b3b9087e7ec5e5dfae5a00c6) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165940 + Tested-by: Jenkins + Reviewed-by: Caolán McNamara + (cherry picked from commit 13e517aa5baa1ce9afefd84ff41496c1adeb5367) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166092 + Reviewed-by: Christian Lohmaier + Reviewed-by: Xisco Fauli + Tested-by: Christian Lohmaier + Reviewed-by: Ilmari Lauhakangas + +2024-04-29 Christian Lohmaier [f185f1fb1ce949f0ebe16eb23f7b76e90020e8cb] + + Update git submodules + + * Update translations from branch 'libreoffice-24-2-3' + to abc5b4da9d1c382d8f76eec58b3c6b0ba17f92bd + - update translations for 24.2.3 rc2 + + and force-fix errors using pocheck + + Change-Id: Ia1b6ca2a6abad23632aafb021c8bba19a20e1a7b + (cherry picked from commit 64792214d2d89afc019f94ca29ff7a2c2a17ab39) + +2024-04-29 Andreas Heinisch [985a85437c1352079ff1812b6039874b5226882b] + + tdf#160765 - Save content for undo when pasting notes + + even if no content was changed after pasting special. Otherwise, the undo functionality crashes due to undoing a cell with no content where the annotation indicator will remain (unod/redo of note captions are handled via drawing undo). + + Change-Id: I7007fce510d6e9896cbda11a1e14a61b5ccb34a9 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166469 + Tested-by: Jenkins + Reviewed-by: Stéphane Guillou + Reviewed-by: Andreas Heinisch + (cherry picked from commit a1694b194c2b3e89250c5b79a69e7dd184b69976) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166523 + Reviewed-by: Xisco Fauli + (cherry picked from commit 7e2e1d7fd4531f57bbc30a0a8e1cb8c40519a349) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166527 + Tested-by: Xisco Fauli + Reviewed-by: Patrick Luby + Reviewed-by: Ilmari Lauhakangas + +2024-04-29 Michael Stahl [8c5b6aca5e3928dd89ecdd78ff0959bd6eccb6f1] + + tdf#159903 xmloff: ODF import: fix bug in margin compatibility override + + The check for the property being set was wrong: the state in a parent + style may be DIRECT_VALUE but a derived style may have a list style set, + which effectively overrides the ParaLeftMargin and ParaFirstLineIndent. + + Fix this so that the compatibility override only happens when required. + + (regression from commit 7cf5faec6fdbc27dd77d2d36fb2ff205322cba0d) + + Change-Id: I6c8ca493df946afcb48a63c01c132620bcd7b390 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166257 + Tested-by: Jenkins + Reviewed-by: Michael Stahl + (cherry picked from commit 1b2a6b98291cf8b7022951be19b915fe2a9e18e6) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166217 + Reviewed-by: Adolfo Jayme Barrientos + (cherry picked from commit 3df05ad4ec73e160f8c29af94ab3a34ee403b90d) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166512 + Tested-by: Xisco Fauli + Reviewed-by: Xisco Fauli + Reviewed-by: Ilmari Lauhakangas + Reviewed-by: Patrick Luby + +2024-04-29 Michael Stahl [9b5b007df580eaeff2bab2fda9a6cb45e3a3bd24] + + tdf#154581 tdf#157411 tdf#158549 sw: HTML import: fix SfxItemIter reuse + + This is obviously wrong, as ALG just pointed out: the aIter is at the + end after the 1st loop, so the 2nd loop does nothing. + Thx Gabor for checking all the reported bugs. + + (regression from commit db115bec9254417ef7a3faf687478fe5424ab378) + + Change-Id: Iae37b9ab5c630d0ee774f42c84d5e76349b92a90 + Tested-by: Gabor Kelemen + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166643 + Reviewed-by: Michael Stahl + Tested-by: Jenkins + (cherry picked from commit ac05822b8957d80018d3ce1cbf97cd9faa0dfe99) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166714 + Reviewed-by: Noel Grandin + Reviewed-by: Ilmari Lauhakangas + Tested-by: Xisco Fauli + Reviewed-by: Xisco Fauli + +2024-04-29 Mike Kaganski [fa83f96bd8d987a7e9abce73d7b4ace1ff389ce7] + + tdf#160700: Avoid both bookmark-start and bookmark-end at the same index + + There is a special handling of CrossRefBookmark, which has no end position + in the document model, but must span the whole paragraph, and end position + is generated explicitly. + + Since commit 1d7ce421480d9170316533de03feb8d04eb5c767 (tdf#159438: when + there's no frame, close previous bookmark first, 2024-01-30), end marks + of an index are sorted before start marks of the same index, with the + expectation that start / end marks represent non-empty span. Dun in case + of empty paragraphs with a CrossRefBookmark, both start and end mark were + emitted into the same index, and the new sorting resulted in the wrong + order of the elements. + + Fix this by checking if the start index is less than node end, and don't + handle CrossRefBookmark specially, if the check is negative. This writes + a single text:bookmark, instead of a text:bookmark-start, followed by a + text:bookmark-end. + + Change-Id: I533c4f7814edddc3cf24b1213490f251d60b2273 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166266 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski + Signed-off-by: Xisco Fauli + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166280 + (cherry picked from commit 63ebbc33e8b1194f1e0ef7b58a98c6e4236476a9) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166219 + Reviewed-by: Patrick Luby + Reviewed-by: Ilmari Lauhakangas + +2024-04-29 Patrick Luby [24bf5dd70e721fd68df0e2bd06adb85ebaf4ea24] + + tdf#160831 only set outside color to black for alpha masks + + The outside color still needs to be white for the content + so only apply the fix for tdf#157795 to the alpha mask. + + Change-Id: I7486b2c9062ca96bf127f2bce6b1bd5e65d00ff6 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166806 + Reviewed-by: Noel Grandin + Reviewed-by: Patrick Luby + Tested-by: Jenkins + (cherry picked from commit 5425103fb5a09c7e5e56d077260523438c593e21) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166728 + Reviewed-by: Adolfo Jayme Barrientos + Tested-by: Patrick Luby + +2024-04-26 Patrick Luby [f7579474089bfc67f7d83680d562efa17783e4b4] + + tdf#160590 Disable Metal with Intel HD Graphics 6000 + + Releasing a Metal buffer resource hangs when fetching pixels from a + Skia surface on this Intel MacBook Air built-in GPU. + + Change-Id: Ic3028bf8eb45ebb9f6d71879bf5d96f0401a95c8 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165927 + Tested-by: Jenkins + Reviewed-by: Patrick Luby + (cherry picked from commit fe3a4bdf48f7b2d4f6da31b4392ac5979653cf9c) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165946 + Reviewed-by: Ilmari Lauhakangas + Reviewed-by: Adolfo Jayme Barrientos + Reviewed-by: Michael Stahl + Tested-by: Patrick Luby + +2024-04-26 Noel Grandin [1e8ac8b7c865d63014c6655e2e7e77979927c4f7] + + tdf#160431 Inverts webp file image when inserted + + regression from + commit 81994cb2b8b32453a92bcb011830fcb884f22ff3 + Author: Noel Grandin + Date: Fri Apr 16 20:33:10 2021 +0200 + Convert internal vcl bitmap formats transparency->alpha (II) + + Change-Id: I3b2959c99a2e18c3972920f8ca86072566d54225 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166450 + Tested-by: Jenkins + Reviewed-by: Noel Grandin + (cherry picked from commit c503b6eef32055f75dc9cf761bd20eda4f161dd4) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166434 + Reviewed-by: Adolfo Jayme Barrientos + (cherry picked from commit 414d58e8fe8ecf545549dc960e1599b1035b7564) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166510 + Reviewed-by: Xisco Fauli + Tested-by: Noel Grandin + +2024-04-26 Patrick Luby [f15ac9bb71266a9c1c058a782e6752129aa4d0b3] + + tdf#160714 use crop box for bounds of embedded PDF object + + If there is no crop box, fallback to the media box just to be safe. + + Change-Id: I29f99a43e550cf09a1534c0aa01ffd6a55536fb7 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166544 + Tested-by: Jenkins + Reviewed-by: Patrick Luby + (cherry picked from commit 4b31f87e918c38a7eb30ceb85563a5c98b426da5) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166671 + Tested-by: Noel Grandin + Reviewed-by: Noel Grandin + Reviewed-by: Adolfo Jayme Barrientos + +2024-04-23 Laurent Balland [1d00b945c25c5b9df6553c0c89ef63749ac0a419] + + tdf#129701 Follow-up of previous change + + According to comments in https://gerrit.libreoffice.org/c/core/+/163536 + Follow-up of previous change + + Change-Id: Icd7b6798d6ef35ca9574125cd3d4c4d89044569c + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166133 + Tested-by: Jenkins + Reviewed-by: Eike Rathke + (cherry picked from commit 47187acee758680cda8086b6e295ef7beea3491b) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166178 + (cherry picked from commit 637312e2aa682ca11543a421a8de0bbbe72bf86b) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166215 + Reviewed-by: Adolfo Jayme Barrientos + Tested-by: Xisco Fauli + Reviewed-by: Laurent Balland + Reviewed-by: Xisco Fauli + +2024-04-11 Christian Lohmaier [87e8d8037cafce6e7eca7cd05eb1fc763639c851] + + bump product version to 24.2.3.1.0+ + + Change-Id: Ic9c7238409a969815c58aa3b1d7bb723bbf20b69 + +2024-04-11 Christian Lohmaier [a6daec12469d25b14bdecf2698a24221b5d62a5d] + + Branch libreoffice-24-2-3 + + This is 'libreoffice-24-2-3' - the stable branch for the 24.2.3 release. + Only very safe changes, reviewed by three people are allowed. + + If you want to commit more complicated fix for the next 24.2.x release, + please use the 'libreoffice-24-2' branch. + + If you want to build something cool, unstable, and risky, use master. + +2024-04-11 Patrick Luby [dd769dd028dad7b67709e6c4268c595d1916a9e7] + + Related: tdf#159529 eliminate possible memory leak + + Despite confirming that the release function passed to + SkBitmap.bitmap.installPixels() does get called for every + data array that has been allocated, Apple's Instruments + indicates that the data is leaking. While it is likely a + false positive, it makes leak analysis difficult so leave + the bitmap mutable. That causes SkBitmap.asImage() to make + a copy of the data and the data can be safely deleted here. + + Change-Id: Ib28d70bd5f51e6d3be7a7d7c0d5923d71a6e5390 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163774 + Tested-by: Jenkins + Reviewed-by: Patrick Luby + (cherry picked from commit 3e2dde97bc15f156837d10bf4456deb81f7f554a) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165187 + Reviewed-by: Christian Lohmaier + +2024-04-11 Mike Kaganski [c94c724d0ba9da6f6bacd6e9c6025ad0759d9658] + + Related: tdf#108057 Use autoincrement for automatically added primary key + + This partially undoes commit 24940e2c3717ad7b07d43db4f08cf7e09cfcc22f + (#100599# #95927# check if row is readonly and disable autoincrement + column for auto primarykey, 2002-06-27), enabling autoincrement again. + + Make sure to use the largest type that supports autoincrement. + + Change-Id: I4dfdbfb0c3d9b94c7634082b029c6e66aa01c782 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165027 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski + (cherry picked from commit c07548447a564b2d142cc439a124b76e6a71dfbd) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165001 + Reviewed-by: Christian Lohmaier + +2024-04-11 Julien Nabet [fe9beede27ce613f01fe51d0c7cc894878d4b31e] + + tdf#160192: fix crash when trying to overwrite file in RO dir+lock file + + Bug exposed with: + 5259ab8104cfba60c40748ed0cd59d93df038c5b + sfx2 store: create temp files next to local files + + bt: + 6 0x00007faac67ad9b5 in sax_fastparser::FastSaxSerializer::FastSaxSerializer(com::sun::star::uno::Reference const&) (this=0x559f316f0e70, xOutputStream=empty uno::Reference) + at sax/source/tools/fastserializer.cxx:68 + 7 0x00007faac67c46e0 in sax_fastparser::FastSerializerHelper::FastSerializerHelper(com::sun::star::uno::Reference const&, bool) + (this=0x559f31721400, xOutputStream=empty uno::Reference, bWriteHeader=true) at sax/source/tools/fshelper.cxx:30 + 8 0x00007fa9bfa1b4cc in std::_Construct, bool const&>(sax_fastparser::FastSerializerHelper*, com::sun::star::uno::Reference&&, bool const&) (__p=0x559f31721400, __args=..., __args=@0x7ffecd609207: true) + at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:119 + ... + 15 0x00007fa9bfa04087 in oox::core::XmlFilterBase::openFragmentStreamWithSerializer(rtl::OUString const&, rtl::OUString const&) + (this=0x559f318ed5f0, rStreamName="docProps/core.xml", rMediaType="application/vnd.openxmlformats-package.core-properties+xml") at oox/source/core/xmlfilterbase.cxx:511 + 16 0x00007fa9bfa04999 in oox::core::writeCoreProperties(oox::core::XmlFilterBase&, com::sun::star::uno::Reference const&) + (rSelf=..., xProperties=uno::Reference to ((anonymous namespace)::SfxDocumentMetaData *) 0x559f2d673e28) at oox/source/core/xmlfilterbase.cxx:645 + 17 0x00007fa9bfa047c2 in oox::core::XmlFilterBase::exportDocumentProperties(com::sun::star::uno::Reference const&, bool) + (this=0x559f318ed5f0, xProperties=uno::Reference to ((anonymous namespace)::SfxDocumentMetaData *) 0x559f2d673e28, bSecurityOptOpenReadOnly=false) at oox/source/core/xmlfilterbase.cxx:981 + 18 0x00007fa9bee21bd4 in DocxExport::WriteProperties() (this=0x7ffecd609d78) at sw/source/filter/ww8/docxexport.cxx:952 + 19 0x00007fa9bee24b0b in DocxExport::DocxExport(DocxExportFilter&, SwDoc&, std::shared_ptr&, SwPaM&, bool, bool) + (this=0x7ffecd609d78, rFilter=..., rDocument=..., pCurrentPam=std::shared_ptr (use count 1, weak count 1) = {...}, rOriginalPam=SwPaM = {...}, bDocm=false, bTemplate=false) + at sw/source/filter/ww8/docxexport.cxx:2149 + 20 0x00007fa9bee4438e in DocxExportFilter::exportDocument() (this=0x559f318ed5f0) at sw/source/filter/ww8/docxexportfilter.cxx:112 + 21 0x00007fa9bf9d6b8b in oox::core::FilterBase::filter(com::sun::star::uno::Sequence const&) (this=0x559f318ed5f0, rMediaDescSeq=uno::Sequence of length 12 = {...}) + at oox/source/core/filterbase.cxx:494 + + full bt here: + https://bugs.documentfoundation.org/attachment.cgi?id=193113 + + Patch prevents LO from crashing + make LO displays error message: + Error saving the document : + Write Error. + The file could not be written + + Change-Id: I41a94eeb17bb6568b586d89755bce330154d1dad + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164808 + Tested-by: Jenkins + Reviewed-by: Miklos Vajna + (cherry picked from commit 2887ffbf240aa70330cb50bf810170cf9c896405) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164821 + Reviewed-by: Christian Lohmaier + +2024-04-11 Mike Kaganski [167be9363ea505b334aa595b273707d7d9217863] + + tdf#160526, tdf#160549: fix split conditions at page start + + A single large object in a paragraph must be moved down, when the page + has other content before this. On the other hand, there must not be + moving down, when an unsuccessful attempt to move was already done (so + the master frame is empty), or even the first time, when the frame is + at the page body start. + + Change-Id: Ib8e2fe7b77c622d9cfac22722ca6b55dba7ad8ae + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165869 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski + Signed-off-by: Xisco Fauli + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165889 + +2024-04-11 Stephan Bergmann [aee47bb74a824cffc029ef9173cedff078583205] + + Adapt flatpak build to upstream changes + + + "Merge pull request #288 from + EliasTheGrandMasterOfMistakes/EliasTheGrandMasterOfMistakes-patch-2: Update JDK, + GVFS and ANT" + + Change-Id: I021ddb9ca6b1fbec6cfe22784a9d023db2fa737c + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165920 + Tested-by: Jenkins + Reviewed-by: Stephan Bergmann + (cherry picked from commit 82c17b61e05b9373ab1100f9c72156d655e0a866) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165930 + Reviewed-by: Xisco Fauli + +2024-04-11 Mike Kaganski [3ca52750661cf8a3b36a42a0a6d293318232f1b9] + + tdf#109272: make sure that Delete / Backspace move cursor correctly + + ... in change tracking mode. Cursor's end position now doesn't depend + on the selection direction; it is at the deletion's beginning in case + of Backspace, and at deletion's end in case of Delete. + + Change-Id: I9cb7af235a066bea2c7b21b8ff515dcdd52218c6 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162240 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski + (cherry picked from commit c80606bb23fd42e41710d70a96b7ffaf948384a6) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165849 + Reviewed-by: Xisco Fauli + +2024-04-11 Christian Lohmaier [5beac71990a82abb21ad8c7962ca7d0ed17abe58] + + Update git submodules + + * Update translations from branch 'libreoffice-24-2' + to 3e215b586e927288b92725d456b4dd7fd54dee85 + - update translations for 24.2.3 rc1 + + and force-fix errors using pocheck + + Change-Id: Ia1332fb36e3ae8379e97f29b087b3431bb5707ea + +2024-04-09 Mike Kaganski [61e94a59a947c372a5802134d94f0908327a2366] + + tdf#160436: fix glyph bounds calculation for vertical glyphs + + It is unclear if LogicalFontInstance::GetGlyphBoundRect can be called + for both normal and rotated variants of the same glyph in the same font. + If yes, then the normal and vertical variants must be cached separately, + or possibly vertical variant can be not cached, but always calculated. + This problem already existed before, so this change doesn't introduce + a new issue. + + Change-Id: I9b50ef340c9e38db7bef890165519aadc96d3ffa + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165581 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski + (cherry picked from commit dff57d2b4f5abd1b51ebfb0015339471f61e72f9) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165843 + Reviewed-by: Xisco Fauli + +2024-04-09 Christian Lohmaier [0f25bb5747eeefcc0668c726e613394dc35cb4de] + + Update git submodules + + * Update translations from branch 'libreoffice-24-2' + to 28615b892ac03b0c5c1b74f60f4008a36da518dd + - update translations for 24.2.3 rc1 + + and force-fix errors using pocheck + + Change-Id: Iaaf78b114dce75267640c50c3512e42ed334d9ab + +2024-04-09 Mike Kaganski [07a566f87213bd4c9c28b454ab4c4d30146fdaa4] + + tdf#81012: avoid content frames in footnotes / endnotes + + This makes the behavior of the endnotes in the end of sections consistent + with the behavior of dedicated endnote pages, where heading fields ignore + headings in endnote content. + + Change-Id: Iad0218b75a678808b1266024fe4c81f040a631c4 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165789 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski + (cherry picked from commit 746b21760b911860c7ac497f10ab07d60111e867) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165842 + Reviewed-by: Michael Stahl + +2024-04-09 Mike Kaganski [70c19e55662e8a42876bc6aebdc7cfe1ede14ee1] + + Fix UB after 8962141a12c966b2d891829925e6203bf8d51852 + + (tdf#160430: Fix glyph bounds calculation, and use basegfx::B2DRectangle, 2024-04-01). + As reported by Stephan in https://gerrit.libreoffice.org/c/core/+/165553/6#message-fec1e45288c0e87d43c58f777ebe51b03c534d82: + + `CppunitTest_sw_rtfexport CPPUNIT_TEST_NAME=testMathEqarray::TestBody` now fails with + + vcl/source/gdi/sallayout.cxx:245:30: runtime error: inf is outside the range of representable values of type 'long' + #0 in SalLayout::GetBoundRect(tools::Rectangle&) const at vcl/source/gdi/sallayout.cxx:245:30 + #1 in OutputDevice::GetTextBoundRect(tools::Rectangle&, rtl::OUString const&, int, int, int, unsigned long, KernArraySpan, std::span, SalLayoutGlyphs const*) const at vcl/source/outdev/text.cxx:1932:28 + #2 in (anonymous namespace)::SmGetGlyphBoundRect(OutputDevice const&, rtl::OUString const&, tools::Rectangle&) at starmath/source/rect.cxx:80:32 + #3 in SmRect::SmRect(OutputDevice const&, SmFormat const*, rtl::OUString const&, unsigned short) at starmath/source/rect.cxx:224:21 + #4 in SmMathSymbolNode::AdaptToY(OutputDevice&, unsigned long) at starmath/source/node.cxx:2122:18 + #5 in SmBraceNode::Arrange(OutputDevice&, SmFormat const&) at starmath/source/node.cxx:1340:17 + #6 in SmBinHorNode::Arrange(OutputDevice&, SmFormat const&) at starmath/source/node.cxx:816:13 + #7 in SmLineNode::Arrange(OutputDevice&, SmFormat const&) at starmath/source/node.cxx:610:20 + #8 in SmTableNode::Arrange(OutputDevice&, SmFormat const&) at starmath/source/node.cxx:534:20 + #9 in SmDocShell::ArrangeFormula() at starmath/source/document.cxx:280:13 + #10 in SmDocShell::GetSize() at starmath/source/document.cxx:405:9 + #11 in SmDocShell::Repaint() at starmath/source/document.cxx:566:21 + #12 in SmDocShell::OnDocumentPrinterChanged(Printer*) at starmath/source/document.cxx:552:5 + #13 in SmDocShell::SetText(rtl::OUString const&) at starmath/source/document.cxx:188:9 + #14 in SmDocShell::readFormulaOoxml(oox::formulaimport::XmlStream&) at starmath/source/document.cxx:848:5 + #15 in SmModel::readFormulaOoxml(oox::formulaimport::XmlStream&) at starmath/source/unomodel.cxx:1105:22 + #16 in writerfilter::rtftok::RTFDocumentImpl::beforePopState(writerfilter::rtftok::RTFParserState&) at writerfilter/source/rtftok/rtfdocumentimpl.cxx:3010:30 + #17 in writerfilter::rtftok::RTFDocumentImpl::popState() at writerfilter/source/rtftok/rtfdocumentimpl.cxx:3666:23 + #18 in writerfilter::rtftok::RTFTokenizer::resolveParse() at writerfilter/source/rtftok/rtftokenizer.cxx:114:37 + #19 in writerfilter::rtftok::RTFDocumentImpl::resolve(writerfilter::Stream&) at writerfilter/source/rtftok/rtfdocumentimpl.cxx:856:27 + #20 in (anonymous namespace)::RtfFilter::filter(com::sun::star::uno::Sequence const&) at writerfilter/source/filter/RtfFilter.cxx:163:20 + #21 in SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference const&) at sfx2/source/doc/objstor.cxx:2392:34 + #22 in SfxObjectShell::DoLoad(SfxMedium*) at sfx2/source/doc/objstor.cxx:760:23 + #23 in SfxBaseModel::load(com::sun::star::uno::Sequence const&) at sfx2/source/doc/sfxbasemodel.cxx:1980:36 + #24 in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence const&, com::sun::star::uno::Reference const&) at sfx2/source/view/frmload.cxx:720:28 + #25 in framework::LoadEnv::impl_loadContent() at framework/source/loadenv/loadenv.cxx:1176:37 + #26 in framework::LoadEnv::start() at framework/source/loadenv/loadenv.cxx:412:20 + #27 in framework::LoadEnv::startLoading(rtl::OUString const&, com::sun::star::uno::Sequence const&, com::sun::star::uno::Reference const&, rtl::OUString const&, int, LoadEnvFeatures) at framework/source/loadenv/loadenv.cxx:308:5 + #28 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference const&, com::sun::star::uno::Reference const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence const&) at framework/source/loadenv/loadenv.cxx:168:14 + #29 in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence const&) at framework/source/services/desktop.cxx:591:16 + #30 in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence const&) at framework/source/services/desktop.cxx + #31 in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence const&) at unotest/source/cpp/macros_test.cxx:71:62 + #32 in UnoApiTest::loadWithParams(rtl::OUString const&, com::sun::star::uno::Sequence const&) at test/source/unoapi_test.cxx:126:19 + #33 in UnoApiTest::load(rtl::OUString const&, char const*) at test/source/unoapi_test.cxx:108:5 + #34 in SwModelTestBase::loadURL(rtl::OUString const&, char const*) at sw/qa/unit/swmodeltestbase.cxx:441:20 + #35 in SwModelTestBase::loadAndReload(char const*) at sw/qa/unit/swmodeltestbase.cxx:466:5 + #36 in (anonymous namespace)::testMathEqarray::TestBody() at sw/qa/extras/rtfexport/rtfexport.cxx:198:5 + + Change-Id: I857861f5bc51a1e43bfbf5e0c9dbce542d673ca7 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165664 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski + (cherry picked from commit 51244ebe62bb25f7d87ab1332e863720d980db66) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165844 + Reviewed-by: Xisco Fauli + +2024-04-08 Caolán McNamara [843b3abd2ab05c66533b12ef6a4b155247f99e58] + + Resolves: tdf#154715 don't use last-used field setting when editing field + + If we are inserting a field it makes sense to use the last-used + settings, but if we are editing an existing field we naturally want to + populate with the current field. + + Here we have IsRefresh used twice as a condition, one inside the other. + But if was true in the outer use, it will also be true in the inner + (this duplication exists all the way back to the initial commit) because + GetUserData() has no side effect. + + IsRefresh is only true during EditNewField (which is the case of using + the "next/back" button to go to edit another field). So even before this + change if you click next and then back (assuming there is another field + to move to) then you then get the right results + + Skip restoring the last-used settings in the EditField case, replace + the outer !IsRefresh() with !IsFieldEdit() + + Change-Id: I4224302171d2e8d02a0f1e0efc9fdada5ada9d7f + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165876 + Tested-by: Jenkins + Reviewed-by: Caolán McNamara + (cherry picked from commit db609a58df7be082de7d5a20a2a924789d6a64a1) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165840 + Reviewed-by: Xisco Fauli + +2024-04-08 Regina Henschel [4e04b442e037a2f679b4cfe26c3e6b1c66ee8642] + + tdf#160369 Do not broadcast temporarily group change + + The position and size of a group needs to be temporarily changed when + saving because ODF does not treat hidden rows/cols as zero, but LO does. + After saving, these changes have to be undone. The error was that the + restore was performed with GetGeoDate/SetGeoData. But SetGeoData + includes a broadcast that triggeres recalculations that should not be + performed here. Now the change and restore are both done with NbcMove + and NbcResize. + + The import had set a 'logical rectangle', but that is nonsense for a + group, because a group does not have a 'logical rectangle'. + For a group, none of the special corrections in + ScDrawLayer::InitializeCellAnchoredObj are needed. + + Change-Id: I00adf39e83011112492822d2900e41242d188e84 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165872 + Tested-by: Jenkins + Reviewed-by: Regina Henschel + (cherry picked from commit 1e1b1d46155163380252093d9d2868351236ce0e) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165839 + Reviewed-by: Xisco Fauli + +2024-04-08 Mike Kaganski [6f4a949c07eb06345df08c722f8e59e97888a499] + + tdf#160430: Fix glyph bounds calculation, and use basegfx::B2DRectangle + + ... instead of tools::Rectangle. + + Several problems were there: + 1. First, a horizontal bounding rectangle was calculated, with due + rounding; and then the result was rotated, and after that, rounded + again. That made the resulting rotated rectangle coordinates very + imprecise. + 2. Also, ceil/floor was applied without normalization; and in case + of rotated font, that meant, that sometimes the range could be not + expanded to cover partially covered pixels, but instead collapsed. + 3. The rotation to angles other than 90 degree multiples was done + incorrectly, resulting in cut off parts of characters. + 4. For 90 degrees, the imprecise result of sin/cos converted 0.0 + into values like 3e-16, which then could be ceil'ed up to 1. + + Using B2DRectangle and its transform allows to simplify and fix + the calculations easily, and avoids premature rounding. Render of + rotated text of small size is more stable with this change. + + Change-Id: Idffd74b9937feb2418ab76a8d325fdaf4ff841b7 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165553 + Tested-by: Jenkins + Reviewed-by: Tomaž Vajngerl + Reviewed-by: Mike Kaganski + (cherry picked from commit 8962141a12c966b2d891829925e6203bf8d51852) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165619 + Reviewed-by: Xisco Fauli + +2024-04-08 Xisco Fauli [8575b792c32613e44324606393cf7a6f136472b3] + + tdf#160386: Add support for switch element + + For now, only use language tag, meaning if + there is a file like in the unittest with + + Howdy! + Wotcha! + G'day! + Hello! + + "Hello!" with be displayed in a en_AU system locale + + This patch partially reverts 13a41e7a12598c7896d6dc8d34aba6af5b80b83c + "tdf#150124: do nothing when parent is of unkown type" + making 0dfd8288a87b58e503bb3a41be6137485fbf3f68 + "ofz#60384 Direct-leak" no longer necessary + + Change-Id: Ifc73bc69aa997088dc0a2b11d7d30446303fa3b3 + + Change-Id: I885ef0f2c44b86196881fe55a963db2e5c7eb1be + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165394 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli + Signed-off-by: Xisco Fauli + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165438 + +2024-04-08 Aron Budea [beff8cb9344f13ddbcdc667ad6b73d2d405fa21d] + + tdf#160342 Unwanted space before end of line when printing + + Also adjust some numeric literals to reflect they're + floating point values in the expressions. + + Regression from 172b500ccbc8dac0496cc2936a9bcca793c0b594. + + Change-Id: I8281ba7c7d480135471ba94b11d447d76fd33063 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165860 + Tested-by: Jenkins + Reviewed-by: Aron Budea + (cherry picked from commit 357f07bfd96da6cca87fcf0ef339495c2fea6937) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165836 + Reviewed-by: خالد حسني + Reviewed-by: Xisco Fauli + +2024-04-08 Noel Grandin [4126c6b94e87f7ad2a1aa93d66bbb3edf67ec790] + + tdf#158556 speedup docx load + + If we want to know if an XText is a header/footer object, no need to + loop over the draw objects, we can just query its service name. + + Reduces load time from 167s to 97s + + Change-Id: I10158c11dd24c4945b3ea6cfed4916717bd4f2f8 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165269 + Tested-by: Noel Grandin + Reviewed-by: Noel Grandin + (cherry picked from commit ab29c857c669bcca3d8eea8a5a9e6ad5eae622d7) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165618 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli + +2024-04-08 Noel Grandin [02b100e8ecbe47bd8d70d81dbefcb24be0501b8b] + + tdf#160399 speed up print preview + + takes time from 11s to 5s for me + + Change-Id: Ic874b9168f9caaf697007e586df8499a849ccfd6 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165460 + Tested-by: Jenkins + Reviewed-by: Noel Grandin + (cherry picked from commit 6931a596350086d52ba32bf8a84cb36fbfdb34d6) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165617 + Reviewed-by: Xisco Fauli + +2024-04-08 Noel Grandin [8f53eb5dc5cc7f90a2b134c5b5ad66988bcc9842] + + tdf#160399 speed up print preview + + takes time from 5s to 2.5s for me + + Change-Id: I7e62e4a47d5b2aae982273cc3ea38c5c9b04256d + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165461 + Tested-by: Jenkins + Reviewed-by: Noel Grandin + (cherry picked from commit 3819e4f6f70ee60fc5c805f0d33c0062a396918c) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165616 + Reviewed-by: Xisco Fauli + +2024-04-08 Caolán McNamara [cbac2445612be0c78ca7e46ca5abd5860025b396] + + ofz#67854 UNKNOWN READ + + Change-Id: I37d2bc6153a8bf616d19105645f91b8519890e61 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165729 + Tested-by: Jenkins + Reviewed-by: Michael Stahl + +2024-04-07 Tibor Nagy [09a055c7457b005e1d7c733dc951dd8469c75411] + + tdf#156655 sc: fix disappear text in merged cell + + The text does not appear if the first row or column of the merged cell + is hidden. + + Change-Id: I398f0d572226e44ffaa4e33c066b51480ad124cb + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164757 + Tested-by: Jenkins + Reviewed-by: Nagy Tibor + (cherry picked from commit d5f25d9c0026ec06a0b46e1560e26adba2725290) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165835 + Reviewed-by: Thorsten Behrens + +2024-04-07 Patrick Luby [96a40862fa010d9022247524913ac51e1d8b189a] + + tdf#159790 temporarily release mutex for child packages + + This code is normally run on a separate thread so if a + child package tries to acquire the solar mutex, a deadlock + can occur if the main thread calls isRegistered() on this + package or any of its parents. So, temporarily release + this package's mutex while registering the child package. + + Change-Id: I45b534c44d5946637a5441927ed01a68aad4c448 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165766 + Tested-by: Jenkins + Reviewed-by: Noel Grandin + (cherry picked from commit cab028121bd9b620529b6492b3247ac48ac2082b) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165831 + Reviewed-by: Patrick Luby + +2024-04-06 Michael Stahl [9f20d89ded05600233ceed7db40cdef57aca1442] + + sw: layout: remove superfluous pages again in InternalAction() + + The bugdoc has a very large header containing hidden text changes height + when toggling Formatting Marks. When toggling on, it crashes, because + UnHide() iterates the text frames in all headers, but after the first + one empty pages at the end of the document are removed, so UAF. + + Remove the pages without content earlier; SwLayAction::InternalAction() + already does it after the "normal" page loop, but the 2nd page loop + following that may also move content off pages, so do it again. + + Change-Id: Iaae6a16842b3494f25cba8fc036d15049b71961f + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165801 + Tested-by: Jenkins + Reviewed-by: Michael Stahl + (cherry picked from commit 759d822dac5edc6104ce61b70c578425d9f2470d) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165727 + Reviewed-by: Caolán McNamara + +2024-04-05 Mike Kaganski [4ad24b828b77b9ebbaf09a08eafa52093349c32f] + + tdf#160260: make poppler wrapper executable Unicode-aware on Windows + + Change-Id: I76dc31ee14d1794fa73f990e641540ff941c7201 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165735 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski + (cherry picked from commit 7b9905df455b47977968a185a7c43f35541e018b) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165717 + Reviewed-by: Michael Stahl + +2024-04-05 Heiko Tietze [d3871c6ac05bb9553aed1cc951ba18efcb06082a] + + Resolves tdf#154209 - Fixes resize issue in Index Entry dialog + + Change-Id: I83400b56d40f145c0e066c0c8b1783a1bae4cf28 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165788 + Tested-by: Jenkins + Reviewed-by: Heiko Tietze + (cherry picked from commit ebfa0d061fdbca6a25d3efcff72ab5ed184a51dc) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165722 + Reviewed-by: Adolfo Jayme Barrientos + +2024-04-04 Oliver Specht [2ae662ed5e2a92ae8c1a2e6b61dcc9b67f94419f] + + tdf#160301 import DOCVARIABLE fields as user fields + + DOCVARIBLE fields in *.doc files are imported as user fields. + + Change-Id: Ib723d8a586ca644e0b158f839caef33b2b6225a0 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165096 + Tested-by: Jenkins + Tested-by: Gabor Kelemen + Reviewed-by: Thorsten Behrens + (cherry picked from commit ad4b72a0eacf6bb6887236ea3a3807b1264de822) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165721 + +2024-04-04 Oliver Specht [1d53871ac5cbb222c53a5aa17050a1c68126e4b8] + + tdf#63259 cycle case on sentences + + Cycle case will be applied to the sentence if the cursor is at + a sentence end. Writer now also keeps the word/sentence selection + after case change. + + Change-Id: I9dd561775ac612689526bcb118533ba81b5722be + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165018 + Tested-by: Jenkins + Tested-by: Gabor Kelemen + Reviewed-by: Thorsten Behrens + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165800 + +2024-04-04 Oliver Specht [f97dcfaee43f5b8c2eba4c7c3c2d0b786af38bc1] + + tdf#63259 Cycle case should work on end of words + + Now words are selected if the cursor is positioned at the end of + the word. SENTENCE_CASE does not force sentence selection anymore. + + Change-Id: I672352b2c18bb695004fd4eb0f20ae5fd7a0ac53 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164546 + Tested-by: Jenkins + Reviewed-by: Thorsten Behrens + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165799 + +2024-04-04 Caolán McNamara [b772466960bbdf4785ff071dea05e834df732f52] + + ofz#67563 infinite loop + + Change-Id: I1654d23fd8768a77d32fc3150a9d8554afa2e91f + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165220 + Tested-by: Jenkins + Reviewed-by: Caolán McNamara + (cherry picked from commit b866019e6ee82ce19dacd653861f8d2b701d2a8e) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165715 + Reviewed-by: Michael Stahl + +2024-04-04 Xisco Fauli [ae8ee986617832ae7ffd853279d6b898386a51dd] + + mariadb connector: upgrade to release 3.3.8 + + Change-Id: I21cf511a2b6c040d4a64ca720606af9312130045 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165284 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli + (cherry picked from commit e201b8916decefe4e5ad62718d33eb1ec1de4306) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165244 + Reviewed-by: Michael Stahl + +2024-04-04 Caolán McNamara [b2a2b4b3093aaba9dd44819f7b8b3ac12f262a19] + + crash on deref null parent on attempting to find label + + ImplFindDlgCtrlWindow always calls ImplGetChildWindow with first arg + + which does + + pParent = ImplGetTopParentOfTabHierarchy( pParent ); + vcl::Window* pWindow = ImplGetSubChildWindow( pParent, n, nIndex ); + + ImplGetSubChildWindow always derefs its first arg and + ImplGetTopParentOfTabHierarchy only returns null if its input was null + so ImplFindDlgCtrlWindow shouldn't be called with null + + program/libmergedlo.so(_ZNK3vcl6Window13ImplGetWindowEv+0x4)[0x7513e2a40e54] + program/libmergedlo.so(+0x33ba57c)[0x7513e29ba57c] + program/libmergedlo.so(+0x33ba97c)[0x7513e29ba97c] + program/libmergedlo.so(+0x33baf64)[0x7513e29baf64] + program/libmergedlo.so(+0x3378d47)[0x7513e2978d47] + program/libmergedlo.so(_ZNK3vcl6Window30GetAccessibleRelationLabeledByEv+0x19c)[0x7513e297866c] + program/libmergedlo.so(_ZN3vcl6Window18DumpAsPropertyTreeERN5tools10JsonWriterE+0x241)[0x7513e2a4b301] + program/libmergedlo.so(_ZN6Dialog18DumpAsPropertyTreeERN5tools10JsonWriterE+0x2e)[0x7513e29b217e] + program/libmergedlo.so(_ZN3vcl6Window18DumpAsPropertyTreeERN5tools10JsonWriterE+0x182)[0x7513e2a4b242] + program/libmergedlo.so(_ZN3vcl3lok9dumpStateERN3rtl13OStringBufferE+0xc0)[0x7513e2d6ee80] + + Change-Id: I732550bd67c3af38627849a7d96d8ee6140008b0 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165314 + Tested-by: Jenkins + Reviewed-by: Caolán McNamara + (cherry picked from commit 23b72488140e7e2031e0071718d55d2b9e1c2bef) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165321 + Reviewed-by: Michael Stahl + +2024-04-04 Juan José González [2870d816415081cd4f5e87d1f924a47519afdc4f] + + Update git submodules + + * Update helpcontent2 from branch 'libreoffice-24-2' + to 91db109b1642a1e8337dde38d76c492882a13de8 + - tdf#160467 Remove z-index in prism code block + + Right now code renders on top of header section. + Remove z-index to fix it. + + Change-Id: Ic0cf226275eae1656107de27907a94af256d5555 + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165768 + Tested-by: Jenkins + Tested-by: Adolfo Jayme Barrientos + Reviewed-by: Adolfo Jayme Barrientos + (cherry picked from commit c89178e82abacbb240e571fcbd9bd0f76b40642d) + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165718 + +2024-04-04 Miklos Vajna [20de432fa4e6f59476e17c4ced216825f6bbeb80] + + tdf#158801 sw floattable: fix crash with headers and interactive editing + + Regression from commit ce2fc5eb29b4e252993b549dee002fa8948c8386 + (tdf#158341 sw floattable: fix layout loop when fly is below the body + frame, 2023-11-29), open the bugdoc, add an empty paragraph at the + start, Writer layout crashes. The immediate problem is that + SwTabFrame::MakeAll() assumes that in case HasFollowFlowLine() is true, + then GetFollow()->GetFirstNonHeadlineRow() is always non-nullptr, + similar to the situation in commit + 223d2fac61e061478721a7a4a89b1362f5037d8f (sw floattable: fix crash by + trying harder to split tables, 2023-11-22). + + The deeper problem is that the bugdoc has a repeated table header row, + the fly frame temporarily gets shifted down, so nominally the header + doesn't fit anymore, and this leads to a modification of the doc model, + which creates inconsistency: the model now says we have no header rows + but the layout still contains table row frames where the header bit is + true. This is problematic in theory, but in practice caused no problem + so far. + + Fix the problem by disabling this mechanism for floating tables: trying + to have a table header that doesn't fit the table is asking for trouble + anyway, and this way at least we have a layout that is consistent with + the model, which also avoids the crash, now that nobody violates the + "HasFollowFlowLine -> follow's FirstNonHeadlineRow != nullptr" + invariant. + + Also extend the layout dump, so it's easier to see when the master's + flag and the follow's row list gets out of sync. + + Change-Id: I52b51f6d86ab4e0bab560f892e9cceb183aecd5f + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164136 + Reviewed-by: Miklos Vajna + Tested-by: Jenkins + (cherry picked from commit 186de7178c6065e1de13fd216b46ac9b716e44c5) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164119 + Reviewed-by: Xisco Fauli + +2024-04-03 Caolán McNamara [666e4e6fc9202577b91addb9054c7b1160a2b7b7] + + ofz: negative column offset + + Change-Id: Ieeb06e5c5d28f1c457db369a732bc37a7d5f2be8 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165418 + Tested-by: Jenkins + Reviewed-by: Michael Stahl + +2024-04-03 Mike Kaganski [b4abb5ee77c6894cd9a9ef3d5f66e868b591d02c] + + tdf#160478: fix Basic LIKE operator + + 1. The regex must match the whole input. Thus, the ^ and $ metacharacters + must be replaced with \A and \z, which only match beginning and end of + input, not any line start / end. + 2. The * and ? metacharacters of LIKE must match newline character; thus, + search flags must include UREGEX_DOTALL. To avoid changing TextSearch + implementation, I use icu::RegexMatcher directly. + + The direct use of icu::RegexMatcher also allowed to simplify the code by + calling icu::RegexMatcher::matches method. This may perform better than + general-purpose utl::TextSearch::SearchForward. + + Change-Id: I75776498b36f236da294462362ed5b36ed8cdf68 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165700 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski + Signed-off-by: Xisco Fauli + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165704 + +2024-04-03 Patrick Luby [27279b82c4e98271db9e999200c70ee8cba11c38] + + tdf#159790 eliminate deadlock on main thread + + A separate thread may have already acquired m_aMutex and that + thread will then try to acquire the solar mutex. However, when + the main thread calls this method, the main thread has already + acquired the solar mutex. + + So, drop the desktop mutex before calling out. + + Change-Id: Ic87063266ac5101b866df9f24067a403e1417745 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165682 + Reviewed-by: Patrick Luby + Tested-by: Jenkins + Reviewed-by: Noel Grandin + (cherry picked from commit 89e23bb599104d3bde30878148e15cf4deb1593f) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165629 + Reviewed-by: Adolfo Jayme Barrientos + +2024-04-02 Caolán McNamara [3ec777c07ec25e537e5f84095c520100d706370f] + + add notify for script use + + Change-Id: I84af197cec7755f6803a578e1e21c03966ad5f3e + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165411 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli + +2024-04-02 Regina Henschel [9ae95bbdfe6494fb87a6e368de8ea3070c5241fb] + + tdf#160421 flip lights too for flipped extruded shapes + + If an extruded custom shape is mirrored, the lights in the scene are + also mirrored. This should not happen. MS Office keeps the light + direction in relation to the camera direction for binary files and pptx + files with legacy camera. We should do the same, especially since the UI + does not allow the user to set the light directions at arbitrary angles. + Otherwise the shape receives only ambient light. + + Change-Id: I091d78c581b3d247f8b0680cd57654e3df330cdd + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165562 + Tested-by: Jenkins + Reviewed-by: Regina Henschel + (cherry picked from commit 9761d4239de6398d4f6ecf08356f2ce18e502a04) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165614 + Reviewed-by: Xisco Fauli + +2024-04-02 Taichi Haradaguchi <20001722@ymail.ne.jp> [223be8d2103e3dd133054e4c7aa5b1148abe36a0] + + lcms2: upgrade to 2.16 + + * backport 0001-Added-missing-export.patch to fix the Windows build. + * drop c++17.patch.1, which fixed uptream. + + Change-Id: Ib658ba3067c35ca5cd1ccb7b3f0f2f3bc9f82a43 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165350 + Tested-by: Jenkins + Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> + (cherry picked from commit c2db961ee69c4fe6a7f7162f2adf712651b6ffcc) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165611 + Reviewed-by: Xisco Fauli + +2024-04-02 Xisco Fauli [26b1dadc3f254cef8c7b9e12e8c7c58f8ee9118a] + + postgresql: upgrade to release 13.14 + + Change-Id: Ia9607fd9c8dad9d5936e867ad76b18a476f1057f + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165278 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli + (cherry picked from commit e311a6a09d753fb566f248d653434f10a4645e63) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165237 + Reviewed-by: Michael Stahl + +2024-04-02 Caolán McNamara [29f24d4bffed3d6d992274adffab375390fbc1a1] + + Related: tdf#157480 use SSL_CERT_FILE on macOS too + + for SSL use by pyuno emailmerge + + another alternative mechanism that could work is to generate one + with something like: "security find-certificate -a -p > cert.pem" + ref: https: //hynek.me/articles/apple-openssl-verification-surprises/ + + Change-Id: I8bff2ca5bbbb4f2c2333a67e0281dd4fa0b06405 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165625 + Reviewed-by: Patrick Luby + Tested-by: Caolán McNamara + Reviewed-by: Caolán McNamara + +2024-04-02 Patrick Luby [4241a641a433511ae9c3e1795de445a25eab14d8] + + tdf#160444 check device's owner window is a nullptr + + Since commit 563f7077f1dbce31ff95ee8d2e8d17b629693db1, the + device's owner window gets deleted before this object is + deleted. + + Change-Id: I15dc8db60e5520c2f0e73a9a117f25af15845caf + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165637 + Tested-by: Jenkins + Reviewed-by: Patrick Luby + (cherry picked from commit d034036a049d6dcc8dc62a8e44c1e4befcaa25b0) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165623 + Reviewed-by: Adolfo Jayme Barrientos + +2024-04-02 Xisco Fauli [46906884b5eefb551d7d3d00420709475962df92] + + libtommath: upgrade to 1.3.0 + + Change-Id: Ica9e2520c7c70a21721f7f389fd3cd8138bf550c + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165609 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli + (cherry picked from commit 45f7af713b303643f524ac9ae7fd41ac56d96bf2) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165624 + Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> + +2024-04-01 Caolán McNamara [ae495a198fc63ab65ae054c59e2b69bffba4c1a2] + + ofz#67708 ignore oversized colspans + + that can't fit in SCCOL + + ignore negative colspan and rowspans too + + Change-Id: I79a010bcd7d9d84de70f6dac2e09614d6d448227 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165479 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli + +2024-04-01 Caolán McNamara [85603be2365e80d3f8a363e99ac6196eb24d61c6] + + Resolves: tdf#160368 crash on save after deleting sheet + + to reproduce the underlying problem: data, calc, recalculate hard: + + which asserts that cell I367 is dirty during parallel calc + + checking the dependencies for a parallel calc is supposed to find what + cells it depends on and either: ensure they are not dirty or detect its + not possible to do the parallel calc + + checking starts in J9 where:: + + J9: =SUM(H$8:H9)-SUM(I9:I$9) + J10 =SUM(H$8:H10)-SUM(I10:I$9) + + for the first sum it detects that the input range is H9:H367 and checks + that for dirty results, but for the second sum it detects a range of + just I9 and the dirty I367 is not detected and the problem arises on + calculation + + The code to detect the range is: + + // The first row that will be referenced through the doubleref. + SCROW nFirstRefRow = bIsRef1RowRel ? aAbs.aStart.Row() + mnStartOffset : aAbs.aStart.Row(); + // The last row that will be referenced through the doubleref. + SCROW nLastRefRow = bIsRef2RowRel ? aAbs.aEnd.Row() + mnEndOffset : aAbs.aEnd.Row(); + + where for the I9 case has nFirstRefRow true and nLastRefRow false so we + just get a range of I9:I9 instead of I9:I367. + + Trying to create a doc from scratch to reproduce this case proves + tricky, so trim down the original document to the sheet and subset + of columns that can trigger it. + + Change-Id: I44bfd1f6d3a3ee13db9024c5b2efa2588cc30521 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165478 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli + +2024-04-01 Xisco Fauli [c3020e41cf95e974f0ff12c78ca841eb8cc4e9f3] + + curl: upgrade to release 8.7.1 + + Change-Id: I0064b4cf6baf1ccd951c95945539961fe72c2a28 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165455 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli + (cherry picked from commit 2c1a7cb13629177f824ed35138907aef10714e89) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165489 + Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> + +2024-03-31 Samuel Mehrbrodt [7a61065bb8ccf33fb1918218bf2febd30e786bf4] + + tdf#159918 a11y check: Don't warn about tabs in ToC + + Change-Id: Ifde41deb66c8dcb72842e18e539609ff351be832 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164972 + Tested-by: Jenkins + Reviewed-by: Samuel Mehrbrodt + (cherry picked from commit c6075e716200e9c6bae1b10be2cf10013958e83a) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165424 + Reviewed-by: Caolán McNamara + +2024-03-31 Caolán McNamara [161bcfa1c8687570acde0947b0350c70e7021d85] + + Resolves: tdf#157258 "Always autocorrect to" deletes the word + + instead of replacing it, affecting extensions like Grammalecte, + LanguageTool, Antidote + + this began in: + + commit afa35742a4633db31b6d6c72cf45741506e9edfb + Date: Sat Dec 11 21:09:39 2021 +0000 + + prefer more css::awt::XPopupMenu api + + but the underlying trap was introduced in: + + commit 6c84dc18062ec6aad71fd65a409373c274402991 + Date: Wed Oct 6 10:16:39 2010 +0100 + + initial commit for vba blob ( not including container_control stuff ) + + which added creating a VCLXPopupMenu in VCLXMenu::getPopupMenu if there + was a vcl PopupMenu in the vcl Menu which hadn't been created by calling + VCLXMenu::setPopupMenu. That didn't take into account that VCLXPopupMenu + (like VCLXMenu) takes ownership of the PopupMenu and will destroy it in + its own dtor, so the sub menu Popup get destroyed if the VCLXPopupMenu + is shorter lived than the VCLXMenu wrapping the parent Menu. + + Change-Id: Ic28c27670d846ee9d2ff77d834e43fc157924eb6 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165484 + Tested-by: Jenkins + Reviewed-by: Adolfo Jayme Barrientos + +2024-03-31 Caolán McNamara [57428bfc71762687594c3c0fa62cdff391dda3f9] + + Resolves: tdf#157587 IconView scoll range not updated + + IconView::SetUpdateMode(true) doesn't update the scroll + range for any changes that might have taken place while + updates were suspended. + + The similar SvImpLBox::UpdateAll() for "normal" lists + does this update, so do the equivalent update here too. + + Noticeable since: + + commit 666925f2ab06e690c41c470713dc83f2d752bfb7 + Date: Sat Jun 3 15:23:15 2023 +0100 + + perf: use freeze/thaw around block insert of multiple icons + + Change-Id: I318fc4509c6906161eabf3b312f311cb97ac063a + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165485 + Tested-by: Jenkins + Reviewed-by: Adolfo Jayme Barrientos + +2024-03-31 Caolán McNamara [f409cc5d0c671d0428f709523238f551f9a5fd69] + + Resolves: tdf#154072 no effect when clicking some dropdown buttons + + when toolbar overflows. + + A problem since: + + commit b534ee2e972711af2dbaadf2190813054adda902 + Date: Tue Nov 22 11:33:23 2022 +0000 + + Resolves: tdf#152155 use gtk's knowledge of relative widget positions + + rather than effectively emulate it poorly + + Change-Id: I18c08e43e9c0b642f2a30b5114d6f0a53f18a331 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165610 + Tested-by: Jenkins + Reviewed-by: Adolfo Jayme Barrientos + +2024-03-30 Caolán McNamara [b206e3b90a4ba34604a5e45faf3f05639ee89752] + + Resolves: tdf#159498 Items in Template Manager dropdown should be left-aligned + + Change-Id: I72d32793814b28b7452be701f0732dbd9dbbcb37 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165483 + Tested-by: Jenkins + Reviewed-by: Adolfo Jayme Barrientos + +2024-03-30 Caolán McNamara [be5f10efe541062cf7ea64ff97d649e92f3f50ca] + + Resolves: tdf#160028 Type to select currency in dropdown does not work for gtk + + LibreOffice embeds RTL/LTR direction markers in currency strings, which + defeats the default gtk search mechanism, so switch in our one instead. + + Change-Id: Ia118f8c8e27103c21955683f8a2fd3c17c2b2098 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165477 + Tested-by: Jenkins + Reviewed-by: Adolfo Jayme Barrientos + +2024-03-30 Caolán McNamara [667e2c452998006db1ce009da9fec7f609018145] + + Resolves: tdf#160159 update spellchecking area colors when style changes + + so for the case of using "automatic" for the document background the + spelling checking textbox background area updates to match + + Change-Id: I8723afb946176596b0a5fa43aa3bb3c036dee12c + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165476 + Tested-by: Jenkins + Reviewed-by: Adolfo Jayme Barrientos + +2024-03-30 Xisco Fauli [9e3b18de8d948782438ae9cc095b3aa07767b1ff] + + nss: upgrade to release 3.99 + + Change-Id: I77ccc45854b2d0aecc288f471d94c81ad9089f85 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165273 + Tested-by: Xisco Fauli + Reviewed-by: Xisco Fauli + (cherry picked from commit c6d791e3d2577498affec491876a0afa441be002) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165245 + Tested-by: Jenkins + Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> + +2024-03-30 Xisco Fauli [efa4104726496c10c1a23b24cbf26edf3f25a6c5] + + libgpg-error: upgrade to release 1.48 + + Change-Id: I3920d10657a91b56f484a5a61017d2e2ba3291b0 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165457 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli + (cherry picked from commit 65bee6317eafd4d0e449c779c160e9b3017b57ce) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165471 + Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> + +2024-03-29 Xisco Fauli [904501114d8b6754ab65bb11c08c145f02fab8fe] + + libassuan: upgrade to 2.5.7 + + Change-Id: I6114c7a77395f14e83d2315ac6f9b6829ddb1c6a + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165456 + Tested-by: Xisco Fauli + Reviewed-by: Xisco Fauli + (cherry picked from commit 0343d7153e77ba79a59bc5f6c51159af9010813e) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165472 + Tested-by: Jenkins + Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> + +2024-03-28 Caolán McNamara [13148df8d8dfa4bac33a574deea7bd0065ca5140] + + null deref of mpSidebarController + + follow the pattern used in the rest of this and skip the branch + that depends on mpSidebarController existing + + git show -w + + Change-Id: I739754b2af7ad09fa80c36693d8adbf173ece2e2 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165426 + Tested-by: Jenkins + Reviewed-by: Caolán McNamara + (cherry picked from commit d4d923f9db926d8b0b6eb3bb7b62f5a7a520c00d) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165470 + Reviewed-by: Xisco Fauli + +2024-03-28 Mike Kaganski [8e0bb9dadb9ef77f693cf6d334843cfb9b4701a3] + + tdf#103068: make sure to update and use current MySQL connection type + + 1. Don't set selection in OGeneralPageWizard::getEmbeddedDBName. The + method should only provide a name of an embedded database - either in + the passed set, or the default one; the activation of controls and + related actions will be done in the calling implInitControls. This + makes sure, that ODbTypeWizDialogSetup::m_sURL doesn't get rewritten + unnecessarily, keeping the current preference intact. + + 2. In ODbTypeWizDialogSetup::activateDatabasePath, do not use the + hardcoded MySQL URL from the control, if the current value of m_sURL + is already a MySQL one. This allows to keep the selected kind intact. + + 3. In OMySQLIntroPageSetup::implInitControls, do not assume that the + existing selection means that there's nothing to do. The page keeps + the selection, even when the wizard's active path was changed; and + so, the wizard's idea which page to show next may differ from the + selection. Just make sure to update the setup mode. + + Change-Id: Iad98d54a615dccc58b2852a1c0d8aefad6b0b898 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164987 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski + (cherry picked from commit 1e66905c840dbee0a67e444fca80bdacfcb6e6b2) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165000 + Reviewed-by: Adolfo Jayme Barrientos + +2024-03-28 Caolán McNamara [d3ed3836cbec932f8a381fcb2c85787fb0f8b766] + + Resolves: tdf#160392 preview's measurement are black on dark bg in dark mode + + Change-Id: I538750ef7d20ecc17a60ce47989eeaf0390a0103 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165414 + Tested-by: Jenkins + Reviewed-by: Adolfo Jayme Barrientos + +2024-03-27 Mike Kaganski [832fb1ab9abf94f4074e0cc20d846c1536931cf3] + + tdf#160390: make sure to forward the iterator + + Change-Id: I302cc4303f083a1024175ce4ba00ce8021c6d4c9 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165390 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski + Signed-off-by: Xisco Fauli + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165404 + +2024-03-27 Patrick Luby [15c04b923b7b86b3f63b9ea62b0005ea101f9217] + + Update git submodules + + * Update helpcontent2 from branch 'libreoffice-24-2' + to 02a11cfe8fb608fdf77b4ce5a57a5dd23784f8ec + - tdf#159326 macOS uses Command+Option+F while other plafforms use Ctrl+H + + Change-Id: Iee37805afba1aa712a45c213d1f9eeae4d01d923 + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162452 + Tested-by: Jenkins + Reviewed-by: Patrick Luby + (cherry picked from commit 509ec415db94a821da1c8f7bacf9e372d320e49d) + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162534 + Reviewed-by: Patrick Luby + Reviewed-by: Olivier Hallot + +2024-03-27 Noel Grandin [e3d3581b327fd201d77f63a71fad52a52b53842f] + + tdf#159805 Printing line style dotted lines (horizontal) turns into dashes. + + I could not find a good place to distinguish between the dragging + visualisation (where we could safely use approximation), and the + non-dragging case, so just revert. + + Revert + commit 9f4ccc63346b26d8d774b22124da0842ef18e0bc + Author: Noel Grandin + Date: Wed Sep 13 14:27:02 2023 +0200 + tdf#156995 speed up dragging complex group objects + + Change-Id: I2ba52f07ea7299643c0f145459038e368a17dea8 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165332 + Tested-by: Jenkins + Reviewed-by: Noel Grandin + (cherry picked from commit fc5d84681d5d898b56171a9622294ecb23623bfd) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165320 + Reviewed-by: Xisco Fauli + +2024-03-27 Xisco Fauli [ea3d61886a2b420b985bed162c28b94698283c76] + + tdf#160373: Iterate over all parents to check whether it's a clipPath content + + Change-Id: I383ec264e4c88ebcee2ae6a839b762bba8abfc12 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165347 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli + (cherry picked from commit 261985b6936ede212852e806c4b140ea634a5af3) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165317 + Reviewed-by: Stéphane Guillou + +2024-03-26 Justin Luth [09b3dd1cb0c1741cf3560fc9faf2aec696d5c9a2] + + tdf#129905 tdf#160365 sw: don't always draw text boundary on frames + + This fixes a 7.6 regression caused by + commit 79811c27f34d3e752de1bc3959605c5d58ac2365 + tdf#129905 Create toggle for Section boundaries + + This fixes the toggle for View - Text boundaries, + so now images can have their thin gray border removed. + + This also fixes the toggle for View - Table boundaries. + + Change-Id: Idb75debf173d64b14a6864c61b4524e46898975f + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165297 + Reviewed-by: Justin Luth + Tested-by: Jenkins + Reviewed-by: Rafael Lima + Reviewed-by: Miklos Vajna + (cherry picked from commit 47af9e64a573684eb42faa097e327e31777a2b58) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165311 + +2024-03-26 Julien Nabet [81fdf964bec1c4555db2f08c300c7b3f09130fbc] + + Related tdf#160351: the field name can be shorter than two symbols + + Change-Id: Ieb6b78b3f9802e66de642a9e708b11c55c0d9a11 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165285 + Tested-by: Jenkins + Reviewed-by: Julien Nabet + (cherry picked from commit 02609da5ee8188cb00fc0b97052d2cc8d2576900) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165249 + Reviewed-by: Xisco Fauli + +2024-03-26 Mike Kaganski [0a86d2e2dd898aa1d455c0bbde91dd9a8b011daf] + + tdf#160351: the field name can be shorter than two symbols + + Change-Id: Id834ae2919661752b921510f766c9e9ff7fc16fd + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165282 + Reviewed-by: Julien Nabet + Tested-by: Jenkins + Reviewed-by: Mike Kaganski + (cherry picked from commit 4a14bad7232ecf23d23c1997dc20922d0b4892cb) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165246 + Reviewed-by: Xisco Fauli + +2024-03-26 Xisco Fauli [999d14c0e4dc8063d7afd5a6c216b1842ef5a171] + + openldap: upgrade to release 2.6.7 + + Change-Id: I7716a41114442ba7a57d81192b01cbeaaeca08b6 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165280 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli + (cherry picked from commit 9a0b37a5337faee5634cc9fce4955da204b95bf4) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165247 + Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> + +2024-03-25 Miklos Vajna [2e31c7cd2976be3d43b0845e50d0bb4ca7e50179] + + Relatted: tdf#160139 RTF paste: don't turn off headers/footers + + Regression from commit d918beda2ab42668014b0dd42996b6ccc97e8c3a + (tdf#158814 DOCX import: fix unwanted header with type="first" & no + titlePg, 2024-02-05), pasting shape text into the body text of Writer + turned off the header, which was not intentional. + + The original use-case was DOCX/RTF import, and the paste case was just + not considered. + + Fix the problem by leaving the paste alone: we already omit a number of + actions in this case (e.g. not overwrite styles), don't turn off + headers, either. + + Note that the original problem is wider: we would probably need to track + what page styles are created and only touch those, or something similar. + + Change-Id: If08fa7956e98766d5807332c5c0baa25b46afe38 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165191 + Reviewed-by: Miklos Vajna + Tested-by: Jenkins + (cherry picked from commit c900850742efd4e1fb7c79c13c1b9a17fcd4981d) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165185 + Reviewed-by: Xisco Fauli + +2024-03-25 Caolán McNamara [26706d907e043f10d92aa81433d712f07c6ee16b] + + ofz#67540 negative offset + + Change-Id: I498985962feb7d77c1a71af7002a85aa02aa3e65 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165188 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli + +2024-03-23 Xisco Fauli [319966df55dda429202f12eba678eeb461eef5ed] + + libxml2: upgrade to release 2.12.6 + + Change-Id: I7372b276f74bc760c99580ffc509fde1031cb3a6 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165049 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli + (cherry picked from commit 832b98cedda2cd1631651f9397a871fb50d9cb1f) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165183 + Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> + +2024-03-23 Xisco Fauli [78f0fa2f7e408cbc75ffe99f61f6a556bed2a032] + + libpng: upgrade to 1.6.43 + + Change-Id: Ia1ddc21dc521cf97b75a64d806417cbfe5dec623 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165050 + Tested-by: Xisco Fauli + Reviewed-by: Xisco Fauli + (cherry picked from commit f29222eaf385891620d4868827b27e734752018e) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165182 + Tested-by: Jenkins + Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> + +2024-03-22 Michael Stahl [36757ace36a5bcb0acd9ba5c4ee6cceed3c14b67] + + sw: fix ~SwIndexReg assert in testTdf149498 + + The problem is that a SwNavigationMgr thingy has a cursor in one of the + table cells, and the text node is moved to the undo nodes array in + SwUndoTableCpyTable::AddBoxBefore() and deleted in + SwUndoTableCpyTable::UndoImpl(). + + SwUndoTableCpyTable needs to move the cursors out of the way because + SwUndoDelete doesn't do it. + + Change-Id: I75e271c84a6624ffb0df151b171acb1e1f743928 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164807 + Tested-by: Jenkins + Reviewed-by: Michael Stahl + (cherry picked from commit 873af30a36504751c6923d4235abd4de040e0001) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164820 + Reviewed-by: Xisco Fauli + +2024-03-22 Caolán McNamara [f2feac3d2ab19fdbcec85194579a88b3995ae335] + + null deref in initial sc html fuzzing + + Change-Id: I368db8fec4cfd9409197d17f2892153aca2ba502 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165019 + Tested-by: Jenkins + Reviewed-by: Caolán McNamara + (cherry picked from commit 85c40af4e9d4c679f66e7f7e004c018dd28994ee) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165005 + Reviewed-by: Xisco Fauli + +2024-03-22 Patrick Luby [be132c413c49175a27a55cfe3e42c748b5660a92] tdf#152524 fix crash by changing the macOS fork() and exec() process - This fix backports commit 839cf255e2670fdf8e974af38432aacf63be4e90 - and commit 3c6c5ef5d1c4f555b465bf56cf9d99e4d67224cc. + This fix backports commit 839cf255e2670fdf8e974af38432aacf63be4e90 + and commit 3c6c5ef5d1c4f555b465bf56cf9d99e4d67224cc. + + Change-Id: I5dd397a1ab624a048c8892c870b991b381a94f9c + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165174 + Reviewed-by: Patrick Luby + Reviewed-by: Caolán McNamara + Tested-by: Jenkins + Reviewed-by: Christian Lohmaier + +2024-03-22 Christian Lohmaier [1fa5ed234afbfcb9d27e1658388250319835b15d] + + Update git submodules + + * Update translations from branch 'libreoffice-24-2' + to d3abafd51ff477a324a0c0342fb1e02c78c93f6c + - update translations for 24.2.2 rc2 + + and force-fix errors using pocheck + + Change-Id: I75a9cc68d9f9d7712b58dfc521173323c3775208 + +2024-03-22 Michael Stahl [0398d6900835ff29767f7ac39bc7fb57917d8ccd] + + sw: GetSelectableFromAny() broken for SwXTextRange + + The function unnecessarily uses an intermediate XUnoTunnel variable to + handle SwXTextRange, but the implementation of XUnoTunnel was removed. + + (regression from commit 635448a996714a81cb15b41ac4bb0c73cabfb74f) + + Change-Id: I90dd7acbd259e8ca562a534ad0bc9a5b85356553 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165162 + Reviewed-by: Noel Grandin + Tested-by: Jenkins + Reviewed-by: Michael Stahl + (cherry picked from commit 8f2de92b3da99346f7282e623d47912f40f92b7b) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165170 + Reviewed-by: Christian Lohmaier + +2024-03-22 Taichi Haradaguchi <20001722@ymail.ne.jp> [b4622a2a5bc4472658b203025524ac5e11fc3c2e] + + Expat: upgrade to release 2.6.2 + + Fixes CVE-2024-28757 + + Change-Id: Id85044fa9d8eda922425e580e9d6979f6563e98a + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165129 + Tested-by: Taichi Haradaguchi <20001722@ymail.ne.jp> + Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> + (cherry picked from commit 370ca73a45b291e172918b4c8fcbc37ccaa434cf) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165175 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli + +2024-03-22 Michael Stahl [6c155583c83eb19c3520084c90df51eca725da00] + + tdf#157241 sw: assert when importing ToX in table in rhbz589883-2.docx + + ndtbl.cxx:1417: SwNodes::TextToTable(): Assertion `!rNode.IsSectionNode()' failed. + + (regression from commit 62cb3b8b8d6106c6aeb073b12d84973a107182ef) + + Change-Id: Iec12282573cb914d1924f4da4a28e26e01b866df + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165164 + Tested-by: Michael Stahl + Reviewed-by: Michael Stahl + (cherry picked from commit df6fdb0041f8bfd251a4b03030b8bc47f0614c36) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165173 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli + +2024-03-22 Mike Kaganski [581b9c2752d6cedd5622c57cd38b1f8a36d53169] + + tdf#160306: make sure that SvNumberFormatter agrees with ROUND output + + After commit 9eb9083ff2fdaeb96399a0830a4394de4e29ef64 (Use Dragonbox + to implement doubleTo*String*, 2022-02-18), the rounding that is used + in SvNumberFormatter became strictly more correct; however, it now + differed from what ROUND spreadsheet function returned, because the + latter uses rtl_math_round, which calls rtl::math::approxFloor. + + To make the visual number representation consistent, this change uses + rtl_math_round in SvNumberformat::ImpGetNumberOutput. + + Change-Id: I05b0bed7d3a6c73584a77adbae2835c95be249fa + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165142 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski + (cherry picked from commit 805dd6bee49164d9a77de4ea9e0d53b416daca7a) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165124 + Reviewed-by: Xisco Fauli + +2024-03-22 Jean-Pierre Ledure [c826976b634596e476515a678ce415d9d16830c6] + + ScriptForge (session).RunApplication() crash fix tdf#160222 + + Use + com.sun.star.system.SystemShellExecuteFlags.DEFAULTS + i.o. + com.sun.star.system.SystemShellExecuteFlags.URIS_ONLY + + as argument of + com.sun.star.system.SystemShellExecute.execute() + + Change-Id: I3919777cf9442387aec6ed694a2883519e4a7910 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165105 + Reviewed-by: Jean-Pierre Ledure + Tested-by: Jenkins + (cherry picked from commit ec2d0fceedec8aa775940d496eb86c40f958a10c) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165127 + +2024-03-22 Michael Stahl [27526cde7fb6cdcf23f23349cdc7ebdaa3d9bcfa] + + configmgr: fix parse error if subelements of used + + The unused but valid child elements of such as may be + used by exentions. This fails with: + + warn:configmgr:15104:10916:configmgr/source/components.cxx:660: error reading "file:///instdir/program/../share/uno_packages/cache/uno_packages/....xcs" com.sun.star.uno.RuntimeException message: "bad member in ....xcs at configmgr/source/xcsparser.cxx:289" + + Because ending the first such element sets bIsParsingInfo_ to false. + + This fix just concatenates all the characters in all the children, + should work well enough for extensions. + + (regression from commit db3078bd8c8e3ce3a99fc3987bb6e93b609990c1) + + Change-Id: I17a3fb7014cd34c1d546701036550085365432a4 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165143 + Tested-by: Jenkins + Reviewed-by: Michael Stahl + (cherry picked from commit 8350404ec1c02df8b4f6b4f48947ddbff53d91e5) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165126 + Reviewed-by: Stephan Bergmann + +2024-03-22 Oliver Specht [9b8f6f881185831ec77f1c692c8726fd1459a746] + + Revert "tdf#159730 add compatibility option in RTF import" + + This reverts commit 3b04e74503ec6d07dc4befdb756e6abdc3de4e58. + + Reason for revert: The compatibility option is the wrong approach. This results in wrong line calculation as seen in tdf#159730#c6. + The problem that really needs to be fixed is the 9pt attribute of the hidden line breaks in the first paragraph that are used to calculate the height of the first paragraph. + Only the 1pt font attribute of the remaining visible space should define the line height. - Change-Id: I5dd397a1ab624a048c8892c870b991b381a94f9c - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165178 - Reviewed-by: Caolán McNamara + Change-Id: I6e0a1a499adaf2df9f68afbcfd6afcd6677e8f76 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165006 + Tested-by: Jenkins + Reviewed-by: Michael Stahl + (cherry picked from commit 44e4ada23dfc8655ec7ddccfd027f02d22684d60) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165118 + Reviewed-by: Xisco Fauli + +2024-03-22 Mike Kaganski [41586f2f417a2d55d6baa07d3885d2d117a16d1d] + + tdf#160278: restore cursor bounds properly + + The passed string length is not a correct measure of how many steps + should the selection expand in the resulting text: the cursor goes + over glyphs, not over UTF-16 code units. Thus, it's easier to store + the position prior to insertion, and restore it from the indexes. + + Change-Id: I1d592ff30199007ba3a99d7e1a6d2db2da35f1cb + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165056 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski + Signed-off-by: Xisco Fauli + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165145 + +2024-03-21 Patrick Luby [227e51b6b4b3e6664c6ed9cc72c85ff3c3d03ab9] + + tdf#93352 Fix horizontal swiping and scrolling when using an RTL UI + + Starting with commit bfa21ce5fa08f2c634ccb6162914be55aef9f3c2, + horizontal swiping in Calc moved in the wrong direction scrollbars + were drawn mirrored. + + So, revert parts of commit bfa21ce5fa08f2c634ccb6162914be55aef9f3c2 + so that we are using Calc's previous "negative scrollbar range" + implementation for RTL UIs, but only for horizontal scrollbars since + vertical scrollbars are the same in LTR and RTL UIs. + + Also, always disable RTL for scrollbars. Enabling RTL causes the + following bugs when clicking or dragging the mouse in scrollbars in + Calc's RTL UI: + - Click or drag events get mirrored so you must click or drag in + unexpected locations to move the scrollbar thumb in the desired + direction + - Repeatedly dragging the scrollbar thumb leftward can only move + no highter than the R, S, or T columns + + Note: even though RTL is always disabled for Calc scrollbars, the arrows + must still be swapped in vcl's ScrollBar class. + + Change-Id: I85aac94ffaf7df2eeb251a3ff150cc0363b5d770 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164959 + Reviewed-by: Stéphane Guillou + Tested-by: Jenkins Reviewed-by: Patrick Luby - Tested-by: Christian Lohmaier - Reviewed-by: Christian Lohmaier + (cherry picked from commit ac1024765d203496bc7d28cb3ed3a6d2215c53ad) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165116 + Reviewed-by: Adolfo Jayme Barrientos -2024-03-22 Christian Lohmaier [3cf709baeb1e502cfe546b3216e848d3b47a3ede] +2024-03-21 Noel Grandin [e4519e38d3598c3e26f2585bbc2553bc7ff5db4c] - Update git submodules + tdf#158556 speedup docx load - * Update translations from branch 'libreoffice-24-2-2' - to 4eb6115303693019b82e06cda258ff1b8b5bfc71 - - update translations for 24.2.2 rc2 - - and force-fix errors using pocheck - - Change-Id: I75a9cc68d9f9d7712b58dfc521173323c3775208 - (cherry picked from commit d3abafd51ff477a324a0c0342fb1e02c78c93f6c) - -2024-03-22 Michael Stahl [3146edaf76f4533f5872dc687a76a55c691ce4e9] + Avoid O(n^2) loop in SwXFrame::setPropertyValue, we even have an index + to search for this stuff + + Reduces load time from 325s to 172s + + Change-Id: I6c6c03206ef81be1d7d7702a4313acd23d75442d + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165044 + Tested-by: Jenkins + Reviewed-by: Noel Grandin + (cherry picked from commit 241e2d68664e0e53cf02fe9986462c4a9ecd8d42) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165110 + Reviewed-by: Xisco Fauli - tdf#157241 sw: assert when importing ToX in table in rhbz589883-2.docx +2024-03-21 Noel Grandin [d83d68f120ad3ccfc036e25cf9d5b04fb36f7c8b] + + tdf#158773 reduce cost of TextProperties::Notify - ndtbl.cxx:1417: SwNodes::TextToTable(): Assertion `!rNode.IsSectionNode()' failed. + Shaves 30% off the load time here, by re-arranging the logic so we do th + expensive dynamic_cast less often - (regression from commit 62cb3b8b8d6106c6aeb073b12d84973a107182ef) + Change-Id: If7a1605994e620dbdb61010506c624cc738359a4 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164466 + Tested-by: Jenkins + Reviewed-by: Noel Grandin + (cherry picked from commit 3b784236d7c3bf386deeeadcf79d9e9b289bf991) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165112 + Reviewed-by: Xisco Fauli + +2024-03-21 Michael Stahl [fc26519a0b11e470ace3651a0cad8ea82d3b03d4] + + python3: upgrade to release 3.8.19 - Change-Id: Iec12282573cb914d1924f4da4a28e26e01b866df - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165164 - Tested-by: Michael Stahl - Reviewed-by: Michael Stahl - (cherry picked from commit df6fdb0041f8bfd251a4b03030b8bc47f0614c36) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165173 + Fixes CVE-2023-6597 and also CVE-2024-0450 + + Change-Id: Iebca2608e16a966356736201c63f1be5185430d4 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165053 Tested-by: Jenkins + Reviewed-by: Michael Stahl + (cherry picked from commit 0633e4b4205334dd65ec64d7f3e306ee125e31be) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165008 Reviewed-by: Xisco Fauli - Signed-off-by: Xisco Fauli - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165193 - Tested-by: Christian Lohmaier - Reviewed-by: Christian Lohmaier -2024-03-22 Michael Stahl [8506ffb5cef6e18c01350874231e66080efbaf5e] +2024-03-20 Caolán McNamara [58f6f62552595acf1da4777ccd1ff11e5b1a55d0] + + leaks in initial corpus for sc html import fuzzing + + Change-Id: Ia7a9d6b283dcf127dccf734fb45cf8ac3dde5478 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164889 + Tested-by: Jenkins + Reviewed-by: Michael Stahl + +2024-03-19 Armin Le Grand (allotropia) [a48ee46a085abfa04779ece38c08dddb5bf017ea] + + tdf#158783 Correct compares of SwTOXMark Items + + That item was never 'pooled', so operator== was not really + ever used. It just compared the 'type', so pretty many + instances were assumed to be equal, what is wrong. + We discussed to implement it (there is quite some content), + but we came to the point that it's only safe to say + instances are equal when same instance -> fallback to ptr + compare. + This came into play since I identified/changed many (160?) + places where SfxPoolItems were ptr-compared when doing that + paradigm change in Items. This leads to the two methods + 'areSfxPoolItemPtrsEqual' which just makes ptr compare and + 'SfxPoolItem::areSame' which also will use op==. For the + initial adaption I chose the wrong function adapting + places where SwTOXMark were involved. + + Change-Id: I7df029ad4542719681b1455de17ed5990d248395 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161963 + Reviewed-by: Michael Stahl + Tested-by: Armin Le Grand + (cherry picked from commit d22a86089edfcadbef5231525a2947b954f4784e) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164996 + Tested-by: Jenkins + Reviewed-by: Adolfo Jayme Barrientos + +2024-03-19 Stéphane Guillou [65ab35f21f18dc6048eeeb218a786ccf0a9584bc] + + Update git submodules + + * Update helpcontent2 from branch 'libreoffice-24-2' + to 9bed20d260f9c0dfd5a43f62bba288aff829da85 + - related tdf#160057: replace ref to obsolete Footer Header page + + Change-Id: Ie6df598c42149ecc527a1a2eef35a7aba469c216 + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164387 + Tested-by: Jenkins + Reviewed-by: Adolfo Jayme Barrientos + (cherry picked from commit 04dcd1b951689689f9449408fd6f512a9c87aa0d) + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164991 + +2024-03-19 Michael Stahl [df5bb0c4343b4a090de3343c7d454a93099989c0] tdf#157241 sw: fix crash on RTF paste or insert of nested tables @@ -83,33 +2004,137 @@ (cherry picked from commit 62cb3b8b8d6106c6aeb073b12d84973a107182ef) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164813 Reviewed-by: Caolán McNamara - (cherry picked from commit df5bb0c4343b4a090de3343c7d454a93099989c0) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165003 - Reviewed-by: Xisco Fauli - Tested-by: Christian Lohmaier - Reviewed-by: Christian Lohmaier -2024-03-22 Michael Stahl [9b4c239b51244dfb28a6822e2046c72e8f937227] +2024-03-19 Michael Stahl [84b5de0e000372e46d7243873859fc03e114bde8] - sw: GetSelectableFromAny() broken for SwXTextRange + ucb: webdav-curl: always set CURLOPT_NOBODY for HEAD - The function unnecessarily uses an intermediate XUnoTunnel variable to - handle SwXTextRange, but the implementation of XUnoTunnel was removed. + Otherwise there will be timeout that depends on when the server will + close the connection, which varies by server but can be several minutes; + getting a potential error document from the server for this one request + when logging is enabled is less important. - (regression from commit 635448a996714a81cb15b41ac4bb0c73cabfb74f) + Change-Id: I505b014b148ba009c400d37d826c9edb8c3a6da2 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164838 + Tested-by: Jenkins + Reviewed-by: Michael Stahl + (cherry picked from commit c8400f5acc36d2cf0c007260bdc94534a53bba90) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164822 + Reviewed-by: Caolán McNamara + +2024-03-19 Michael Stahl [372ee9e4c24e628ce73ec0c6a6fee91abd2e6b94] + + ucb: webdav-curl: only set CURLOPT_NOBODY for HEAD - Change-Id: I90dd7acbd259e8ca562a534ad0bc9a5b85356553 - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165162 - Reviewed-by: Noel Grandin + Some testing with Apache httpd+mod_dav reveals that it usually sends a + body with a 401 status, which causes the CURLE_WEIRD_SERVER_REPLY error + code from curl. + + So we should either ignore this error in case there's a HTTP status too, + or stop using CURLOPT_NOBODY. + + The latter seems to have no downside, except for HEAD requests, where + strangely the server keeps the connection open and curl waits for 5 + seconds for no body to arrive, blocking the UI, so continue to use + CURLOPT_NOBODY for HEAD. + + The other methods don't seem to block. + + It turns out that the SAL_LOG-dependent setting of g_NoBody turned HEAD + into GET anyway if logging is enabled, so explicitly set the method. + + Change-Id: Ibe2eef8e7a827d4e356ba37c4b56bee0be3b9c13 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164569 Tested-by: Jenkins Reviewed-by: Michael Stahl - (cherry picked from commit 8f2de92b3da99346f7282e623d47912f40f92b7b) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165180 + (cherry picked from commit e0259d4c0951c4dd77c74d08b9d905728d4c8dfd) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164507 + Reviewed-by: Caolán McNamara + +2024-03-19 Michael Stahl [7e5891a327889be3a052594efd7862ed5be13606] + + ucb: webdav-curl: don't set CURLOPT_NOBODY for OPTIONS + + The problem is that if the server does send a body, then curl returns + CURLE_WEIRD_SERVER_REPLY error code, which is translated to + DAVException; this looks unnecessary now because write_callback + will just return if there's no stream to write to anyway. + + Change-Id: Iddaee9778ac7bbd538b64584f822f65ab0e395c2 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164550 + Tested-by: Jenkins + Reviewed-by: Michael Stahl + (cherry picked from commit 980ca3953084560806cd980d2ec16951d9e30c2b) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164501 + Reviewed-by: Caolán McNamara + +2024-03-19 Caolán McNamara [b25a88677ce2d713b0f454ef2d4cf5a202a005a7] + + calc html filter ScDocShell* deref for document properties + + ScDocShell is optional in other parts of this filter + + Change-Id: If219cfa6ef737a9695b85bf6db5d45e9750a7ed9 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164974 + Tested-by: Jenkins + Reviewed-by: Caolán McNamara + (cherry picked from commit 1dc579ae9cd7fcf504016ef510a9484173c9392d) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164994 Reviewed-by: Xisco Fauli - Tested-by: Christian Lohmaier - Reviewed-by: Christian Lohmaier -2024-03-22 Mike Kaganski [df684c9d68fb130295c5a667fa6fcb6de3068fd2] +2024-03-19 Caolán McNamara [c131e83e5d45e25b6f82fb01d4e2170ab8622908] + + cid#1594402 Unchecked dynamic_cast + + Change-Id: I01218f7c457b23539ca911ab1bf4a910198285b3 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164954 + Tested-by: Jenkins + Reviewed-by: Caolán McNamara + Signed-off-by: Xisco Fauli + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164977 + +2024-03-19 Tibor Nagy [4c1b617863f46ec4ef2553df8bde46b98b4a48bf] + + tdf#159094 sc: fix failure when exporting media files to PDF + + Change-Id: I948190b31f45cf05ba24d1fbc4a84dfe91eb3876 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164557 + Tested-by: Jenkins + Reviewed-by: Nagy Tibor + Signed-off-by: Xisco Fauli + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164976 + +2024-03-19 Christian Lohmaier [6485c324e911bebb4c8f8a50d0f51a6b156bd01d] + + update credits + + Change-Id: I72d86d1a7dcadf3e015b5f9a3eb98d56fb9a49c5 + (cherry picked from commit a1fbfbabbf65bbddd99e1e660ea5435abc8d9ca9) + +2024-03-19 Skyler Grey [edacf30340058707e02c3348a255435f4f4481b3] + + exported SVGs: Stop bullets skipping animation + + Previously, we used the incorrect format for bullet point IDs, leading + to them not being noticed by animation code, leading to them being + skipped during animation. + + This meant that if you exported an SVG of an impress presentation, and + you had a bullet list animating to appear later, you would see the + bullets without the text from the start. + + Change-Id: Ibce764c0843778dd09b108fb251ce606255afb90 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164661 + Tested-by: Jenkins CollaboraOffice + Reviewed-by: Gökay ŞATIR + (cherry picked from commit 5ee89034692eb21f9a71c9a36cc205b09f24e856) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164871 + Tested-by: Jenkins + (cherry picked from commit c3327640208fb5117ca88878afd7e716981372c7) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164887 + Reviewed-by: Skyler Grey + +2024-03-18 Mike Kaganski [c2979145899db161e2659d69ad2f478123254694] tdf#160149: save and restore the whole set of tab's conditional formats @@ -122,98 +2147,193 @@ Tested-by: Jenkins Reviewed-by: Mike Kaganski (cherry picked from commit c492de66a077f3a2a960209b0b8b278b3901f361) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164888 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164886 Reviewed-by: Xisco Fauli + +2024-03-18 Christian Lohmaier [98843372144d1b3e517b0e9876c8b79268dcb9b3] + + Update git submodules + + * Update translations from branch 'libreoffice-24-2' + to 14ff5e76dedc18f32051747acc540dd2856c770e + - bump copyright year for sl translation + + Change-Id: I7211f904b9b3822e5c45bc4c3c7a3b0512853185 + + - update translations for 24-2 and force-fix errors using pocheck + + Change-Id: I964bed068dfa7396512c1742c73c674caa96669c + +2024-03-18 Julien Nabet [697dbd9a708e73f6e83a76baf0541dcaf1489a68] + + tdf#160180: bump copyright year to 2024 + + Change-Id: I466b8f86e8a53a238ed2ce2d2b053dc519ff8eed + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164794 Reviewed-by: Adolfo Jayme Barrientos - Tested-by: Christian Lohmaier + Tested-by: Julien Nabet + (cherry picked from commit 94da114cd86e3bcd8b6235566ca5f926f09d4b18) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164748 + Tested-by: Jenkins Reviewed-by: Christian Lohmaier -2024-03-22 Taichi Haradaguchi <20001722@ymail.ne.jp> [314286d59b3d24e700def6f817224770573579ad] +2024-03-18 Julien Nabet [b97348107831c5699e679dc8d2c36d626122ae0c] - Expat: upgrade to release 2.6.2 + tdf#160225, related tdf#92768: hide axis title not taken into account when... - Fixes CVE-2024-28757 + duplicating sheet or when saving a file and reopen it. - Change-Id: Id85044fa9d8eda922425e580e9d6979f6563e98a - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165129 - Tested-by: Taichi Haradaguchi <20001722@ymail.ne.jp> - Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> - (cherry picked from commit 370ca73a45b291e172918b4c8fcbc37ccaa434cf) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165176 - Reviewed-by: Xisco Fauli - Tested-by: Christian Lohmaier - Reviewed-by: Christian Lohmaier + When creating a title for an axis, "createTitle" is called. + Before tdf#92768 "support hiding title objects", when unchecking "axis title" in sidebar, + the title was removed (via "removeTitle") + But since tdf#92768, "hideTitle" is called instead. + + The pb is "Visible" attribute wasn't registered in StaticTitleWrapperPropertyArray. + So when duplicating sheet after having created a title and hidden it, + when duplicating sheet, the new sheet had the title visible. + In the same way if, after having created a title and hidden it, + you save the file and reopen it, the title is displayed. + + Change-Id: I980505ec02906e673dd60a60e4d9837928bf8876 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164938 + Reviewed-by: Noel Grandin + Tested-by: Jenkins + Reviewed-by: Julien Nabet + (cherry picked from commit 6aac5b2c96b42e8204a10def52df1b85ebebeb46) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164878 -2024-03-22 Oliver Specht [67e35d0159d30829c7672f3d4d33de2e85cd6626] +2024-03-17 Rafael Lima [765242935149dca7cb41e10462708739b71f2810] - Revert "tdf#159730 add compatibility option in RTF import" + tdf#160122 Increase height of the Solver Options dialog - This reverts commit 3b04e74503ec6d07dc4befdb756e6abdc3de4e58. + Currently the Solver Options dialog (Tools - Solver and then click the Options button) has a height of 6 rows, which is good for the Linear and Swarm non-linear solvers, since they have 4-5 options. - Reason for revert: The compatibility option is the wrong approach. This results in wrong line calculation as seen in tdf#159730#c6. - The problem that really needs to be fixed is the 9pt attribute of the hidden line breaks in the first paragraph that are used to calculate the height of the first paragraph. - Only the 1pt font attribute of the remaining visible space should define the line height. + However, the SCO and DEPS engines have 12 and 19 options, respectively, so it is very unconfortable to view and scroll through these options with such a small dialog. - Change-Id: I6e0a1a499adaf2df9f68afbcfd6afcd6677e8f76 - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165006 + This patch raises the height of the dialog to 12, so that scrolling is minimized, making it more confortable to navigate through the solver options. + + Change-Id: I51c1c6880613818dd91c6bb8494775c863e8b406 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164749 Tested-by: Jenkins - Reviewed-by: Michael Stahl - (cherry picked from commit 44e4ada23dfc8655ec7ddccfd027f02d22684d60) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165119 + Reviewed-by: Heiko Tietze + Reviewed-by: Adolfo Jayme Barrientos + (cherry picked from commit 58f565cb2dcf6e7b7eb2eb269776993516a29bf0) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164875 + +2024-03-17 Patrick Luby [0696fa0845feaab96a90dfdce96131998961b50a] + + tdf#160036 Enable SKSL when using Skia/Raster + + Starting with the upgrade of Skia from m111 to m116, SKSL is disabled + by default for Skia/Raster so define SK_RASTER_PIPELINE_OPS_ALL to + enable it. + + Change-Id: Ibd10efa0540f1e87123c341b529c8e3931e1a8fb + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164933 + Tested-by: Jenkins + Reviewed-by: Patrick Luby + (cherry picked from commit 22dbaf45fb378107ad7daa0d7894939d6e0c7ee3) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164876 + Reviewed-by: Adolfo Jayme Barrientos + +2024-03-15 Miklos Vajna [08d144dfafca6077d988a10ca005c8666470b94c] + + sw: fix fieldmark crash in MSWordExportBase::OutputTextNode() + + Crashreport signature: + + program/libmswordlo.so + MSWordExportBase::OutputTextNode(SwTextNode&) + sw/source/filter/ww8/wrtw8nds.cxx:2547 + program/libmswordlo.so + MSWordExportBase::WriteText() + sw/source/filter/ww8/wrtww8.cxx:2936 + program/libmswordlo.so + DocxExport::WriteMainText() + /opt/rh/devtoolset-10/root/usr/include/c++/10/bits/stl_tree.h:1261 + program/libmswordlo.so + DocxExport::ExportDocument_Impl() + sw/source/filter/ww8/docxexport.cxx:541 + + Keep the assert, because ideally it should not happen that we have no + fieldmark at CH_TXT_ATR_FIELDEND, but crashing in non-debug builds goes + a bit too far. + + Change-Id: I428f46821771802a0ea2beaaf86463487e561aff + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164844 + Tested-by: Jenkins + Reviewed-by: Miklos Vajna + (cherry picked from commit 27a41c7e4ec0e82e2ed0ca2577574f5295a16057) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164825 Reviewed-by: Xisco Fauli - Tested-by: Christian Lohmaier - Reviewed-by: Christian Lohmaier -2024-03-22 Michael Stahl [7eeaa3f188f8a3c24d2c7a5fe90d97de4708bfc8] +2024-03-15 Mike Kaganski [3bb21c55b1badb35e286c0960cb982b61249dd30] - python3: upgrade to release 3.8.19 + Re-enable Alt key handling + + Regression after commit 772da0f1aa6891a0b31d45d99a5978c65ed24e34 + (tdf#156443, tdf#159079, tdf#158112: support Windows Alt codes + >=256, 2024-01-10). In master, it was later fixed in commit + a2dd71feb75d93adf0f0daac899e7476f961ec34 (tdf#54169: implement + auto-accelerator feature on Windows, 2024-02-10). + + This is a selective fix for 24.2. + + Change-Id: Ic203b78de561ca9afaf589e242ff95c0481ffc15 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164824 + Tested-by: Jenkins + Reviewed-by: Michael Weghorn + +2024-03-13 Hossein [2ad14fdade187579b2abf3c76a08780b77614662] + + tdf#160162 Fix hyperlink update in Draw - Fixes CVE-2023-6597 and also CVE-2024-0450 + Changing the links to keep them up-to-date was previously done only when + the name "Slide" was used for the pages, just like Impress, as Draw and + Impress share code. Now, the term "Page" is used instead of "Slide" + since 942d1d2ea59bf4605f2c464a6b29c967fa9f8de8 in Draw. This change, + fixes the above issue by also using the correct string consntant. - Change-Id: Iebca2608e16a966356736201c63f1be5185430d4 - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165053 + The patch is tested for Draw and Impress to make sure both are working + correctly now. + + Change-Id: I55b4f56bd499d05f87f475d4c6cb3423247bf8d7 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164716 Tested-by: Jenkins - Reviewed-by: Michael Stahl - (cherry picked from commit 0633e4b4205334dd65ec64d7f3e306ee125e31be) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165111 - Reviewed-by: Xisco Fauli - Tested-by: Christian Lohmaier - Reviewed-by: Christian Lohmaier + Reviewed-by: Stéphane Guillou + Reviewed-by: Hossein + Signed-off-by: Xisco Fauli + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164760 + Reviewed-by: Adolfo Jayme Barrientos -2024-03-22 Armin Le Grand (allotropia) [c5b878a7c55f7e6f8d3a66fa9728c8fca5d0e13b] +2024-03-13 Justin Luth [7a561440acd01949e9b7b4efef9062ce05ce5d64] - tdf#158783 Correct compares of SwTOXMark Items + allow build with python 3.12.0: initialize new tp_watched - That item was never 'pooled', so operator== was not really - ever used. It just compared the 'type', so pretty many - instances were assumed to be equal, what is wrong. - We discussed to implement it (there is quite some content), - but we came to the point that it's only safe to say - instances are equal when same instance -> fallback to ptr - compare. - This came into play since I identified/changed many (160?) - places where SfxPoolItems were ptr-compared when doing that - paradigm change in Items. This leads to the two methods - 'areSfxPoolItemPtrsEqual' which just makes ptr compare and - 'SfxPoolItem::areSame' which also will use op==. For the - initial adaption I chose the wrong function adapting - places where SwTOXMark were involved. + This fixes the build failure after I updated Ubuntu 24.04 (alpha), + which upgraded python 3.11.7 to python 3.12.0, causing the error: - Change-Id: I7df029ad4542719681b1455de17ed5990d248395 - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161963 - Reviewed-by: Michael Stahl - Tested-by: Armin Le Grand - (cherry picked from commit d22a86089edfcadbef5231525a2947b954f4784e) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164996 + libreoffice/pyuno/source/module/pyuno_callable.cxx:249:1: + error: missing initializer for member ‘_typeobject::tp_watched’ + [-Werror=missing-field-initializers] + ... + + I gleaned this information from a July 2023 commit for + https://github.com/xbmc/xbmc/issues/23503 + + tp_watched was added in upstream commit python/cpython@82ccbf6 + https://github.com/python/cpython/commit/82ccbf69a842db25d8117f1c41b47aa5b4ed96ab + + This change first appeared in Python v3.12.0a1 + + Change-Id: If82ff1eb47d66d2669d90d6e00e0feff3c55b5ca + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164775 Tested-by: Jenkins - Reviewed-by: Adolfo Jayme Barrientos - (cherry picked from commit a48ee46a085abfa04779ece38c08dddb5bf017ea) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165004 - Reviewed-by: Xisco Fauli - Tested-by: Christian Lohmaier - Reviewed-by: Christian Lohmaier + Reviewed-by: Justin Luth + Reviewed-by: Stephan Bergmann + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164785 -2024-03-22 Michael Weghorn [17fe161389df04b16a4c61bf089a3ce113ea22e7] +2024-03-13 Michael Weghorn [7989a04cee3b614d493a5acbd1ff0363596efc00] tdf#159915 qt: Force Qt::HighDpiScaleFactorRoundingPolicy::Round @@ -252,13 +2372,8 @@ (cherry picked from commit 07688e864c913e005dcae366cf10702404a73d80) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164744 Reviewed-by: Adolfo Jayme Barrientos - (cherry picked from commit 7989a04cee3b614d493a5acbd1ff0363596efc00) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164816 - Reviewed-by: Xisco Fauli - Tested-by: Christian Lohmaier - Reviewed-by: Christian Lohmaier -2024-03-20 Mike Kaganski [a541f33b30e4c95ef69128e60ba4cc86ba8d585e] +2024-03-13 Mike Kaganski [53b8a4c687df83a91e584fb6afa6729d9669f454] tdf#160117: check bAnyCondition @@ -276,32 +2391,10 @@ Tested-by: Jenkins Reviewed-by: Mike Kaganski (cherry picked from commit 61580fcbd10bad2e0aab663d4c8fe43c1e01f92c) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164736 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164735 Reviewed-by: Xisco Fauli - Reviewed-by: Michael Weghorn - Tested-by: Adolfo Jayme Barrientos - Reviewed-by: Adolfo Jayme Barrientos - -2024-03-19 Julien Nabet [40f6e9a45edae06556e1d1a26237dc2ab12bc0ca] - - tdf#159373: band-aid for crash in: ScTable::HasAttrib - - band-aid because as Eike indicated in https://bugs.documentfoundation.org/show_bug.cgi?id=159373#c8 - "Question remains why this PostPaint() is called at all for an invalid range.." - - Change-Id: Ie44378119202addd8ddb46f0be4b0124be9fd48b - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164354 - Tested-by: Jenkins - Reviewed-by: Julien Nabet - Signed-off-by: Xisco Fauli - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164644 - (cherry picked from commit 2bb8b6df61d3fd27d38a9ac1724295b885e5e919) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164627 - Reviewed-by: Michael Weghorn - Tested-by: Adolfo Jayme Barrientos - Reviewed-by: Adolfo Jayme Barrientos -2024-03-19 Michael Stahl [6a9feb0bba19bcff87e0e1a16fcd03ad3a390dfa] +2024-03-13 Michael Stahl [2fa450193fbf6013144bdf436076aa4971c3a12e] tdf#157241 sw: layout: inconsistent conditions in lcl_RecalcSplitLine() @@ -322,13 +2415,142 @@ (cherry picked from commit 7d3b439de357c8e97c0a73f6f63e67ec980e432d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164733 Reviewed-by: Xisco Fauli - (cherry picked from commit 3ea0c848b490f5b6f5f3860a9036ce25754a1f17) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164740 - Reviewed-by: Adolfo Jayme Barrientos - Reviewed-by: Michael Weghorn - Tested-by: Xisco Fauli -2024-03-19 Julien Nabet [545179ee711381b641dd6a34e46722353f2b2488] +2024-03-13 Fridrich Strba [01d39c444a62d69dedcaa1d9f6b2bed47a5dadee] + + Fix build with autoconf 2.72 + + This commit http://git.savannah.gnu.org/gitweb/ + ?p=autoconf.git;a=commitdiff; + h=cf09f48841b66fe76f606dd6018bb3a93242a7c9 + changed the internal cache variable name and its content + + The effects show later in message like + /tmp/ccyB6wS6.ltrans9.ltrans.o: in function `comphelper::DocPasswordHelper::decryptGpgSession(com::sun::star::uno::Sequence > const&)': + /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/docpasswordhelper.cxx:705:(.text+0x4fb7): undefined reference to `GpgME::Data::seek(long, int)' + /usr/bin/ld.bfd: /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/docpasswordhelper.cxx:716:(.text+0x5402): undefined reference to `GpgME::Data::seek(long, int)' + /usr/bin/ld.bfd: /tmp/ccyB6wS6.ltrans13.ltrans.o: in function `comphelper::OStorageHelper::CreateGpgPackageEncryptionData()': + /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/storagehelper.cxx:507:(.text+0x64e3): undefined reference to `GpgME::Data::seek(long, int)' + /usr/bin/ld.bfd: /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/storagehelper.cxx:520:(.text+0x6583): undefined reference to `GpgME::Data::seek(long, int)' + collect2: error: ld returned 1 exit status + + Where the type 'off_t' at the time of inclusion of the header and + at the time of compilation of the library differ. + + Change-Id: Ie0486dbc869e84f5fb2688473334cfe464abd570 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164704 + Tested-by: Jenkins + Reviewed-by: Stephan Bergmann + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164715 + +2024-03-12 Xisco Fauli [b6a2a101797543be6cf6e1ef1c72390451d137d9] + + tdf#142133: partially revert 576611895e5 + + if 'Internet Link' character style doens't exist then + apply the hyperlink style + This also reverts 023285158bde72dcd73b965ce205cf8550e7a5e2 + "tdf#128504 save DOCX as ODT: don't color not highlighted hyperlinks" + which is no longer necessary + + Change-Id: Id100af5fddb10745af9d56c0ba75cb2366ecbe55 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164576 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli + (cherry picked from commit 03ca7031f3bf4c2a3e841b18c8f9e00004046098) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164509 + Reviewed-by: Stéphane Guillou + +2024-03-12 Stéphane Guillou [bc0df26cafd8cbe1c9e7bf385f176d999af0ab7f] + + Update git submodules + + * Update helpcontent2 from branch 'libreoffice-24-2' + to d25d6d02f06138274426492ef11f35409966e829 + - tdf#156156: add Animation sidebar deck help button's HID + + Change-Id: Ia0500321f9216aff4f249f9088694f6cd1fa1a80 + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161217 + Tested-by: Jenkins + Reviewed-by: Adolfo Jayme Barrientos + +2024-03-12 Stéphane Guillou [db96cd124436109c228ee013d17dcd24cabcd9a2] + + Update git submodules + + * Update helpcontent2 from branch 'libreoffice-24-2' + to fd026c4fce76473afbb92d7a5098d0e9af152517 + - tdf#156156: add Manage Changes sidebar decks help button's HID + + Change-Id: Ibeab9e20ea4f8684b8d0a8a535b30c3122e4df70 + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161165 + Tested-by: Jenkins + Reviewed-by: Adolfo Jayme Barrientos + +2024-03-11 Justin Luth [703cc8d674d81573a1e6191a12cec4012cca22f7] + + tdf#159927 sd headerfooterdlg: detect existing date/time language + + Sometimes it was hard to change an existing foreign language + to your own language for Impress' header/footer fields. + + The function was only checking the first master slide for the + date/time language. If it didn't have one, then the default locale + was selected. + + However, although all pages share the same date/time language, + it is not necessary for all (or even the first) master slide + to have a date/time field. So check through all the master slides + until one with a date/time is found. + + Obviously if none have one defined things still work OK, + because that is effectively how it was working beforehand. + + I don't have much hope for a successful unit test. + I'll try to develop it as a follow-up to this patch. + + Change-Id: Ida44957013978720ad12fadc9b4ebc88bc10ea40 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164045 + Tested-by: Jenkins + Reviewed-by: Justin Luth + (cherry picked from commit 62323124f54885c6de4ac4fa38052d380309a5a1) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164506 + Reviewed-by: Miklos Vajna + +2024-03-11 Julien Nabet [2ffba480017a44522cb6c8946d75f6ad5f1c9026] + + tdf#159373: band-aid for crash in: ScTable::HasAttrib + + band-aid because as Eike indicated in https://bugs.documentfoundation.org/show_bug.cgi?id=159373#c8 + "Question remains why this PostPaint() is called at all for an invalid range.." + + Change-Id: Ie44378119202addd8ddb46f0be4b0124be9fd48b + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164354 + Tested-by: Jenkins + Reviewed-by: Julien Nabet + Signed-off-by: Xisco Fauli + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164644 + +2024-03-11 Mike Kaganski [6bc66a08b8fef03772979f67a34df4e9cc3ff33d] + + Enable CVE tests on Windows by default + + Since commit c16969b9bc73fdd77e763299d6aea7b614e203e2 + (tdf#84553 Detect and warn of Windows Antivirus., 2020-02-08), + it is checked that antivirus is disabled in $SRC_ROOT and $BUILDDIR. + + This reverts commit a6b2c618cb02168bba950652367f494a1021cf53 + (disable cve tests by default on windows, 2014-10-01). + + Change-Id: I3816e97cfb4559f7647167ed291b75468b03dc4d + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164612 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski + (cherry picked from commit 4c65ab909598766e5859a5f0ce4bf55b23c9551b) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164621 + Reviewed-by: Xisco Fauli + +2024-03-11 Julien Nabet [1ecbee191411bf340173fd64d56888e245a54e08] tdf#160095: fix crash when using ALT+RETURN twice @@ -339,13 +2561,24 @@ (cherry picked from commit 82e6236cd6ba6f45aa913a3be606e6b00f81fe07) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164614 Reviewed-by: Xisco Fauli - (cherry picked from commit ad5bd68124f5cd63c1ac9f2b92b25d6a02ecfb97) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164624 - Reviewed-by: Michael Stahl - Reviewed-by: Michael Weghorn - Tested-by: Xisco Fauli -2024-03-19 Sarper Akdemir [aa371949ae72e84379ae811e469d9ec34bab6ec5] +2024-03-10 Andras Timar [059d3c514d28b075793be75fd9c1739ec1aeea99] + + Update git submodules + + * Update helpcontent2 from branch 'libreoffice-24-2' + to 87aff2af247c6f6bfc2a656fcc7c9c5c4d83a077 + - fix Helpex warnings: 'No string specified!' + + Change-Id: I70ad73b6859cd989e6046c3bd5a76c54c27f416d + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164631 + Tested-by: Jenkins + Reviewed-by: Olivier Hallot + (cherry picked from commit 99537726eca951a450182d7672458afeb2b65e66) + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164615 + Reviewed-by: Adolfo Jayme Barrientos + +2024-03-10 Sarper Akdemir [ebd9530b458cbc37a7b2b1da077435f2b33081ba] tdf#159931: pptx export: export each used slide layout for a master @@ -363,14 +2596,8 @@ Reviewed-by: Sarper Akdemir (cherry picked from commit a35831becee3781daf8628c48944660d31d84d8b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164495 - (cherry picked from commit ebd9530b458cbc37a7b2b1da077435f2b33081ba) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164629 - Reviewed-by: Michael Stahl - Reviewed-by: Michael Weghorn - Tested-by: Xisco Fauli - Reviewed-by: Xisco Fauli -2024-03-19 Stephan Bergmann [c84f5898db8083fdc631a8871d0fef5eb4dd4197] +2024-03-08 Stephan Bergmann [0b5a9065263bf8f82db497a1f2c51bf531a341fe] Blind fix for Linux 32-bit builds @@ -403,102 +2630,142 @@ Reviewed-by: Stephan Bergmann (cherry picked from commit 0f5dfaebd61b9cabbe9762865563c2296ebb0112) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164504 - (cherry picked from commit 25c2c7aeeeebd2ce1d3067e2b8f95d0729f462a5) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164611 - Reviewed-by: Xisco Fauli - Reviewed-by: Michael Weghorn - Reviewed-by: Adolfo Jayme Barrientos - -2024-03-19 Christian Lohmaier [958be2ba8986f94e866a457eff96fd7aee497752] - - update credits - - Change-Id: I72d86d1a7dcadf3e015b5f9a3eb98d56fb9a49c5 - (cherry picked from commit a1fbfbabbf65bbddd99e1e660ea5435abc8d9ca9) - (cherry picked from commit 6485c324e911bebb4c8f8a50d0f51a6b156bd01d) - -2024-03-18 Christian Lohmaier [24ab022c4d6a14acd55e2b54c90b4d512146e4dc] - - Update git submodules - - * Update translations from branch 'libreoffice-24-2-2' - to 7b1c0310be9eafb46f9f5750bb89c44bc211513f - - bump copyright year for sl translation - - Change-Id: I7211f904b9b3822e5c45bc4c3c7a3b0512853185 - (cherry picked from commit 14ff5e76dedc18f32051747acc540dd2856c770e) - - - update translations for 24-2 and force-fix errors using pocheck - - Change-Id: I964bed068dfa7396512c1742c73c674caa96669c - (cherry picked from commit 4d541d2bb86ca82b4fd161c6851bd4a2f965608a) - -2024-03-18 Julien Nabet [32db1b0cc61c9457411accf2e7832507c2836fdd] - - tdf#160180: bump copyright year to 2024 - - Change-Id: I466b8f86e8a53a238ed2ce2d2b053dc519ff8eed - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164794 - Reviewed-by: Adolfo Jayme Barrientos - Tested-by: Julien Nabet - (cherry picked from commit 94da114cd86e3bcd8b6235566ca5f926f09d4b18) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164748 - Tested-by: Jenkins - Reviewed-by: Christian Lohmaier - (cherry picked from commit 52084113d5c284e2eca364191a96d38490580b49) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164883 - Tested-by: Christian Lohmaier - -2024-03-17 Patrick Luby [0ffcf99d3e05cf6405d3aa5fbea281a6b5632c9a] - - tdf#160036 Enable SKSL when using Skia/Raster - - Starting with the upgrade of Skia from m111 to m116, SKSL is disabled - by default for Skia/Raster so define SK_RASTER_PIPELINE_OPS_ALL to - enable it. - - Change-Id: Ibd10efa0540f1e87123c341b529c8e3931e1a8fb - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164933 - Tested-by: Jenkins - Reviewed-by: Patrick Luby - (cherry picked from commit 22dbaf45fb378107ad7daa0d7894939d6e0c7ee3) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164877 - Reviewed-by: Adolfo Jayme Barrientos - Reviewed-by: Noel Grandin - Tested-by: Patrick Luby - -2024-03-15 Fridrich Strba [78629e74e1e046a9ae4945088e2f7afde6db88d6] - - Fix build with autoconf 2.72 - - This commit http://git.savannah.gnu.org/gitweb/ - ?p=autoconf.git;a=commitdiff; - h=cf09f48841b66fe76f606dd6018bb3a93242a7c9 - changed the internal cache variable name and its content - - The effects show later in message like - /tmp/ccyB6wS6.ltrans9.ltrans.o: in function `comphelper::DocPasswordHelper::decryptGpgSession(com::sun::star::uno::Sequence > const&)': - /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/docpasswordhelper.cxx:705:(.text+0x4fb7): undefined reference to `GpgME::Data::seek(long, int)' - /usr/bin/ld.bfd: /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/docpasswordhelper.cxx:716:(.text+0x5402): undefined reference to `GpgME::Data::seek(long, int)' - /usr/bin/ld.bfd: /tmp/ccyB6wS6.ltrans13.ltrans.o: in function `comphelper::OStorageHelper::CreateGpgPackageEncryptionData()': - /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/storagehelper.cxx:507:(.text+0x64e3): undefined reference to `GpgME::Data::seek(long, int)' - /usr/bin/ld.bfd: /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/storagehelper.cxx:520:(.text+0x6583): undefined reference to `GpgME::Data::seek(long, int)' - collect2: error: ld returned 1 exit status - - Where the type 'off_t' at the time of inclusion of the header and - at the time of compilation of the library differ. - - Change-Id: Ie0486dbc869e84f5fb2688473334cfe464abd570 - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164704 - Tested-by: Jenkins - Reviewed-by: Stephan Bergmann - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164715 - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164764 - Reviewed-by: Miklos Vajna - Reviewed-by: Michael Meeks - Tested-by: Stephan Bergmann -2024-03-09 Patrick Luby [c4d42d7ffca8c8e1bfc6d23d5ca3b7553be5e78e] +2024-03-08 Miklos Vajna [a85bd1bc9305af059d880ee422a656a3d9ce1b0b] + + Related: tdf#158986 sw floattable: fix unexpected page break with sections + + Regression from commit c303981cfd95ce1c3881366023d5495ae2edce97 + (tdf#156724 sw: layout: fix tables not splitting due to footnotes + differently, 2023-08-24), the floating table in the DOCX version of the + bugdoc went from page 1 to page 2. + + It seems what happens is that the first page has 2 section frames, and + we used to directly recalc the last lower of the first section frame, + which triggered a recalc of the second section frame, so the table moved + from page 2 to page 1 once the top of the second section frame was + reduced (so the table could fit on page 1). But this direct recalc was + removed because it caused problems for split tables and footnotes in + tdf#156724. + + Fix the problem by conditionally restoring the OptCalc() call in + SwLayAction::FormatLayout(): only do it for the last lower of section + frames, which is enough for the DOCX version of tdf#158986, but it keeps + the old tdf#156724 use-case working (the layout of that bugdoc doesn't + modify with this change). + + The RTF version of the bugdoc (which was the originally reported + problem) still needs more work, but that's hopefully not a layout + problem but an RTF import one. + + Change-Id: I1134ec3a27aec8ee871b535d81dedf9d27bd6bd5 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163805 + Reviewed-by: Miklos Vajna + Tested-by: Jenkins + (cherry picked from commit 397d72e582c725d162c7e0b819dc6c0bb62e42b0) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163768 + Reviewed-by: Michael Stahl + +2024-03-08 Michael Stahl [5a897e100370c93414479226515d4844b8c20bd3] + + vcl,accessibility: try to fix a crash while disposing SvxFontNameBox_Impl + + This happened in a 6.3 based branch, no idea how to reproduce it. + Clearly the SvxFontNameBox_Impl is being disposed and in its base class + Window::dispose() when a call to SvxFontNameBox_Impl::CreateAccessible() + happens, which seems very suspicious; try to prevent that. + + mergedlo.dll!ImplListBox::InsertEntry(long nPos, const rtl::OUString & rStr) Zeile 2225 + unter d:\lo\core\vcl\source\control\imp_listbox.cxx (2225) + mergedlo.dll!ComboBox::InsertEntry(const rtl::OUString & rStr, long nPos) Zeile 886 + unter d:\lo\core\vcl\source\control\combobox.cxx (886) + mergedlo.dll!FontNameBox::Fill(const FontList * pList) Zeile 447 + unter d:\lo\core\svtools\source\control\ctrlbox.cxx (447) + [Inlineframe] mergedlo.dll!SvxFontNameBox_Impl::Fill(const FontList * pList) Zeile 236 + unter d:\lo\core\svx\source\tbxctrls\tbcontrl.cxx (236) + mergedlo.dll!lcl_GetDocFontList(const FontList * * ppFontList, SvxFontNameBox_Impl * pBox) Zeile 1290 + unter d:\lo\core\svx\source\tbxctrls\tbcontrl.cxx (1290) + mergedlo.dll!SvxFontNameBox_Impl::FillList() Zeile 1331 + unter d:\lo\core\svx\source\tbxctrls\tbcontrl.cxx (1331) + mergedlo.dll!SvxFontNameBox_Impl::CreateAccessible() Zeile 3739 + unter d:\lo\core\svx\source\tbxctrls\tbcontrl.cxx (3739) + mergedlo.dll!vcl::Window::GetAccessible(bool bCreate) Zeile 129 + unter d:\lo\core\vcl\source\window\accessibility.cxx (129) + acclo.dll!VCLXAccessibleToolBox::getAccessibleChild(long i) Zeile 733 + unter d:\lo\core\accessibility\source\standard\vclxaccessibletoolbox.cxx (733) + acclo.dll!VCLXAccessibleToolBox::GetItemWindowAccessible(const VclWindowEvent & rVclWindowEvent) Zeile 784 + unter d:\lo\core\accessibility\source\standard\vclxaccessibletoolbox.cxx (784) + acclo.dll!VCLXAccessibleToolBox::GetChildAccessible(const VclWindowEvent & rVclWindowEvent) Zeile 795 + unter d:\lo\core\accessibility\source\standard\vclxaccessibletoolbox.cxx (795) + mergedlo.dll!VCLXAccessibleComponent::ProcessWindowChildEvent(const VclWindowEvent & rVclWindowEvent) Zeile 165 + unter d:\lo\core\toolkit\source\awt\vclxaccessiblecomponent.cxx (165) + acclo.dll!VCLXAccessibleToolBox::ProcessWindowChildEvent(const VclWindowEvent & rVclWindowEvent) Zeile 657 + unter d:\lo\core\accessibility\source\standard\vclxaccessibletoolbox.cxx (657) + mergedlo.dll!VCLXAccessibleComponent::WindowChildEventListener(VclWindowEvent & rEvent) Zeile 129 + unter d:\lo\core\toolkit\source\awt\vclxaccessiblecomponent.cxx (129) + mergedlo.dll!VCLXAccessibleComponent::LinkStubWindowChildEventListener(void * instance, VclWindowEvent & data) Zeile 118 + unter d:\lo\core\toolkit\source\awt\vclxaccessiblecomponent.cxx (118) + [Inlineframe] mergedlo.dll!Link::Call(VclWindowEvent &) Zeile 84 + unter d:\lo\core\include\tools\link.hxx (84) + mergedlo.dll!vcl::Window::CallEventListeners(VclEventId nEvent, void * pData) Zeile 280 + unter d:\lo\core\vcl\source\window\event.cxx (280) + mergedlo.dll!vcl::Window::ImplResetReallyVisible() Zeile 735 + unter d:\lo\core\vcl\source\window\stacking.cxx (735) + mergedlo.dll!vcl::Window::ImplResetReallyVisible() Zeile 747 + unter d:\lo\core\vcl\source\window\stacking.cxx (747) + mergedlo.dll!vcl::Window::Show(bool bVisible, ShowFlags nFlags) Zeile 2198 + unter d:\lo\core\vcl\source\window\window.cxx (2198) + mergedlo.dll!vcl::Window::Show(bool bVisible, ShowFlags nFlags) Zeile 2176 + unter d:\lo\core\vcl\source\window\window.cxx (2176) + [Inlineframe] mergedlo.dll!vcl::Window::Hide() Zeile 925 + unter d:\lo\core\include\vcl\window.hxx (925) + mergedlo.dll!vcl::Window::dispose() Zeile 402 + unter d:\lo\core\vcl\source\window\window.cxx (402) + mergedlo.dll!Edit::dispose() Zeile 258 + unter d:\lo\core\vcl\source\control\edit.cxx (258) + mergedlo.dll!ComboBox::dispose() Zeile 132 + unter d:\lo\core\vcl\source\control\combobox.cxx (132) + mergedlo.dll!SvxFontNameBox_Impl::dispose() Zeile 1322 + unter d:\lo\core\svx\source\tbxctrls\tbcontrl.cxx (1322) + [Inlineframe] mergedlo.dll!VclPtr::disposeAndClear() Zeile 206 + unter d:\lo\core\include\vcl\vclptr.hxx (206) + mergedlo.dll!SvxFontNameToolBoxControl::dispose() Zeile 3309 + unter d:\lo\core\svx\source\tbxctrls\tbcontrl.cxx (3309) + mergedlo.dll!framework::ToolBarManager::RemoveControllers() Zeile 651 + unter d:\lo\core\framework\source\uielement\toolbarmanager.cxx (651) + mergedlo.dll!framework::ToolBarManager::dispose() Zeile 468 + unter d:\lo\core\framework\source\uielement\toolbarmanager.cxx (468) + mergedlo.dll!framework::ToolBarWrapper::dispose() Zeile 105 + unter d:\lo\core\framework\source\uielement\toolbarwrapper.cxx (105) + mergedlo.dll!framework::ToolbarLayoutManager::destroyToolbars() Zeile 666 + unter d:\lo\core\framework\source\layoutmanager\toolbarlayoutmanager.cxx (666) + mergedlo.dll!framework::ToolbarLayoutManager::reset() Zeile 364 + unter d:\lo\core\framework\source\layoutmanager\toolbarlayoutmanager.cxx (364) + mergedlo.dll!framework::LayoutManager::implts_reset(bool bAttached) Zeile 458 + unter d:\lo\core\framework\source\layoutmanager\layoutmanager.cxx (458) + mergedlo.dll!framework::LayoutManager::frameAction(const com::sun::star::frame::FrameActionEvent & aEvent) Zeile 2757 + unter d:\lo\core\framework\source\layoutmanager\layoutmanager.cxx (2757) + mergedlo.dll!`anonymous namespace'::XFrameImpl::implts_sendFrameActionEvent(const com::sun::star::frame::FrameAction & aAction) Zeile 2952 + unter d:\lo\core\framework\source\services\frame.cxx (2952) + mergedlo.dll!`anonymous namespace'::XFrameImpl::setComponent(const com::sun::star::uno::Reference & xComponentWindow, const com::sun::star::uno::Reference & xController) Zeile 1470 + unter d:\lo\core\framework\source\services\frame.cxx (1470) + mergedlo.dll!`anonymous namespace'::XFrameImpl::close(unsigned char bDeliverOwnership) Zeile 1701 + unter d:\lo\core\framework\source\services\frame.cxx (1701) + mergedlo.dll!framework::pattern::frame::closeIt(const com::sun::star::uno::Reference & xResource) Zeile 62 + unter d:\lo\core\framework\source\inc\pattern\frame.hxx (62) + [Inlineframe] mergedlo.dll!framework::CloseDispatcher::implts_closeFrame() Zeile 492 + unter d:\lo\core\framework\source\dispatch\closedispatcher.cxx (492) + + Change-Id: Ie05cd05158df58021d0fb4a19e9e38cd35af2426 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164451 + Tested-by: Jenkins + Reviewed-by: Michael Weghorn + Reviewed-by: Michael Stahl + (cherry picked from commit 825dde03999a55d02e4d5bc88a4d5beacb65e67f) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164503 + Reviewed-by: Noel Grandin + +2024-03-08 Patrick Luby [358eee88dd0af37ffc83c3abd9633593b758a5be] tdf#159996 use transparent alpha mask for output device @@ -511,28 +2778,14 @@ Tested-by: Jenkins Reviewed-by: Patrick Luby (cherry picked from commit 73c14fcf97a1dcc9c95c98f9223449957b0b4963) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164500 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164499 Reviewed-by: Noel Grandin - Tested-by: Adolfo Jayme Barrientos - Reviewed-by: Adolfo Jayme Barrientos - -2024-03-07 Christian Lohmaier [195856d74dc68d2d74dfb221a3affadf259ea0d0] - bump product version to 24.2.2.1.0+ - - Change-Id: Ifc53da11118fcbe937df38723adb164846261b6e - -2024-03-07 Christian Lohmaier [b8424dde35e5169c1c7ac1ec59df9d63d232572c] +2024-03-07 Christian Lohmaier [b0c2f78a9d398b92e24a0b9f91c7773ecd743d6f] - Branch libreoffice-24-2-2 - - This is 'libreoffice-24-2-2' - the stable branch for the 24.2.2 release. - Only very safe changes, reviewed by three people are allowed. + bump product version to 24.2.3.0.0+ - If you want to commit more complicated fix for the next 24.2.x release, - please use the 'libreoffice-24-2' branch. - - If you want to build something cool, unstable, and risky, use master. + Change-Id: I984e5fcd6f5367fb284912d9d6bb3c8f53125c43 2024-03-07 Julien Nabet [c899c2e463c61d056e68efd180e0a596c7569a1e] -- cgit v1.2.3