blob: 013bf1b4725c42b4e4418b7a61837f5dff991d8f (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#ifndef LO_CLANG_SHARED_PLUGINS
#include <cassert>
#include <stack>
#include "check.hxx"
#include "plugin.hxx"
#include "config_clang.h"
// Check for uses of std::optional<bool> being assigned to bool, which generally does not do
// what you would expect.
namespace
{
class OptionalBool final : public loplugin::FilteringPlugin<OptionalBool>
{
public:
explicit OptionalBool(loplugin::InstantiationData const& data)
: FilteringPlugin(data)
{
}
bool preRun() override
{
if (!compiler.getLangOpts().CPlusPlus)
return false;
return true;
}
void run() override
{
if (preRun())
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
}
bool VisitIfStmt(const IfStmt* ifStmt)
{
if (ignoreLocation(ifStmt))
return true;
m_ignoreIfCondition = ifStmt->getCond()->IgnoreImplicit();
return true;
}
bool VisitCXXMemberCallExpr(const CXXMemberCallExpr* memberCall)
{
if (ignoreLocation(memberCall))
return true;
if (m_ignoreIfCondition == memberCall)
return true;
// check if we are calling a 'operator bool' conversion method
auto conversionDecl = dyn_cast_or_null<CXXConversionDecl>(memberCall->getMethodDecl());
if (!conversionDecl || !conversionDecl->getConversionType()->isBooleanType())
return true;
auto ctsd = dyn_cast_or_null<ClassTemplateSpecializationDecl>(
memberCall->getObjectType()->getAsRecordDecl());
if (!ctsd || ctsd->getTemplateArgs().size() < 1)
return true;
if (ctsd->getName() != "optional")
return true;
if (!ctsd->getTemplateArgs().get(0).getAsType()->isBooleanType())
return true;
report(DiagnosticsEngine::Warning,
"using conversion call to convert std::optional<bool> to bool probably does not do "
"what you expect, rather use has_value() or value_or()",
memberCall->getBeginLoc())
<< memberCall->getSourceRange();
return true;
}
private:
const Expr* m_ignoreIfCondition = nullptr;
};
loplugin::Plugin::Registration<OptionalBool> optionalbool("optionalbool");
}
#endif
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|
