1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <rtl/strbuf.hxx>
#include <rtl/string.hxx>
#include <rtl/ustrbuf.hxx>
#include <rtl/ustring.hxx>
#pragma clang diagnostic ignored "-Wunknown-warning-option" // for Clang < 13
#pragma clang diagnostic ignored "-Wunused-but-set-parameter"
#pragma clang diagnostic ignored "-Wunused-but-set-variable"
// ---------------------------------------------------------------
// += tests
namespace test1
{
static const char XXX1[] = "xxx";
static constexpr char16_t XXX1u[] = u"xxx";
static const char XXX2[] = "xxx";
void f1(OUString s1, int i, OString o)
{
OUString s2 = s1;
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
s2 += "xxx";
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
s2 += "xxx";
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
s2 += s1;
s2 = s1 + "xxx";
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
s2 += s1;
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
s2 += OUString::number(i);
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
s2 += XXX1;
// expected-error-re@+2 {{rather use O[U]String::Concat than constructing '{{(rtl::)?}}OUStringLiteral<4>'{{( \(aka 'rtl::OUStringLiteral<4>'\))?}} from 'const char16_t{{ ?}}[4]' on LHS of + (where RHS is of type 'const char{{ ?}}[4]') [loplugin:stringadd]}}
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
s2 += OUStringLiteral(XXX1u) + XXX2;
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
s2 += OStringToOUString(o, RTL_TEXTENCODING_UTF8);
}
void f2(OString s1, int i, OUString u)
{
OString s2 = s1;
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
s2 += "xxx";
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
s2 += "xxx";
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
s2 += s1;
s2 = s1 + "xxx";
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
s2 += s1;
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
s2 += OString::number(i);
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
s2 += OUStringToOString(u, RTL_TEXTENCODING_ASCII_US);
}
void f3(OUString aStr, int nFirstContent)
{
OUString aFirstStr = aStr.copy(0, nFirstContent);
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
aFirstStr += "...";
}
OUString side_effect();
void f4(int i)
{
OUString s1;
OUString s2("xxx");
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
s2 += "xxx";
++i;
// any other kind of statement breaks the chain (at least for now)
s2 += "xxx";
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
s2 += side_effect();
s1 += "yyy";
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
s1 += "yyy";
}
}
namespace test2
{
void f(OUString s3)
{
s3 += "xxx";
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
s3 += "xxx";
}
void g(OString s3)
{
s3 += "xxx";
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
s3 += "xxx";
}
}
namespace test3
{
struct Bar
{
OUString m_field;
};
void f(Bar b1, Bar& b2, Bar* b3)
{
OUString s3 = "xxx";
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
s3 += b1.m_field;
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
s3 += b2.m_field;
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
s3 += b3->m_field;
}
OUString side_effect();
void f2(OUString s)
{
OUString sRet = "xxx";
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
sRet += side_effect();
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
sRet += "xxx";
sRet += side_effect();
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
sRet += "xxx";
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
sRet += "xxx";
sRet += s;
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
sRet += "xxx";
}
}
// no warning expected
namespace test4
{
OUString side_effect();
void f()
{
OUString sRet = "xxx";
#if OSL_DEBUG_LEVEL > 0
sRet += ";";
#endif
sRet += " ";
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
sRet += side_effect();
}
}
// no warning expected
namespace test5
{
OUString side_effect();
void f()
{
OUString sRet = side_effect();
sRet += side_effect();
}
}
namespace test6
{
void f(OUString sComma, OUString maExtension, int mnDocumentIconID)
{
OUString sValue;
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
sValue += sComma + sComma + maExtension + sComma;
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
sValue += OUString::number(mnDocumentIconID) + sComma;
}
struct Foo
{
OUString sFormula1;
};
void g(int x, const Foo& aValidation)
{
OUString sCondition;
switch (x)
{
case 1:
sCondition += "cell-content-is-in-list(";
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
sCondition += aValidation.sFormula1 + ")";
}
}
}
// ---------------------------------------------------------------
// detecting OUString temporary construction in +
namespace test9
{
OUString getByValue();
const OUString& getByRef();
void f1(OUString s, OUString t, int i, const char* pChar)
{
// no warning expected
t = t + "xxx";
// expected-error-re@+1 {{rather use O[U]String::Concat than constructing '{{(rtl::)?}}OUString' from 'const char{{ ?}}[4]' on RHS of + (where LHS is of type '{{(rtl::)?}}OUString') [loplugin:stringadd]}}
s = s + OUString("xxx");
// expected-error-re@+1 {{rather use O[U]String::Concat than constructing '{{(rtl::)?}}OUString' from 'const {{(rtl::)?}}OUString' on RHS of + (where LHS is of type '{{(rtl::)?}}OUString') [loplugin:stringadd]}}
s = s + OUString(getByRef());
// no warning expected
OUString a;
a = a + getByValue();
// no warning expected
OUString b;
b = b + (i == 1 ? "aaa" : "bbb");
// no warning expected
OUString c;
c = c + OUString(pChar, strlen(pChar), RTL_TEXTENCODING_UTF8);
OUStringBuffer buf;
// expected-error@+1 {{chained append, rather use single append call and + operator [loplugin:stringadd]}}
buf.append(" ").append(b);
}
void f2(char ch)
{
OString s;
// expected-error-re@+1 {{rather use O[U]String::Concat than constructing '{{(rtl::)?}}OString' from 'const char{{ ?}}[4]' on RHS of + (where LHS is of type '{{(rtl::)?}}OString') [loplugin:stringadd]}}
s = s + OString("xxx");
// expected-error-re@+1 {{rather use O[U]String::Concat than constructing '{{(rtl::)?}}OString' from 'char' on RHS of + (where LHS is of type '{{(rtl::)?}}OString') [loplugin:stringadd]}}
s = s + OString(ch);
}
}
namespace test10
{
struct C
{
OString constStringFunction(int) const;
OString nonConstStringFunction();
int constIntFunction() const;
int nonConstIntFunction();
};
C getC();
void f1(C c)
{
OString s;
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
s += c.constStringFunction(c.constIntFunction());
s += c.constStringFunction(c.nonConstIntFunction());
s += c.nonConstStringFunction();
s += getC().constStringFunction(c.constIntFunction());
}
}
namespace test11
{
void f1()
{
OUStringBuffer aFirstStr1("aaa");
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
aFirstStr1.append("...");
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
aFirstStr1.append("...");
}
}
namespace test12
{
void f1(int j)
{
OUStringBuffer aFirstStr1(12);
// no warning expected
aFirstStr1.append("...");
// expected-error@+1 {{simplify by merging with the preceding assign/append [loplugin:stringadd]}}
aFirstStr1.append("...");
// no warning expected
aFirstStr1.append(((j + 1) % 15) ? " " : "\n");
}
}
namespace test13
{
void f1()
{
OUStringBuffer aFirstStr1(12);
// no warning expected
aFirstStr1.append("...");
// because we have a comment between them
aFirstStr1.append("...");
}
}
namespace test14
{
void f1()
{
OUStringBuffer b(16);
b.append("...");
}
void f2(long long n)
{
OUStringBuffer b(n);
b.append("...");
}
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|
