Adding upstream version 2.117.0.upstream/2.117.0upstream

Signed-off-by: Daniel Baumann <daniel.baumann@progress-linux.org>

5 files changed, 572 insertions, 0 deletions

diff --git a/lib/Lintian/Check/Languages/Php.pm b/lib/Lintian/Check/Languages/Php.pm
new file mode 100644
index 0000000..948a7a3
--- /dev/null
+++ b/lib/Lintian/Check/Languages/Php.pm
@@ -0,0 +1,53 @@
+# languages/php -- lintian check script -*- perl -*-
+
+# Copyright (C) 1998 Christian Schwarz and Richard Braakman
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, you can find it on the World Wide
+# Web at https://www.gnu.org/copyleft/gpl.html, or write to the Free
+# Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
+# MA 02110-1301, USA.
+
+package Lintian::Check::Languages::Php;
+
+use v5.20;
+use warnings;
+use utf8;
+
+use Moo;
+use namespace::clean;
+
+with 'Lintian::Check';
+
+sub visit_installed_files {
+    my ($self, $item) = @_;
+
+    # /etc/php/*/mods-available/*.ini
+    if (   $item->is_file
+        && $item->name =~ m{^etc/php/.*/mods-available/.+\.ini$}) {
+
+        $self->pointed_hint('obsolete-comments-style-in-php-ini',
+            $item->pointer)
+          if $item->decoded_utf8 =~ /^\s*#/m;
+    }
+
+    return;
+}
+
+1;
+
+# Local Variables:
+# indent-tabs-mode: nil
+# cperl-indent-level: 4
+# End:
+# vim: syntax=perl sw=4 sts=4 sr et
diff --git a/lib/Lintian/Check/Languages/Php/Composer.pm b/lib/Lintian/Check/Languages/Php/Composer.pm
new file mode 100644
index 0000000..142c1e8
--- /dev/null
+++ b/lib/Lintian/Check/Languages/Php/Composer.pm
@@ -0,0 +1,93 @@
+# languages/php/composer -- lintian check script -*- perl -*-
+#
+# Copyright (C) 2021 Felix Lechner
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, you can find it on the World Wide
+# Web at https://www.gnu.org/copyleft/gpl.html, or write to the Free
+# Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
+# MA 02110-1301, USA.
+
+package Lintian::Check::Languages::Php::Composer;
+
+use v5.20;
+use warnings;
+use utf8;
+
+use Lintian::Relation;
+
+use Moo;
+use namespace::clean;
+
+with 'Lintian::Check';
+
+sub source {
+    my ($self) = @_;
+
+    my $control = $self->processable->debian_control;
+    my $source_fields = $control->source_fields;
+
+    for my $field (
+        qw(Build-Depends Build-Depends-Indep
+        Build-Conflicts Build-Conflicts-Indep)
+    ) {
+        next
+          unless $source_fields->declares($field);
+
+        my $position = $source_fields->position($field);
+        my $pointer = $control->item->pointer($position);
+
+        my $raw = $source_fields->value($field);
+        my $relation = Lintian::Relation->new->load($raw);
+
+        my $condition = 'composer:any';
+
+        $self->pointed_hint('composer-prerequisite', $pointer, $field,
+            '(in source paragraph)')
+          if $relation->satisfies($condition);
+    }
+
+    for my $installable ($control->installables) {
+        my $installable_fields = $control->installable_fields($installable);
+
+        for my $field (
+            qw(Pre-Depends Depends Recommends Suggests Breaks
+            Conflicts Provides Replaces Enhances)
+        ) {
+            next
+              unless $installable_fields->declares($field);
+
+            my $position = $installable_fields->position($field);
+            my $pointer = $control->item->pointer($position);
+
+            my $relation
+              = $self->processable->binary_relation($installable, $field);
+
+            my $condition = 'composer:any';
+
+            $self->pointed_hint('composer-prerequisite', $pointer, $field,
+                "(in section for $installable)")
+              if $relation->satisfies($condition);
+        }
+    }
+
+    return;
+}
+
+1;
+
+# Local Variables:
+# indent-tabs-mode: nil
+# cperl-indent-level: 4
+# End:
+# vim: syntax=perl sw=4 sts=4 sr et
diff --git a/lib/Lintian/Check/Languages/Php/Embedded.pm b/lib/Lintian/Check/Languages/Php/Embedded.pm
new file mode 100644
index 0000000..2287f09
--- /dev/null
+++ b/lib/Lintian/Check/Languages/Php/Embedded.pm
@@ -0,0 +1,92 @@
+# languages/php/embedded -- lintian check script -*- perl -*-
+
+# Copyright (C) 1998 Christian Schwarz and Richard Braakman
+# Copyright (C) 2020 Felix Lechner
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, you can find it on the World Wide
+# Web at https://www.gnu.org/copyleft/gpl.html, or write to the Free
+# Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
+# MA 02110-1301, USA.
+
+package Lintian::Check::Languages::Php::Embedded;
+
+use v5.20;
+use warnings;
+use utf8;
+
+use Moo;
+use namespace::clean;
+
+with 'Lintian::Check';
+
+my $PHP_EXT = qr{(?i)\.(?:php|inc|dtd)$};
+my %PHP_FILES = (
+    'libphp-adodb'         => qr{(?i)/adodb\.inc\.php$},
+    'smarty3?'             => qr{(?i)/Smarty(?:_Compiler)?\.class\.php$},
+    'libphp-phpmailer'     => qr{(?i)/class\.phpmailer(\.(?:php|inc))+$},
+    'phpsysinfo'           =>
+qr{(?i)/phpsysinfo\.dtd|/class\.(?:Linux|(?:Open|Net|Free|)BSD)\.inc\.php$},
+    'php-openid'           => qr{/Auth/(?:OpenID|Yadis/Yadis)\.php$},
+    'libphp-snoopy'        => qr{(?i)/Snoopy\.class\.(?:php|inc)$},
+    'php-markdown'         => qr{(?i)/markdown\.php$},
+    'php-geshi'            => qr{(?i)/geshi\.php$},
+    'libphp-pclzip'        =>qr{(?i)/(?:class[.-])?pclzip\.(?:inc|lib)?\.php$},
+    'libphp-phplayersmenu' => qr{(?i)/.*layersmenu.*/(lib/)?PHPLIB\.php$},
+    'libphp-phpsniff'      => qr{(?i)/phpSniff\.(?:class|core)\.php$},
+    'libphp-jabber'        => qr{(?i)/(?:class\.)?jabber\.php$},
+    'libphp-simplepie'     =>
+      qr{(?i)/(?:class[\.-])?simplepie(?:\.(?:php|inc))+$},
+    'libphp-jpgraph'       => qr{(?i)/jpgraph\.php$},
+    'php-fpdf'             => qr{(?i)/fpdf\.php$},
+    'php-getid3'           => qr{(?i)/getid3\.(?:lib\.)?(?:\.(?:php|inc))+$},
+    'php-php-gettext'      => qr{(?i)/(?<!pomo/)streams\.php$},
+    'libphp-magpierss'     => qr{(?i)/rss_parse\.(?:php|inc)$},
+    'php-simpletest'       => qr{(?i)/unit_tester\.php$},
+    'libsparkline-php'     => qr{(?i)/Sparkline\.php$},
+    'libnusoap-php'        => qr{(?i)/(?:class\.)?nusoap\.(?:php|inc)$},
+    'php-htmlpurifier'     => qr{(?i)/HTMLPurifier\.php$},
+    # not yet available in unstable:,
+    # 'libphp-ixr'         => qr{(?i)/IXR_Library(?:\.inc|\.php)+$},
+    # 'libphp-kses'        => qr{(?i)/(?:class\.)?kses\.php$},
+);
+
+sub visit_installed_files {
+    my ($self, $item) = @_;
+
+    return
+      unless $item->is_file;
+
+    # embedded PHP
+    for my $provider (keys %PHP_FILES) {
+
+        next
+          if $self->processable->name =~ /^$provider$/;
+
+        next
+          unless $item->name =~ /$PHP_FILES{$provider}/;
+
+        $self->pointed_hint('embedded-php-library', $item->pointer,
+            'please use',$provider);
+    }
+
+    return;
+}
+
+1;
+
+# Local Variables:
+# indent-tabs-mode: nil
+# cperl-indent-level: 4
+# End:
+# vim: syntax=perl sw=4 sts=4 sr et
diff --git a/lib/Lintian/Check/Languages/Php/Pear.pm b/lib/Lintian/Check/Languages/Php/Pear.pm
new file mode 100644
index 0000000..b73b268
--- /dev/null
+++ b/lib/Lintian/Check/Languages/Php/Pear.pm
@@ -0,0 +1,242 @@
+# langauges/php/pear -- lintian check script -*- perl -*-
+
+# Copyright (C) 2013 Mathieu Parent <math.parent@gmail.com>
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, you can find it on the World Wide
+# Web at https://www.gnu.org/copyleft/gpl.html, or write to the Free
+# Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
+# MA 02110-1301, USA.
+
+package Lintian::Check::Languages::Php::Pear;
+
+use v5.20;
+use warnings;
+use utf8;
+
+use Const::Fast;
+use List::SomeUtils qw(none);
+use Unicode::UTF8 qw(encode_utf8);
+
+const my $DOLLAR => q{$};
+
+use Moo;
+use namespace::clean;
+
+with 'Lintian::Check';
+
+sub source {
+    my ($self) = @_;
+
+    # Don't check package if it doesn't contain a .php file
+    if (none { $_->basename =~ m/\.php$/i && !$_->is_dir }
+        @{$self->processable->patched->sorted_list}){
+        return;
+    }
+
+    my $build_depends = $self->processable->relation('Build-Depends');
+    my $package_type = 'unknown';
+
+    # PEAR or PECL package
+    my $package_xml = $self->processable->patched->lookup('package.xml');
+    my $package2_xml = $self->processable->patched->lookup('package2.xml');
+
+    my $debian_control = $self->processable->debian_control;
+
+    if (defined($package_xml) || defined($package2_xml)) {
+        # Checking source builddep
+        if (!$build_depends->satisfies('pkg-php-tools')) {
+            $self->hint('pear-package-without-pkg-php-tools-builddep');
+
+        } else {
+            # Checking first binary relations
+            my @binaries = $debian_control->installables;
+            my $binary = $binaries[0];
+
+            my $depends
+              = $self->processable->binary_relation($binary, 'Depends');
+            my $recommends
+              = $self->processable->binary_relation($binary, 'Recommends');
+            my $breaks= $self->processable->binary_relation($binary, 'Breaks');
+
+            $self->hint('pear-package-but-missing-dependency', 'Depends')
+              unless $depends->satisfies($DOLLAR . '{phppear:Debian-Depends}');
+
+            $self->hint('pear-package-but-missing-dependency','Recommends')
+              unless $recommends->satisfies(
+                $DOLLAR . '{phppear:Debian-Recommends}');
+
+            $self->hint('pear-package-but-missing-dependency', 'Breaks')
+              unless $breaks->satisfies($DOLLAR . '{phppear:Debian-Breaks}');
+
+            # checking description
+            my $description
+              = $debian_control->installable_fields($binary)
+              ->untrimmed_value('Description');
+
+            $self->hint(
+                'pear-package-not-using-substvar',
+                $DOLLAR . '{phppear:summary}'
+            )if $description !~ /\$\{phppear:summary\}/;
+
+            $self->hint(
+                'pear-package-not-using-substvar',
+                $DOLLAR . '{phppear:description}'
+            )if $description !~ /\$\{phppear:description\}/;
+
+            if (defined $package_xml && $package_xml->is_regular_file) {
+
+                # Wild guess package type as in
+                # PEAR_PackageFile_v2::getPackageType()
+                open(my $package_xml_fd, '<', $package_xml->unpacked_path)
+                  or die encode_utf8(
+                    'Cannot open ' . $package_xml->unpacked_path);
+
+                while (my $line = <$package_xml_fd>) {
+                    if (
+                        $line =~ m{\A \s* <
+                           (php|extsrc|extbin|zendextsrc|zendextbin)
+                           release \s* /? > }xsm
+                    ) {
+                        $package_type = $1;
+                        last;
+                    }
+                    if ($line =~ /^\s*<bundle\s*\/?>/){
+                        $package_type = 'bundle';
+                        last;
+                    }
+                }
+
+                close $package_xml_fd;
+
+                if ($package_type eq 'extsrc') { # PECL package
+                    if (!$build_depends->satisfies('php-dev')) {
+
+                        $self->pointed_hint(
+                            'pecl-package-requires-build-dependency',
+                            $package_xml->pointer,'php-dev');
+                    }
+
+                    if (!$build_depends->satisfies('dh-php')) {
+                        $self->pointed_hint(
+                            'pecl-package-requires-build-dependency',
+                            $package_xml->pointer,'dh-php');
+                    }
+                }
+            }
+        }
+    }
+
+    # PEAR channel
+    my $channel_xml = $self->processable->patched->lookup('channel.xml');
+    $self->pointed_hint('pear-channel-without-pkg-php-tools-builddep',
+        $channel_xml->pointer)
+      if defined $channel_xml
+      && !$build_depends->satisfies('pkg-php-tools');
+
+    # Composer package
+    my $composer_json = $self->processable->patched->lookup('composer.json');
+    $self->pointed_hint('composer-package-without-pkg-php-tools-builddep',
+        $composer_json->pointer)
+      if defined $composer_json
+      && !($build_depends->satisfies('pkg-php-tools')
+        || $build_depends->satisfies('dh-sequence-phpcomposer'))
+      && !defined $package_xml
+      && !defined $package2_xml;
+
+    # Check rules
+    if (
+        $build_depends->satisfies('pkg-php-tools')
+        && (   defined $package_xml
+            || defined $package2_xml
+            || defined $channel_xml
+            || defined $composer_json)
+    ) {
+        my $rules = $self->processable->patched->resolve_path('debian/rules');
+        if (defined $rules && $rules->is_open_ok) {
+
+            my $has_buildsystem_phppear = 0;
+            my $has_addon_phppear = 0;
+            my $has_addon_phpcomposer= 0;
+            my $has_addon_php = 0;
+
+            open(my $rules_fd, '<', $rules->unpacked_path)
+              or die encode_utf8('Cannot open ' . $rules->unpacked_path);
+
+            while (my $line = <$rules_fd>) {
+
+                while ($line =~ s/\\$// && defined(my $cont = <$rules_fd>)) {
+                    $line .= $cont;
+                }
+
+                next
+                  if $line =~ /^\s*\#/;
+
+                $has_buildsystem_phppear = 1
+                  if $line
+                  =~ /^\t\s*dh\s.*--buildsystem(?:=|\s+)(?:\S+,)*phppear(?:,\S+)*\s/;
+
+                $has_addon_phppear = 1
+                  if $line
+                  =~ /^\t\s*dh\s.*--with(?:=|\s+)(?:\S+,)*phppear(?:,\S+)*\s/;
+
+                $has_addon_phpcomposer = 1
+                  if $line
+                  =~ /^\t\s*dh\s.*--with(?:=|\s+)(?:\S+,)*phpcomposer(?:,\S+)*\s/;
+
+                $has_addon_php = 1
+                  if $line
+                  =~ /^\t\s*dh\s.*--with(?:=|\s+)(?:\S+,)*php(?:,\S+)*\s/;
+            }
+
+            close $rules_fd;
+
+            if (   defined $package_xml
+                || defined $package2_xml
+                || defined $channel_xml) {
+
+                $self->pointed_hint('missing-pkg-php-tools-buildsystem',
+                    $rules->pointer, 'phppear')
+                  unless $has_buildsystem_phppear;
+
+                $self->pointed_hint('missing-pkg-php-tools-addon',
+                    $rules->pointer, 'phppear')
+                  unless $has_addon_phppear;
+
+                $self->pointed_hint('missing-pkg-php-tools-addon',
+                    $rules->pointer, 'php')
+                  if $package_type eq 'extsrc'
+                  && !$has_addon_php;
+            }
+
+            if (   !defined $package_xml
+                && !defined $package2_xml
+                && defined $composer_json) {
+
+                $self->pointed_hint('missing-pkg-php-tools-addon',
+                    $rules->pointer, 'phpcomposer')
+                  unless $has_addon_phpcomposer;
+            }
+        }
+    }
+
+    return;
+}
+
+1;
+
+# Local Variables:
+# indent-tabs-mode: nil
+# cperl-indent-level: 4
+# End:
+# vim: syntax=perl sw=4 sts=4 sr et
diff --git a/lib/Lintian/Check/Languages/Php/Pear/Embedded.pm b/lib/Lintian/Check/Languages/Php/Pear/Embedded.pm
new file mode 100644
index 0000000..dfb1268
--- /dev/null
+++ b/lib/Lintian/Check/Languages/Php/Pear/Embedded.pm
@@ -0,0 +1,92 @@
+# languages/php/pear/embedded -- lintian check script -*- perl -*-
+
+# Copyright (C) 1998 Christian Schwarz and Richard Braakman
+# Copyright (C) 2020 Felix Lechner
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, you can find it on the World Wide
+# Web at https://www.gnu.org/copyleft/gpl.html, or write to the Free
+# Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
+# MA 02110-1301, USA.
+
+package Lintian::Check::Languages::Php::Pear::Embedded;
+
+use v5.20;
+use warnings;
+use utf8;
+
+use Moo;
+use namespace::clean;
+
+with 'Lintian::Check';
+
+my $PEAR_MAGIC = qr{pear[/.]};
+my $PEAR_EXT = qr{(?i)\.php$};
+my %PEAR_FILES = (
+    'php-auth'            => qr{/Auth} . $PEAR_EXT,
+    'php-auth-http'       => qr{/Auth/HTTP} . $PEAR_EXT,
+    'php-benchmark'       => qr{/Benchmark/(?:Timer|Profiler|Iterate)}
+      . $PEAR_EXT,
+    'php-http'            => qr{(?<!/Auth)/HTTP} . $PEAR_EXT,
+    'php-cache'           => qr{/Cache} . $PEAR_EXT,
+    'php-cache-lite'      => qr{/Cache/Lite} . $PEAR_EXT,
+    'php-compat'          => qr{/Compat} . $PEAR_EXT,
+    'php-config'          => qr{/Config} . $PEAR_EXT,
+    'php-crypt-cbc'       => qr{/CBC} . $PEAR_EXT,
+    'php-date'            => qr{/Date} . $PEAR_EXT,
+    'php-db'              => qr{(?<!/Container)/DB} . $PEAR_EXT,
+    'php-file'            => qr{(?<!/Container)/File} . $PEAR_EXT,
+    'php-log'             =>
+      qr{(?:/Log/(?:file|error_log|null|syslog|sql\w*)|/Log)} . $PEAR_EXT,
+    'php-mail'            => qr{/Mail} . $PEAR_EXT,
+    'php-mail-mime'       => qr{(?i)/mime(Part)?} . $PEAR_EXT,
+    'php-mail-mimedecode' => qr{/mimeDecode} . $PEAR_EXT,
+    'php-net-ftp'         => qr{/FTP} . $PEAR_EXT,
+    'php-net-imap'        => qr{(?<!/Container)/IMAP} . $PEAR_EXT,
+    'php-net-ldap'        => qr{(?<!/Container)/LDAP} . $PEAR_EXT,
+    'php-net-smtp'        => qr{/SMTP} . $PEAR_EXT,
+    'php-net-socket'      => qr{(?<!/FTP)/Socket} . $PEAR_EXT,
+);
+
+sub visit_installed_files {
+    my ($self, $item) = @_;
+
+    return
+      unless $item->is_file;
+
+    # embedded PEAR
+    for my $provider (keys %PEAR_FILES) {
+
+        next
+          if $self->processable->name =~ /^$provider$/;
+
+        next
+          unless $item->name =~ /$PEAR_FILES{$provider}/;
+
+        next
+          unless length $item->bytes_match($PEAR_MAGIC);
+
+        $self->pointed_hint('embedded-pear-module', $item->pointer,
+            'please use',$provider);
+    }
+
+    return;
+}
+
+1;
+
+# Local Variables:
+# indent-tabs-mode: nil
+# cperl-indent-level: 4
+# End:
+# vim: syntax=perl sw=4 sts=4 sr et