1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
|
# debian/patches -- lintian check script -*- perl -*-
#
# Copyright (C) 2007 Marc Brockschmidt
# Copyright (C) 2008 Raphael Hertzog
# Copyright (C) 2018-2019 Chris Lamb <lamby@debian.org>
# Copyright (C) 2020 Felix Lechner
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, you can find it on the World Wide
# Web at https://www.gnu.org/copyleft/gpl.html, or write to the Free
# Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
# MA 02110-1301, USA.
package Lintian::Check::Debian::Patches;
use v5.20;
use warnings;
use utf8;
use Path::Tiny;
use Moo;
use namespace::clean;
with 'Lintian::Check';
sub source {
my ($self) = @_;
my @patch_system;
# Get build deps so we can decide which build system the
# maintainer meant to use:
my $build_deps = $self->processable->relation('Build-Depends-All');
# Get source package format
my $source_format = $self->processable->fields->value('Format');
my $quilt_format = ($source_format =~ /3\.\d+ \(quilt\)/) ? 1 : 0;
my $debian_dir = $self->processable->patched->resolve_path('debian/');
return
unless defined $debian_dir;
my $patch_dir = $debian_dir->resolve_path('patches');
# Find debian/patches/series, assuming debian/patches is a (symlink to a)
# dir. There are cases, where it is a file (ctwm: #778556)
my $patch_series;
$patch_series
= $self->processable->patched->resolve_path('debian/patches/series');
push(@patch_system, 'dpatch')
if $build_deps->satisfies('dpatch');
push(@patch_system, 'quilt')
if $quilt_format || $build_deps->satisfies('quilt');
$self->hint('patch-system', $_) for @patch_system;
$self->hint('more-than-one-patch-system')
if @patch_system > 1;
if (@patch_system && !$quilt_format) {
my $readme = $debian_dir->resolve_path('README.source');
$self->hint('patch-system-but-no-source-readme')
unless defined $readme;
}
my @direct_changes
= grep { !m{^debian/} } keys %{$self->processable->diffstat};
if (@direct_changes) {
my $files = $direct_changes[0];
$files .= " and $#direct_changes more"
if @direct_changes > 1;
$self->hint('patch-system-but-direct-changes-in-diff', $files)
if @patch_system;
$self->hint('direct-changes-in-diff-but-no-patch-system', $files)
unless @patch_system;
}
return;
}
1;
# Local Variables:
# indent-tabs-mode: nil
# cperl-indent-level: 4
# End:
# vim: syntax=perl sw=4 sts=4 sr et
|
