1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
|
# images/filenames -- lintian check script -*- perl -*-
# Copyright (C) 2019 Felix Lechner
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, you can find it on the World Wide
# Web at https://www.gnu.org/copyleft/gpl.html, or write to the Free
# Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
# MA 02110-1301, USA.
package Lintian::Check::Images::Filenames;
use v5.20;
use warnings;
use utf8;
use Moo;
use namespace::clean;
with 'Lintian::Check';
my @image_formats = (
{
name => 'PNG',
file_type => qr/^PNG image data/,
good_name => sub { $_[0] =~ /\.(?:png|PNG)$/ }
},
{
name => 'JPEG',
file_type => qr/^JPEG image data/,
good_name => sub { $_[0] =~ /\.(?:jpe?g|JPE?G)$/ }
},
{
name => 'GIF',
file_type => qr/^GIF image data/,
good_name => sub { $_[0] =~ /\.(?:gif|GIF)$/ }
},
{
name => 'TIFF',
file_type => qr/^TIFF image data/,
good_name => sub { $_[0] =~ /\.(?:tiff?|TIFF?)$/ }
},
{
name => 'XPM',
file_type => qr/^X pixmap image/,
good_name => sub { $_[0] =~ /\.(?:xpm|XPM)$/ }
},
{
name => 'Netpbm',
file_type => qr/^Netpbm image data/,
good_name => sub { $_[0] =~ /\.(?:p[bgpn]m|P[BGPN]M)$/ }
},
{
name => 'SVG',
file_type => qr/^SVG Scalable Vector Graphics image/,
good_name => sub { $_[0] =~ /\.(?:svg|SVG)$/ }
},
);
# ICO format developed into a container and may contain PNG
sub visit_installed_files {
my ($self, $item) = @_;
return
unless $item->is_file;
my $our_format;
for my $format (@image_formats) {
if ($item->file_type =~ $format->{file_type}) {
$our_format = $format;
last;
}
}
# not an image
return
unless $our_format;
return
if $our_format->{good_name}->($item->name);
my $conflicting_format;
my @other_formats = grep { $_ != $our_format } @image_formats;
for my $format (@other_formats) {
if ($format->{good_name}->($item->name)) {
$conflicting_format = $format;
last;
}
}
if ($conflicting_format) {
$self->pointed_hint('image-file-has-conflicting-name',
$item->pointer, '(is ' . $our_format->{name} . ')')
unless $our_format->{good_name}->($item->name);
} else {
$self->pointed_hint('image-file-has-unexpected-name',
$item->pointer, '(is ' . $our_format->{name} . ')');
}
return;
}
1;
# Local Variables:
# indent-tabs-mode: nil
# cperl-indent-level: 4
# End:
# vim: syntax=perl sw=4 sts=4 sr et
|
