diff options
Diffstat (limited to '')
| -rwxr-xr-x | debian/additions/debian-start | 50 | ||||
| -rwxr-xr-x | debian/additions/debian-start.inc.sh | 92 |
2 files changed, 142 insertions, 0 deletions
diff --git a/debian/additions/debian-start b/debian/additions/debian-start new file mode 100755 index 00000000..d85e4a12 --- /dev/null +++ b/debian/additions/debian-start @@ -0,0 +1,50 @@ +#!/bin/bash +# +# This script is executed by both SysV init /etc/init.d/mariadb and +# systemd mariadb.service on every (re)start. +# +# Changes to this file will be preserved when updating the Debian package. +# + +# shellcheck source=debian/additions/debian-start.inc.sh +source /usr/share/mysql/debian-start.inc.sh + +# Read default/mysql first and then default/mariadb just like the init.d file does +if [ -f /etc/default/mysql ] +then + # shellcheck source=/dev/null + . /etc/default/mysql +fi + +if [ -f /etc/default/mariadb ] +then + # shellcheck source=/dev/null + . /etc/default/mariadb +fi + +MARIADB="/usr/bin/mariadb --defaults-file=/etc/mysql/debian.cnf" +MYADMIN="/usr/bin/mariadb-admin --defaults-file=/etc/mysql/debian.cnf" +# Don't run full mariadb-upgrade on every server restart, use --version-check to do it only once +MYUPGRADE="/usr/bin/mariadb-upgrade --defaults-extra-file=/etc/mysql/debian.cnf --version-check --silent" +MYCHECK_SUBJECT="WARNING: mariadb-check has found corrupt tables" +MYCHECK_RCPT="${MYCHECK_RCPT:-root}" + +## Checking for corrupt, not cleanly closed (only for MyISAM and Aria engines) and upgrade needing tables. + +# The following commands should be run when the server is up but in background +# where they do not block the server start and in one shell instance so that +# they run sequentially. They are supposed not to echo anything to stdout. +# If you want to disable the check for crashed tables comment +# "check_for_crashed_tables" out. +# (There may be no output to stdout inside the background process!) + +# Need to ignore SIGHUP, as otherwise a SIGHUP can sometimes abort the upgrade +# process in the middle. +trap "" SIGHUP +( + upgrade_system_tables_if_necessary; + check_root_accounts; + check_for_crashed_tables; +) >&2 & + +exit 0 diff --git a/debian/additions/debian-start.inc.sh b/debian/additions/debian-start.inc.sh new file mode 100755 index 00000000..57050057 --- /dev/null +++ b/debian/additions/debian-start.inc.sh @@ -0,0 +1,92 @@ +#!/bin/bash +# +# This file is included by /etc/mysql/debian-start +# + +## Check MyISAM and Aria unclosed tables. +# - Requires the server to be up. +# - Is supposed to run silently in background. +function check_for_crashed_tables() { + set -e + set -u + + # But do it in the background to not stall the boot process. + logger -p daemon.info -i -t"$0" "Triggering myisam-recover for all MyISAM tables and aria-recover for all Aria tables" + + # Checking for $? is unreliable so the size of the output is checked. + # Some table handlers like HEAP do not support CHECK TABLE. + tempfile=$(mktemp) + + # We have to use xargs in this case, because a for loop barfs on the + # spaces in the thing to be looped over. + + # If a crashed table is encountered, the "mariadb" command will return with a status different from 0 + # + # The first query will generate lines like. + # select count(*) into @discard from 'mysql'.'db' + # The second line will load all tables without printing any actual results, + # but may show warnings and definitely is expected to have some error and + # exit code if crashed tables are encountered. + # + # Note that inside single quotes must be quoted with '\'' (to be outside of single quotes). + set +e + # The $MARIADB is intentionally used to expand into a command and arguments + # shellcheck disable=SC2086 + LC_ALL=C echo ' + SELECT CONCAT("select count(*) into @discard from '\''", TABLE_SCHEMA, "'\''.'\''", TABLE_NAME, "'\''") + FROM information_schema.TABLES WHERE TABLE_SCHEMA<>"INFORMATION_SCHEMA" AND TABLE_SCHEMA<>"PERFORMANCE_SCHEMA" + AND (ENGINE="MyISAM" OR ENGINE="Aria") + ' | \ + $MARIADB --skip-column-names --batch | \ + xargs -i $MARIADB --skip-column-names --silent --batch --force -e "{}" &> "${tempfile}" + set -e + + if [ -s "$tempfile" ] + then + ( + /bin/echo -e "\n" \ + "Improperly closed tables are also reported if clients are accessing\n" \ + "the tables *now*. A list of current connections is below.\n"; + $MYADMIN processlist status + ) >> "${tempfile}" + # Check for presence as a dependency on mailx would require an MTA. + if [ -x /usr/bin/mailx ] + then + mailx -e -s"$MYCHECK_SUBJECT" "$MYCHECK_RCPT" < "$tempfile" + fi + (echo "$MYCHECK_SUBJECT"; cat "${tempfile}") | logger -p daemon.warn -i -t"$0" + fi + rm "${tempfile}" +} + +## Check for tables needing an upgrade. +# - Requires the server to be up. +# - Is supposed to run silently in background. +function upgrade_system_tables_if_necessary() { + set -e + set -u + + logger -p daemon.info -i -t"$0" "Upgrading MariaDB tables if necessary." + + # Filter all "duplicate column", "duplicate key" and "unknown column" + # errors as the script is designed to be idempotent. + LC_ALL=C $MYUPGRADE \ + 2>&1 \ + | grep -E -v '^(1|@had|ERROR (1051|1054|1060|1061|1146|1347|1348))' \ + | logger -p daemon.warn -i -t"$0" +} + +## Check for the presence of both, root accounts with and without password. +# This might have been caused by a bug related to mysql_install_db (#418672). +function check_root_accounts() { + set -e + set -u + + logger -p daemon.info -i -t"$0" "Checking for insecure root accounts." + + ret=$(echo "SELECT count(*) FROM mysql.user WHERE user='root' and password='' and plugin in ('', 'mysql_native_password', 'mysql_old_password');" | $MARIADB --skip-column-names) + if [ "$ret" -ne "0" ] + then + logger -p daemon.warn -i -t"$0" "WARNING: mysql.user contains $ret root accounts without password!" + fi +} |