summaryrefslogtreecommitdiffstats
path: root/compiler/rustc_span/src/edit_distance.rs
diff options
context:
space:
mode:
Diffstat (limited to 'compiler/rustc_span/src/edit_distance.rs')
-rw-r--r--compiler/rustc_span/src/edit_distance.rs32
1 files changed, 29 insertions, 3 deletions
diff --git a/compiler/rustc_span/src/edit_distance.rs b/compiler/rustc_span/src/edit_distance.rs
index 89f0386e3..259f42386 100644
--- a/compiler/rustc_span/src/edit_distance.rs
+++ b/compiler/rustc_span/src/edit_distance.rs
@@ -174,10 +174,10 @@ pub fn find_best_match_for_name(
fn find_best_match_for_name_impl(
use_substring_score: bool,
candidates: &[Symbol],
- lookup: Symbol,
+ lookup_symbol: Symbol,
dist: Option<usize>,
) -> Option<Symbol> {
- let lookup = lookup.as_str();
+ let lookup = lookup_symbol.as_str();
let lookup_uppercase = lookup.to_uppercase();
// Priority of matches:
@@ -190,6 +190,8 @@ fn find_best_match_for_name_impl(
let mut dist = dist.unwrap_or_else(|| cmp::max(lookup.len(), 3) / 3);
let mut best = None;
+ // store the candidates with the same distance, only for `use_substring_score` current.
+ let mut next_candidates = vec![];
for c in candidates {
match if use_substring_score {
edit_distance_with_substrings(lookup, c.as_str(), dist)
@@ -198,12 +200,36 @@ fn find_best_match_for_name_impl(
} {
Some(0) => return Some(*c),
Some(d) => {
- dist = d - 1;
+ if use_substring_score {
+ if d < dist {
+ dist = d;
+ next_candidates.clear();
+ } else {
+ // `d == dist` here, we need to store the candidates with the same distance
+ // so we won't decrease the distance in the next loop.
+ }
+ next_candidates.push(*c);
+ } else {
+ dist = d - 1;
+ }
best = Some(*c);
}
None => {}
}
}
+
+ // We have a tie among several candidates, try to select the best among them ignoring substrings.
+ // For example, the candidates list `force_capture`, `capture`, and user inputted `forced_capture`,
+ // we select `force_capture` with a extra round of edit distance calculation.
+ if next_candidates.len() > 1 {
+ debug_assert!(use_substring_score);
+ best = find_best_match_for_name_impl(
+ false,
+ &next_candidates,
+ lookup_symbol,
+ Some(lookup.len()),
+ );
+ }
if best.is_some() {
return best;
}