summaryrefslogtreecommitdiffstats
path: root/src/librustdoc/docfs.rs
diff options
context:
space:
mode:
Diffstat (limited to 'src/librustdoc/docfs.rs')
-rw-r--r--src/librustdoc/docfs.rs28
1 files changed, 21 insertions, 7 deletions
diff --git a/src/librustdoc/docfs.rs b/src/librustdoc/docfs.rs
index be066bdaf..d58b8dc6a 100644
--- a/src/librustdoc/docfs.rs
+++ b/src/librustdoc/docfs.rs
@@ -2,18 +2,20 @@
//!
//! On Windows this indirects IO into threads to work around performance issues
//! with Defender (and other similar virus scanners that do blocking operations).
-//! On other platforms this is a thin shim to fs.
//!
//! Only calls needed to permit this workaround have been abstracted: thus
//! fs::read is still done directly via the fs module; if in future rustdoc
//! needs to read-after-write from a file, then it would be added to this
//! abstraction.
+use std::cmp::max;
use std::fs;
use std::io;
use std::path::{Path, PathBuf};
use std::string::ToString;
use std::sync::mpsc::Sender;
+use std::thread::available_parallelism;
+use threadpool::ThreadPool;
pub(crate) trait PathError {
fn new<S, P: AsRef<Path>>(e: S, path: P) -> Self
@@ -24,11 +26,21 @@ pub(crate) trait PathError {
pub(crate) struct DocFS {
sync_only: bool,
errors: Option<Sender<String>>,
+ pool: ThreadPool,
}
impl DocFS {
pub(crate) fn new(errors: Sender<String>) -> DocFS {
- DocFS { sync_only: false, errors: Some(errors) }
+ const MINIMUM_NB_THREADS: usize = 2;
+ DocFS {
+ sync_only: false,
+ errors: Some(errors),
+ pool: ThreadPool::new(
+ available_parallelism()
+ .map(|nb| max(nb.get(), MINIMUM_NB_THREADS))
+ .unwrap_or(MINIMUM_NB_THREADS),
+ ),
+ }
}
pub(crate) fn set_sync_only(&mut self, sync_only: bool) {
@@ -54,12 +66,11 @@ impl DocFS {
where
E: PathError,
{
- #[cfg(windows)]
if !self.sync_only {
// A possible future enhancement after more detailed profiling would
// be to create the file sync so errors are reported eagerly.
let sender = self.errors.clone().expect("can't write after closing");
- rayon::spawn(move || {
+ self.pool.execute(move || {
fs::write(&path, contents).unwrap_or_else(|e| {
sender.send(format!("\"{}\": {}", path.display(), e)).unwrap_or_else(|_| {
panic!("failed to send error on \"{}\"", path.display())
@@ -70,9 +81,12 @@ impl DocFS {
fs::write(&path, contents).map_err(|e| E::new(e, path))?;
}
- #[cfg(not(windows))]
- fs::write(&path, contents).map_err(|e| E::new(e, path))?;
-
Ok(())
}
}
+
+impl Drop for DocFS {
+ fn drop(&mut self) {
+ self.pool.join();
+ }
+}