summaryrefslogtreecommitdiffstats
path: root/src/tools/clippy/clippy_lints/src/create_dir.rs
diff options
context:
space:
mode:
Diffstat (limited to 'src/tools/clippy/clippy_lints/src/create_dir.rs')
-rw-r--r--src/tools/clippy/clippy_lints/src/create_dir.rs33
1 files changed, 15 insertions, 18 deletions
diff --git a/src/tools/clippy/clippy_lints/src/create_dir.rs b/src/tools/clippy/clippy_lints/src/create_dir.rs
index 2bca695c4..7a3d5a070 100644
--- a/src/tools/clippy/clippy_lints/src/create_dir.rs
+++ b/src/tools/clippy/clippy_lints/src/create_dir.rs
@@ -1,10 +1,9 @@
use clippy_utils::diagnostics::span_lint_and_sugg;
use clippy_utils::source::snippet;
-use if_chain::if_chain;
use rustc_errors::Applicability;
use rustc_hir::{Expr, ExprKind};
use rustc_lint::{LateContext, LateLintPass};
-use rustc_session::{declare_lint_pass, declare_tool_lint};
+use rustc_session::declare_lint_pass;
use rustc_span::sym;
declare_clippy_lint! {
@@ -33,22 +32,20 @@ declare_lint_pass!(CreateDir => [CREATE_DIR]);
impl LateLintPass<'_> for CreateDir {
fn check_expr(&mut self, cx: &LateContext<'_>, expr: &Expr<'_>) {
- if_chain! {
- if let ExprKind::Call(func, [arg, ..]) = expr.kind;
- if let ExprKind::Path(ref path) = func.kind;
- if let Some(def_id) = cx.qpath_res(path, func.hir_id).opt_def_id();
- if cx.tcx.is_diagnostic_item(sym::fs_create_dir, def_id);
- then {
- span_lint_and_sugg(
- cx,
- CREATE_DIR,
- expr.span,
- "calling `std::fs::create_dir` where there may be a better way",
- "consider calling `std::fs::create_dir_all` instead",
- format!("create_dir_all({})", snippet(cx, arg.span, "..")),
- Applicability::MaybeIncorrect,
- )
- }
+ if let ExprKind::Call(func, [arg, ..]) = expr.kind
+ && let ExprKind::Path(ref path) = func.kind
+ && let Some(def_id) = cx.qpath_res(path, func.hir_id).opt_def_id()
+ && cx.tcx.is_diagnostic_item(sym::fs_create_dir, def_id)
+ {
+ span_lint_and_sugg(
+ cx,
+ CREATE_DIR,
+ expr.span,
+ "calling `std::fs::create_dir` where there may be a better way",
+ "consider calling `std::fs::create_dir_all` instead",
+ format!("create_dir_all({})", snippet(cx, arg.span, "..")),
+ Applicability::MaybeIncorrect,
+ );
}
}
}