summaryrefslogtreecommitdiffstats
path: root/src/tools/clippy/clippy_lints/src/loops/missing_spin_loop.rs
diff options
context:
space:
mode:
Diffstat (limited to 'src/tools/clippy/clippy_lints/src/loops/missing_spin_loop.rs')
-rw-r--r--src/tools/clippy/clippy_lints/src/loops/missing_spin_loop.rs46
1 files changed, 25 insertions, 21 deletions
diff --git a/src/tools/clippy/clippy_lints/src/loops/missing_spin_loop.rs b/src/tools/clippy/clippy_lints/src/loops/missing_spin_loop.rs
index 7b7d19c75..e405829b2 100644
--- a/src/tools/clippy/clippy_lints/src/loops/missing_spin_loop.rs
+++ b/src/tools/clippy/clippy_lints/src/loops/missing_spin_loop.rs
@@ -31,26 +31,30 @@ fn unpack_cond<'tcx>(cond: &'tcx Expr<'tcx>) -> &'tcx Expr<'tcx> {
}
pub(super) fn check<'tcx>(cx: &LateContext<'tcx>, cond: &'tcx Expr<'_>, body: &'tcx Expr<'_>) {
- if_chain! {
- if let ExprKind::Block(Block { stmts: [], expr: None, ..}, _) = body.kind;
- if let ExprKind::MethodCall(method, callee, ..) = unpack_cond(cond).kind;
- if [sym::load, sym::compare_exchange, sym::compare_exchange_weak].contains(&method.ident.name);
- if let ty::Adt(def, _args) = cx.typeck_results().expr_ty(callee).kind();
- if cx.tcx.is_diagnostic_item(sym::AtomicBool, def.did());
- then {
- span_lint_and_sugg(
- cx,
- MISSING_SPIN_LOOP,
- body.span,
- "busy-waiting loop should at least have a spin loop hint",
- "try",
- (if is_no_std_crate(cx) {
- "{ core::hint::spin_loop() }"
- } else {
- "{ std::hint::spin_loop() }"
- }).into(),
- Applicability::MachineApplicable
- );
- }
+ if let ExprKind::Block(
+ Block {
+ stmts: [], expr: None, ..
+ },
+ _,
+ ) = body.kind
+ && let ExprKind::MethodCall(method, callee, ..) = unpack_cond(cond).kind
+ && [sym::load, sym::compare_exchange, sym::compare_exchange_weak].contains(&method.ident.name)
+ && let ty::Adt(def, _args) = cx.typeck_results().expr_ty(callee).kind()
+ && cx.tcx.is_diagnostic_item(sym::AtomicBool, def.did())
+ {
+ span_lint_and_sugg(
+ cx,
+ MISSING_SPIN_LOOP,
+ body.span,
+ "busy-waiting loop should at least have a spin loop hint",
+ "try",
+ (if is_no_std_crate(cx) {
+ "{ core::hint::spin_loop() }"
+ } else {
+ "{ std::hint::spin_loop() }"
+ })
+ .into(),
+ Applicability::MachineApplicable,
+ );
}
}