summaryrefslogtreecommitdiffstats
path: root/src/tools/clippy/clippy_lints/src/methods/bytes_nth.rs
diff options
context:
space:
mode:
Diffstat (limited to 'src/tools/clippy/clippy_lints/src/methods/bytes_nth.rs')
-rw-r--r--src/tools/clippy/clippy_lints/src/methods/bytes_nth.rs34
1 files changed, 34 insertions, 0 deletions
diff --git a/src/tools/clippy/clippy_lints/src/methods/bytes_nth.rs b/src/tools/clippy/clippy_lints/src/methods/bytes_nth.rs
new file mode 100644
index 000000000..44857d61f
--- /dev/null
+++ b/src/tools/clippy/clippy_lints/src/methods/bytes_nth.rs
@@ -0,0 +1,34 @@
+use clippy_utils::diagnostics::span_lint_and_sugg;
+use clippy_utils::source::snippet_with_applicability;
+use clippy_utils::ty::is_type_diagnostic_item;
+use rustc_errors::Applicability;
+use rustc_hir::Expr;
+use rustc_lint::LateContext;
+use rustc_span::sym;
+
+use super::BYTES_NTH;
+
+pub(super) fn check<'tcx>(cx: &LateContext<'tcx>, expr: &Expr<'_>, recv: &'tcx Expr<'tcx>, n_arg: &'tcx Expr<'tcx>) {
+ let ty = cx.typeck_results().expr_ty(recv).peel_refs();
+ let caller_type = if ty.is_str() {
+ "str"
+ } else if is_type_diagnostic_item(cx, ty, sym::String) {
+ "String"
+ } else {
+ return;
+ };
+ let mut applicability = Applicability::MachineApplicable;
+ span_lint_and_sugg(
+ cx,
+ BYTES_NTH,
+ expr.span,
+ &format!("called `.bytes().nth()` on a `{}`", caller_type),
+ "try",
+ format!(
+ "{}.as_bytes().get({})",
+ snippet_with_applicability(cx, recv.span, "..", &mut applicability),
+ snippet_with_applicability(cx, n_arg.span, "..", &mut applicability)
+ ),
+ applicability,
+ );
+}